@jphutchins/code-review 0.1.0-alpha.63 → 0.1.0-alpha.64

package/dist/index.js

@@ -494,7 +494,7 @@ var incompleteFindings = (summary) => ({
 var isIncompleteFindings = (findings) => findings.verdict === "error" && findings.findings.length === 0;
 
 // src/released.ts
-var RELEASED = "2026-09-27";
+var RELEASED = "2026-10-02";
 
 // src/cost.ts
 var defaultWarn = (message) => {
@@ -3546,6 +3546,18 @@ ${dropNote}` : ""}`,
   const template = readFileSync(input.templatePath, "utf-8");
   const inlineRequested = input.inline === true;
   const envelope = loadEnvelope(input.envelopePath);
+  const effectiveRoute = input.route ?? envelope?.route;
+  const runRenderInput = {
+    prices: decodedPrices.right,
+    pricesProvided: input.pricesProvided,
+    template,
+    route: effectiveRoute,
+    reviewedSha: input.headSha,
+    effort: input.effort,
+    runUrl: input.runUrl,
+    jsonUrl: input.jsonUrl,
+    postedAt: input.postedAt
+  };
   const reachable = existingSticky !== null ? discussionRows(commentRows, existingSticky.id, input.botLogin) : [];
   const priorIsMechanic = existingSticky !== null && (parseReviewedRoute(existingSticky.body) === "mechanic" || parseMechanicAncestor(existingSticky.body));
   const noticeDiscussion = async () => {
@@ -3569,7 +3581,7 @@ ${dropNote}` : ""}`,
     };
   };
   const renderNotice = (message, discussion) => {
-    const noticeConvergence = (input.route ?? envelope?.route) === "mechanic" ? mechanicConvergence(
+    const noticeConvergence = effectiveRoute === "mechanic" ? mechanicConvergence(
       priorConv,
       input.convergenceThreshold ?? DEFAULT_CONVERGENCE_THRESHOLD
     ) : priorConv;
@@ -3582,22 +3594,14 @@ ${dropNote}` : ""}`,
     };
     return formatMarkdown(
       render({
+        ...runRenderInput,
         findings: findings2,
         envelope: null,
         incomplete: true,
-        prices: decodedPrices.right,
-        pricesProvided: input.pricesProvided,
-        template,
-        route: input.route,
-        reviewedSha: input.headSha,
-        effort: input.effort,
         sameRootNotes: {},
         roundCount: priorRoundCount,
         convergenceRound: false,
-        runUrl: input.runUrl,
-        jsonUrl: input.jsonUrl,
         findingsPointer: noticeFindingsPointer(findings2),
-        postedAt: input.postedAt,
         orphanedDiscussion: discussion.orphanedDiscussion,
         orphanedTotal: discussion.orphanedTotal,
         orphanedTruncated: discussion.orphanedTruncated,
@@ -3694,7 +3698,6 @@ ${dropNote}` : ""}`,
   const orphanedTruncated = stickyDiscussion.orphanedTruncated;
   const testReport = input.testReportPath ? loadTestReport(input.testReportPath) : void 0;
   const clocDiff = input.clocDiffPath ? loadClocDiff(input.clocDiffPath) : void 0;
-  const effectiveRoute = input.route ?? envelope?.route;
   const shedPriority = (f) => SEVERITIES.length - 1 - SEVERITIES.indexOf(f.severity);
   const shedOrderOf = (list) => list.map((f, index) => ({ f, index })).sort((a, b) => shedPriority(a.f) - shedPriority(b.f) || a.index - b.index).map((entry) => entry.f);
   const sizeSticky = (renderAt, total, reserve = SHED_RESERVE) => {
@@ -3763,6 +3766,33 @@ ${findingsPointer2}`
 ${note}
 `;
   };
+  const sharedRenderInput = {
+    ...runRenderInput,
+    repo: input.headRepo || input.repo,
+    testReport,
+    clocDiff,
+    // The answered-state honesty rules apply on EVERY surface that renders the filtered
+    // findings — the lost-envelope branch lists every VISIBLE finding (no inline review exists to
+    // carry them) so the kept re-raises' annotations actually render, and names the drops
+    // exactly like the main path (issues #151 review r1 + r2). The nit visibility floor applies
+    // here too (issue #164): below-floor nits are hidden from the human list and shown only in the
+    // collapsed aside — the floor is a human-visibility policy, not an inline-comment policy, so it
+    // must hold on the surface that lists findings without an inline review.
+    suppressedNits,
+    nitVisibilityFloor: input.nitVisibilityFloor,
+    answeredNotes: reRaisedNotes,
+    answeredReRaiseNote: answeredDropNote,
+    discussionByFinding,
+    orphanedDiscussion,
+    orphanedTotal,
+    discussionTruncated,
+    orphanedTruncated,
+    orphanedUnresolvable: orphanResolveFailed,
+    convergenceThreshold: input.convergenceThreshold,
+    unverifiedNoLogs: input.unverifiedNoLogs,
+    pricedAt: input.pricedAt,
+    summaryAvailable
+  };
   if (envelope === null) {
     const envelopelessIncomplete = isIncompleteFindings(findings);
     if (wouldBuryCompleted(envelopelessIncomplete)) {
@@ -3779,44 +3809,14 @@ ${note}
       ) : priorConv
     );
     const lostInput = {
+      ...sharedRenderInput,
       findings: stampedFindings2,
       envelope: null,
       incomplete: envelopelessIncomplete,
-      prices: decodedPrices.right,
-      pricesProvided: input.pricesProvided,
-      template,
-      route: effectiveRoute,
-      reviewedSha: input.headSha,
-      repo: input.headRepo || input.repo,
-      effort: input.effort,
       sameRootNotes: {},
-      // The answered-state honesty rules apply on EVERY surface that renders the filtered
-      // findings — the lost-envelope branch lists every VISIBLE finding (no inline review exists to
-      // carry them) so the kept re-raises' annotations actually render, and names the drops
-      // exactly like the main path (issues #151 review r1 + r2). The nit visibility floor applies
-      // here too (issue #164): below-floor nits are hidden from the human list and shown only in the
-      // collapsed aside — the floor is a human-visibility policy, not an inline-comment policy, so it
-      // must hold on the surface that lists findings without an inline review.
-      suppressedNits,
-      nitVisibilityFloor: input.nitVisibilityFloor,
-      answeredNotes: reRaisedNotes,
-      answeredReRaiseNote: answeredDropNote,
       roundCount: priorRoundCount,
       convergenceRound: false,
-      testReport,
-      clocDiff,
-      runUrl: input.runUrl,
-      unverifiedNoLogs: input.unverifiedNoLogs,
-      jsonUrl: input.jsonUrl,
-      findingsPointer: findingsBlob(stampedFindings2),
-      postedAt: input.postedAt,
-      summaryAvailable,
-      discussionByFinding,
-      orphanedDiscussion,
-      orphanedTotal,
-      discussionTruncated,
-      orphanedTruncated,
-      orphanedUnresolvable: orphanResolveFailed
+      findingsPointer: findingsBlob(stampedFindings2)
     };
     const lostRender = (opts) => formatMarkdown(
       render({
@@ -3894,7 +3894,6 @@ ${note}
   }
   const botReviews = await fetchBotReviews(input.repo, prNumber, input.botLogin, ghApi);
   const initialDisposition = !inlineRequested ? { kind: "disabled" } : comments.length === 0 && strays.length > 0 ? { kind: "none-in-diff" } : void 0;
-  const currentCounts = computeSeverityCounts(findings.findings);
   const currentCodes = computeIdCounts(findings.findings, findings.systemic_problems ?? []);
   const roundNumber = priorRoundCount + 1;
   const convergence = isRound ? buildConvergence(
@@ -3914,41 +3913,15 @@ ${note}
   const currentRoundCount = isRound ? roundNumber : priorRoundCount;
   const findingsMarker = findingsBlob(stampedFindings);
   const commonRenderInput = {
+    ...sharedRenderInput,
     findings: stampedFindings,
     envelope,
     incomplete: thisIncomplete,
-    prices: decodedPrices.right,
-    pricesProvided: input.pricesProvided,
-    template,
-    route: effectiveRoute,
-    reviewedSha: input.headSha,
-    repo: input.headRepo || input.repo,
-    effort: input.effort,
-    testReport,
-    clocDiff,
-    severityCounts: currentCounts,
     sameRootNotes,
-    answeredNotes: reRaisedNotes,
-    answeredReRaiseNote: answeredDropNote,
-    discussionByFinding,
-    orphanedDiscussion,
-    orphanedTotal,
-    discussionTruncated,
-    orphanedTruncated,
-    orphanedUnresolvable: orphanResolveFailed,
     roundCount: currentRoundCount,
-    convergenceThreshold: input.convergenceThreshold,
-    nitVisibilityFloor: input.nitVisibilityFloor,
     convergenceRound: isRound,
     strays,
-    suppressedNits,
-    runUrl: input.runUrl,
-    unverifiedNoLogs: input.unverifiedNoLogs,
-    jsonUrl: input.jsonUrl,
-    findingsPointer: findingsMarker,
-    postedAt: input.postedAt,
-    pricedAt: input.pricedAt,
-    summaryAvailable
+    findingsPointer: findingsMarker
   };
   const longFilesNote = longFiles.length > 0 ? `
 
@@ -4526,6 +4499,13 @@ failing_jobs=${String(result.failingJobs)}
 `;
   }
 };
+var FETCH_WITHOUT_DETACHED_CHILDREN = [
+  "-c",
+  "maintenance.auto=false",
+  "-c",
+  "gc.auto=0",
+  "fetch"
+];
 var runGit = (args) => execFileWithTimeout({
   command: "git",
   args,
@@ -4593,7 +4573,7 @@ var fetchFullDiff = async (repo, defaultBranch, headSha, ghApi, gitRun) => {
     process.stderr.write(`compare diff fetch failed (${errMsg(err)}) \u2014 falling back to git diff
 `);
   }
-  await gitRun(["fetch", "origin", headSha]);
+  await gitRun([...FETCH_WITHOUT_DETACHED_CHILDREN, "origin", headSha]);
   const base = (await gitRun(["rev-parse", "HEAD"])).trim();
   return gitRun(["diff", `${base}...${headSha}`]);
 };
@@ -4785,7 +4765,7 @@ var gather = async (input, ghApi = runGhApi, gitRun = runGit, readArtifact = ghA
       `PR diff fetch failed or was empty for ${String(meta.changed_files)} changed files \u2014 falling back to git diff
 `
     );
-    await gitRun(["fetch", "origin", input.headSha]);
+    await gitRun([...FETCH_WITHOUT_DETACHED_CHILDREN, "origin", input.headSha]);
     return gitRun(["diff", meta.base_sha, input.headSha]);
   })();
   const fullDiff = stacked ? await fetchFullDiff(input.repo, input.defaultBranch, input.headSha, ghApi, gitRun) : prDiff;
@@ -5153,7 +5133,6 @@ var composeReviewSettings = (opts) => {
 };
 
 // src/sandbox.ts
-var GITHUB_HOSTS = ["api.github.com", "github.com"];
 var deriveModelHost = (apiBaseUrl) => {
   const host = URL.canParse(apiBaseUrl) ? new URL(apiBaseUrl).hostname : "";
   if (host === "") {
@@ -5173,11 +5152,7 @@ var parseExtraEndpoints = (extra) => extra.split(/\s+/).map((token) => token.rep
 var buildSandboxConfig = (opts) => ({
   network: {
     allowedDomains: [
-      .../* @__PURE__ */ new Set([
-        deriveModelHost(opts.apiBaseUrl),
-        ...GITHUB_HOSTS,
-        ...parseExtraEndpoints(opts.extra ?? "")
-      ])
+      .../* @__PURE__ */ new Set([deriveModelHost(opts.apiBaseUrl), ...parseExtraEndpoints(opts.extra ?? "")])
     ],
     deniedDomains: []
   },
@@ -6969,7 +6944,7 @@ var checkScopeCmd = defineCommand({
 var sandboxConfigCmd = defineCommand({
   meta: {
     name: "sandbox-config",
-    description: "Emit the sandbox-runtime (srt) settings that jail the untrusted review agent's egress: allow the model host (derived from api_base_url), the GitHub API/host, and the consumer's extra_endpoints; deny all else; filesystem isolation off"
+    description: "Emit the sandbox-runtime (srt) settings that jail the untrusted review agent's egress: allow the model host (derived from api_base_url) and the consumer's extra_endpoints; deny all else; filesystem isolation off"
   },
   args: {
     "api-base-url": {