@jphutchins/code-review 0.1.0-alpha.60 → 0.1.0-alpha.62

package/README.md

@@ -67,7 +67,8 @@ in [templates/](templates/). See [docs/adapters.md](docs/adapters.md) for the ad
    window). Both are required: with no endpoint configured the workflow fails loudly rather than
    letting the CLI pick where your key gets sent.
 3. Commit `.github/prices.json` (fork [schema/prices.example.json](schema/prices.example.json) and
-   fill in your provider's per-token rates) — without it the cost footer renders **$0**
+   fill in your provider's per-token rates, and set `_updated` to the day you verified them — the
+   staleness warn keys on it) — without it the cost footer renders **N/A**
    ([SPEC §4.4](SPEC.md#44-required-controls-conformance)).
 4. Merge to your default branch first — `workflow_run` only fires from the default branch, so the
    introducing PR won't review itself — then open a test PR.

package/dist/index.js

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 import { defineCommand, runMain } from 'citty';
-import { readFileSync, writeFileSync, copyFileSync, statSync, readdirSync, appendFileSync } from 'fs';
+import { readFileSync, writeFileSync, unlinkSync, copyFileSync, statSync, readdirSync, appendFileSync } from 'fs';
 import { randomBytes, createHash } from 'crypto';
 import { resolve as resolve$1, join, dirname, basename, extname, sep } from 'path';
 import { Eta } from 'eta';
@@ -484,6 +484,9 @@ var incompleteFindings = (summary) => ({
 });
 var isIncompleteFindings = (findings) => findings.verdict === "error" && findings.findings.length === 0;
 
+// src/released.ts
+var RELEASED = "2026-09-27";
+
 // src/cost.ts
 var defaultWarn = (message) => {
   process.stderr.write(`${message}
@@ -515,7 +518,7 @@ var resolveFlatPrices = (model, p, pricedAt, warn) => {
   if (!("slots" in p)) return p;
   if (pricedAt === void 0) {
     warn(
-      `code-review cost: model "${model}" has time-slotted prices but no run instant was supplied to select a slot; cost for this model set to $0`
+      `code-review cost: model "${annotationSafe(model)}" has time-slotted prices but no run instant was supplied to select a slot; cost for this model renders as N/A`
     );
     return null;
   }
@@ -526,12 +529,12 @@ var resolveFlatPrices = (model, p, pricedAt, warn) => {
   const covering = slots.filter((s) => slotCovers(s, minute));
   if (covering.length === 1) return covering[0] ?? null;
   warn(
-    `code-review cost: model "${model}" \u2014 ${String(covering.length)} price slots in \`${useWeekend ? "weekend_slots" : "slots"}\` cover ${hhmmOf(minute)} UTC (expected exactly 1); that array must partition the 24h day with no gap or overlap; cost for this model set to $0`
+    `code-review cost: model "${annotationSafe(model)}" \u2014 ${String(covering.length)} price slots in \`${useWeekend ? "weekend_slots" : "slots"}\` cover ${hhmmOf(minute)} UTC (expected exactly 1); that array must partition the 24h day with no gap or overlap; cost for this model renders as N/A`
   );
   return null;
 };
 var computeModelCost = (entry, prices, pricedAt, warn) => {
-  const p = prices.models[entry.model];
+  const p = Object.hasOwn(prices.models, entry.model) ? prices.models[entry.model] : void 0;
   const cacheRead = entry.cache_read_tokens ?? 0;
   const cacheWrite = entry.cache_write_tokens ?? 0;
   const zero = {
@@ -540,16 +543,19 @@ var computeModelCost = (entry, prices, pricedAt, warn) => {
     outputTokens: entry.output_tokens,
     cacheReadTokens: cacheRead,
     cacheWriteTokens: cacheWrite,
-    costUSD: 0
+    costUSD: 0,
+    known: true
   };
   if (!p) {
     warn(
-      `code-review cost: unknown model "${entry.model}" \u2014 no entry in price map; cost for this model set to $0`
+      // annotationSafe: a model id is an unvalidated t.string — a CR/LF in it must not emit a
+      // second line the Actions runner parses as a workflow command.
+      `code-review cost: unknown model "${annotationSafe(entry.model)}" \u2014 no entry in price map; cost for this model renders as N/A`
     );
-    return zero;
+    return { ...zero, known: false };
   }
   const rate = resolveFlatPrices(entry.model, p, pricedAt, warn);
-  if (rate === null) return zero;
+  if (rate === null) return { ...zero, known: false };
   const costUSD = (entry.input_tokens * rate.in + entry.output_tokens * rate.out + cacheRead * rate.cache_read + cacheWrite * rate.cache_write) / 1e6;
   return { ...zero, costUSD };
 };
@@ -561,9 +567,35 @@ var computeCost = (models, prices, pricedAt, warn = defaultWarn) => {
     totalOutputTokens: lines.reduce((s, l) => s + l.outputTokens, 0),
     totalCacheReadTokens: lines.reduce((s, l) => s + l.cacheReadTokens, 0),
     totalCacheWriteTokens: lines.reduce((s, l) => s + l.cacheWriteTokens, 0),
-    totalCostUSD: lines.reduce((s, l) => s + l.costUSD, 0)
+    totalCostUSD: lines.reduce((s, l) => s + l.costUSD, 0),
+    allKnown: lines.every((l) => l.known)
   };
 };
+var parseIsoDate = (stamp) => {
+  if (!/^\d{4}-\d{2}-\d{2}$/.test(stamp)) return void 0;
+  const parsed = /* @__PURE__ */ new Date(`${stamp}T00:00:00Z`);
+  return !Number.isNaN(parsed.getTime()) && parsed.toISOString().slice(0, 10) === stamp ? stamp : void 0;
+};
+var costAxisAnnouncement = (report, markerExists) => {
+  if (report === null) return "none";
+  if (!report.allKnown) return markerExists ? "none" : "announce";
+  return markerExists ? "clear" : "none";
+};
+var warnStalePrices = (prices, warn = defaultWarn) => {
+  if (prices === null) return;
+  const updated = parseIsoDate(prices._updated);
+  if (updated === void 0) return;
+  if (updated > (/* @__PURE__ */ new Date()).toISOString().slice(0, 10)) {
+    warn(
+      `::warning:: code-review cost: the price map's _updated (${prices._updated}) is in the future \u2014 a typo'd year silences the staleness check permanently; re-verify and re-stamp`
+    );
+    return;
+  }
+  if (updated >= RELEASED) return;
+  warn(
+    `::warning:: code-review cost: the price map was last verified ${prices._updated}, before this CLI's release (${RELEASED}) \u2014 the map may miss pricing this CLI ships; re-verify against the provider's pricing page`
+  );
+};
 
 // src/patch.ts
 var HUNK_HEADER_RE = /^@@ -(\d+)(?:,\d+)? \+\d+(?:,\d+)? @@/;
@@ -1611,6 +1643,7 @@ var render = (input) => {
   const incomplete = (input.incomplete ?? input.envelope?.incomplete ?? false) || isIncompleteFindings(input.findings);
   const pricedAt = parseInstant(input.envelope?.generated_at) ?? input.pricedAt;
   const costReport = input.envelope ? computeCost(input.envelope.models, input.prices, pricedAt) : null;
+  const costProvenance = costReport === null || costReport.lines.length === 0 ? "unknown" : costReport.allKnown ? "complete" : costReport.lines.some((line) => line.known) ? "partial" : "unknown";
   const pricesProvided = input.pricesProvided ?? true;
   const route = input.route ?? input.envelope?.route ?? null;
   const effort = input.effort ?? input.envelope?.effort ?? null;
@@ -1721,6 +1754,13 @@ var render = (input) => {
     incomplete,
     costReport,
     pricesProvided,
+    costProvenance,
+    // The house sanitizer for untrusted template fields — collapses line breaks AND escapes
+    // backticks, so a hand-edited stamp cannot break the code span or the blockquote.
+    // A nonconforming stamp must not be presented as validated: the template shows a note
+    // instead of the smoothed value when the staleness axis cannot parse it.
+    stampValid: parseIsoDate(input.prices._updated) !== void 0,
+    pricesUpdatedAt: escapeCodeBackticks(input.prices._updated.replace(/\r/g, " ")).trim(),
     route,
     effort,
     modelNames,
@@ -1764,8 +1804,16 @@ var render = (input) => {
     answeredReRaiseNote: input.answeredReRaiseNote ?? "",
     reviewUrl: input.reviewUrl ?? null,
     formatTokens: (n) => Number.isFinite(n) && n >= 0 ? n.toLocaleString("en-US") : "\u2014",
-    // N/A (never a false $0.00) when no real price map was provided — real tokens, no rates to price them.
-    formatCost: (n) => !pricesProvided ? "N/A" : Number.isFinite(n) ? n > 0 && n.toFixed(2) === "0.00" ? "<$0.01" : `$${n.toFixed(2)}` : "\u2014",
+    // N/A (never a false $0.00) when no real price map was provided — real tokens, no rates to
+    // price them — and N/A for a model that missed the map entirely (issue #221): a misconfigured
+    // row must not look like a free review. Provenance is REQUIRED (no permissive default): a
+    // user-swapped template that drops the argument fails loudly, not silently fail-open.
+    formatCost: (n, provenance) => {
+      if (!pricesProvided || provenance !== "complete" && provenance !== "partial") return "N/A";
+      if (provenance === "partial" && !(n >= 5e-3)) return "N/A";
+      const figure = Number.isFinite(n) ? n > 0 && n.toFixed(2) === "0.00" ? "<$0.01" : `$${n.toFixed(2)}` : "\u2014";
+      return provenance === "partial" ? `\u2265 ${figure}` : figure;
+    },
     formatDuration: (ms) => {
       if (!Number.isFinite(ms) || ms < 0) return "\u2014";
       const s = Math.round(ms / 1e3);
@@ -2129,6 +2177,7 @@ var priorContextPath = (draftPath) => sidecarPath(draftPath, ".prior");
 var priorAnswersPath = (draftPath) => sidecarPath(draftPath, ".prior-answers");
 var priorSuppressedPath = (draftPath) => sidecarPath(draftPath, ".prior-suppressed");
 var lastValidPath = (draftPath) => sidecarPath(draftPath, ".last-valid");
+var costAxisDisengagedPath = (draftPath) => sidecarPath(draftPath, ".cost-axis-disengaged");
 var spawnFloorMessage = (draftPath) => `Write your own first-pass findings to ${draftPath} before spawning subagents \u2014 a review must never depend on subagents alone, and the pre-seeded $DRAFT is a non-review sentinel: it does not count until you have replaced it with your own review. Write ${draftPath} from what you have read so far (preliminary findings are fine), run \`code-review validate ${draftPath} --explain\` until it passes, then fan out; your subagents run in the background, so keep refining the draft as their reports arrive.`;
 var forceBackgroundSpawn = (toolInput) => ({
   hookSpecificOutput: {
@@ -3400,6 +3449,7 @@ ${dropNote}` : ""}`,
   if (decodedPrices._tag === "Left") {
     throw new Error(`Price map at ${input.pricesPath} does not match the expected shape`);
   }
+  warnStalePrices(input.pricesProvided ? decodedPrices.right : null);
   const template = readFileSync(input.templatePath, "utf-8");
   const inlineRequested = input.inline === true;
   const envelope = loadEnvelope(input.envelopePath);
@@ -4989,7 +5039,8 @@ var transcriptFallbackFrom = (path) => {
   return { models: usage.models, turns: usage.turns, durationMs: usage.durationMs };
 };
 var bundledPath = (...segments) => resolve$1(import.meta.dirname, "..", ...segments);
-var packageVersion = JSON.parse(readFileSync(bundledPath("package.json"), "utf-8")).version;
+var readPackageVersion = () => JSON.parse(readFileSync(bundledPath("package.json"), "utf-8")).version;
+var packageVersion = readPackageVersion();
 var resolveTemplatePath = (templateArg) => templateArg ? resolve$1(templateArg) : bundledPath("templates", "comment.eta");
 var resolveInlineTemplatePath = (templateArg) => templateArg ? resolve$1(templateArg) : bundledPath("templates", "inline.eta");
 var resolvePrices = (pricesArg) => {
@@ -5062,6 +5113,7 @@ var renderCmd = defineCommand({
     const templatePath = resolveTemplatePath(args.template);
     const priceResolution = resolvePrices(args.prices);
     const prices = decode(PriceMapCodec.decode(readJSON(priceResolution.path)), "prices");
+    warnStalePrices(priceResolution.kind === "provided" ? prices : null);
     const template = readFileSync(templatePath, "utf-8");
     const testReport = args["test-report"] ? decode(TestSummaryCodec.decode(readJSON(args["test-report"])), "test report") : void 0;
     const clocDiff = args["cloc-diff"] ? loadClocDiff(args["cloc-diff"]) : void 0;
@@ -5155,6 +5207,7 @@ var costCmd = defineCommand({
   run: async ({ args }) => {
     const envelope = decode(ResultEnvelopeCodec.decode(readJSON(args.envelope)), "envelope");
     const prices = decode(PriceMapCodec.decode(readJSON(args.prices)), "prices");
+    warnStalePrices(prices);
     const report = computeCost(
       envelope.models,
       prices,
@@ -5176,7 +5229,7 @@ var checkCostCmd = defineCommand({
     },
     prices: {
       type: "string",
-      description: "Path to price map JSON (default: bundled schema/prices.example.json \u2014 token totals stay real, cost reads as $0)"
+      description: "Path to price map JSON (default: bundled schema/prices.example.json \u2014 token totals stay real, cost reads as N/A)"
     }
   },
   run: async ({ args }) => {
@@ -5190,6 +5243,7 @@ var checkCostCmd = defineCommand({
     const usage = sumTranscriptUsage(tree.entries);
     const priceResolution = resolvePrices(args.prices);
     const prices = decode(PriceMapCodec.decode(readJSON(priceResolution.path)), "prices");
+    warnStalePrices(priceResolution.kind === "provided" ? prices : null);
     const report = computeCost(
       usage.models,
       prices,
@@ -5338,7 +5392,7 @@ var budgetHookCmd = defineCommand({
       const tree = transcriptPath ? readTranscriptTree(resolve$1(transcriptPath)) : void 0;
       const usage = tree ? sumTranscriptUsage(tree.entries) : void 0;
       const prices = args.prices ? tryReadPrices(args.prices) : null;
-      const spentUsd = prices !== null && usage ? (
+      const costReport = prices !== null && usage ? (
         // Price at the transcript's last activity instant, not the wall clock (issue #170 review
         // r2). Silent warn: this budget-steering cost is recomputed on EVERY tool event, so a
         // misconfigured slot map would otherwise flood stderr; the final post's cost render warns.
@@ -5347,8 +5401,27 @@ var budgetHookCmd = defineCommand({
           prices,
           usage.lastTsMs !== null ? new Date(usage.lastTsMs) : /* @__PURE__ */ new Date(),
           () => void 0
-        ).totalCostUSD
+        )
       ) : null;
+      if (!isSubagentHookInput(input)) {
+        const axisPath = costAxisDisengagedPath(draftPath);
+        const action = costAxisAnnouncement(costReport, readFileOrNull(axisPath) !== null);
+        if (action === "announce") {
+          process.stderr.write(
+            "code-review budget-hook: the price map does not cover every model in the transcript, or its slots leave the run instant uncovered \u2014 the cost axis is disengaged for this run; add the missing models (or fix the slot partition) and re-verify\n"
+          );
+          try {
+            writeFileSync(axisPath, "");
+          } catch {
+          }
+        } else if (action === "clear") {
+          try {
+            unlinkSync(axisPath);
+          } catch {
+          }
+        }
+      }
+      const spentUsd = costReport !== null && costReport.allKnown ? costReport.totalCostUSD : null;
       const wallMs = args.wall ? parseWallMs(args.wall) : null;
       const output2 = evaluateBudgetHook(input, {
         spentUsd,
@@ -6721,6 +6794,6 @@ if (!process.env["VITEST"]) {
   await runMain(main);
 }
 
-export { main, printableSchema, snapshotIfValid };
+export { main, printableSchema, readPackageVersion, snapshotIfValid };
 //# sourceMappingURL=index.js.map
 //# sourceMappingURL=index.js.map