@jphutchins/code-review 0.1.0-alpha.6 → 0.1.0-alpha.60

package/templates/comment.eta

@@ -1,52 +1,206 @@
 <!-- code-review -->
 <!-- reviewed-sha: <%= it.reviewedSha %> -->
-<% if (it.embeddedFindings) { -%>
-<!-- code-review:findings-json;base64 <%~ it.embeddedFindings %> -->
-<% } else if (it.jsonUrl) { -%>
-<!-- code-review:findings-json <%~ it.jsonUrl %> -->
+<% if (!it.incomplete && it.route) { -%>
+<!-- reviewed-route: <%= it.route %> -->
 <% } -%>
+<% if (!it.incomplete) { -%>
+<!-- review-complete -->
+<% } -%>
+<% if (it.findingsPointer) { -%>
+<%~ it.findingsPointer %>
+<% } -%>
+
+## <%= it.verdictBadge(it.findings.verdict) %>
 
-### <%= it.verdictBadge(it.findings.verdict) %>
+<% const meta = [] %><% if (it.postedAt) { meta.push('**Reviewed** `' + it.reviewedSha.slice(0, 7) + '` at ' + it.postedAt) } %><% if (it.route) { meta.push('**route:** ' + it.route) } %><% if (it.effort) { meta.push('**effort:** ' + it.effort) } %><% if (it.hasUsage) { meta.push('**turns:** ' + it.envelope.turns); meta.push('**wall:** ' + it.formatDuration(it.envelope.duration_ms)); meta.push('**models:** ' + it.modelNames); meta.push('**cost:** ' + it.formatCost(it.costReport.totalCostUSD)) } else { meta.push('_usage unavailable_') } %><sub><%~ meta.join(' · ') %></sub>
+<% if (!it.incomplete) { -%>
+<% if (it.roundsSummary) { -%>
+<sub><%~ it.roundsSummary %></sub>
+<% } -%>
+<% if (it.convergenceSummary) { -%>
+<sub><%~ it.convergenceSummary %></sub>
+<% } -%>
+<% if (it.changeSummary) { -%>
+<sub>**Changes:** <%~ it.changeSummary %></sub>
+<% } -%>
+<% if (it.clocDiff) { -%>
+<details><summary>📏 cloc</summary>
+
+```
+<%~ it.clocDiff %>
+```
+
+</details>
 
-<% const meta = [] %><% if (it.route) { meta.push('**Route:** ' + it.route) } %><% if (it.effort) { meta.push('**effort:** ' + it.effort) } %><% if (it.usageAvailable) { meta.push('**turns:** ' + it.envelope.turns); meta.push('**wall:** ' + it.formatDuration(it.envelope.duration_ms)); meta.push('**models:** ' + it.modelNames); meta.push('**cost:** ' + it.formatCost(it.costReport.totalCostUSD)) } else { meta.push('_usage unavailable_') } %><%~ meta.join(' · ') %>
+<% } -%>
+<% if (it.metastasisNote) { -%>
+<%~ it.metastasisNote %>
+<% } -%>
+<% if (it.answeredReRaiseNote) { -%>
+<%~ it.answeredReRaiseNote %>
+<% } -%>
+<% } -%>
 
 <%~ it.findings.summary %>
 
+<% if (!it.incomplete && it.systemic.length > 0) { -%>
+
+## 🔗 Systemic problems
+
+<% it.systemic.forEach(function(s) { -%>
+### <%= it.severityEmoji(s.severity) %> (<%= s.severity %>) <%= s.title %>
+<sub>confidence <%= it.formatConfidence(s.confidence) %><% if (s.id) { %> · id <% if (s.code_url) { %>[`<%~ s.id %>`](<%~ s.code_url %>)<% } else { %>`<%~ s.id %>`<% } %><% } %></sub>
+<% const meta = [] %><% if (s.paths && s.paths.length > 0) { meta.push('Affects: ' + s.paths.map(function(p) { return '`' + p + '`' }).join(', ')) } %><% if (s.finding_ids && s.finding_ids.length > 0) { meta.push('Ties together: ' + s.finding_ids.map(function(c) { return '`' + c + '`' }).join(', ')) } %><% if (meta.length > 0) { %>_<%~ meta.join(' · ') %>_<% } %>
+
+<%~ s.description %>
+<% if (s.discussionHtml) { -%>
+
+<details><summary>💬 Discussion</summary>
+
+<%~ s.discussionHtml %>
+</details>
+<% } -%>
+
+> <details><summary>Reasoning</summary>
+>
+<% s.reasoning.split("\n").forEach(function(rl) { -%>
+> <%= rl %>
+<% }) -%>
+>
+> </details>
+<% }) -%>
+<% } -%>
+
 ---
 
 <% const c = it.severityCounts %><% const findingsTotal = c.critical + c.major + c.minor + c.nit %>
+<% if (it.unverifiedNoLogs && findingsTotal > 0) { %>
+> [!WARNING]
+> **Unverified — no failing-job logs were available.** This route reads the failing CI job's log to
+> name the failure; none could be staged for this run, so every finding below was reasoned from the
+> diff or from local reproduction of the checks. Treat them as hypotheses until the failing log is
+> checked.
+
+<% } %>
+
 <% if (findingsTotal > 0) { %>
 <% const parts = [] %><% if (c.critical) { parts.push(it.severityEmoji('critical') + ' ' + c.critical) } %><% if (c.major) { parts.push(it.severityEmoji('major') + ' ' + c.major) } %><% if (c.minor) { parts.push(it.severityEmoji('minor') + ' ' + c.minor) } %><% if (c.nit) { parts.push(it.severityEmoji('nit') + ' ' + c.nit) } %>
 **Findings:** <%~ parts.join(' · ') %>
-<% } else { %>
-_No findings — clean review._
+<% } else if (!it.incomplete && it.systemic.length === 0 && !it.answeredReRaiseNote) { %>
+<% if (it.unverifiedNoLogs) { %>_No findings — but no failing-job logs were staged, so this pass could not read the CI failure. "No findings" is not evidence of none._<% } else { %>_No findings — clean review._<% } %>
 <% } %>
 
 <% if (it.inlineDisposition && it.inlineDisposition.kind === 'posted') { %>
-→ <%= it.inlineDisposition.count %> comment<%= it.inlineDisposition.count === 1 ? '' : 's' %> posted inline on `<%= it.inlineDisposition.sha.slice(0, 7) %>` — <% if (it.reviewUrl) { %>[see the review](<%~ it.reviewUrl %>)<% } else { %>see the review<% } %>.
+→ <%= it.inlineDisposition.count %> comment<%= it.inlineDisposition.count === 1 ? '' : 's' %> posted inline on `<%= it.inlineDisposition.sha.slice(0, 7) %>`<% if (it.reviewUrl) { %> — [see the review](<%~ it.reviewUrl %>)<% } %>.
 <% } else if (it.inlineDisposition && it.inlineDisposition.kind === 'none-in-diff') { %>
 → No inline comments — all findings are outside the diff (listed below).
-<% } else if (it.inlineDisposition && it.inlineDisposition.kind === 'suppressed-existing-review') { %>
-→ Inline review suppressed — `<%= it.inlineDisposition.sha.slice(0, 7) %>` was already reviewed.
+<% } else if (it.inlineDisposition && it.inlineDisposition.kind === 'inline-unavailable') { %>
+→ ⚠️ Inline comments couldn't be posted for this review (GitHub rejected a comment's position) — every finding is listed below instead.
+<% } else if (it.inlineDisposition && it.inlineDisposition.kind === 'whole-document') { %>
+→ This run's <%= it.incomplete ? 'review record' : 'complete review' %><% if (it.reviewUrl) { %> — [see the review](<%~ it.reviewUrl %>)<% } %>.
 <% } %>
 
 <% if (it.strays.length > 0) { %>
-#### ⚠️ Findings outside the diff
-
-These findings are on lines not in the diff, so they can't be anchored as inline comments:
+## <% if (it.inlineDisposition && (it.inlineDisposition.kind === 'disabled' || it.inlineDisposition.kind === 'whole-document')) { %>Findings<% } else if (it.inlineDisposition && it.inlineDisposition.kind === 'no-envelope') { %>Findings (no inline review — result envelope lost)<% } else { %><%= (it.unanchoredCount && it.unanchoredCount > 0) ? 'Findings' : 'Findings outside the diff' %><% } %>
+<% if (it.inlineDisposition && it.inlineDisposition.kind === 'no-envelope') { %>
+_Every finding is listed below — the inline review could not be built because the result envelope was missing._
+<% } else if (it.inlineDisposition && it.inlineDisposition.kind === 'whole-document') { %>
+_Every finding from this run<% if (it.inlineDisposition.inlineCount > 0) { %>, including the <%= it.inlineDisposition.inlineCount %> posted as inline comment<%= it.inlineDisposition.inlineCount === 1 ? '' : 's' %> on the diff<% } %><% if (it.inlineDisposition.rejectedCount > 0) { %>; <%= it.inlineDisposition.rejectedCount %> could not be anchored (GitHub rejected the position)<% } %>._
+<% } else if (it.unanchoredCount && it.unanchoredCount > 0) { %>
+_<%= it.unanchoredCount %> finding<%= it.unanchoredCount === 1 ? '' : 's' %> below couldn't be posted as inline comment<%= it.unanchoredCount === 1 ? '' : 's' %> (GitHub rejected the position)<% if (it.strays.length > it.unanchoredCount) { %>; the rest are outside the diff<% } %>._
+<% } %>
 
 <% it.strays.forEach(function(f) { -%>
-- <%= it.severityEmoji(f.severity) %> `<%= f.path %>:<%= f.start_line %><% if (f.start_line !== f.end_line) { %>–<%= f.end_line %><% } %>` — <%= f.title %><% if (typeof f.confidence === "number") { %> · confidence <%= f.confidence %><% } %>
-<% if (f.reasoning) { -%>
-  <details><summary>Reasoning</summary>
+### <%= it.severityEmoji(f.severity) %> (<%= f.severity %>) `<%= f.path %>:<%= f.rangeLabel %><% if (f.side) { %> (<%= f.side %>)<% } %>` — <%= f.title %>
+<sub>confidence <%= it.formatConfidence(f.confidence) %> · likelihood <%= it.formatConfidence(f.likelihood) %><% if (f.id) { %> · id <% if (f.code_url) { %>[`<%~ f.id %>`](<%~ f.code_url %>)<% } else { %>`<%~ f.id %>`<% } %><% } %></sub>
+<% if (f.permalink) { -%>
+
+<%~ f.permalink %><% if (f.permalinkAnchored) { %> · _agent-reported location_<% } %>
+<% } -%>
 
+<%~ f.description %>
+<% if (it.sameRootNotes && Object.prototype.hasOwnProperty.call(it.sameRootNotes, f.idKey)) { -%>
+
+> ⚠️ <%~ it.sameRootNotes[f.idKey] %>
+<% } -%>
+<% if (f.answeredNote) { -%>
+
+> ↩️ <%~ f.answeredNote %>
+<% } -%>
+<% if (f.recommendation) { -%>
+
+**Recommended fix:** <%~ f.recommendation %>
+<% } -%>
+<% if (f.patchProjection.kind === "suggestion") { -%>
+
+```suggestion
+<%~ f.patchProjection.text %>
+```
+<% } else if (f.patchProjection.kind === "patch") { -%>
+
+```patch
+<%~ f.patchProjection.raw %>
+```
+<% } -%>
+<% if (f.discussionHtml) { -%>
+
+<details><summary>💬 Discussion</summary>
+
+<%~ f.discussionHtml %>
+</details>
+<% } -%>
+
+> <details><summary>Reasoning</summary>
+>
 <% f.reasoning.split("\n").forEach(function(rl) { -%>
-  <%= rl %>
+> <%= rl %>
+<% }) -%>
+>
+> </details>
+<% }) %>
+<% } %>
+
+<% if (it.discussionDropped > 0) { %>
+_<%= it.discussionDropped %> discussion thread<%= it.discussionDropped === 1 ? '' : 's' %> not listed<% if ((it.discussionDroppedIds && it.discussionDroppedIds.length > 0) || (it.discussionDroppedSystemicIds && it.discussionDroppedSystemicIds.length > 0) || (it.discussionDroppedOrphanedIds && it.discussionDroppedOrphanedIds.length > 0)) { %> (<% if (it.discussionDroppedIds && it.discussionDroppedIds.length > 0) { %>finding<%= it.discussionDroppedIds.length === 1 ? '' : 's' %> <% it.discussionDroppedIds.forEach(function(id) { %>`<%~ id %>` <% }) %><% if ((it.discussionDroppedSystemicIds && it.discussionDroppedSystemicIds.length > 0) || (it.discussionDroppedOrphanedIds && it.discussionDroppedOrphanedIds.length > 0)) { %>· <% } %><% } %><% if (it.discussionDroppedSystemicIds && it.discussionDroppedSystemicIds.length > 0) { %>systemic<%= it.discussionDroppedSystemicIds.length === 1 ? '' : 's' %> <% it.discussionDroppedSystemicIds.forEach(function(id) { %>`<%~ id %>` <% }) %><% if (it.discussionDroppedOrphanedIds && it.discussionDroppedOrphanedIds.length > 0) { %>· <% } %><% } %><% if (it.discussionDroppedOrphanedIds && it.discussionDroppedOrphanedIds.length > 0) { %>earlier-round<% if (it.discussionDroppedOrphanedIds.length > 1) { %> (×<%= it.discussionDroppedOrphanedIds.length %>)<% } %> <% it.discussionDroppedOrphanedIds.forEach(function(id) { %>`<%~ id %>` <% }) %><% } %>)<% } %><% if (it.discussionDroppedExtra > 0) { %> +<%= it.discussionDroppedExtra %> more<% } %> — the links live on the comment thread._
+<% } %>
+
+<% if ((it.orphanedLines && it.orphanedLines.length > 0) || it.orphanedUnresolvable) { %>
+## 💬 Discussions on findings from earlier rounds
+
+<% if (it.orphanedUnresolvable && (!it.orphanedLines || it.orphanedLines.length === 0)) { %>
+_Comments naming tokens outside this round's report could not be matched against the prior findings — the prior findings artifact could not be resolved, so whether they name departed findings is unknown._
+<% } else { %>
+<details><summary>Comments naming findings this round no longer reports (fixed or re-id'd) — the conversation stays discoverable.<% if (it.orphanedTotal > it.orphanedLines.length) { %> (showing <%= it.orphanedLines.length %> of <%= it.orphanedTotal %>)<% } %></summary>
+
+<% it.orphanedLines.forEach(function(line) { -%>
+<%~ line %>
 <% }) -%>
 
-  </details>
+</details>
+<% } %>
+<% } %>
+
+<% if (it.suppressedNits && it.suppressedNits.length > 0) { %>
+> [!NOTE]
+> <details><summary>🔇 <%= it.suppressedNits.length %> nit<%= it.suppressedNits.length === 1 ? '' : 's' %> below the visibility floor (confidence × likelihood < <%= it.nitVisibilityFloor %>) — hidden</summary>
+>
+<% it.suppressedNits.forEach(function(n) { -%>
+> - `<%= n.path %>:<%= n.startLine %>` — <%= n.title %><% if (n.id) { %> (<% if (n.codeUrl) { %>[`<%~ n.id %>`](<%~ n.codeUrl %>)<% } else { %>`<%~ n.id %>`<% } %>)<% } %> _(m = <%= n.m %>)_
+<% if (n.discussionHtml) { %><%~ n.discussionHtml %><% } %>
+> <%~ '<!-- code-review:suppressed-nit' %>
+> <%~ 'severity: ' + n.severity %>
+> <%~ 'location: ' + n.path + ':' + n.startLine + '-' + n.endLine + (n.side ? ' (' + n.side + ')' : '') %>
+> <%~ 'confidence: ' + n.confidence + ' \u00b7 likelihood: ' + n.likelihood %>
+<% n.carried.forEach(function(cl) { -%>
+> <%~ cl %>
+<% }) -%>
+> <%~ '-->' %>
+<% }) -%>
+<% if (it.carriedDroppedNits > 0) { -%>
+> <%~ '<!-- code-review:suppressed-nit ' + it.carriedDroppedNits + ' nit(s) dropped from the sticky — their findings are in the artifact -->' %>
 <% } -%>
-<% }) %>
+>
+> </details>
 <% } %>
 
 <% if (it.testReport) { %>
@@ -83,5 +237,9 @@ All <%= it.testReport.total %> tests passed.
 <% } else { -%>
 > **Usage/cost unavailable** — the result envelope for this run was missing or malformed.
 <% } -%>
+<% if (it.usageAvailable && !it.pricesProvided) { -%>
+>
+> _Cost shown as **N/A** — [No `.github/prices.json`](https://github.com/JPHutchins/code-review/blob/main/schema/prices.example.json) price map to recompute from._
+<% } -%>
 >
 > _Generated by [code-review](https://github.com/JPHutchins/code-review)<% if (it.runUrl) { %> · [view the run & traces](<%~ it.runUrl %>)<% } %>._

package/templates/inline.eta

@@ -1,19 +1,35 @@
-<% if (it.jsonUrl) { -%>
-<!-- code-review:findings-json <%~ it.jsonUrl %> -->
+<% if (it.findingsPointer) { -%>
+<%~ it.findingsPointer %>
 <% } -%>
-<%= it.severityEmoji(it.severity) %> **<%= it.severity %>** — <%= it.title %>
+<%= it.severityEmoji(it.severity) %> <%= it.severity.charAt(0).toUpperCase() + it.severity.slice(1) %>: **<%= it.title %>** · <%= it.formatConfidence(it.confidence) %> confidence · <%= it.formatConfidence(it.likelihood) %> likelihood
 
-<%~ it.body %>
-<% if (it.suggestion !== null && it.suggestion !== undefined) { -%>
+<%~ it.description %>
+<% if (it.sameRootNote) { -%>
+
+> ⚠️ <%~ it.sameRootNote %>
+<% } -%>
+<% if (it.answeredNote) { -%>
+
+> ↩️ <%~ it.answeredNote %>
+<% } -%>
+<% if (it.recommendation) { -%>
+
+**Recommended fix:** <%~ it.recommendation %>
+<% } -%>
+<% if (it.patchProjection.kind === "suggestion") { -%>
 
 ```suggestion
-<%~ it.suggestion %>
+<%~ it.patchProjection.text %>
+```
+<% } else if (it.patchProjection.kind === "patch") { -%>
+
+```patch
+<%~ it.patchProjection.raw %>
 ```
 <% } -%>
 
 > [!TIP]
-> Generated by <%~ it.modelsText %><% if (typeof it.confidence === "number") { %> at <%= it.confidence %> confidence<% } %>.
-<% if (it.reasoning) { -%>
+> Generated by <%~ it.modelsText %>.
 > <details>
 > <summary>Reasoning</summary>
 >
@@ -22,4 +38,3 @@
 <% }) -%>
 >
 > </details>
-<% } -%>