@jphutchins/code-review 0.1.0-alpha.59 → 0.1.0-alpha.60

package/dist/index.js

@@ -2903,14 +2903,30 @@ var postInlineReview = async (pr, comments, inDiff, ghApi) => {
   const reviewsEndpoint = [`repos/${pr.repo}/pulls/${String(pr.prNumber)}/reviews`, "--input", "-"];
   try {
     const stdout = await ghApi(reviewsEndpoint, reviewBody(true));
-    return { url: parseHtmlUrl(stdout), inlinePosted: comments.length, unposted: [] };
+    return { url: parseHtmlUrl(stdout), posted: true, inlinePosted: comments.length, unposted: [] };
   } catch (err) {
-    if (comments.length === 0) throw err;
+    if (comments.length === 0) {
+      process.stderr.write(
+        `::warning:: the review-object POST on PR #${String(pr.prNumber)} failed (${errMsg(err)}) \u2014 the sticky carries the review, but no diff-anchored review object exists this round
+`
+      );
+      return { url: void 0, posted: false, inlinePosted: 0, unposted: [] };
+    }
     process.stderr.write(
       `Warning: the batched inline review on PR #${String(pr.prNumber)} was rejected (${errMsg(err)}) \u2014 posting the review body-only, then each comment individually to keep the ones GitHub accepts (issue #57)
 `
     );
-    const url = parseHtmlUrl(await ghApi(reviewsEndpoint, reviewBody(false)));
+    let url;
+    let posted = false;
+    try {
+      url = parseHtmlUrl(await ghApi(reviewsEndpoint, reviewBody(false)));
+      posted = true;
+    } catch (bodyErr) {
+      process.stderr.write(
+        `::warning:: the body-only review retry on PR #${String(pr.prNumber)} failed (${errMsg(bodyErr)}) \u2014 individual comments still re-post, but no breadcrumb review object exists this round
+`
+      );
+    }
     const commentsEndpoint = [
       `repos/${pr.repo}/pulls/${String(pr.prNumber)}/comments`,
       "--input",
@@ -2934,7 +2950,7 @@ var postInlineReview = async (pr, comments, inDiff, ghApi) => {
         );
       }
     }
-    return { url, inlinePosted, unposted };
+    return { url, posted, inlinePosted, unposted };
   }
 };
 var ISSUE_COMMENTS_JQ = '.[] | {id, user: (.user.login // "(deleted)"), created_at, html_url, body: (.body // "")}';
@@ -3731,6 +3747,7 @@ ${dropNote}` : ""}`,
   );
   const {
     url: reviewUrl,
+    posted: reviewObjectPosted,
     inlinePosted,
     unposted
   } = await postInlineReview(
@@ -3746,15 +3763,19 @@ ${dropNote}` : ""}`,
     ghApi
   );
   process.stderr.write(
-    inlineRequested ? `Posted a review with ${String(inlinePosted)} inline comment(s) on PR #${String(prNumber)}
+    reviewObjectPosted ? inlineRequested ? `Posted a review with ${String(inlinePosted)} inline comment(s) on PR #${String(prNumber)}
 ` : `Posted a body-only review on PR #${String(prNumber)}; the findings are in the sticky
+` : inlinePosted > 0 ? `No review object posted this round on PR #${String(prNumber)}, but ${String(inlinePosted)} inline comment(s) anchored \u2014 the sticky carries the review
+` : `No review object posted this round on PR #${String(prNumber)} \u2014 the sticky carries the review
 `
   );
   const priorReviewIds = botReviews.map((r) => r.id);
-  if (priorReviewIds.length > 0) {
+  if (reviewObjectPosted && priorReviewIds.length > 0) {
     await dismissReviews(input.repo, prNumber, priorReviewIds, ghApi);
   }
-  await minimizeComments(prNumber, priorInlineComments, ghApi);
+  if (reviewObjectPosted || inlinePosted > 0) {
+    await minimizeComments(prNumber, priorInlineComments, ghApi);
+  }
   const unanchoredCount = unposted.length;
   const finalStrays = unanchoredCount > 0 ? [...unposted, ...strays] : strays;
   const finalDiscussion = unanchoredCount > 0 ? buildStickyDiscussion(