@jphutchins/code-review 0.1.0-alpha.56 → 0.1.0-alpha.58

package/dist/index.js

@@ -63,7 +63,9 @@ var Confidence = t.refinement(t.number, (n) => n >= 0 && n <= 1, "Confidence");
 var Likelihood = t.refinement(t.number, (n) => n >= 0 && n <= 1, "Likelihood");
 var FiniteNumber = t.refinement(t.number, (n) => Number.isFinite(n), "FiniteNumber");
 var NonNegativePrice = t.refinement(t.number, (n) => n >= 0, "NonNegativePrice");
-var SCHEMA_VERSION_RE = /^(0|[1-9]\d*)\.(\d+)\.(\d+)(?:-[0-9A-Za-z-]+(?:\.[0-9A-Za-z-]+)*)?(?:\+[0-9A-Za-z-]+(?:\.[0-9A-Za-z-]+)*)?$/;
+var SEMVER_SUFFIX = "(?:-[0-9A-Za-z-]+(?:\\.[0-9A-Za-z-]+)*)?(?:\\+[0-9A-Za-z-]+(?:\\.[0-9A-Za-z-]+)*)?";
+var SCHEMA_VERSION_RE = new RegExp(`^(0|[1-9]\\d*)\\.(\\d+)\\.(\\d+)${SEMVER_SUFFIX}$`);
+var anchoredSchemaVersionPattern = (version) => `^${version.split(".").slice(0, 2).join("\\.")}\\.[0-9]+${SEMVER_SUFFIX}$`;
 var SchemaVersion = t.refinement(
   t.string,
   (s) => SCHEMA_VERSION_RE.test(s),
@@ -3393,7 +3395,7 @@ var post = async (input, ghApi = runGhApi, readArtifact = ghArtifactReader) => {
       noticeBody(
         `${DEFAULT_MARKER}
 
-\u26A0\uFE0F **CI-fix pass completed with no findings** for \`${input.headSha.slice(0, 7)}\`${input.unverifiedNoLogs === true ? ' \u2014 **but no failing-job logs were available**, so it had only the diff to work from and "no findings" is not evidence of none' : ""} \u2014 the completed full review of \`${priorSha ? priorSha.slice(0, 7) : "an earlier commit"}\` is preserved below.${dropNote ? `
+\u26A0\uFE0F **CI-fix pass completed with no findings** for \`${input.headSha.slice(0, 7)}\`${input.unverifiedNoLogs === true ? ' \u2014 **but no failing-job logs were available**, so it worked from the diff and any local reproduction of the checks, and "no findings" is not evidence of none' : ""} \u2014 the completed full review of \`${priorSha ? priorSha.slice(0, 7) : "an earlier commit"}\` is preserved below.${dropNote ? `
 
 ${dropNote}` : ""}`,
         sticky.body
@@ -4234,8 +4236,14 @@ var IssueCommentCodec = t.intersection([
     author_association: t.union([t.string, t.null])
   })
 ]);
-var JobCodec = t.type({ id: t.number, conclusion: t.union([t.string, t.null]) });
-var JOBS_JQ = ".jobs[] | {id: .id, conclusion: .conclusion}";
+var JobCodec = t.type({
+  id: t.number,
+  // A null name (an API edge) degrades to a nameless entry rather than aborting the whole gather —
+  // the identity the reproduction steer needs is best-effort, never load-bearing.
+  name: t.union([t.string, t.null]),
+  conclusion: t.union([t.string, t.null])
+});
+var JOBS_JQ = ".jobs[] | {id: .id, name: .name, conclusion: .conclusion}";
 var fetchPrMeta = async (repo, prNumber, ghApi) => {
   const stdout = await ghApi([
     `repos/${repo}/pulls/${String(prNumber)}`,
@@ -4396,6 +4404,13 @@ var downloadFailingJobLogs = async (repo, runId, outDir, ghApi) => {
   for (const job of selected) {
     try {
       const log = await ghApi([`repos/${repo}/actions/jobs/${String(job.id)}/logs`]);
+      if (log.trim() === "no log available" || log.trim() === "") {
+        process.stderr.write(
+          `Warning: job ${String(job.id)} has no log available (placeholder body) \u2014 not staged
+`
+        );
+        continue;
+      }
       writeFileSync(join(outDir, `job_${String(job.id)}.log`), log);
       staged += 1;
     } catch (err) {
@@ -4405,6 +4420,15 @@ var downloadFailingJobLogs = async (repo, runId, outDir, ghApi) => {
       );
     }
   }
+  writeFileSync(
+    join(outDir, "failed_jobs.json"),
+    `${JSON.stringify(
+      failing.map((j) => ({ name: j.name, conclusion: j.conclusion })),
+      null,
+      2
+    )}
+`
+  );
   if (failing.length > selected.length) {
     process.stderr.write(
       `::warning::${annotationSafe(`${String(failing.length)} failing job(s) in run ${runId}; staged ${String(staged)} of the first ${String(selected.length)} log(s) \u2014 the review does not see the rest`)}
@@ -4412,8 +4436,11 @@ var downloadFailingJobLogs = async (repo, runId, outDir, ghApi) => {
     );
   }
   if (staged === 0) {
+    const reported = failing.length > 0 ? `${String(failing.length)} failing job(s) reported` : "no job concluded 'failure' (timeouts or cancellations)";
     process.stderr.write(
-      `::warning::${annotationSafe(`No failing-job logs could be staged for run ${runId} (${String(failing.length)} failing job(s) reported) \u2014 the review has only the diff to work from`)}
+      `::warning::${annotationSafe(
+        `No failing-job logs could be staged for run ${runId} (${reported}) \u2014 the review must reproduce the failures itself${failing.length > 0 ? " (the failing jobs are listed in failed_jobs.json)" : ""}`
+      )}
 `
     );
   }
@@ -5464,11 +5491,20 @@ var deadlineCmd = defineCommand({
   }
 });
 var derivedSchemaVersion = (kind, raw) => kind === "findings" ? declaredVersion(raw) : void 0;
-var printableSchema = (schemaPath) => {
+var printableSchema = (schemaPath, pinVersion) => {
   const schema = JSON.parse(readFileSync(schemaPath, "utf-8"));
   const enforcementSchema = Object.fromEntries(
     Object.entries(schema).filter(([key2]) => key2 !== "$schema")
   );
+  if (!pinVersion) return JSON.stringify(enforcementSchema, null, 2);
+  const properties = enforcementSchema["properties"];
+  const schemaVersion = typeof properties === "object" && properties !== null ? properties["schema_version"] : void 0;
+  if (typeof schemaVersion === "object" && schemaVersion !== null) {
+    properties["schema_version"] = {
+      ...schemaVersion,
+      pattern: anchoredSchemaVersionPattern(DEFAULT_SCHEMA_VERSION)
+    };
+  }
   return JSON.stringify(enforcementSchema, null, 2);
 };
 var validateCmd = defineCommand({
@@ -5514,7 +5550,7 @@ var validateCmd = defineCommand({
         process.stderr.write(
           `
 The ${kind} document must conform to this schema (the field descriptions are the authoritative spec \u2014 match the property names exactly):
-${printableSchema(schemaPath)}
+${printableSchema(schemaPath, kind === "findings" && schemaPath === schemaPathFor(kind))}
 `
         );
       }
@@ -5983,7 +6019,26 @@ var printSchemaCmd = defineCommand({
   run: async ({ args }) => {
     const schemaKind = requireSchemaKind(args.name);
     const schemaPath = requireSchemaPath(schemaKind, args["schema-version"]);
-    process.stdout.write(`${printableSchema(schemaPath)}
+    process.stdout.write(
+      `${printableSchema(schemaPath, schemaKind === "findings" && schemaPath === schemaPathFor(schemaKind))}
+`
+    );
+  }
+});
+var defaultVersionCmd = defineCommand({
+  meta: {
+    name: "default-version",
+    description: "Print the in-force schema version the installed registry resolves by default \u2014 the value a draft should stamp as schema_version"
+  },
+  args: {
+    kind: {
+      type: "string",
+      description: "Schema kind (findings | triage | prices); default: findings"
+    }
+  },
+  run: async ({ args }) => {
+    const kind = requireSchemaKind(args.kind || "findings");
+    process.stdout.write(`${defaultVersion(kind)}
 `);
   }
 });
@@ -6081,7 +6136,7 @@ var stopGateCmd = defineCommand({
 var gatherCmd = defineCommand({
   meta: {
     name: "gather",
-    description: "Resolve the PR from the CI head SHA and gather review inputs (diff with git-diff fallback, PR context, prior bot review, untrusted PR conversation to triage, failing-job logs) as files for the review agent"
+    description: "Resolve the PR from the CI head SHA and gather review inputs (diff with git-diff fallback, PR context, prior bot review, untrusted PR conversation to triage, failing-job logs and the failing jobs' identities in failed_jobs.json) as files for the review agent"
   },
   args: {
     repo: { type: "string", description: "Repository (owner/name)", required: true },
@@ -6654,6 +6709,7 @@ var main = defineCommand({
     extract: extractCmd,
     "validate-patches": validatePatchesCmd,
     "print-schema": printSchemaCmd,
+    "default-version": defaultVersionCmd,
     "stop-gate": stopGateCmd,
     "budget-hook": budgetHookCmd,
     "print-settings": printSettingsCmd,
@@ -6665,6 +6721,6 @@ if (!process.env["VITEST"]) {
   await runMain(main);
 }
 
-export { main, snapshotIfValid };
+export { main, printableSchema, snapshotIfValid };
 //# sourceMappingURL=index.js.map
 //# sourceMappingURL=index.js.map