@jphutchins/code-review 0.1.0-alpha.56 → 0.1.0-alpha.57

package/dist/index.js

@@ -3393,7 +3393,7 @@ var post = async (input, ghApi = runGhApi, readArtifact = ghArtifactReader) => {
       noticeBody(
         `${DEFAULT_MARKER}
 
-\u26A0\uFE0F **CI-fix pass completed with no findings** for \`${input.headSha.slice(0, 7)}\`${input.unverifiedNoLogs === true ? ' \u2014 **but no failing-job logs were available**, so it had only the diff to work from and "no findings" is not evidence of none' : ""} \u2014 the completed full review of \`${priorSha ? priorSha.slice(0, 7) : "an earlier commit"}\` is preserved below.${dropNote ? `
+\u26A0\uFE0F **CI-fix pass completed with no findings** for \`${input.headSha.slice(0, 7)}\`${input.unverifiedNoLogs === true ? ' \u2014 **but no failing-job logs were available**, so it worked from the diff and any local reproduction of the checks, and "no findings" is not evidence of none' : ""} \u2014 the completed full review of \`${priorSha ? priorSha.slice(0, 7) : "an earlier commit"}\` is preserved below.${dropNote ? `
 
 ${dropNote}` : ""}`,
         sticky.body
@@ -4234,8 +4234,14 @@ var IssueCommentCodec = t.intersection([
     author_association: t.union([t.string, t.null])
   })
 ]);
-var JobCodec = t.type({ id: t.number, conclusion: t.union([t.string, t.null]) });
-var JOBS_JQ = ".jobs[] | {id: .id, conclusion: .conclusion}";
+var JobCodec = t.type({
+  id: t.number,
+  // A null name (an API edge) degrades to a nameless entry rather than aborting the whole gather —
+  // the identity the reproduction steer needs is best-effort, never load-bearing.
+  name: t.union([t.string, t.null]),
+  conclusion: t.union([t.string, t.null])
+});
+var JOBS_JQ = ".jobs[] | {id: .id, name: .name, conclusion: .conclusion}";
 var fetchPrMeta = async (repo, prNumber, ghApi) => {
   const stdout = await ghApi([
     `repos/${repo}/pulls/${String(prNumber)}`,
@@ -4396,6 +4402,13 @@ var downloadFailingJobLogs = async (repo, runId, outDir, ghApi) => {
   for (const job of selected) {
     try {
       const log = await ghApi([`repos/${repo}/actions/jobs/${String(job.id)}/logs`]);
+      if (log.trim() === "no log available" || log.trim() === "") {
+        process.stderr.write(
+          `Warning: job ${String(job.id)} has no log available (placeholder body) \u2014 not staged
+`
+        );
+        continue;
+      }
       writeFileSync(join(outDir, `job_${String(job.id)}.log`), log);
       staged += 1;
     } catch (err) {
@@ -4405,6 +4418,15 @@ var downloadFailingJobLogs = async (repo, runId, outDir, ghApi) => {
       );
     }
   }
+  writeFileSync(
+    join(outDir, "failed_jobs.json"),
+    `${JSON.stringify(
+      failing.map((j) => ({ name: j.name, conclusion: j.conclusion })),
+      null,
+      2
+    )}
+`
+  );
   if (failing.length > selected.length) {
     process.stderr.write(
       `::warning::${annotationSafe(`${String(failing.length)} failing job(s) in run ${runId}; staged ${String(staged)} of the first ${String(selected.length)} log(s) \u2014 the review does not see the rest`)}
@@ -4412,8 +4434,11 @@ var downloadFailingJobLogs = async (repo, runId, outDir, ghApi) => {
     );
   }
   if (staged === 0) {
+    const reported = failing.length > 0 ? `${String(failing.length)} failing job(s) reported` : "no job concluded 'failure' (timeouts or cancellations)";
     process.stderr.write(
-      `::warning::${annotationSafe(`No failing-job logs could be staged for run ${runId} (${String(failing.length)} failing job(s) reported) \u2014 the review has only the diff to work from`)}
+      `::warning::${annotationSafe(
+        `No failing-job logs could be staged for run ${runId} (${reported}) \u2014 the review must reproduce the failures itself${failing.length > 0 ? " (the failing jobs are listed in failed_jobs.json)" : ""}`
+      )}
 `
     );
   }
@@ -6081,7 +6106,7 @@ var stopGateCmd = defineCommand({
 var gatherCmd = defineCommand({
   meta: {
     name: "gather",
-    description: "Resolve the PR from the CI head SHA and gather review inputs (diff with git-diff fallback, PR context, prior bot review, untrusted PR conversation to triage, failing-job logs) as files for the review agent"
+    description: "Resolve the PR from the CI head SHA and gather review inputs (diff with git-diff fallback, PR context, prior bot review, untrusted PR conversation to triage, failing-job logs and the failing jobs' identities in failed_jobs.json) as files for the review agent"
   },
   args: {
     repo: { type: "string", description: "Repository (owner/name)", required: true },