@jphutchins/code-review 0.1.0-alpha.52 → 0.1.0-alpha.53

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@jphutchins/code-review",
-  "version": "0.1.0-alpha.52",
-  "description": "Deterministic commenter for agentic PR review \u2014 gather, render, inline, post, adapt, extract, cost, validate, print-schema",
+  "version": "0.1.0-alpha.53",
+  "description": "Deterministic commenter for agentic PR review — gather, render, inline, post, adapt, extract, cost, validate, print-schema",
   "type": "module",
   "license": "MIT",
   "author": "JP Hutchins <jp@intercreate.io>",

package/templates/comment.eta

@@ -48,7 +48,7 @@
 ### 🔗 Systemic problems
 
 <% it.systemic.forEach(function(s) { -%>
-#### <%= it.severityEmoji(s.severity) %> (<%= s.severity %>) <%= s.title %> · confidence <%= it.formatConfidence(s.confidence) %>
+#### <%= it.severityEmoji(s.severity) %> (<%= s.severity %>) <%= s.title %><% if (s.code) { %> (<% if (s.code_url) { %>[`<%= s.code %>`](<%~ s.code_url %>)<% } else { %>`<%= s.code %>`<% } %>)<% } %> · confidence <%= it.formatConfidence(s.confidence) %>
 <% const meta = [] %><% if (s.paths && s.paths.length > 0) { meta.push('Affects: ' + s.paths.map(function(p) { return '`' + p + '`' }).join(', ')) } %><% if (s.finding_codes && s.finding_codes.length > 0) { meta.push('Ties together: ' + s.finding_codes.map(function(c) { return '`' + c + '`' }).join(', ')) } %><% if (meta.length > 0) { %>_<%~ meta.join(' · ') %>_<% } %>
 
 <%~ s.description %>
@@ -103,12 +103,12 @@ _<%= it.unanchoredCount %> finding<%= it.unanchoredCount === 1 ? '' : 's' %> bel
 <% } %>
 
 <% it.strays.forEach(function(f) { -%>
-#### <%= it.severityEmoji(f.severity) %> (<%= f.severity %>) `<%= f.path %>:<%= f.start_line %><% if (f.start_line !== f.end_line) { %>–<%= f.end_line %><% } %>` — <%= f.title %> · confidence <%= it.formatConfidence(f.confidence) %> · likelihood <%= it.formatConfidence(f.likelihood) %>
+#### <%= it.severityEmoji(f.severity) %> (<%= f.severity %>) `<%= f.path %>:<%= f.start_line %><% if (f.start_line !== f.end_line) { %>–<%= f.end_line %><% } %><% if (f.side) { %> (<%= f.side %>)<% } %>` — <%= f.title %><% if (f.code) { %> (<% if (f.code_url) { %>[`<%= f.code %>`](<%~ f.code_url %>)<% } else { %>`<%= f.code %>`<% } %>)<% } %> · confidence <%= it.formatConfidence(f.confidence) %> · likelihood <%= it.formatConfidence(f.likelihood) %>
 
 <%~ f.description %>
-<% if (f.code && it.sameRootNotes && Object.prototype.hasOwnProperty.call(it.sameRootNotes, f.code)) { -%>
+<% if (f.code && it.sameRootNotes && Object.prototype.hasOwnProperty.call(it.sameRootNotes, (f.codeKey !== undefined ? f.codeKey : f.code))) { -%>
 
-> ⚠️ <%~ it.sameRootNotes[f.code] %>
+> ⚠️ <%~ it.sameRootNotes[(f.codeKey !== undefined ? f.codeKey : f.code)] %>
 <% } -%>
 <% if (f.answeredNote) { -%>
 
@@ -146,8 +146,19 @@ _<%= it.unanchoredCount %> finding<%= it.unanchoredCount === 1 ? '' : 's' %> bel
 > <details><summary>🔇 <%= it.suppressedNits.length %> nit<%= it.suppressedNits.length === 1 ? '' : 's' %> below the visibility floor (confidence × likelihood < <%= it.nitVisibilityFloor %>) — hidden</summary>
 >
 <% it.suppressedNits.forEach(function(n) { -%>
-> - `<%= n.path %>:<%= n.startLine %>` — <%= n.title %><% if (n.code) { %> (`<%= n.code %>`)<% } %> _(m = <%= n.m %>)_
+> - `<%= n.path %>:<%= n.startLine %>` — <%= n.title %><% if (n.code) { %> (<% if (n.codeUrl) { %>[`<%= n.code %>`](<%~ n.codeUrl %>)<% } else { %>`<%= n.code %>`<% } %>)<% } %> _(m = <%= n.m %>)_
+> <%~ '<!-- code-review:suppressed-nit' %>
+> <%~ 'severity: ' + n.severity %>
+> <%~ 'location: ' + n.path + ':' + n.startLine + '-' + n.endLine + (n.side ? ' (' + n.side + ')' : '') %>
+> <%~ 'confidence: ' + n.confidence + ' \u00b7 likelihood: ' + n.likelihood %>
+<% n.carried.forEach(function(cl) { -%>
+> <%~ cl %>
 <% }) -%>
+> <%~ '-->' %>
+<% }) -%>
+<% if (it.carriedDroppedNits > 0) { -%>
+> <%~ '<!-- code-review:suppressed-nit ' + it.carriedDroppedNits + ' nit(s) dropped from the sticky — their findings are in the artifact -->' %>
+<% } -%>
 >
 > </details>
 <% } %>