@jphutchins/code-review 0.1.0-alpha.5 → 0.1.0-alpha.50

package/templates/comment.eta

@@ -1,40 +1,144 @@
 <!-- code-review -->
 <!-- reviewed-sha: <%= it.reviewedSha %> -->
+<% if (!it.incomplete && it.route) { -%>
+<!-- reviewed-route: <%= it.route %> -->
+<% } -%>
+<% if (!it.incomplete) { -%>
+<!-- review-complete -->
+<% } -%>
+<% if (it.findingsPointer) { -%>
+<%~ it.findingsPointer %>
+<% } -%>
 
 ### <%= it.verdictBadge(it.findings.verdict) %>
 
-<% const meta = [] %><% if (it.route) { meta.push('**Route:** ' + it.route) } %><% if (it.effort) { meta.push('**effort:** ' + it.effort) } %><% if (it.usageAvailable) { meta.push('**turns:** ' + it.envelope.turns); meta.push('**wall:** ' + it.formatDuration(it.envelope.duration_ms)) } else { meta.push('_usage unavailable_') } %><%~ meta.join(' · ') %>
+<% const meta = [] %><% if (it.postedAt) { meta.push('**Reviewed** `' + it.reviewedSha.slice(0, 7) + '` at ' + it.postedAt) } %><% if (it.route) { meta.push('**route:** ' + it.route) } %><% if (it.effort) { meta.push('**effort:** ' + it.effort) } %><% if (it.hasUsage) { meta.push('**turns:** ' + it.envelope.turns); meta.push('**wall:** ' + it.formatDuration(it.envelope.duration_ms)); meta.push('**models:** ' + it.modelNames); meta.push('**cost:** ' + it.formatCost(it.costReport.totalCostUSD)) } else { meta.push('_usage unavailable_') } %><sub><%~ meta.join(' · ') %></sub>
+<% if (!it.incomplete) { -%>
+<% if (it.roundsSummary) { -%>
+<sub><%~ it.roundsSummary %></sub>
+<% } -%>
+<% if (it.convergenceSummary) { -%>
+<sub><%~ it.convergenceSummary %></sub>
+<% } -%>
+<% if (it.changeSummary) { -%>
+<sub>**Changes:** <%~ it.changeSummary %></sub>
+<% } -%>
+<% if (it.clocDiff) { -%>
+<details><summary>📏 cloc</summary>
+
+```
+<%~ it.clocDiff %>
+```
+
+</details>
+<% } -%>
+<% if (it.metastasisNote) { -%>
+<%~ it.metastasisNote %>
+<% } -%>
+<% if (it.answeredReRaiseNote) { -%>
+<%~ it.answeredReRaiseNote %>
+<% } -%>
+<% } -%>
 
 <%~ it.findings.summary %>
 
+<% if (!it.incomplete && it.systemic.length > 0) { -%>
+
+### 🔗 Systemic problems
+
+<% it.systemic.forEach(function(s) { -%>
+#### <%= it.severityEmoji(s.severity) %> (<%= s.severity %>) <%= s.title %> · confidence <%= it.formatConfidence(s.confidence) %>
+<% const meta = [] %><% if (s.paths && s.paths.length > 0) { meta.push('Affects: ' + s.paths.map(function(p) { return '`' + p + '`' }).join(', ')) } %><% if (s.finding_codes && s.finding_codes.length > 0) { meta.push('Ties together: ' + s.finding_codes.map(function(c) { return '`' + c + '`' }).join(', ')) } %><% if (meta.length > 0) { %>_<%~ meta.join(' · ') %>_<% } %>
+
+<%~ s.description %>
+
+> [!TIP]
+> <details><summary>Reasoning</summary>
+>
+<% s.reasoning.split("\n").forEach(function(rl) { -%>
+> <%= rl %>
+<% }) -%>
+>
+> </details>
+<% }) -%>
+<% } -%>
+
 ---
 
 <% const c = it.severityCounts %><% const findingsTotal = c.critical + c.major + c.minor + c.nit %>
 <% if (findingsTotal > 0) { %>
 <% const parts = [] %><% if (c.critical) { parts.push(it.severityEmoji('critical') + ' ' + c.critical) } %><% if (c.major) { parts.push(it.severityEmoji('major') + ' ' + c.major) } %><% if (c.minor) { parts.push(it.severityEmoji('minor') + ' ' + c.minor) } %><% if (c.nit) { parts.push(it.severityEmoji('nit') + ' ' + c.nit) } %>
 **Findings:** <%~ parts.join(' · ') %>
-<% } else { %>
+<% } else if (!it.incomplete && it.systemic.length === 0 && !it.answeredReRaiseNote) { %>
 _No findings — clean review._
 <% } %>
 
 <% if (it.inlineDisposition && it.inlineDisposition.kind === 'posted') { %>
-→ <%= it.inlineDisposition.count %> comment<%= it.inlineDisposition.count === 1 ? '' : 's' %> posted inline on `<%= it.inlineDisposition.sha.slice(0, 7) %>` — see the review.
+→ <%= it.inlineDisposition.count %> comment<%= it.inlineDisposition.count === 1 ? '' : 's' %> posted inline on `<%= it.inlineDisposition.sha.slice(0, 7) %>` — <% if (it.reviewUrl) { %>[see the review](<%~ it.reviewUrl %>)<% } else { %>see the review<% } %>.
 <% } else if (it.inlineDisposition && it.inlineDisposition.kind === 'none-in-diff') { %>
 → No inline comments — all findings are outside the diff (listed below).
-<% } else if (it.inlineDisposition && it.inlineDisposition.kind === 'suppressed-existing-review') { %>
-→ Inline review suppressed — `<%= it.inlineDisposition.sha.slice(0, 7) %>` was already reviewed.
+<% } else if (it.inlineDisposition && it.inlineDisposition.kind === 'inline-unavailable') { %>
+→ ⚠️ Inline comments couldn't be posted for this review (GitHub rejected a comment's position) — every finding is listed below instead.
 <% } %>
 
 <% if (it.strays.length > 0) { %>
-#### ⚠️ Findings outside the diff
-
-These findings are on lines not in the diff, so they can't be anchored as inline comments:
+### <% if (it.inlineDisposition && it.inlineDisposition.kind === 'no-envelope') { %>Findings (no inline review — result envelope lost)<% } else { %><%= (it.unanchoredCount && it.unanchoredCount > 0) ? 'Findings' : 'Findings outside the diff' %><% } %>
+<% if (it.inlineDisposition && it.inlineDisposition.kind === 'no-envelope') { %>
+_Every finding is listed below — the inline review could not be built because the result envelope was missing._
+<% } else if (it.unanchoredCount && it.unanchoredCount > 0) { %>
+_<%= it.unanchoredCount %> finding<%= it.unanchoredCount === 1 ? '' : 's' %> below couldn't be posted as inline comment<%= it.unanchoredCount === 1 ? '' : 's' %> (GitHub rejected the position)<% if (it.strays.length > it.unanchoredCount) { %>; the rest are outside the diff<% } %>._
+<% } %>
 
 <% it.strays.forEach(function(f) { -%>
-- <%= it.severityEmoji(f.severity) %> `<%= f.path %>:<%= f.start_line %><% if (f.start_line !== f.end_line) { %>–<%= f.end_line %><% } %>` — <%= f.title %>
+#### <%= it.severityEmoji(f.severity) %> (<%= f.severity %>) `<%= f.path %>:<%= f.start_line %><% if (f.start_line !== f.end_line) { %>–<%= f.end_line %><% } %>` — <%= f.title %> · confidence <%= it.formatConfidence(f.confidence) %> · likelihood <%= it.formatConfidence(f.likelihood) %>
+
+<%~ f.description %>
+<% if (f.code && it.sameRootNotes && Object.prototype.hasOwnProperty.call(it.sameRootNotes, f.code)) { -%>
+
+> ⚠️ <%~ it.sameRootNotes[f.code] %>
+<% } -%>
+<% if (f.answeredNote) { -%>
+
+> ↩️ <%~ f.answeredNote %>
+<% } -%>
+<% if (f.recommendation) { -%>
+
+**Recommended fix:** <%~ f.recommendation %>
+<% } -%>
+<% if (f.patchProjection.kind === "suggestion") { -%>
+
+```suggestion
+<%~ f.patchProjection.text %>
+```
+<% } else if (f.patchProjection.kind === "patch") { -%>
+
+```patch
+<%~ f.patchProjection.raw %>
+```
+<% } -%>
+
+> [!TIP]
+> <details><summary>Reasoning (<%= it.formatConfidence(f.confidence) %> confidence · <%= it.formatConfidence(f.likelihood) %> likelihood)</summary>
+>
+<% f.reasoning.split("\n").forEach(function(rl) { -%>
+> <%= rl %>
+<% }) -%>
+>
+> </details>
 <% }) %>
 <% } %>
 
+<% if (it.suppressedNits && it.suppressedNits.length > 0) { %>
+> [!NOTE]
+> <details><summary>🔇 <%= it.suppressedNits.length %> nit<%= it.suppressedNits.length === 1 ? '' : 's' %> below the visibility floor (confidence × likelihood < <%= it.nitVisibilityFloor %>) — hidden</summary>
+>
+<% it.suppressedNits.forEach(function(n) { -%>
+> - `<%= n.path %>:<%= n.startLine %>` — <%= n.title %><% if (n.code) { %> (`<%= n.code %>`)<% } %> _(m = <%= n.m %>)_
+<% }) -%>
+>
+> </details>
+<% } %>
+
 <% if (it.testReport) { %>
 ---
 
@@ -54,24 +158,24 @@ All <%= it.testReport.total %> tests passed.
 
 ---
 
-<% if (it.usageAvailable && it.costReport.lines.length > 0) { %>
-<sub>
-
-| Model | Input | Output | Cache read | Cache write | Cost |
-|---|--:|--:|--:|--:|--:|
+> [!WARNING]
+> **LLM Disclosure** — this review was produced by <%= it.modelNames || "unknown model" %>.
+>
+<% if (it.usageAvailable && it.costReport.lines.length > 0) { -%>
+> | Model | Input | Output | Cache read | Cache write | Cost |
+> |---|--:|--:|--:|--:|--:|
 <% it.costReport.lines.forEach(function(l) { -%>
-| <%= l.model %> | <%= it.formatTokens(l.inputTokens) %> | <%= it.formatTokens(l.outputTokens) %> | <%= it.formatTokens(l.cacheReadTokens) %> | <%= it.formatTokens(l.cacheWriteTokens) %> | <%= it.formatCost(l.costUSD) %> |
+> | <%= l.model %> | <%= it.formatTokens(l.inputTokens) %> | <%= it.formatTokens(l.outputTokens) %> | <%= it.formatTokens(l.cacheReadTokens) %> | <%= it.formatTokens(l.cacheWriteTokens) %> | <%= it.formatCost(l.costUSD) %> |
 <% }) -%>
-| **Total** | **<%= it.formatTokens(it.costReport.totalInputTokens) %>** | **<%= it.formatTokens(it.costReport.totalOutputTokens) %>** | **<%= it.formatTokens(it.costReport.totalCacheReadTokens) %>** | **<%= it.formatTokens(it.costReport.totalCacheWriteTokens) %>** | **<%= it.formatCost(it.costReport.totalCostUSD) %>** |
-
-</sub>
-<% } else if (it.usageAvailable) { %>
-<sub>No per-model usage was recorded for this run.</sub>
-<% } else { %>
+> | **Total** | **<%= it.formatTokens(it.costReport.totalInputTokens) %>** | **<%= it.formatTokens(it.costReport.totalOutputTokens) %>** | **<%= it.formatTokens(it.costReport.totalCacheReadTokens) %>** | **<%= it.formatTokens(it.costReport.totalCacheWriteTokens) %>** | **<%= it.formatCost(it.costReport.totalCostUSD) %>** |
+<% } else if (it.usageAvailable) { -%>
+> No per-model usage was recorded for this run.
+<% } else { -%>
 > **Usage/cost unavailable** — the result envelope for this run was missing or malformed.
-<% } %>
-
-> [!NOTE]
-> **LLM Disclosure** — this review was produced by <%= it.modelNames || "unknown model" %> running
-> headless in an ephemeral, egress-locked CI runner with no write access to the repository. It is
-> advisory and does not block merge.
+<% } -%>
+<% if (it.usageAvailable && !it.pricesProvided) { -%>
+>
+> _Cost shown as **N/A** — [No `.github/prices.json`](https://github.com/JPHutchins/code-review/blob/main/schema/prices.example.json) price map to recompute from._
+<% } -%>
+>
+> _Generated by [code-review](https://github.com/JPHutchins/code-review)<% if (it.runUrl) { %> · [view the run & traces](<%~ it.runUrl %>)<% } %>._

package/templates/inline.eta

@@ -1,9 +1,40 @@
-<%~ it.body %>
+<% if (it.findingsPointer) { -%>
+<%~ it.findingsPointer %>
+<% } -%>
+<%= it.severityEmoji(it.severity) %> <%= it.severity.charAt(0).toUpperCase() + it.severity.slice(1) %>: **<%= it.title %>** · <%= it.formatConfidence(it.confidence) %> confidence · <%= it.formatConfidence(it.likelihood) %> likelihood
+
+<%~ it.description %>
+<% if (it.sameRootNote) { -%>
+
+> ⚠️ <%~ it.sameRootNote %>
+<% } -%>
+<% if (it.answeredNote) { -%>
+
+> ↩️ <%~ it.answeredNote %>
+<% } -%>
+<% if (it.recommendation) { -%>
+
+**Recommended fix:** <%~ it.recommendation %>
+<% } -%>
+<% if (it.patchProjection.kind === "suggestion") { -%>
 
-<% if (it.suggestion !== null && it.suggestion !== undefined) { %>
 ```suggestion
-<%~ it.suggestion %>
+<%~ it.patchProjection.text %>
+```
+<% } else if (it.patchProjection.kind === "patch") { -%>
+
+```patch
+<%~ it.patchProjection.raw %>
 ```
-<% } %>
+<% } -%>
 
-<sub>🤖 AI-generated — advisory only</sub>
+> [!TIP]
+> Generated by <%~ it.modelsText %>.
+> <details>
+> <summary>Reasoning</summary>
+>
+<% it.reasoning.split("\n").forEach(function(rl) { -%>
+> <%= rl %>
+<% }) -%>
+>
+> </details>