@jphutchins/code-review 0.1.0-alpha.47 → 0.1.0-alpha.49

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jphutchins/code-review",
-  "version": "0.1.0-alpha.47",
+  "version": "0.1.0-alpha.49",
   "description": "Deterministic commenter for agentic PR review — gather, render, inline, post, adapt, extract, cost, validate, print-schema",
   "type": "module",
   "license": "MIT",

package/schema/VERSIONING.md

@@ -106,7 +106,8 @@ policy; the `main` `$id` tracks latest, tagged releases pin to the version. Its
 
 | Version | Status | Notes |
 |---|---|---|
-| `v0.1.0` | **current** | Initial price-map schema. Per-model `in`/`out`/`cache_read`/`cache_write` (USD per 1M tokens); `_updated` date; `_unit`. |
+| `v0.1.0` | superseded | Initial price-map schema. Per-model `in`/`out`/`cache_read`/`cache_write` (USD per 1M tokens); `_updated` date; `_unit`. |
+| `v0.2.0` | **current** | A model's value is now a `oneOf` (issue #170): the flat shape above, OR `{ "slots": [ { "utc_from", "utc_to", "in", "out", "cache_read", "cache_write" } ] }` — UTC time-of-day pricing (half-open `[utc_from, utc_to)` windows; `utc_to <= utc_from` wraps past midnight; slots must partition the 24h day). Additive/backward-compatible: every flat map keeps validating. |
 
 The `_updated` field inside a price-map instance tracks **price drift** (a data concern) and is
 distinct from the schema's semver version (a **contract** concern). Adding a new price field (e.g. a

package/schema/findings.schema.json

@@ -172,6 +172,40 @@
         }
       }
     },
+    "change_size": {
+      "type": "object",
+      "additionalProperties": false,
+      "description": "Best-effort (issue #182): the change's added/removed line counts bucketed by ROLE. Fill this with a LOW-effort path heuristic, no file introspection: a file under a tests directory or matching *.test.* / *_test.* is `tests`; a *.md file, anything under docs/, or a license/config doc is `docs`; everything else is `code`. Sum the diff's added and removed lines per bucket. Omit a role that did not change, or omit the whole field if you cannot estimate it. Chrome only — never affects the verdict or the convergence score. (The per-language cloc table shown beside it is supplied deterministically by the pipeline, not by you.)",
+      "properties": {
+        "code": {
+          "type": "object",
+          "additionalProperties": false,
+          "required": ["added", "removed"],
+          "properties": {
+            "added": { "type": "integer", "minimum": 0 },
+            "removed": { "type": "integer", "minimum": 0 }
+          }
+        },
+        "tests": {
+          "type": "object",
+          "additionalProperties": false,
+          "required": ["added", "removed"],
+          "properties": {
+            "added": { "type": "integer", "minimum": 0 },
+            "removed": { "type": "integer", "minimum": 0 }
+          }
+        },
+        "docs": {
+          "type": "object",
+          "additionalProperties": false,
+          "required": ["added", "removed"],
+          "properties": {
+            "added": { "type": "integer", "minimum": 0 },
+            "removed": { "type": "integer", "minimum": 0 }
+          }
+        }
+      }
+    },
     "findings": {
       "type": "array",
       "description": "Zero or more specific findings.",

package/schema/prices.example.json

@@ -1,9 +1,15 @@
 {
-  "_comment": "USD per 1,000,000 tokens. PRICES DRIFT — keep _updated current. cost = sum over models of (input*in + output*out + cache_read*cache_read + cache_write*cache_write) / 1e6. The CLI's vendor_cost_usd is vendor-priced and will be wrong for non-Anthropic backends; recompute from this map using the `models` array in the abstract result envelope (SPEC §6.1). Fill the zeros from your provider's pricing page.",
+  "_comment": "USD per 1,000,000 tokens. PRICES DRIFT — keep _updated current. cost = sum over models of (input*in + output*out + cache_read*cache_read + cache_write*cache_write) / 1e6. A model's value is EITHER a flat all-day price OR a { \"slots\": [...] } set of UTC time-of-day slots for peak/off-peak pricing (issue #170) — see schema/prices.schema.json for the rules: each slot is a half-open [utc_from, utc_to) UTC window, a slot whose utc_to <= utc_from wraps past midnight, and a model's slots must partition the 24h day with no gap or overlap. The CLI's vendor_cost_usd is vendor-priced and will be wrong for non-Anthropic backends; recompute from this map using the `models` array in the abstract result envelope (SPEC §6.1). Fill the zeros from your provider's pricing page.",
   "_updated": "2026-07-03",
   "_unit": "USD per 1M tokens",
   "models": {
     "deepseek-v4-pro": { "in": 0.0, "out": 0.0, "cache_read": 0.0, "cache_write": 0.0 },
-    "deepseek-v4-flash": { "in": 0.0, "out": 0.0, "cache_read": 0.0, "cache_write": 0.0 }
+    "deepseek-v4-flash": { "in": 0.0, "out": 0.0, "cache_read": 0.0, "cache_write": 0.0 },
+    "example-time-slotted-model": {
+      "slots": [
+        { "utc_from": "10:00", "utc_to": "01:00", "in": 0.0, "out": 0.0, "cache_read": 0.0, "cache_write": 0.0 },
+        { "utc_from": "01:00", "utc_to": "10:00", "in": 0.0, "out": 0.0, "cache_read": 0.0, "cache_write": 0.0 }
+      ]
+    }
   }
 }

package/schema/prices.schema.json

@@ -21,33 +21,86 @@
     },
     "models": {
       "type": "object",
-      "description": "Map of model identifier → per-token prices. Keys are the model identifiers as they appear in the result envelope's `models[].model`.",
+      "description": "Map of model identifier → per-token prices. Keys are the model identifiers as they appear in the result envelope's `models[].model`. A model's value is EITHER a flat all-day price (unchanged) OR a set of UTC time-of-day slots (issue #170), for a provider with peak/off-peak rates.",
       "additionalProperties": {
-        "type": "object",
-        "additionalProperties": false,
-        "required": ["in", "out", "cache_read", "cache_write"],
-        "properties": {
-          "in": {
-            "type": "number",
-            "minimum": 0,
-            "description": "Price per 1M input tokens."
+        "oneOf": [
+          {
+            "type": "object",
+            "additionalProperties": false,
+            "required": ["in", "out", "cache_read", "cache_write"],
+            "properties": {
+              "in": {
+                "type": "number",
+                "minimum": 0,
+                "description": "Price per 1M input tokens (cache-miss)."
+              },
+              "out": {
+                "type": "number",
+                "minimum": 0,
+                "description": "Price per 1M output tokens."
+              },
+              "cache_read": {
+                "type": "number",
+                "minimum": 0,
+                "description": "Price per 1M cache-read tokens (prompt-cache hits)."
+              },
+              "cache_write": {
+                "type": "number",
+                "minimum": 0,
+                "description": "Price per 1M cache-write tokens (prompt-cache population)."
+              }
+            }
           },
-          "out": {
-            "type": "number",
-            "minimum": 0,
-            "description": "Price per 1M output tokens."
-          },
-          "cache_read": {
-            "type": "number",
-            "minimum": 0,
-            "description": "Price per 1M cache-read tokens (prompt-cache hits)."
-          },
-          "cache_write": {
-            "type": "number",
-            "minimum": 0,
-            "description": "Price per 1M cache-write tokens (prompt-cache population)."
+          {
+            "type": "object",
+            "additionalProperties": false,
+            "required": ["slots"],
+            "description": "UTC time-of-day pricing (issue #170). `slots` MUST partition the full 24h UTC day with no gap and no overlap: each is a half-open [utc_from, utc_to) window, and a slot whose utc_to <= utc_from wraps past midnight. Everything is UTC — there is no timezone or DST field. Cost recomputation selects the one slot covering the run's UTC instant; a run's time-of-day matching zero or more than one slot is a misconfiguration that warns loudly and prices that model at $0 (never silently wrong).",
+            "properties": {
+              "slots": {
+                "type": "array",
+                "minItems": 1,
+                "items": {
+                  "type": "object",
+                  "additionalProperties": false,
+                  "required": ["utc_from", "utc_to", "in", "out", "cache_read", "cache_write"],
+                  "properties": {
+                    "utc_from": {
+                      "type": "string",
+                      "pattern": "^([01][0-9]|2[0-3]):[0-5][0-9]$",
+                      "description": "Slot start, HH:MM in UTC (inclusive)."
+                    },
+                    "utc_to": {
+                      "type": "string",
+                      "pattern": "^([01][0-9]|2[0-3]):[0-5][0-9]$",
+                      "description": "Slot end, HH:MM in UTC (exclusive); a value <= utc_from wraps past midnight."
+                    },
+                    "in": {
+                      "type": "number",
+                      "minimum": 0,
+                      "description": "Price per 1M input tokens (cache-miss) in this slot."
+                    },
+                    "out": {
+                      "type": "number",
+                      "minimum": 0,
+                      "description": "Price per 1M output tokens in this slot."
+                    },
+                    "cache_read": {
+                      "type": "number",
+                      "minimum": 0,
+                      "description": "Price per 1M cache-read tokens (prompt-cache hits) in this slot."
+                    },
+                    "cache_write": {
+                      "type": "number",
+                      "minimum": 0,
+                      "description": "Price per 1M cache-write tokens in this slot."
+                    }
+                  }
+                }
+              }
+            }
           }
-        }
+        ]
       }
     }
   }

package/templates/comment.eta

@@ -20,6 +20,18 @@
 <% if (it.convergenceSummary) { -%>
 <sub><%~ it.convergenceSummary %></sub>
 <% } -%>
+<% if (it.changeSummary) { -%>
+<sub>**Changes:** <%~ it.changeSummary %></sub>
+<% } -%>
+<% if (it.clocDiff) { -%>
+<details><summary>📏 cloc</summary>
+
+```
+<%~ it.clocDiff %>
+```
+
+</details>
+<% } -%>
 <% if (it.metastasisNote) { -%>
 <%~ it.metastasisNote %>
 <% } -%>