@jphutchins/code-review 0.1.0-alpha.35 → 0.1.0-alpha.36

package/dist/index.js

@@ -773,8 +773,7 @@ var DEFAULT_RESERVE = {
   frac: 0.15,
   growth: 0.25,
   flatUsd: 0.02,
-  flatMs: 12e4,
-  flatMem: 2 * 1024 * 1024 * 1024
+  flatMs: 12e4
 };
 var SOFT_MULTIPLE = 2;
 var growingReserve = (used, limit, flat, r) => {
@@ -801,7 +800,6 @@ var decideBudget = (i) => {
   const worst = [costAxis(i), timeAxis(i)].filter((a) => a !== null).reduce((max, a) => Math.max(max, axisSeverity(a)), 0);
   return worst === 2 ? { kind: "hard" } : worst === 1 ? { kind: "soft" } : { kind: "ok" };
 };
-var memoryCritical = (availMemBytes, totalMemBytes, floorBytes) => availMemBytes !== null && totalMemBytes !== null && totalMemBytes > 0 && availMemBytes <= floorBytes;
 var pct = (n) => `${String(Math.round(n * 100))}%`;
 var money = (n) => `$${n.toFixed(2)}`;
 var mins = (ms) => `${(ms / 6e4).toFixed(1)}m`;
@@ -856,7 +854,6 @@ var lastValidPath = (draftPath) => {
 };
 var mainHasWrittenDraft = (draftMtimeMs, seedMarkerMtimeMs) => draftMtimeMs !== null && (seedMarkerMtimeMs === null || draftMtimeMs > seedMarkerMtimeMs);
 var spawnFloorMessage = (draftPath) => `Write your own first-pass findings to ${draftPath} before spawning subagents \u2014 a review must never depend on subagents alone, and a pre-seeded draft does not count until you have revised it yourself this run. Write ${draftPath} from what you have read so far (preliminary findings are fine), run \`code-review validate ${draftPath} --explain\` until it passes, then fan out; your subagents run in the background, so keep refining the draft as their reports arrive.`;
-var memoryPressureMessage = (draftPath) => `System memory is critically low right now, so another subagent can't be spawned \u2014 a fresh process is the fastest way to tip the runner into an out-of-memory kill that would lose the whole review. Don't wind down: keep reading code directly and keep folding the reports from subagents already running into ${draftPath}, then try spawning again in a moment \u2014 this clears as soon as running subagents finish and free their memory.`;
 var forceBackgroundSpawn = (toolInput) => ({
   hookSpecificOutput: {
     hookEventName: "PreToolUse",
@@ -902,8 +899,6 @@ var evaluateBudgetHook = (input, params) => {
       if (phase.kind === "hard" && blockedDuringConvergence(toolName, rec["tool_input"]))
         return denyPreTool(budgetMessage(inputs, phase, params.draftPath, isSubagent));
       if (SPAWN_TOOLS.has(toolName)) {
-        if (memoryCritical(params.availMemBytes, params.totalMemBytes, params.reserve.flatMem))
-          return denyPreTool(memoryPressureMessage(params.draftPath));
         if (!isSubagent && !params.mainDraftWritten)
           return denyPreTool(spawnFloorMessage(params.draftPath));
         return forceBackgroundSpawn(rec["tool_input"]);
@@ -950,21 +945,6 @@ var parseFraction = (raw, fallback) => {
   const n = Number.parseFloat(raw);
   return Number.isFinite(n) && n >= 0 && n <= 1 ? n : fallback;
 };
-var BYTE_UNIT = {
-  "": 1,
-  k: 1024,
-  m: 1024 * 1024,
-  g: 1024 * 1024 * 1024,
-  t: 1024 * 1024 * 1024 * 1024
-};
-var parseByteSize = (raw) => {
-  const m = /^(\d+(?:\.\d+)?)\s*([kmgt])?(?:i?b)?$/i.exec(raw.trim());
-  if (m === null) return null;
-  const [, num = "", unit = ""] = m;
-  const n = Number.parseFloat(num);
-  const mult = BYTE_UNIT[unit.toLowerCase()];
-  return Number.isFinite(n) && mult !== void 0 ? n * mult : null;
-};
 var budgetHookCommand = (draftPath, opts) => [
   "code-review budget-hook --draft",
   shellQuote(draftPath),
@@ -974,8 +954,7 @@ var budgetHookCommand = (draftPath, opts) => [
   ...opts.reserveFrac ? ["--reserve-frac", shellQuote(opts.reserveFrac)] : [],
   ...opts.reserveGrowth ? ["--reserve-growth", shellQuote(opts.reserveGrowth)] : [],
   ...opts.reserveUsd ? ["--reserve-usd", shellQuote(opts.reserveUsd)] : [],
-  ...opts.reserveWall ? ["--reserve-wall", shellQuote(opts.reserveWall)] : [],
-  ...opts.reserveMem ? ["--reserve-mem", shellQuote(opts.reserveMem)] : []
+  ...opts.reserveWall ? ["--reserve-wall", shellQuote(opts.reserveWall)] : []
 ].join(" ");
 
 // src/format.ts
@@ -2736,6 +2715,32 @@ var composeReviewSettings = (opts) => {
   };
 };
 
+// src/sandbox.ts
+var GITHUB_HOSTS = ["api.github.com", "github.com"];
+var deriveModelHost = (apiBaseUrl) => {
+  const host = URL.canParse(apiBaseUrl) ? new URL(apiBaseUrl).hostname : "";
+  if (host === "") {
+    throw new Error(
+      `could not derive the model host from api_base_url ${JSON.stringify(apiBaseUrl)} \u2014 expected a URL like https://api.deepseek.com/anthropic`
+    );
+  }
+  return host;
+};
+var parseExtraEndpoints = (extra) => extra.split(/\s+/).map((token) => token.replace(/:\d+$/, "")).filter((token) => token.length > 0);
+var buildSandboxConfig = (opts) => ({
+  network: {
+    allowedDomains: [
+      .../* @__PURE__ */ new Set([
+        deriveModelHost(opts.apiBaseUrl),
+        ...GITHUB_HOSTS,
+        ...parseExtraEndpoints(opts.extra ?? "")
+      ])
+    ],
+    deniedDomains: []
+  },
+  filesystem: { allowRead: [], denyRead: [], allowWrite: ["/"], denyWrite: [] }
+});
+
 // src/index.ts
 var readJSON = (path) => {
   try {
@@ -3032,18 +3037,6 @@ var snapshotIfValid = (draftPath) => {
     );
   }
 };
-var readMemInfo = () => {
-  try {
-    const text = readFileSync("/proc/meminfo", "utf8");
-    const kb = (key2) => {
-      const m = new RegExp(`^${key2}:\\s+(\\d+)\\s+kB`, "m").exec(text);
-      return m?.[1] !== void 0 ? Number(m[1]) * 1024 : null;
-    };
-    return { availBytes: kb("MemAvailable"), totalBytes: kb("MemTotal") };
-  } catch {
-    return { availBytes: null, totalBytes: null };
-  }
-};
 var budgetHookCmd = defineCommand({
   meta: {
     name: "budget-hook",
@@ -3082,17 +3075,12 @@ var budgetHookCmd = defineCommand({
     "reserve-wall": {
       type: "string",
       description: "Flat wall-clock wind-down floor (e.g. 2m, 120s), whichever is larger with --reserve-frac (default: 2m)"
-    },
-    "reserve-mem": {
-      type: "string",
-      description: "Free-RAM floor (e.g. 2g, 1536m) below which new subagent spawns are denied until memory recovers; not a convergence axis (default: 2g)"
     }
   },
   run: async ({ args }) => {
     try {
       const draftPath = resolve$1(args.draft);
       const input = readStdinJSON();
-      const mem = readMemInfo();
       const transcriptPath = transcriptPathOf(input);
       const tree = transcriptPath ? readTranscriptTree(resolve$1(transcriptPath)) : void 0;
       const usage = tree ? sumTranscriptUsage(tree.entries) : void 0;
@@ -3109,14 +3097,11 @@ var budgetHookCmd = defineCommand({
           nowMs: Date.now()
         }),
         wallMs,
-        availMemBytes: mem.availBytes,
-        totalMemBytes: mem.totalBytes,
         reserve: {
           frac: parseFraction(args["reserve-frac"], DEFAULT_RESERVE.frac),
           growth: parseFraction(args["reserve-growth"], DEFAULT_RESERVE.growth),
           flatUsd: parseBudgetUsd(args["reserve-usd"]) ?? DEFAULT_RESERVE.flatUsd,
-          flatMs: args["reserve-wall"] ? parseWallMs(args["reserve-wall"]) ?? DEFAULT_RESERVE.flatMs : DEFAULT_RESERVE.flatMs,
-          flatMem: args["reserve-mem"] ? parseByteSize(args["reserve-mem"]) ?? DEFAULT_RESERVE.flatMem : DEFAULT_RESERVE.flatMem
+          flatMs: args["reserve-wall"] ? parseWallMs(args["reserve-wall"]) ?? DEFAULT_RESERVE.flatMs : DEFAULT_RESERVE.flatMs
         },
         draftPath,
         mainDraftWritten: mainHasWrittenDraft(
@@ -3193,10 +3178,6 @@ var printSettingsCmd = defineCommand({
     "reserve-wall": {
       type: "string",
       description: "Flat wall-clock wind-down floor (e.g. 2m), whichever is larger with --reserve-frac (default: 2m)"
-    },
-    "reserve-mem": {
-      type: "string",
-      description: "Free-RAM floor (e.g. 2g) below which new subagent spawns are denied until memory recovers (default: 2g)"
     }
   },
   run: async ({ args }) => {
@@ -3218,8 +3199,7 @@ var printSettingsCmd = defineCommand({
         reserveFrac: args["reserve-frac"],
         reserveGrowth: args["reserve-growth"],
         reserveUsd: args["reserve-usd"],
-        reserveWall: args["reserve-wall"],
-        reserveMem: args["reserve-mem"]
+        reserveWall: args["reserve-wall"]
       }
     });
     process.stdout.write(`${JSON.stringify(settings)}
@@ -4189,6 +4169,37 @@ var awaitCiCmd = defineCommand({
     process.stdout.write(renderCiOutputs(outcome));
   }
 });
+var sandboxConfigCmd = defineCommand({
+  meta: {
+    name: "sandbox-config",
+    description: "Emit the sandbox-runtime (srt) settings that jail the untrusted review agent's egress: allow the model host (derived from api_base_url), the GitHub API/host, and the consumer's extra_endpoints; deny all else; filesystem isolation off"
+  },
+  args: {
+    "api-base-url": {
+      type: "string",
+      description: "The model endpoint the CLI dials (ANTHROPIC_BASE_URL) \u2014 its host is allowlisted",
+      required: true
+    },
+    extra: {
+      type: "string",
+      description: "Whitespace-separated host[:port] list of extra domains to allow (the extra_endpoints input)"
+    },
+    out: {
+      type: "string",
+      description: "Write the settings JSON here instead of stdout"
+    }
+  },
+  run: ({ args }) => {
+    const config = buildSandboxConfig({ apiBaseUrl: args["api-base-url"], extra: args.extra });
+    const json = `${JSON.stringify(config, null, 2)}
+`;
+    if (args.out) {
+      writeFileSync(resolve$1(args.out), json);
+    } else {
+      process.stdout.write(json);
+    }
+  }
+});
 var main = defineCommand({
   meta: {
     name: "code-review",
@@ -4218,7 +4229,8 @@ var main = defineCommand({
     "stop-gate": stopGateCmd,
     "budget-hook": budgetHookCmd,
     "print-settings": printSettingsCmd,
-    deadline: deadlineCmd
+    deadline: deadlineCmd,
+    "sandbox-config": sandboxConfigCmd
   }
 });
 if (!process.env["VITEST"]) {