@jphutchins/code-review 0.1.0-alpha.31 → 0.1.0-alpha.32

package/dist/index.js

@@ -1105,27 +1105,61 @@ var resolvers = {
   prices: (raw) => resolveSingleVersion("prices", raw)
 };
 var resolve = (kind, raw) => resolvers[kind](raw);
-var describeEndpoint = (args) => args.find((a) => a === "graphql" || a.includes("/") && !a.startsWith("-")) ?? args[0] ?? "(no endpoint)";
-var runGhApi = (args, stdin, env) => new Promise((resolve3, reject) => {
+var MAX_BUFFER = 100 * 1024 * 1024;
+var MAX_TIMEOUT_MS = 2147483647;
+var parseTimeoutMs = (raw, fallback) => {
+  if (raw === void 0 || !/^\d+$/.test(raw)) return fallback;
+  const parsed = Number(raw);
+  return parsed > 0 && parsed <= MAX_TIMEOUT_MS ? parsed : fallback;
+};
+var SUBPROCESS_TIMEOUT_ENV = "CODE_REVIEW_SUBPROCESS_TIMEOUT_MS";
+var DEFAULT_SUBPROCESS_TIMEOUT_MS = 12e4;
+var subprocessTimeoutMs = () => parseTimeoutMs(process.env[SUBPROCESS_TIMEOUT_ENV], DEFAULT_SUBPROCESS_TIMEOUT_MS);
+var classifyExecError = (err, stderr, timeoutMs) => {
+  const e = err;
+  const stderrStr = stderr.trim();
+  if (e.code === "ERR_CHILD_PROCESS_STDIO_MAXBUFFER")
+    return `output exceeded ${String(MAX_BUFFER)} bytes (killed)`;
+  if (e.killed === true)
+    return `no response within ${String(timeoutMs)}ms (killed a hung child)${stderrStr ? `: ${stderrStr}` : ""}`;
+  return stderrStr || errMsg(err);
+};
+var execFileWithTimeout = (spec) => new Promise((resolve3, reject) => {
   const child = execFile(
-    "gh",
-    ["api", ...args],
-    { env: { ...process.env, ...env }, encoding: "utf-8", maxBuffer: 100 * 1024 * 1024 },
+    spec.command,
+    [...spec.args],
+    {
+      ...spec.env ? { env: { ...process.env, ...spec.env } } : {},
+      encoding: "utf-8",
+      maxBuffer: MAX_BUFFER,
+      timeout: spec.timeoutMs,
+      killSignal: "SIGKILL"
+    },
     (err, stdout, stderr) => {
-      if (err) {
-        const stderrStr = typeof stderr === "string" && stderr.trim() ? stderr.trim() : "";
-        const errStr = err instanceof Error ? err.message : "unknown error";
-        reject(new Error(`gh api ${describeEndpoint(args)} failed: ${stderrStr || errStr}`));
-      } else {
-        resolve3(stdout);
-      }
+      if (err)
+        reject(
+          new Error(`${spec.label} failed: ${classifyExecError(err, stderr, spec.timeoutMs)}`)
+        );
+      else resolve3(stdout);
     }
   );
-  if (stdin !== void 0) {
-    child.stdin?.end(stdin);
+  if (spec.stdin !== void 0) {
+    child.stdin?.on("error", () => void 0);
+    child.stdin?.end(spec.stdin);
   }
 });
 
+// src/gh.ts
+var describeEndpoint = (args) => args.find((a) => a === "graphql" || a.includes("/") && !a.startsWith("-")) ?? args[0] ?? "(no endpoint)";
+var runGhApi = (args, stdin, env) => execFileWithTimeout({
+  command: "gh",
+  args: ["api", ...args],
+  label: `gh api ${describeEndpoint(args)}`,
+  timeoutMs: subprocessTimeoutMs(),
+  env,
+  stdin
+});
+
 // src/pr.ts
 var CANDIDATE_JQ = ".[] | {number: .number, state: .state, headRef: .head.ref, headSha: .head.sha}";
 var parseCandidates = (stdout) => parseJsonl(stdout);
@@ -1988,21 +2022,11 @@ stacked=${String(result.stacked)}
 `;
   }
 };
-var runGit = (args) => new Promise((resolve3, reject) => {
-  execFile(
-    "git",
-    [...args],
-    { encoding: "utf-8", maxBuffer: 100 * 1024 * 1024 },
-    (err, stdout, stderr) => {
-      if (err) {
-        const stderrStr = typeof stderr === "string" && stderr.trim() ? stderr.trim() : "";
-        const errStr = err instanceof Error ? err.message : "unknown error";
-        reject(new Error(`git ${args.join(" ")} failed: ${stderrStr || errStr}`));
-      } else {
-        resolve3(stdout);
-      }
-    }
-  );
+var runGit = (args) => execFileWithTimeout({
+  command: "git",
+  args,
+  label: `git ${args.join(" ")}`,
+  timeoutMs: subprocessTimeoutMs()
 });
 var PrMetaCodec = t.type({
   changed_files: t.number,
@@ -3290,7 +3314,7 @@ var noticeCmd = defineCommand({
   run: ({ args }) => {
     if (!isNoticeKind(args.kind)) {
       process.stderr.write(
-        `::warning::code-review notice: unrecognized kind "${args.kind}" \u2014 the pinned CLI is older than the workflow calling it; rendering a generic incomplete notice
+        `::warning::code-review notice: unrecognized kind "${annotationSafe(args.kind)}" \u2014 the pinned CLI is older than the workflow calling it; rendering a generic incomplete notice
 `
       );
       process.stdout.write(`${JSON.stringify(buildUnknownNoticeEnvelope(args.kind), null, 2)}