@jphutchins/code-review 0.1.0-alpha.13 → 0.1.0-alpha.14

package/dist/index.js

@@ -762,10 +762,14 @@ var money = (n) => `$${n.toFixed(2)}`;
 var mins = (ms) => `${(ms / 6e4).toFixed(1)}m`;
 var spendClause = (i) => i.spentUsd === null ? null : i.budgetUsd !== null && i.budgetUsd > 0 ? `spent ${money(i.spentUsd)}/${money(i.budgetUsd)} (${pct(i.spentUsd / i.budgetUsd)})` : `spent ${money(i.spentUsd)}`;
 var timeClause = (i) => i.elapsedMs === null ? null : i.wallMs !== null && i.wallMs > 0 ? `${mins(i.elapsedMs)}/${mins(i.wallMs)} elapsed (${pct(i.elapsedMs / i.wallMs)})` : `${mins(i.elapsedMs)} elapsed`;
-var directive = (phase, draftPath) => phase.kind === "hard" ? `Budget nearly exhausted \u2014 STOP all new investigation now. Write your COMPLETE findings to ${draftPath} and run \`code-review validate ${draftPath} --explain\` until it passes (--explain prints the exact schema when the shape is wrong). Other tools are blocked until that draft is written.` : `Wind down investigation and write your COMPLETE findings to ${draftPath} now, then run \`code-review validate ${draftPath} --explain\` (it prints the exact schema if the shape is wrong) \u2014 you may run out of budget before you finish otherwise.`;
-var budgetMessage = (i, phase, draftPath) => {
+var directive = (phase, draftPath, isSubagent) => {
+  if (isSubagent)
+    return phase.kind === "hard" ? `Budget nearly exhausted \u2014 STOP all new investigation now and report the findings you have back to the main agent in your reply. Do not write ${draftPath} yourself; only the main agent writes it.` : `Wind down investigation and report the findings you have back to the main agent in your reply \u2014 do not write ${draftPath} yourself; the main agent writes it, and you may run out of budget otherwise.`;
+  return phase.kind === "hard" ? `Budget nearly exhausted \u2014 STOP all new investigation now. Write your COMPLETE findings to ${draftPath} and run \`code-review validate ${draftPath} --explain\` until it passes (--explain prints the exact schema when the shape is wrong). Other tools are blocked until that draft is written.` : `Wind down investigation and write your COMPLETE findings to ${draftPath} now, then run \`code-review validate ${draftPath} --explain\` (it prints the exact schema if the shape is wrong) \u2014 you may run out of budget before you finish otherwise.`;
+};
+var budgetMessage = (i, phase, draftPath, isSubagent) => {
   const status = [spendClause(i), timeClause(i)].filter((c) => c !== null).join(" \xB7 ");
-  return `Budget check \u2014 ${status}. ${directive(phase, draftPath)}`;
+  return `Budget check \u2014 ${status}. ${directive(phase, draftPath, isSubagent)}`;
 };
 var invokesCodeReviewValidate = (toolInput) => {
   const cmd = asRecord(toolInput)?.["command"];
@@ -778,6 +782,35 @@ var blockedDuringConvergence = (toolName, toolInput) => {
   if (toolName === "Bash") return !invokesCodeReviewValidate(toolInput);
   return false;
 };
+var escapeRegExp = (s) => s.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+var WRITE_TOOLS = /* @__PURE__ */ new Set(["Write", "Edit", "MultiEdit", "NotebookEdit"]);
+var writesToDraft = (toolName, toolInput, draftPath) => {
+  const rec = asRecord(toolInput);
+  const targets = [draftPath, basename(draftPath), "$DRAFT", "${DRAFT}"];
+  if (WRITE_TOOLS.has(toolName)) {
+    const fp = rec?.["file_path"] ?? rec?.["notebook_path"];
+    if (typeof fp === "string" && targets.some((t4) => fp === t4 || basename(fp) === basename(t4)))
+      return true;
+  }
+  if (toolName === "Bash") {
+    const cmd = rec?.["command"];
+    if (typeof cmd !== "string") return false;
+    const alt = targets.map(escapeRegExp).join("|");
+    const end = "(?=$|[\\s|&;)])";
+    const redirect = new RegExp(`>>?\\|?\\s*(['"]?)(?:${alt})\\1${end}`);
+    const teeArg = new RegExp(`\\btee\\b(?:\\s+-{1,2}\\S+)*\\s+(['"]?)(?:${alt})\\1${end}`);
+    return redirect.test(cmd) || teeArg.test(cmd);
+  }
+  return false;
+};
+var singleWriterMessage = (draftPath) => `Only the main agent may write ${draftPath}. When a subagent writes it too, the concurrent writers clobber each other and the review comes out empty. Do NOT write, edit, or redirect into ${draftPath} \u2014 instead, return the findings you discovered in your reply (the field names are in the schema); the main agent collects every subagent's reported findings and writes the draft itself.`;
+var denyPreTool = (reason) => ({
+  hookSpecificOutput: {
+    hookEventName: "PreToolUse",
+    permissionDecision: "deny",
+    permissionDecisionReason: reason
+  }
+});
 var evaluateBudgetHook = (input, params) => {
   const rec = asRecord(input);
   const inputs = {
@@ -788,25 +821,23 @@ var evaluateBudgetHook = (input, params) => {
     reserve: params.reserve
   };
   const phase = decideBudget(inputs);
+  const agentId = rec?.["agent_id"];
+  const isSubagent = typeof agentId === "string" && agentId.length > 0;
   switch (rec?.["hook_event_name"]) {
     case "PostToolBatch":
       return phase.kind === "ok" ? {} : {
         hookSpecificOutput: {
           hookEventName: "PostToolBatch",
-          additionalContext: budgetMessage(inputs, phase, params.draftPath)
+          additionalContext: budgetMessage(inputs, phase, params.draftPath, isSubagent)
         }
       };
     case "PreToolUse": {
-      if (phase.kind !== "hard") return {};
       const toolName = rec["tool_name"];
+      if (isSubagent && typeof toolName === "string" && writesToDraft(toolName, rec["tool_input"], params.draftPath))
+        return denyPreTool(singleWriterMessage(params.draftPath));
+      if (phase.kind !== "hard") return {};
       if (typeof toolName === "string" && blockedDuringConvergence(toolName, rec["tool_input"]))
-        return {
-          hookSpecificOutput: {
-            hookEventName: "PreToolUse",
-            permissionDecision: "deny",
-            permissionDecisionReason: budgetMessage(inputs, phase, params.draftPath)
-          }
-        };
+        return denyPreTool(budgetMessage(inputs, phase, params.draftPath, isSubagent));
       return {};
     }
     default: