@josundt/eslint-config 5.2.2 → 5.3.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@josundt/eslint-config",
-  "version": "5.2.2",
+  "version": "5.3.1",
   "description": "ESLint ruleset with required plugins for josundt TypeScript projects",
   "main": "index.js",
   "scripts": {
@@ -27,22 +27,22 @@
     "utils/**/*.js"
   ],
   "peerDependencies": {
-    "typescript": ">=5.0.4"
+    "typescript": ">=5.3.2"
   },
   "dependencies": {
-    "@josundt/prettier-config": "^1.0.0",
-    "@typescript-eslint/eslint-plugin": "5.59.5",
-    "@typescript-eslint/parser": "5.59.5",
-    "eslint": "8.40.0",
-    "eslint-import-resolver-typescript": "3.5.5",
-    "eslint-plugin-deprecation": "1.4.1",
+    "@josundt/prettier-config": "^3.1.0",
+    "@typescript-eslint/eslint-plugin": "6.13.1",
+    "@typescript-eslint/parser": "6.13.1",
+    "eslint": "8.54.0",
+    "eslint-import-resolver-typescript": "3.6.1",
+    "eslint-plugin-deprecation": "2.0.0",
     "eslint-plugin-eslint-comments": "3.2.0",
-    "eslint-plugin-import": "2.27.5",
+    "eslint-plugin-import": "2.29.0",
     "eslint-plugin-jasmine": "4.1.3",
-    "eslint-plugin-jest": "27.2.1",
-    "eslint-plugin-jsdoc": "44.0.2",
-    "eslint-plugin-no-lookahead-lookbehind-regexp": "0.1.0",
-    "eslint-plugin-prettier": "4.2.1",
-    "eslint-plugin-unicorn": "47.0.0"
+    "eslint-plugin-jest": "27.6.0",
+    "eslint-plugin-jsdoc": "46.9.0",
+    "eslint-plugin-no-lookahead-lookbehind-regexp": "0.3.0",
+    "eslint-plugin-prettier": "5.0.1",
+    "eslint-plugin-unicorn": "49.0.0"
   }
 }

package/rules/eslint.js

@@ -3,7 +3,7 @@ module.exports = {
     rules: {
         "arrow-body-style": "error",
         "arrow-parens": ["error", "as-needed"],
-        "class-methods-use-this": "off", // Warn when methods could be static
+        "class-methods-use-this": ["off", { enforceForClassFields: true }], // Warn when methods could be static
         "complexity": ["warn", { max: 20 }],
         "curly": "error",
         "default-case-last": "error",
@@ -150,6 +150,16 @@ module.exports = {
             "error",
             { destructuring: "all", ignoreReadBeforeAssign: false }
         ],
+        "prefer-destructuring": [
+            "warn",
+            {
+                array: true,
+                object: true
+            },
+            {
+                enforceForRenamedProperties: false
+            }
+        ],
         "prefer-exponentiation-operator": "error",
         "prefer-object-spread": "error",
         "prefer-promise-reject-errors": "error",

package/rules/typescript-eslint/extensionrules.js

@@ -5,16 +5,24 @@ const eslintRules = eslintRuleSet.rules;
 
 // Map of all the typescript-eslint extensions.
 // If extension rule has additional properties compared to standard eslint rule:
-// If the map value is null:
-//     The options from the standard rule will be used as is.
+// If the map value is a boolean:
+//     If true the options from the standard rule will be used as is; if false the rule will be switched off.
 // If the map value is an object:
 //     The object will be merged merged with standard rule (rule object 1).
 // If the map value is an array:
-//     The items of the array will be added as a new rule options object.
+//     The options items of the array (expected to be object literals or undefined) will be merged with the options items of the standard rule (expected to be object literals or undefined).
 // If the map value is a function:
 //     The standard eslint options object will be passed as parameters, the return statement will be added as options.
 
 const extensions = new Map([
+    [
+        "class-methods-use-this",
+        false
+        // {
+        //     ignoreOverrideMethods: false,
+        //     ignoreClassesThatImplementAnInterface: false
+        // }
+    ],
     ["default-param-last", true],
     [
         "dot-notation",
@@ -33,7 +41,7 @@ const extensions = new Map([
     ],
     ["no-array-constructor", true],
     ["no-dupe-class-members", true],
-    ["no-duplicate-imports", true],
+    ["no-duplicate-imports", false], // typescript-eslint 5.25.0: deprecated in favour of import/no-duplicates
     [
         "no-empty-function",
         {
@@ -68,6 +76,10 @@ const extensions = new Map([
     ["no-unused-vars", false],
     ["no-use-before-define", false],
     ["no-useless-constructor", false],
+    [
+        "prefer-destructuring",
+        [{}, { enforceForDeclarationWithTypeAnnotation: false }]
+    ],
     ["require-await", true],
     ["return-await", true]
 ]);
@@ -97,7 +109,19 @@ module.exports.typescriptEslintExtensionrules = Object.entries(
                 // Ensure value is array if only severity string:
                 value = Array.isArray(value) ? [...value] : [value];
                 if (Array.isArray(extension)) {
-                    value.push(...extension);
+                    const [severity, ...orgOpts] = value;
+                    const extOpts = extension;
+                    value = [severity];
+                    for (
+                        let i = 0;
+                        i < Math.max(orgOpts.length, extOpts.length);
+                        i++
+                    ) {
+                        value.push({
+                            ...(orgOpts[i] ?? {}),
+                            ...(extOpts[i] ?? {})
+                        });
+                    }
                 } else if (typeof extension === "object") {
                     // If array only contains severity string, push object
                     if (value.length === 1) {

package/rules/typescript-eslint/rules.js

@@ -21,7 +21,12 @@ const rules = {
         }
     ],
     "ban-tslint-comment": "error", // No longer use tslint - remove rules
-    "ban-types": "off", // Can be used to ban certain types
+    "ban-types": [
+        "error",
+        {
+            // Enable additional/disable default disabled types here
+        }
+    ],
     "class-literal-property-style": "off",
     "consistent-generic-constructors": ["off", "constructor"],
     "consistent-indexed-object-style": ["error", "record"],
@@ -183,6 +188,7 @@ const rules = {
     "no-redundant-type-constituents": "error",
     "no-require-imports": "error",
     "no-unsafe-enum-comparison": "error",
+    "no-unsafe-unary-minus": "error",
     "no-this-alias": "error",
     "no-throw-literal": [
         "error",
@@ -191,7 +197,6 @@ const rules = {
             allowThrowingUnknown: true // Default is to allow throwing values of type unknown
         }
     ],
-    "no-type-alias": "off",
     "no-unnecessary-boolean-literal-compare": "error",
     "no-unnecessary-condition": "off", // allow runtime null checks etc even if reported not necessary by type system
     "no-unnecessary-qualifier": "error",
@@ -226,7 +231,13 @@ const rules = {
         {
             ignoreConditionalTests: true,
             ignoreTernaryTests: true,
-            ignoreMixedLogicalExpressions: true
+            ignoreMixedLogicalExpressions: true,
+            ignorePrimitives: {
+                string: false,
+                number: false,
+                bigint: false,
+                boolean: false
+            }
         }
     ],
     "prefer-optional-chain": "error",
@@ -238,11 +249,16 @@ const rules = {
     "prefer-string-starts-ends-with": "error",
     "prefer-ts-expect-error": "error",
     "promise-function-async": "off",
-    "require-array-sort-compare": "error",
+    "require-array-sort-compare": [
+        "error",
+        {
+            ignoreStringArrays: false
+        }
+    ],
     "restrict-plus-operands": [
         "error",
         {
-            checkCompoundAssignments: true,
+            skipCompoundAssignments: false,
             allowAny: false
         }
     ],