@josueavalosjim/taste-check 0.5.0 → 0.5.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@josueavalosjim/taste-check",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "Design review in CI with a line down the middle: measured checks that gate the build (WCAG contrast from your tokens or from a real rendered page, one-off values in your markup) and a fresh-eyes model judge whose verdicts stay advisory. Zero dependencies. Ships no design rules of its own.",
   "keywords": [
     "accessibility",

package/src/cdp.mjs

@@ -224,11 +224,18 @@ export async function connect({ endpoint, browserPath, timeout = 15000 }) {
       return result.value;
     },
     /**
-     * Best effort, and deliberately incapable of throwing. Teardown failing
-     * must never take down a run whose measurements already succeeded, and a
-     * temp directory the browser is still writing into is not worth a crash.
+     * Waits for the browser to actually exit before removing its profile.
+     *
+     * Killing and deleting in the same breath loses a race with Chrome, which
+     * is still flushing its profile when the signal arrives. Best effort was
+     * not good enough: it left a directory behind on nearly every run, and a
+     * tool that litters the temp directory every time CI runs is not one to
+     * inflict on anybody.
+     *
+     * Still incapable of throwing. Teardown must never take down a run whose
+     * measurements already succeeded.
      */
-    close() {
+    async close() {
       try {
         ws.close();
       } catch {
@@ -236,7 +243,20 @@ export async function connect({ endpoint, browserPath, timeout = 15000 }) {
       }
       if (!child) return;
       try {
-        child.kill();
+        if (child.exitCode === null && child.signalCode === null) {
+          const exited = new Promise((resolve) => child.once('exit', resolve));
+          child.kill();
+          // SIGTERM is usually enough. If it is not, stop being polite.
+          const forced = new Promise((resolve) => setTimeout(resolve, 2000)).then(() => {
+            try {
+              child.kill('SIGKILL');
+            } catch {
+              /* already gone */
+            }
+            return new Promise((resolve) => setTimeout(resolve, 300));
+          });
+          await Promise.race([exited, forced]);
+        }
       } catch {
         /* already gone */
       }

package/src/runtime.mjs

@@ -147,7 +147,7 @@ export async function runRuntime(config, cwd, { connect: open = connect } = {})
   } catch (error) {
     problems.push(`the page could not be measured: ${error.message}`);
   } finally {
-    page.close();
+    await page.close();
   }
 
   return {