@joshuafolkken/kit 1.887.0 → 1.929.0

package/scripts/test/test-declared-logic.ts

@@ -27,6 +27,7 @@ const TEST_SUFFIXES: ReadonlyArray<string> = ['.e2e.ts', '.test.ts']
 const EXEMPT_PATHS: ReadonlyArray<string> = ['.editorconfig']
 const EXEMPT_PREFIXES: ReadonlyArray<string> = ['.idea/', '.vscode/', 'prompts/']
 const EXEMPT_SUFFIXES: ReadonlyArray<string> = ['.md']
+const STATIC_VISUAL_SUFFIXES: ReadonlyArray<string> = ['.html', '.css']
 
 function normalize(paths: ReadonlyArray<string>): Array<string> {
 	return paths.map((path) => path.trim()).filter((path) => path !== '')
@@ -36,8 +37,12 @@ function is_test_file(path: string): boolean {
 	return TEST_SUFFIXES.some((suffix) => path.endsWith(suffix))
 }
 
-function is_exempt(path: string): boolean {
-	if (EXEMPT_PATHS.includes(path)) return true
+function is_static_visual(path: string, is_static: boolean): boolean {
+	return is_static && STATIC_VISUAL_SUFFIXES.some((suffix) => path.endsWith(suffix))
+}
+
+function is_exempt(path: string, is_static = false): boolean {
+	if (EXEMPT_PATHS.includes(path) || is_static_visual(path, is_static)) return true
 
 	return (
 		EXEMPT_SUFFIXES.some((suffix) => path.endsWith(suffix)) ||
@@ -47,31 +52,31 @@ function is_exempt(path: string): boolean {
 
 // A runtime file is one that is neither a test nor exempt. Its presence with no test file beside it is
 // the whole of what `required` reports.
-function is_runtime(path: string): boolean {
-	return !is_test_file(path) && !is_exempt(path)
+function is_runtime(path: string, is_static = false): boolean {
+	return !is_test_file(path) && !is_exempt(path, is_static)
 }
 
 // **A test file changed → `satisfied`, whatever else did.** A runtime file with no test beside it →
 // `required`. Everything left — an all-exempt change, and the empty diff — is `exempt`, because there
 // is no runtime file the change failed to test.
-function verdict_for(paths: ReadonlyArray<string>): Verdict {
+function verdict_for(paths: ReadonlyArray<string>, is_static = false): Verdict {
 	const changed = normalize(paths)
 
 	if (changed.some((path) => is_test_file(path))) return 'satisfied'
-	if (changed.some((path) => is_runtime(path))) return 'required'
+	if (changed.some((path) => is_runtime(path, is_static))) return 'required'
 
 	return 'exempt'
 }
 
 // The runtime files with no test beside them — the `required` detail line, so the answer says which
 // files it is about rather than only that it refused.
-function runtime_files(paths: ReadonlyArray<string>): Array<string> {
-	return normalize(paths).filter((path) => is_runtime(path))
+function runtime_files(paths: ReadonlyArray<string>, is_static = false): Array<string> {
+	return normalize(paths).filter((path) => is_runtime(path, is_static))
 }
 
 // The paths that made the change exempt — the `exempt` detail line.
-function exempt_files(paths: ReadonlyArray<string>): Array<string> {
-	return normalize(paths).filter((path) => is_exempt(path))
+function exempt_files(paths: ReadonlyArray<string>, is_static = false): Array<string> {
+	return normalize(paths).filter((path) => is_exempt(path, is_static))
 }
 
 const test_declared_logic = {

package/scripts/test/test-declared.ts

@@ -2,6 +2,7 @@
 import { text } from 'node:stream/consumers'
 import { fileURLToPath } from 'node:url'
 import { parseArgs } from 'node:util'
+import { project_checks } from '#scripts/gate/project-checks'
 import { test_declared_changed } from './test-declared-changed'
 import { test_declared_logic, type Verdict } from './test-declared-logic'
 import { test_declared_match, type MatchResult } from './test-declared-match'
@@ -76,24 +77,35 @@ function typed_runtime_file(path: string): string {
 }
 
 // The word is stdout so a caller can read it alone; the reason — which files, and why — is stderr.
-function detail_for(verdict: Verdict, paths: ReadonlyArray<string>): string {
+function exempt_detail(paths: ReadonlyArray<string>, is_static: boolean): string {
+	const exempt = test_declared_logic.exempt_files(paths, is_static)
+	const has_visual = is_static && exempt.some((path) => /\.(?:html|css)$/u.test(path))
+	const instruction = has_visual ? ' — confirm the rendered page in a browser' : ''
+
+	return `exempt paths: ${exempt.join(', ')}${instruction}`
+}
+
+function detail_for(verdict: Verdict, paths: ReadonlyArray<string>, is_static = false): string {
 	if (verdict === 'required') {
-		const typed = test_declared_logic.runtime_files(paths).map((path) => typed_runtime_file(path))
+		const typed = test_declared_logic
+			.runtime_files(paths, is_static)
+			.map((path) => typed_runtime_file(path))
 
 		return `runtime files with no test: ${typed.join(', ')}`
 	}
 
-	if (verdict === 'exempt') {
-		return `exempt paths: ${test_declared_logic.exempt_files(paths).join(', ')}`
-	}
+	if (verdict === 'exempt') return exempt_detail(paths, is_static)
 
 	return 'a test file changed'
 }
 
-function report(paths: ReadonlyArray<string>): { detail: string; verdict: Verdict } {
-	const verdict = test_declared_logic.verdict_for(paths)
+function report(
+	paths: ReadonlyArray<string>,
+	is_static: boolean = project_checks.is_static(process.cwd()),
+): { detail: string; verdict: Verdict } {
+	const verdict = test_declared_logic.verdict_for(paths, is_static)
 
-	return { detail: detail_for(verdict, paths), verdict }
+	return { detail: detail_for(verdict, paths, is_static), verdict }
 }
 
 function run(): void {

package/scripts/test/test-red-logic.ts

@@ -1,4 +1,4 @@
-import { markdown_section } from '#scripts/issue/markdown-section'
+import { issue_bug_label } from '#scripts/issue/issue-bug-label'
 import { z } from 'zod'
 import { test_declared_logic } from './test-declared-logic'
 
@@ -16,14 +16,14 @@ type RedVerdict = 'red' | 'green' | 'no-test'
 // The declaration a bug-fix Issue carries under its background heading, in the same slot as the
 // behavior-change declaration (`behavior-change-lint.ts`). Read from the declaration, never inferred,
 // so an Issue that does not declare itself a bug is never held to it.
-const BUG_DECLARATION_LINE = '- 種別: 不具合'
+const { BUG_DECLARATION_LINE } = issue_bug_label
 
 // Only a Vitest file can be run against the pre-fix tree here — an `*.e2e.ts` needs a served app, so it
 // is left to the CI E2E job rather than counted as a test this command ran.
 const UNIT_TEST_SUFFIX = '.test.ts'
 
 function is_bug_fix(body: string): boolean {
-	return markdown_section.has_line(body, BUG_DECLARATION_LINE)
+	return issue_bug_label.is_bug_fix(body)
 }
 
 // The changed paths that are Vitest files, in the order they were given.

package/scripts/test/test-unit-guard.ts

@@ -3,7 +3,9 @@ import { existsSync, globSync } from 'node:fs'
 import path from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { PROJECT_ENVIRONMENT_KEYS } from '#ports'
+import { project_checks } from '#scripts/gate/project-checks'
 import { execa } from 'execa'
+import { SKIP_MARKER } from './skip-marker'
 import { unit_worker_share } from './unit-worker-share'
 
 const PNPM = 'pnpm'
@@ -19,10 +21,10 @@ const NODE_MODULES = 'node_modules'
 // - **`vitest` absent is the young project.** `josh init` installs no vitest and writes no
 //   `test:unit` script, so a freshly-bootstrapped project always lands here — which is the case the
 //   skip was written for, and it keeps it.
-// - **`vitest` present is the project declaring that it runs unit tests.** Zero matching files
-//   there is a broken state rather than a young one — a mis-scoped glob, or a suite that was
-//   deleted — and reporting it as a passing check hands `pnpm josh followup`, which reads
-//   only the exit code, a verification that verified nothing. That half fails.
+// - **`vitest` present is the node project's declaration that it runs unit tests.** Zero matching
+//   files there is a broken state — a mis-scoped glob, or a deleted suite — and fails. A static
+//   project may carry vitest as an unused dependency without declaring a unit suite; zero files
+//   there are reported as skipped, never as a test pass.
 //
 // Rejected: leaving both halves green — joshuafolkken/kit#1216's `--verbose` makes the zero count
 // *readable* in the CI log, but nobody reads a green log and the merge gate reads only pass/fail;
@@ -35,25 +37,29 @@ const NODE_MODULES = 'node_modules'
 // `@playwright/test` is not one: it is an optional peer dependency that vitest's browser mode also
 // needs, so a project can legitimately have it installed with no `*.e2e.{ts,js}` file at all.
 const SKIP_ACTION = 'skip-missing-package'
+const SKIP_NO_TESTS_ACTION = 'skip-no-tests'
 const FAIL_ACTION = 'fail-no-tests'
 
-type GuardAction = 'run' | typeof SKIP_ACTION | typeof FAIL_ACTION
+type GuardAction = 'run' | typeof SKIP_ACTION | typeof SKIP_NO_TESTS_ACTION | typeof FAIL_ACTION
 
 // The word the gate looks for to know a passing step did not actually run. Exported and reused on
 // both sides rather than matched by eye: joshuafolkken/kit#967 stopped printing a passing check's
 // body, and without this a gate that skipped the whole unit suite printed the same five lines as one
 // that ran it.
-const SKIP_MARKER = '— skipping'
-
 const SKIP_REASON = 'vitest is not installed'
+const SKIP_NO_TESTS_REASON = 'no unit test files were found in this static project'
 const FAIL_REASON =
 	'vitest is installed but no *.{test,spec}.{ts,js} test file was found — refusing to report a unit check that ran nothing'
 
-function resolve_guard_action(is_installed: boolean, has_tests: boolean): GuardAction {
+function resolve_guard_action(
+	is_installed: boolean,
+	has_tests: boolean,
+	is_static = false,
+): GuardAction {
 	if (!is_installed) return SKIP_ACTION
-	if (!has_tests) return FAIL_ACTION
+	if (has_tests) return 'run'
 
-	return 'run'
+	return is_static ? SKIP_NO_TESTS_ACTION : FAIL_ACTION
 }
 
 function is_vitest_installed(project_directory: string): boolean {
@@ -132,7 +138,9 @@ function report_no_run(action: Exclude<GuardAction, 'run'>, command_label: strin
 		return FAIL_EXIT_CODE
 	}
 
-	console.info(`josh ${command_label}: ${SKIP_REASON} ${SKIP_MARKER} vitest unit tests.`)
+	const reason = action === SKIP_NO_TESTS_ACTION ? SKIP_NO_TESTS_REASON : SKIP_REASON
+
+	console.info(`josh ${command_label}: ${reason} ${SKIP_MARKER} vitest unit tests.`)
 
 	return 0
 }
@@ -149,7 +157,11 @@ async function run_guarded_vitest(
 ): Promise<number> {
 	const is_installed = is_vitest_installed(project_directory)
 	const has_tests = has_unit_tests(project_directory)
-	const action = resolve_guard_action(is_installed, has_tests)
+	const action = resolve_guard_action(
+		is_installed,
+		has_tests,
+		project_checks.is_static(project_directory),
+	)
 
 	if (action !== 'run') return report_no_run(action, command_label)
 	if (announcement !== undefined) process.stdout.write(`${announcement}\n`)

package/templates/CLAUDE.static.md

@@ -0,0 +1,8 @@
+# Project instructions
+
+- 既存のファイルと利用者の設定を尊重し、変更する前に内容を確認する。
+- 変更には検証を付け、実行した結果を報告する。
+- HTML、CSS、JavaScript のファイルがある場合は Prettier で整形する。
+- 画面に見える変更をした場合はブラウザーで表示と操作を確認する。
+- JavaScript または TypeScript の動作を変更した場合は、その動作を確認する自動テストを追加する。
+- Git や GitHub を使う場合だけ、それぞれのワークフローを利用する。

package/templates/cursorrules.static

@@ -0,0 +1 @@
+Read CLAUDE.md before making changes in this project. It contains the project instructions.

package/templates/pnpm-workspace.static.yaml

@@ -0,0 +1,4 @@
+# Written by `josh init` for a static project (joshuafolkken/kit#2693). kit's CLI runs on tsx, which
+# depends on esbuild, and pnpm fails an install whose dependencies carry an unapproved build script.
+allowBuilds:
+  esbuild: true

package/templates/prettierignore.static

@@ -0,0 +1,12 @@
+# Dependencies and generated files
+node_modules/
+dist/
+build/
+.pnpm-store/
+
+# Package manager lock files
+package-lock.json
+pnpm-lock.yaml
+yarn.lock
+bun.lock
+bun.lockb

package/templates/workflows/ci.yml

@@ -6,6 +6,7 @@ on:
 
   pull_request:
     branches: [main]
+    types: [opened, synchronize, reopened, labeled, unlabeled]
 
 # A push run is grouped by the commit it carries, so a later push to the default branch never
 # cancels an earlier one. Without the sha every such push shares one group — `github.ref` is
@@ -220,6 +221,10 @@ jobs:
       - name: Run unit tests
         run: pnpm josh test:unit
 
+      - name: Check release classification
+        if: github.event_name == 'pull_request'
+        run: pnpm josh pr:classification
+
       - name: Check bundle size
         run: pnpm size-limit