@joshuafolkken/kit 1.1128.0 → 1.1136.0

package/scripts/test/test-unit-guard.ts

@@ -79,6 +79,24 @@ function has_unit_tests(project_directory: string): boolean {
 	return matches.length > 0
 }
 
+// The guard's decision for one project, asked here once so the run, the scoped record and the gate's
+// precondition can never disagree about whether this project's vitest runs (joshuafolkken/kit#3136).
+function guard_action(project_directory: string): GuardAction {
+	return resolve_guard_action(
+		is_vitest_installed(project_directory),
+		has_unit_tests(project_directory),
+		project_checks.is_basic(project_directory),
+	)
+}
+
+// **A skip is the project having no unit suite, so no unit check can ever vouch for its tree.** The
+// failing branch is not one: it is a broken suite, and it is left to fail where it is reported.
+function is_skipping(project_directory: string): boolean {
+	const action = guard_action(project_directory)
+
+	return action === SKIP_ACTION || action === SKIP_NO_TESTS_ACTION
+}
+
 // A lane's port allocation belongs to its development and preview servers, not to unit fixtures.
 // Passing it into Vitest makes every case that deliberately omits or replaces the seed inherit the
 // checkout's seat instead. Keep the rest of the caller's environment, including CI and PATH guards.
@@ -155,13 +173,7 @@ async function run_guarded_vitest(
 	command_label: string = UNIT_COMMAND_LABEL,
 	announcement?: string,
 ): Promise<number> {
-	const is_installed = is_vitest_installed(project_directory)
-	const has_tests = has_unit_tests(project_directory)
-	const action = resolve_guard_action(
-		is_installed,
-		has_tests,
-		project_checks.is_basic(project_directory),
-	)
+	const action = guard_action(project_directory)
 
 	if (action !== 'run') return report_no_run(action, command_label)
 	if (announcement !== undefined) process.stdout.write(`${announcement}\n`)
@@ -185,6 +197,8 @@ if (process.argv[1] === fileURLToPath(import.meta.url)) {
 
 const test_unit_guard = {
 	SKIP_MARKER,
+	guard_action,
+	is_skipping,
 	resolve_guard_action,
 	is_vitest_installed,
 	has_unit_tests,

package/scripts/time-runtime/time-spans.ts

@@ -138,6 +138,9 @@ interface ToolCall {
 	// second write to one file is independent work, a read of a file just written is not
 	// (joshuafolkken/kit#1509).
 	is_writing: boolean
+	// The conservative write answer `is_read_only_call` asks of a live call, carried so a reader of the
+	// transcript asks the same read-only question as the guard (joshuafolkken/kit#3139).
+	may_write: boolean
 	// Whether this is a subagent launch whose prompt builds on an earlier launch's finding
 	// (joshuafolkken/kit#1854). Carried for the reason every field here is — the prompt it is read from
 	// is the input, and a span keeps none. `time-agent-bundles.ts` reads it.
@@ -474,6 +477,7 @@ function to_spans(events: ReadonlyArray<TimelineEvent>, finished: FinishedAt): A
 		is_bundleable: event.is_bundleable,
 		targets: event.targets,
 		is_writing: event.is_writing,
+		may_write: event.may_write,
 		has_prior_reference: event.has_prior_reference,
 		writes: event.writes,
 		message_id: event.message_id,

package/templates/workflows/github-release.yml

@@ -1,14 +1,13 @@
 name: GitHub Release
 
 # Creates the GitHub Release, with notes generated from `.github/release.yml`, for each tag
-# `josh release` cuts (joshuafolkken/kit#3007). A repository with a Publish workflow gets its release
-# once that workflow has succeeded for the tag; one without it gets the release when auto-tag.yml
-# announces the tag. kit's own release is the `create-release` job of its publish.yml, which runs the
-# same `josh release:github`, so this file is distributed but never runs in kit.
+# `josh release` cuts (joshuafolkken/kit#3007). It starts when auto-tag.yml announces the tag; a
+# repository with a Publish workflow gets its release once that workflow has succeeded for the tag,
+# waited for inside `josh release:github`. A `workflow_run` on Publish is not used: a Publish run
+# started by the GITHUB_TOKEN never fires one (joshuafolkken/kit#3138). kit's own release is the
+# `create-release` job of its publish.yml, which runs the same `josh release:github`, so this file is
+# distributed but never runs in kit.
 on:
-  workflow_run:
-    workflows: [Publish]
-    types: [completed]
   repository_dispatch:
     types: [new-tag-created]
 
@@ -17,12 +16,6 @@ on:
 
 jobs:
   release:
-    # The Publish run is titled `Publish <tag>`; its head branch is not the tag when it was started by
-    # repository_dispatch, so the title is where the tag is read from.
-    if: >-
-      (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success' &&
-      startsWith(github.event.workflow_run.display_title, 'Publish v')) ||
-      github.event_name == 'repository_dispatch'
     runs-on: ubuntu-latest
     timeout-minutes: 65
     permissions:
@@ -36,23 +29,17 @@ jobs:
           fetch-depth: 0
           persist-credentials: false
 
-      # A repository with a Publish workflow is released from the workflow_run above, after its
-      # publication, so the tag announcement is left alone there and one tag never starts two releases.
+      # A repository with a Publish workflow waits for that workflow's `Publish <tag>` run to succeed
+      # before releasing; the announcement is the only trigger, so one tag never starts two releases.
       - name: Select release tag
         id: release
         env:
-          EVENT_NAME: ${{ github.event_name }}
-          RUN_TITLE: ${{ github.event.workflow_run.display_title }}
-          RUN_WORKFLOW: ${{ github.event.workflow_run.workflow_id }}
           DISPATCH_TAG: ${{ github.event.client_payload.tag }}
         run: |
-          if [ "$EVENT_NAME" = workflow_run ]; then
-            echo "tag=${RUN_TITLE#Publish }" >> "$GITHUB_OUTPUT"
-            echo "workflow=$RUN_WORKFLOW" >> "$GITHUB_OUTPUT"
-          elif [ -f .github/workflows/publish.yml ]; then
-            echo "ℹ️ publish.yml releases this tag once it has published, skipping"
-          else
-            echo "tag=$DISPATCH_TAG" >> "$GITHUB_OUTPUT"
+          echo "tag=$DISPATCH_TAG" >> "$GITHUB_OUTPUT"
+          if [ -f .github/workflows/publish.yml ]; then
+            echo "workflow=publish.yml" >> "$GITHUB_OUTPUT"
+            echo "await=true" >> "$GITHUB_OUTPUT"
           fi
 
       - name: Setup Node.js
@@ -77,3 +64,4 @@ jobs:
           GH_TOKEN: ${{ github.token }}
           RELEASE_TAG: ${{ steps.release.outputs.tag }}
           RELEASE_WORKFLOW: ${{ steps.release.outputs.workflow }}
+          RELEASE_AWAIT_PUBLISH: ${{ steps.release.outputs.await }}