@jonit-dev/night-watch-cli 1.7.97 → 1.7.98

package/dist/scripts/night-watch-qa-cron.sh

@@ -379,12 +379,6 @@ cd "${PROJECT_DIR}"
 PROVIDER_MODEL_DISPLAY=$(resolve_provider_model_display "${PROVIDER_CMD}" "${PROVIDER_LABEL}")
 QA_ARTIFACTS_DESC=$(describe_qa_artifacts "${QA_ARTIFACTS}")
 
-send_telegram_status_message "🧪 Night Watch QA: started" "Project: ${PROJECT_NAME}
-Provider (model): ${PROVIDER_MODEL_DISPLAY}
-Artifacts: ${QA_ARTIFACTS_DESC} (mode=${QA_ARTIFACTS})
-Branch patterns: ${BRANCH_PATTERNS_RAW}
-Scanning open PRs for QA candidates."
-
 # Convert comma-separated branch prefixes into a regex that matches branch starts.
 BRANCH_REGEX=""
 IFS=',' read -r -a BRANCH_PATTERNS <<< "${BRANCH_PATTERNS_RAW}"
@@ -413,10 +407,6 @@ OPEN_PRS=$(
 
 if [ "${OPEN_PRS}" -eq 0 ]; then
   log "SKIP: No open PRs matching branch patterns (${BRANCH_PATTERNS_RAW})"
-  send_telegram_status_message "🧪 Night Watch QA: no matching PRs" "Project: ${PROJECT_NAME}
-Provider (model): ${PROVIDER_MODEL_DISPLAY}
-Branch patterns: ${BRANCH_PATTERNS_RAW}
-Result: 0 open PRs matched."
   emit_result "skip_no_open_prs"
   exit 0
 fi
@@ -472,10 +462,6 @@ done < <(
 
 if [ "${QA_NEEDED}" -eq 0 ]; then
   log "SKIP: All ${OPEN_PRS} open PR(s) matching patterns already have QA comments"
-  send_telegram_status_message "🧪 Night Watch QA: nothing to do" "Project: ${PROJECT_NAME}
-Provider (model): ${PROVIDER_MODEL_DISPLAY}
-Artifacts: ${QA_ARTIFACTS_DESC} (mode=${QA_ARTIFACTS})
-Result: All matching PRs already have QA results."
   emit_result "skip_all_qa_done"
   exit 0
 fi
@@ -525,10 +511,7 @@ QA_SCREENSHOT_SUMMARY=""
 for pr_ref in ${PRS_NEEDING_QA}; do
   pr_num="${pr_ref#\#}"
   PROCESSED_PRS_CSV=$(append_csv "${PROCESSED_PRS_CSV}" "#${pr_num}")
-  send_telegram_status_message "🧪 Night Watch QA: processing PR #${pr_num}" "Project: ${PROJECT_NAME}
-Provider (model): ${PROVIDER_MODEL_DISPLAY}
-Artifacts: ${QA_ARTIFACTS_DESC} (mode=${QA_ARTIFACTS})
-Action: generating QA tests and evidence."
+  log "QA: Processing PR #${pr_num}"
 
   cleanup_worktrees "${PROJECT_DIR}"
   if ! prepare_detached_worktree "${PROJECT_DIR}" "${QA_WORKTREE_DIR}" "${DEFAULT_BRANCH}" "${LOG_FILE}"; then

package/dist/templates/qa.md

@@ -37,7 +37,27 @@ Based on the diff, determine:
 - **Both**: PR touches both UI and API code
 - **No tests needed**: Trivial changes (docs, config, comments only) — in this case, post a comment saying "QA: No tests needed for this PR" and stop
 
-### Step 3: Prepare Test Infrastructure
+### Step 3: Discover Project Test Conventions
+
+Before generating any tests, examine the existing project structure:
+
+```bash
+# Find existing test files to understand conventions
+find . -type f \( -name "*.test.ts" -o -name "*.spec.ts" -o -name "*.test.js" -o -name "*.spec.js" \) \
+  ! -path "*/node_modules/*" ! -path "*/dist/*" | head -20
+
+# Check for test config files
+ls playwright.config.* vitest.config.* jest.config.* 2>/dev/null || true
+cat package.json | grep -A5 '"scripts"'
+
+# Check CLAUDE.md if it exists
+cat CLAUDE.md 2>/dev/null || true
+```
+
+Based on this output:
+- **Identify where existing tests live** (e.g., `src/__tests__/`, `tests/`, `__tests__/`, `spec/`)
+- **Identify naming conventions** (e.g., `*.test.ts`, `*.spec.ts`)
+- **Identify sub-directory structure** (flat, feature-grouped, etc.)
 
 **For UI tests (Playwright):**
 
@@ -54,23 +74,27 @@ Based on the diff, determine:
 
 ### Step 4: Generate Tests
 
+**Key rule: follow existing conventions. Do not create new folder structures unless they already exist in the project.**
+
 **UI Tests (Playwright):**
 
-- Create test files in `tests/e2e/qa/` (or the project's existing e2e directory)
+- Place test files alongside existing e2e/Playwright tests (wherever `playwright.config.*` points, or wherever existing `.spec.ts` files live)
+- Do NOT create a new `qa/` subdirectory — put files directly in the existing test directory with a descriptive name
 - Test the specific feature/page changed in the PR
 - Configure Playwright for artifacts based on `NW_QA_ARTIFACTS`:
   - `"screenshot"`: `screenshot: 'on'` only
   - `"video"`: `video: { mode: 'on', size: { width: 1280, height: 720 } }` only
   - `"both"`: Both screenshot and video enabled
-- Name test files with a `qa-` prefix: `qa-<feature-name>.spec.ts`
+- Name files matching the project's existing convention (e.g., `<feature>.spec.ts`, `<feature>.test.ts`)
 - Include at minimum: navigation to the feature, interaction with key elements, visual assertions
 
-**API Tests:**
+**API/Unit Tests:**
 
-- Create test files in `tests/integration/qa/` (or the project's existing test directory)
-- Test the specific endpoints changed in the PR
+- Place test files alongside existing tests in the same directory structure
+- Do NOT create a new `qa/` subdirectory — put files directly in the appropriate existing test directory
+- Test the specific endpoints/functions changed in the PR
 - Include: happy path, error cases, validation checks
-- Name test files with a `qa-` prefix: `qa-<endpoint-name>.test.ts`
+- Name files matching the project's existing convention (e.g., `<feature>.test.ts`)
 
 ### Step 5: Run Tests
 
@@ -101,8 +125,8 @@ mkdir -p qa-artifacts
 ### Step 7: Commit and Push
 
 ```bash
-git add tests/e2e/qa/ tests/integration/qa/ qa-artifacts/ || true
-git add -A tests/*/qa/ qa-artifacts/ || true
+# Stage the specific test files you created (use the exact paths)
+git add <path/to/test-file.test.ts> qa-artifacts/ 2>/dev/null || true
 git commit -m "test(qa): add automated QA tests for PR changes
 
 - Generated by Night Watch QA agent
@@ -163,7 +187,8 @@ Video artifact committed to \`qa-artifacts/\` — view in the PR's file changes.
 ### Important Rules
 
 - Process each PR **once** per run. Do NOT loop or retry after pushing.
-- Do NOT modify existing project tests — only add new files in `qa/` subdirectories.
+- Do NOT modify existing project tests — only add new test files.
+- **Do NOT create new directories** — place test files inside existing test directories following project conventions. Only create a new directory if the project has absolutely no test infrastructure at all.
 - If tests fail, still commit and report — the failures are useful information.
 - Keep test files self-contained and independent from each other.
 - Follow the project's existing code style and conventions (check CLAUDE.md, package.json scripts, tsconfig).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jonit-dev/night-watch-cli",
-  "version": "1.7.97",
+  "version": "1.7.98",
   "description": "Autonomous PRD execution using AI Provider CLIs + cron",
   "type": "module",
   "bin": {