@jonit-dev/night-watch-cli 1.7.78 → 1.7.80

package/dist/scripts/night-watch-audit-cron.sh

@@ -23,21 +23,13 @@ SCRIPT_TYPE="audit"
 PROVIDER_LABEL="${NW_PROVIDER_LABEL:-}"
 SCRIPT_START_TIME=$(date +%s)
 
-# Ensure NVM / Node / Claude are on PATH
-export NVM_DIR="${HOME}/.nvm"
-[ -s "${NVM_DIR}/nvm.sh" ] && . "${NVM_DIR}/nvm.sh"
-
 mkdir -p "${LOG_DIR}"
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=night-watch-helpers.sh
 source "${SCRIPT_DIR}/night-watch-helpers.sh"
-PROJECT_RUNTIME_KEY=$(project_runtime_key "${PROJECT_DIR}")
-# NOTE: Lock file path must match auditLockPath() in src/utils/status-data.ts
-LOCK_FILE="/tmp/night-watch-audit-${PROJECT_RUNTIME_KEY}.lock"
-AUDIT_PROMPT_TEMPLATE="${SCRIPT_DIR}/../templates/audit.md"
-PROVIDER_MODEL_DISPLAY=$(resolve_provider_model_display "${PROVIDER_CMD}" "${PROVIDER_LABEL}")
 
+# emit_result helper - must be defined before use
 emit_result() {
   local status="${1:?status required}"
   local details="${2:-}"
@@ -48,13 +40,25 @@ emit_result() {
   fi
 }
 
-# Validate provider
+# Validate provider name first (must be claude or codex)
 if ! validate_provider "${PROVIDER_CMD}"; then
   echo "ERROR: Unknown provider: ${PROVIDER_CMD}" >&2
   emit_result "failure" "reason=unknown_provider"
   exit 1
 fi
 
+# Ensure provider CLI is on PATH (nvm, fnm, volta, common bin dirs)
+if ! ensure_provider_on_path "${PROVIDER_CMD}"; then
+  echo "ERROR: Provider '${PROVIDER_CMD}' not found in PATH or common installation locations" >&2
+  emit_result "failure" "reason=provider_not_found"
+  exit 1
+fi
+PROJECT_RUNTIME_KEY=$(project_runtime_key "${PROJECT_DIR}")
+# NOTE: Lock file path must match auditLockPath() in src/utils/status-data.ts
+LOCK_FILE="/tmp/night-watch-audit-${PROJECT_RUNTIME_KEY}.lock"
+AUDIT_PROMPT_TEMPLATE="${SCRIPT_DIR}/../templates/audit.md"
+PROVIDER_MODEL_DISPLAY=$(resolve_provider_model_display "${PROVIDER_CMD}" "${PROVIDER_LABEL}")
+
 # Global gate: if queue is enabled and we can't acquire the global lock,
 # enqueue the job and exit. The dispatcher will run it later.
 if [ "${NW_QUEUE_ENABLED:-0}" = "1" ]; then
@@ -166,7 +170,7 @@ for AUDIT_ATTEMPT in $(seq 1 "${AUDIT_MAX_RETRIES}"); do
         cd "${AUDIT_WORKTREE_DIR}" && timeout "${MAX_RUNTIME}" \
           claude -p "${AUDIT_PROMPT}" \
             --dangerously-skip-permissions \
-            >> "${LOG_FILE}" 2>&1
+            2>&1 | tee -a "${LOG_FILE}"
       ); then
         EXIT_CODE=0
       else
@@ -180,7 +184,7 @@ for AUDIT_ATTEMPT in $(seq 1 "${AUDIT_MAX_RETRIES}"); do
             -C "${AUDIT_WORKTREE_DIR}" \
             --yolo \
             "${AUDIT_PROMPT}" \
-            >> "${LOG_FILE}" 2>&1
+            2>&1 | tee -a "${LOG_FILE}"
       ); then
         EXIT_CODE=0
       else

package/dist/scripts/night-watch-cron.sh

@@ -8,7 +8,7 @@ set -euo pipefail
 # NOTE: This script expects environment variables to be set by the caller.
 # The Node.js CLI will inject config values via environment variables.
 # Required env vars (with defaults shown):
-#   NW_MAX_RUNTIME=7200          - Maximum runtime in seconds (2 hours)
+#   NW_MAX_RUNTIME=14400         - Maximum runtime in seconds (4 hours)
 #   NW_PROVIDER_CMD=claude       - AI provider CLI to use (claude, codex, etc.)
 #   NW_DRY_RUN=0                 - Set to 1 for dry-run mode (prints diagnostics only)
 
@@ -22,7 +22,7 @@ else
 fi
 LOG_DIR="${PROJECT_DIR}/logs"
 LOG_FILE="${LOG_DIR}/executor.log"
-MAX_RUNTIME="${NW_MAX_RUNTIME:-7200}"  # 2 hours — used for cooldowns and eligibility
+MAX_RUNTIME="${NW_MAX_RUNTIME:-14400}"  # 4 hours — used for cooldowns and eligibility
 SESSION_MAX_RUNTIME="${NW_SESSION_MAX_RUNTIME:-${MAX_RUNTIME}}"  # per-invocation timeout; defaults to MAX_RUNTIME
 MAX_LOG_SIZE="524288"  # 512 KB
 PROVIDER_CMD="${NW_PROVIDER_CMD:-claude}"
@@ -34,19 +34,18 @@ EFFECTIVE_PROVIDER_LABEL="${PROVIDER_LABEL}"
 BRANCH_PREFIX="${NW_BRANCH_PREFIX:-night-watch}"
 SCRIPT_START_TIME=$(date +%s)
 
-# Ensure NVM / Node / Claude are on PATH
-export NVM_DIR="${HOME}/.nvm"
-[ -s "${NVM_DIR}/nvm.sh" ] && . "${NVM_DIR}/nvm.sh"
-
-# NOTE: Environment variables should be set by the caller (Node.js CLI).
-# The .env.night-watch sourcing has been removed - config is now injected via env vars.
-
 mkdir -p "${LOG_DIR}"
 
 # Load shared helpers
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=night-watch-helpers.sh
 source "${SCRIPT_DIR}/night-watch-helpers.sh"
+
+# Ensure provider CLI is on PATH (nvm, fnm, volta, common bin dirs)
+if ! ensure_provider_on_path "${PROVIDER_CMD}"; then
+  echo "ERROR: Provider '${PROVIDER_CMD}' not found in PATH or common installation locations" >&2
+  exit 127
+fi
 PROJECT_RUNTIME_KEY=$(project_runtime_key "${PROJECT_DIR}")
 # NOTE: Lock file path must match executorLockPath() in src/utils/status-data.ts
 LOCK_FILE="/tmp/night-watch-${PROJECT_RUNTIME_KEY}.lock"
@@ -548,7 +547,7 @@ while [ "${ATTEMPT}" -lt "${MAX_RETRIES}" ]; do
         cd "${WORKTREE_DIR}" && timeout "${SESSION_MAX_RUNTIME}" \
           claude -p "${PROMPT}" \
             --dangerously-skip-permissions \
-            >> "${LOG_FILE}" 2>&1
+            2>&1 | tee -a "${LOG_FILE}"
       ); then
         EXIT_CODE=0
       else
@@ -562,7 +561,7 @@ while [ "${ATTEMPT}" -lt "${MAX_RETRIES}" ]; do
             -C "${WORKTREE_DIR}" \
             --yolo \
             "${PROMPT}" \
-            >> "${LOG_FILE}" 2>&1
+            2>&1 | tee -a "${LOG_FILE}"
       ); then
         EXIT_CODE=0
       else
@@ -629,7 +628,7 @@ if [ "${RATE_LIMIT_FALLBACK_TRIGGERED}" = "1" ]; then
         claude -p "${PROMPT}" \
           --dangerously-skip-permissions \
           --model "${FALLBACK_MODEL}" \
-          >> "${LOG_FILE}" 2>&1
+          2>&1 | tee -a "${LOG_FILE}"
   ); then
     EXIT_CODE=0
   else
@@ -667,6 +666,7 @@ if [ ${EXIT_CODE} -eq 0 ]; then
       fi
       "${NW_CLI}" board close-issue "${ISSUE_NUMBER}" 2>>"${LOG_FILE}" || \
         "${NW_CLI}" board move-issue "${ISSUE_NUMBER}" --column "Done" 2>>"${LOG_FILE}" || true
+      log "SUCCESS: PR opened and ready for review — ${PR_URL}"
       emit_result "success_open_pr" "prd=${ELIGIBLE_PRD}|branch=${BRANCH_NAME}"
     elif finalize_prd_done "implemented, PR opened on ${BRANCH_NAME}"; then
       # Non-board mode: post attribution comment to the PR
@@ -675,6 +675,7 @@ if [ ${EXIT_CODE} -eq 0 ]; then
       if [ -n "${NON_BOARD_PR_URL}" ]; then
         gh pr comment "${NON_BOARD_PR_URL}" --body "> 🤖 Implemented by ${EFFECTIVE_PROVIDER_LABEL}" 2>>"${LOG_FILE}" || true
       fi
+      log "SUCCESS: PR opened and ready for review — ${NON_BOARD_PR_URL}"
       emit_result "success_open_pr" "prd=${ELIGIBLE_PRD}|branch=${BRANCH_NAME}"
     else
       night_watch_history record "${PROJECT_DIR}" "${ELIGIBLE_PRD}" failure --exit-code 1 2>/dev/null || true

package/dist/scripts/night-watch-helpers.sh

@@ -2,6 +2,78 @@
 # Night Watch helper functions — shared by cron scripts.
 # Source this file, don't execute it directly.
 
+# ── Provider PATH resolution ─────────────────────────────────────────────────
+
+# Ensure AI provider CLI (claude, codex, etc.) and Node.js tooling are
+# discoverable on PATH.  Sources common Node version managers and probes
+# well-known bin directories so the script works regardless of how the
+# provider was installed (nvm, fnm, volta, npm global, Homebrew, etc.).
+# Returns 0 if the provider is found, 1 otherwise.
+ensure_provider_on_path() {
+  local provider="${1:-claude}"
+
+  # Already available — nothing to do
+  if command -v "${provider}" >/dev/null 2>&1; then
+    return 0
+  fi
+
+  # ── Node version managers ──────────────────────────────────────────────
+  # nvm
+  export NVM_DIR="${NVM_DIR:-${HOME}/.nvm}"
+  if [ -s "${NVM_DIR}/nvm.sh" ]; then
+    # shellcheck source=/dev/null
+    . "${NVM_DIR}/nvm.sh"
+    if command -v "${provider}" >/dev/null 2>&1; then return 0; fi
+  fi
+
+  # fnm (Fast Node Manager)
+  if command -v fnm >/dev/null 2>&1; then
+    eval "$(fnm env 2>/dev/null)" || true
+  elif [ -x "${HOME}/.local/share/fnm/fnm" ]; then
+    export PATH="${HOME}/.local/share/fnm:${PATH}"
+    eval "$(fnm env 2>/dev/null)" || true
+  fi
+  if command -v "${provider}" >/dev/null 2>&1; then return 0; fi
+
+  # volta
+  if [ -d "${HOME}/.volta/bin" ]; then
+    export PATH="${HOME}/.volta/bin:${PATH}"
+    if command -v "${provider}" >/dev/null 2>&1; then return 0; fi
+  fi
+
+  # mise / asdf
+  if [ -d "${HOME}/.local/share/mise/shims" ]; then
+    export PATH="${HOME}/.local/share/mise/shims:${PATH}"
+    if command -v "${provider}" >/dev/null 2>&1; then return 0; fi
+  fi
+  if [ -d "${HOME}/.asdf/shims" ]; then
+    export PATH="${HOME}/.asdf/shims:${PATH}"
+    if command -v "${provider}" >/dev/null 2>&1; then return 0; fi
+  fi
+
+  # ── Well-known bin directories ─────────────────────────────────────────
+  local candidate_dirs=(
+    "${HOME}/.npm-global/bin"
+    "${HOME}/.local/bin"
+    "${HOME}/.claude/bin"
+    "/usr/local/bin"
+    "${HOME}/.yarn/bin"
+    "${HOME}/.bun/bin"
+    "${HOME}/.local/share/pnpm"
+    "/home/linuxbrew/.linuxbrew/bin"
+    "/opt/homebrew/bin"
+  )
+
+  for dir in "${candidate_dirs[@]}"; do
+    if [ -x "${dir}/${provider}" ]; then
+      export PATH="${dir}:${PATH}"
+      return 0
+    fi
+  done
+
+  return 1
+}
+
 # ── Provider validation ───────────────────────────────────────────────────────
 
 # Validates that the provider command is supported.
@@ -168,7 +240,9 @@ log() {
     _esec=$(( _elapsed % 60 ))
     elapsed_str=" [+${_emin}m${_esec}s]"
   fi
-  echo "[$(date '+%Y-%m-%d %H:%M:%S')] [PID:$$]${elapsed_str} $*" >> "${log_file}"
+  local msg="[$(date '+%Y-%m-%d %H:%M:%S')] [PID:$$]${elapsed_str} $*"
+  echo "${msg}" >> "${log_file}"
+  echo "${msg}" >&2
 }
 
 # Write a visual separator line to the log to delimit separate runs.

package/dist/scripts/night-watch-pr-reviewer-cron.sh

@@ -54,18 +54,17 @@ if [ "${REVIEWER_RETRY_DELAY}" -gt 300 ]; then
   REVIEWER_RETRY_DELAY="300"
 fi
 
-# Ensure NVM / Node / Claude are on PATH
-export NVM_DIR="${HOME}/.nvm"
-[ -s "${NVM_DIR}/nvm.sh" ] && . "${NVM_DIR}/nvm.sh"
-
-# NOTE: Environment variables should be set by the caller (Node.js CLI).
-# The .env.night-watch sourcing has been removed - config is now injected via env vars.
-
 mkdir -p "${LOG_DIR}"
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=night-watch-helpers.sh
 source "${SCRIPT_DIR}/night-watch-helpers.sh"
+
+# Ensure provider CLI is on PATH (nvm, fnm, volta, common bin dirs)
+if ! ensure_provider_on_path "${PROVIDER_CMD}"; then
+  echo "ERROR: Provider '${PROVIDER_CMD}' not found in PATH or common installation locations" >&2
+  exit 127
+fi
 PROJECT_RUNTIME_KEY=$(project_runtime_key "${PROJECT_DIR}")
 PROVIDER_MODEL_DISPLAY=$(resolve_provider_model_display "${PROVIDER_CMD}" "${PROVIDER_LABEL}")
 GLOBAL_LOCK_FILE="/tmp/night-watch-pr-reviewer-${PROJECT_RUNTIME_KEY}.lock"
@@ -1078,7 +1077,7 @@ for ATTEMPT in $(seq 1 "${TOTAL_ATTEMPTS}"); do
         cd "${REVIEW_WORKTREE_DIR}" && timeout "${ATTEMPT_TIMEOUT}" \
           claude -p "${REVIEWER_PROMPT}" \
             --dangerously-skip-permissions \
-            >> "${LOG_FILE}" 2>&1
+            2>&1 | tee -a "${LOG_FILE}"
       ); then
         EXIT_CODE=0
       else
@@ -1092,7 +1091,7 @@ for ATTEMPT in $(seq 1 "${TOTAL_ATTEMPTS}"); do
             -C "${REVIEW_WORKTREE_DIR}" \
             --yolo \
             "${REVIEWER_PROMPT}" \
-            >> "${LOG_FILE}" 2>&1
+            2>&1 | tee -a "${LOG_FILE}"
       ); then
         EXIT_CODE=0
       else

package/dist/scripts/night-watch-qa-cron.sh

@@ -29,18 +29,17 @@ QA_ARTIFACTS="${NW_QA_ARTIFACTS:-both}"
 QA_AUTO_INSTALL_PLAYWRIGHT="${NW_QA_AUTO_INSTALL_PLAYWRIGHT:-1}"
 SCRIPT_START_TIME=$(date +%s)
 
-# Ensure NVM / Node / Claude are on PATH
-export NVM_DIR="${HOME}/.nvm"
-[ -s "${NVM_DIR}/nvm.sh" ] && . "${NVM_DIR}/nvm.sh"
-
-# NOTE: Environment variables should be set by the caller (Node.js CLI).
-# The .env.night-watch sourcing has been removed - config is now injected via env vars.
-
 mkdir -p "${LOG_DIR}"
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=night-watch-helpers.sh
 source "${SCRIPT_DIR}/night-watch-helpers.sh"
+
+# Ensure provider CLI is on PATH (nvm, fnm, volta, common bin dirs)
+if ! ensure_provider_on_path "${PROVIDER_CMD}"; then
+  echo "ERROR: Provider '${PROVIDER_CMD}' not found in PATH or common installation locations" >&2
+  exit 127
+fi
 PROJECT_RUNTIME_KEY=$(project_runtime_key "${PROJECT_DIR}")
 # NOTE: Lock file path must match qaLockPath() in src/utils/status-data.ts
 LOCK_FILE="/tmp/night-watch-qa-${PROJECT_RUNTIME_KEY}.lock"
@@ -598,7 +597,7 @@ Action: generating QA tests and evidence."
         cd "${QA_WORKTREE_DIR}" && timeout "${MAX_RUNTIME}" \
           claude -p "${QA_PROMPT}" \
             --dangerously-skip-permissions \
-            >> "${LOG_FILE}" 2>&1
+            2>&1 | tee -a "${LOG_FILE}"
       ); then
         PROVIDER_OK=1
       else
@@ -625,7 +624,7 @@ Action: generating QA tests and evidence."
             -C "${QA_WORKTREE_DIR}" \
             --yolo \
             "${QA_PROMPT}" \
-            >> "${LOG_FILE}" 2>&1
+            2>&1 | tee -a "${LOG_FILE}"
       ); then
         PROVIDER_OK=1
       else

package/dist/scripts/night-watch-slicer-cron.sh

@@ -25,15 +25,14 @@ PROVIDER_CMD="${NW_PROVIDER_CMD:-claude}"
 PROVIDER_LABEL="${NW_PROVIDER_LABEL:-}"
 SCRIPT_START_TIME=$(date +%s)
 
-# Ensure NVM / Node / Night Watch CLI are on PATH
-export NVM_DIR="${HOME}/.nvm"
-[ -s "${NVM_DIR}/nvm.sh" ] && . "${NVM_DIR}/nvm.sh"
-
 mkdir -p "${LOG_DIR}"
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=night-watch-helpers.sh
 source "${SCRIPT_DIR}/night-watch-helpers.sh"
+
+# Ensure provider CLI is on PATH (nvm, fnm, volta, common bin dirs)
+ensure_provider_on_path "${PROVIDER_CMD}" || true
 PROJECT_RUNTIME_KEY=$(project_runtime_key "${PROJECT_DIR}")
 LOCK_FILE="/tmp/night-watch-slicer-${PROJECT_RUNTIME_KEY}.lock"
 PROVIDER_MODEL_DISPLAY=$(resolve_provider_model_display "${PROVIDER_CMD}" "${PROVIDER_LABEL}")

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jonit-dev/night-watch-cli",
-  "version": "1.7.78",
+  "version": "1.7.80",
   "description": "Autonomous PRD execution using AI Provider CLIs + cron",
   "type": "module",
   "bin": {