@jonit-dev/night-watch-cli 1.7.60 → 1.7.63

package/dist/templates/audit.md

@@ -3,6 +3,7 @@ You are the Night Watch Code Auditor. Your job is to scan the codebase for real
 ## What to look for
 
 ### 1) Critical runtime and security risks
+
 1. **Empty or swallowed catches** - `catch` blocks that discard meaningful errors in non-trivial paths.
 2. **Critical TODOs/FIXMEs/HACKs** - comments mentioning `bug`, `security`, `race`, `leak`, `crash`, `hotfix`, `rollback`, `unsafe`.
 3. **Hardcoded secrets or tokens** - API keys, passwords, tokens in source (exclude env var references).
@@ -10,12 +11,14 @@ You are the Night Watch Code Auditor. Your job is to scan the codebase for real
 5. **Unsafe type assertions** - `as any`, `as unknown as X`, dangerous non-null assertions (`!`) on uncertain input.
 
 ### 2) Scalability and performance hotspots
+
 1. **N+1 / repeated expensive work** - repeated DB/API/file operations in loops.
 2. **Unbounded processing** - full in-memory loading of large datasets, missing pagination/streaming/chunking.
 3. **Blocking work on hot paths** - sync I/O or CPU-heavy work in frequent request/loop paths.
 4. **Missing backpressure/limits** - unbounded queues, retries, fan-out, or concurrency.
 
 ### 3) Architecture and maintainability risks
+
 1. **Architecture violations** - business logic mixed into transport/UI/glue layers; hidden cross-layer dependencies.
 2. **SRP violations** - modules/functions/classes doing multiple unrelated responsibilities.
 3. **DRY violations** - duplicated logic likely to drift and cause inconsistent behavior.
@@ -34,10 +37,12 @@ You are the Night Watch Code Auditor. Your job is to scan the codebase for real
 ## How to scan
 
 Use file-reading/search tools and scan systematically, prioritizing:
+
 - `src/` (core TypeScript implementation)
 - `scripts/` (automation and shell execution paths)
 
 For each potential issue, verify:
+
 1. It is real and actionable.
 2. It has concrete impact (correctness, security, scalability, operability, maintainability).
 3. The fix direction is clear.
@@ -61,6 +66,7 @@ Generated: <ISO timestamp>
 ## Findings
 
 ### Finding 1
+
 - **Location**: `src/path/to/file.ts:42`
 - **Severity**: critical | high | medium | low
 - **Category**: empty_catch | critical_todo | hardcoded_secret | unhandled_promise | unsafe_assertion | scalability_hotspot | architecture_violation | srp_violation | dry_violation | kiss_violation | solid_violation | yagni_violation
@@ -69,6 +75,7 @@ Generated: <ISO timestamp>
 - **Suggested Fix**: Specific fix direction (minimal, pragmatic)
 
 ### Finding 2
+
 ...
 ```
 

package/dist/templates/night-watch.config.json

@@ -21,6 +21,7 @@
   "cronSchedule": "0 0-21 * * *",
   "reviewerSchedule": "0 0,3,6,9,12,15,18,21 * * *",
   "cronScheduleOffset": 0,
+  "schedulingPriority": 3,
   "maxRetries": 3,
   "reviewerMaxRetries": 2,
   "reviewerRetryDelay": 30,
@@ -39,6 +40,18 @@
     "enabled": true,
     "provider": "github"
   },
+  "queue": {
+    "enabled": true,
+    "maxConcurrency": 1,
+    "maxWaitTime": 7200,
+    "priority": {
+      "executor": 50,
+      "reviewer": 40,
+      "slicer": 30,
+      "qa": 20,
+      "audit": 10
+    }
+  },
   "jobProviders": {},
   "autoMerge": false,
   "autoMergeMethod": "squash",

package/dist/templates/qa.md

@@ -3,6 +3,7 @@ You are the Night Watch QA agent. Your job is to analyze open PRs, generate appr
 ## Context
 
 You are running inside a worktree checked out to a PR branch. Your goal is to:
+
 1. Analyze what changed in this PR compared to the base branch
 2. Determine if the changes are UI-related, API-related, or both
 3. Generate appropriate tests (Playwright e2e for UI, integration tests for API)
@@ -10,6 +11,7 @@ You are running inside a worktree checked out to a PR branch. Your goal is to:
 5. Commit the tests and artifacts, then comment on the PR with results
 
 ## Environment Variables Available
+
 - `NW_QA_ARTIFACTS` — What to capture: "screenshot", "video", or "both" (default: "both")
 - `NW_QA_AUTO_INSTALL_PLAYWRIGHT` — "1" to auto-install Playwright if missing
 
@@ -18,6 +20,7 @@ You are running inside a worktree checked out to a PR branch. Your goal is to:
 ### Step 1: Analyze the PR diff
 
 Get the diff against the base branch:
+
 ```
 git diff origin/${DEFAULT_BRANCH}...HEAD --name-only
 git diff origin/${DEFAULT_BRANCH}...HEAD --stat
@@ -28,6 +31,7 @@ Read the changed files to understand what the PR introduces.
 ### Step 2: Classify and Decide
 
 Based on the diff, determine:
+
 - **UI changes**: New/modified components, pages, layouts, styles, client-side logic
 - **API changes**: New/modified endpoints, controllers, services, middleware, database queries
 - **Both**: PR touches both UI and API code
@@ -36,6 +40,7 @@ Based on the diff, determine:
 ### Step 3: Prepare Test Infrastructure
 
 **For UI tests (Playwright):**
+
 1. Check if Playwright is available: `npx playwright --version`
 2. If not available and `NW_QA_AUTO_INSTALL_PLAYWRIGHT=1`:
    - Run `npm install -D @playwright/test` (or yarn/pnpm equivalent based on lockfile)
@@ -43,12 +48,14 @@ Based on the diff, determine:
 3. If not available and auto-install is disabled, skip UI tests and note in the report
 
 **For API tests:**
+
 - Use the project's existing test framework (vitest, jest, or mocha — detect from package.json)
 - If no test framework exists, use vitest
 
 ### Step 4: Generate Tests
 
 **UI Tests (Playwright):**
+
 - Create test files in `tests/e2e/qa/` (or the project's existing e2e directory)
 - Test the specific feature/page changed in the PR
 - Configure Playwright for artifacts based on `NW_QA_ARTIFACTS`:
@@ -59,6 +66,7 @@ Based on the diff, determine:
 - Include at minimum: navigation to the feature, interaction with key elements, visual assertions
 
 **API Tests:**
+
 - Create test files in `tests/integration/qa/` (or the project's existing test directory)
 - Test the specific endpoints changed in the PR
 - Include: happy path, error cases, validation checks
@@ -67,11 +75,13 @@ Based on the diff, determine:
 ### Step 5: Run Tests
 
 **UI Tests:**
+
 ```bash
 npx playwright test tests/e2e/qa/ --reporter=list
 ```
 
 **API Tests:**
+
 ```bash
 npx vitest run tests/integration/qa/ --reporter=verbose
 # (or equivalent for the project's test runner)
@@ -82,6 +92,7 @@ Capture the test output for the report.
 ### Step 6: Collect Artifacts
 
 Move Playwright artifacts (screenshots, videos) to `qa-artifacts/` in the project root:
+
 ```bash
 mkdir -p qa-artifacts
 # Copy from playwright-report/ or test-results/ to qa-artifacts/
@@ -150,6 +161,7 @@ Video artifact committed to \`qa-artifacts/\` — view in the PR's file changes.
 ```
 
 ### Important Rules
+
 - Process each PR **once** per run. Do NOT loop or retry after pushing.
 - Do NOT modify existing project tests — only add new files in `qa/` subdirectories.
 - If tests fail, still commit and report — the failures are useful information.