@jonathan0823/pi-sonarqube 0.8.2 → 0.9.1

package/dist/types.js.map

@@ -1 +1 @@
-{"version":3,"file":"types.js","sourceRoot":"","sources":["../src/types.ts"],"names":[],"mappings":"AAAA,iFAAiF;AA4HjF,+EAA+E;AAE/E,MAAM,CAAC,MAAM,gBAAgB,GAAG;IAC9B,SAAS;IACT,UAAU;IACV,OAAO;IACP,OAAO;IACP,MAAM;CACE,CAAC;AACX,MAAM,CAAC,MAAM,cAAc,GAAG;IAC5B,MAAM;IACN,WAAW;IACX,UAAU;IACV,UAAU;IACV,QAAQ;CACA,CAAC;AACX,MAAM,CAAC,MAAM,WAAW,GAAG,CAAC,KAAK,EAAE,eAAe,EAAE,YAAY,CAAU,CAAC;AAC3E,MAAM,CAAC,MAAM,wBAAwB,GAAG;IACtC,iBAAiB;IACjB,aAAa;IACb,UAAU;CACF,CAAC;AACX,MAAM,CAAC,MAAM,uBAAuB,GAAG;IACrC,SAAS;IACT,MAAM;IACN,QAAQ;IACR,KAAK;IACL,MAAM;CACE,CAAC"}
+{"version":3,"file":"types.js","sourceRoot":"","sources":["../src/types.ts"],"names":[],"mappings":"AAAA,iFAAiF;AA8HjF,+EAA+E;AAE/E,MAAM,CAAC,MAAM,gBAAgB,GAAG;IAC9B,SAAS;IACT,UAAU;IACV,OAAO;IACP,OAAO;IACP,MAAM;CACE,CAAC;AACX,MAAM,CAAC,MAAM,cAAc,GAAG;IAC5B,MAAM;IACN,WAAW;IACX,UAAU;IACV,UAAU;IACV,QAAQ;CACA,CAAC;AACX,MAAM,CAAC,MAAM,WAAW,GAAG,CAAC,KAAK,EAAE,eAAe,EAAE,YAAY,CAAU,CAAC;AAC3E,MAAM,CAAC,MAAM,wBAAwB,GAAG;IACtC,iBAAiB;IACjB,aAAa;IACb,UAAU;CACF,CAAC;AACX,MAAM,CAAC,MAAM,uBAAuB,GAAG;IACrC,SAAS;IACT,MAAM;IACN,QAAQ;IACR,KAAK;IACL,MAAM;CACE,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jonathan0823/pi-sonarqube",
-  "version": "0.8.2",
+  "version": "0.9.1",
   "description": "SonarQube extension for Pi — run local analysis and browse issues.",
   "type": "module",
   "main": "dist/index.js",
@@ -44,11 +44,11 @@
     "type": "git",
     "url": "git+https://github.com/Jonathan0823/pi-sonarqube.git"
   },
-  "dependencies": {
-    "@earendil-works/pi-ai": "^0.79.6",
-    "@earendil-works/pi-coding-agent": "^0.79.6",
-    "@earendil-works/pi-tui": "^0.79.6",
-    "typebox": "^1.1.38"
+  "peerDependencies": {
+    "@earendil-works/pi-ai": "*",
+    "@earendil-works/pi-coding-agent": "*",
+    "@earendil-works/pi-tui": "*",
+    "typebox": "*"
   },
   "devDependencies": {
     "c8": "^11.0.0",

package/src/api.ts

@@ -20,7 +20,7 @@ import {
   SONAR_IMPACT_SEVERITIES,
   CleanCodeMode,
 } from "./types.js";
-import { parseProperties } from "./config.js";
+import { parseProperties, trimTrailing } from "./config.js";
 
 // ── Clean code mode detection ────────────────────────────────────────────────
 
@@ -115,6 +115,7 @@ export function normalizeIssueFilters(
     rules: normalizeIssueList(filters?.rules),
     softwareQualities: normalizeIssueList(filters?.softwareQualities, true),
     impactSeverities: normalizeIssueList(filters?.impactSeverities, true),
+    issueKeys: normalizeIssueList(filters?.issueKeys),
     pathScope: filters?.pathScope,
     componentKeys: filters?.componentKeys,
   };
@@ -124,6 +125,7 @@ export function normalizeIssueFilters(
     normalized.rules ||
     normalized.softwareQualities ||
     normalized.impactSeverities ||
+    normalized.issueKeys ||
     normalized.pathScope ||
     normalized.componentKeys?.length
     ? normalized
@@ -213,15 +215,34 @@ export function parseIssueFilterToken(
   return undefined;
 }
 
+function parseIssueKeyToken(
+  token: string,
+  allowIssueKeys: boolean,
+): string[] | undefined {
+  if (!allowIssueKeys || !token.toLowerCase().startsWith("issue:")) {
+    return undefined;
+  }
+  const keys = token
+    .slice(token.indexOf(":") + 1)
+    .split(",")
+    .map((key) => key.trim())
+    .filter(Boolean);
+  if (keys.length === 0) throw new Error("issue: requires an issue key");
+  return keys;
+}
+
 export function parseSonarIssueArgs(
   tokens: string[],
   allowIssueIndex = false,
+  allowIssueKeys = false,
 ): {
   targetInput?: string;
   issueIndex?: number;
+  issueKeys?: string[];
   filters?: SonarIssueFetchOptions;
 } {
   const filters: Array<Partial<SonarIssueFetchOptions> | undefined> = [];
+  const issueKeys: string[] = [];
   let targetInput: string | undefined;
   let issueIndex: number | undefined;
 
@@ -231,6 +252,11 @@ export function parseSonarIssueArgs(
       issueIndex = Number(token);
       continue;
     }
+    const parsedIssueKeys = parseIssueKeyToken(token, allowIssueKeys);
+    if (parsedIssueKeys) {
+      issueKeys.push(...parsedIssueKeys);
+      continue;
+    }
 
     const parsedFilter = parseIssueFilterToken(token);
     if (parsedFilter) {
@@ -243,7 +269,12 @@ export function parseSonarIssueArgs(
     }
   }
 
-  return { targetInput, issueIndex, filters: mergeFilters(...filters) };
+  return {
+    targetInput,
+    issueIndex,
+    issueKeys: normalizeIssueList(issueKeys),
+    filters: mergeFilters(...filters),
+  };
 }
 
 function mergeFilterField<T>(
@@ -289,6 +320,8 @@ export function issueFilterLabel(filters?: SonarIssueFetchOptions): string {
     parts.push(`qualities=${filters.softwareQualities.join(",")}`);
   if (filters.impactSeverities?.length)
     parts.push(`impactSeverities=${filters.impactSeverities.join(",")}`);
+  if (filters.issueKeys?.length)
+    parts.push(`issues=${filters.issueKeys.join(",")}`);
   if (filters.pathScope) parts.push(`in:${filters.pathScope}`);
   return parts.join(" • ");
 }
@@ -302,7 +335,7 @@ export function resolvePathScope(
   const absPath = resolve(baseDir, raw);
   const relPath = relative(baseDir, absPath);
   if (relPath === "" || relPath === ".") return projectKey;
-  const cleanRel = relPath.replace(/[\\/]+$/, "");
+  const cleanRel = trimTrailing(relPath, "/\\");
   return `${projectKey}:${cleanRel}`;
 }
 
@@ -508,7 +541,7 @@ function buildIssueSearchUrl(
 ): string {
   const url = new URL("/api/issues/search", serverUrl);
   url.searchParams.set("projects", projectKey);
-  url.searchParams.set("resolved", "false");
+  if (!filters?.issueKeys?.length) url.searchParams.set("resolved", "false");
   url.searchParams.set("ps", "100");
   url.searchParams.set("p", String(page));
   if (filters?.severities?.length)
@@ -529,6 +562,8 @@ function buildIssueSearchUrl(
       "impactSeverities",
       filters.impactSeverities.join(","),
     );
+  if (filters?.issueKeys?.length)
+    url.searchParams.set("issues", filters.issueKeys.join(","));
   if (filters?.componentKeys?.length)
     url.searchParams.set("componentKeys", filters.componentKeys.join(","));
   return url.toString();

package/src/commands.ts

@@ -157,7 +157,8 @@ function createFilterCompletionList(mode?: CleanCodeMode): AutocompleteItem[] {
     {
       value: "in:",
       label: "in:",
-      description: "path or dir scope (e.g. in:src/api.ts or in:src/)",
+      description:
+        "file or directory inside the selected project (e.g. in:src/api.ts or in:src/)",
     },
   ];
 
@@ -372,19 +373,10 @@ function getInPathCompletions(
 }
 
 function getOpenCompletions(
-  issues: SonarIssue[] | undefined,
   mode: CleanCodeMode | undefined,
   current: string,
 ): AutocompleteItem[] | null {
-  const issueItems = (issues ?? []).slice(0, 10).map((issue, index) => {
-    const lineSuffix = issue.line ? `:${issue.line}` : "";
-    return {
-      value: String(index + 1),
-      label: String(index + 1),
-      description: `${issue.severity} ${issue.filePath}${lineSuffix}`,
-    };
-  });
-  const suggestions = [...issueItems, ...createFilterCompletionList(mode)];
+  const suggestions = createFilterCompletionList(mode);
   const filtered = filterAutocompleteItems(suggestions, current);
   return filtered.length > 0 ? filtered : null;
 }
@@ -494,7 +486,7 @@ export async function sonarArgumentCompletions(
   }
 
   if (lowerCommand === "open") {
-    return getOpenCompletions(issues, mode, current);
+    return getOpenCompletions(mode, current);
   }
 
   if (lowerCommand === "analyze") {
@@ -547,6 +539,7 @@ export type ParsedSonarCommand =
       action: "open";
       targetInput?: string;
       issueIndex?: number;
+      issueKeys?: string[];
       filters?: SonarIssueFetchOptions;
     }
   | { action: "metrics"; targetInput?: string }
@@ -575,7 +568,10 @@ export function parseCommandArgs(args: string): ParsedSonarCommand {
     return { action: "issues", ...parseSonarIssueArgs(tokens.slice(1)) };
   }
   if (head === "open") {
-    return { action: "open", ...parseSonarIssueArgs(tokens.slice(1), true) };
+    return {
+      action: "open",
+      ...parseSonarIssueArgs(tokens.slice(1), true, true),
+    };
   }
   if (head === "analyze" || head === "run") {
     return { action: "analyze", ...parseSonarIssueArgs(tokens.slice(1)) };
@@ -600,9 +596,10 @@ export function helpText(): string {
     "SonarQube commands:",
     "",
     "  /sonarqube init [alias] [path]   configure a project target",
-    "  /sonarqube analyze [target]      run analysis for a target or path",
-    "  /sonarqube issues [target]       browse issues for a target or path",
-    "  /sonarqube open [target] <n>     preview issue #n for a target or path",
+    "  /sonarqube analyze [target]      run analysis for a project target",
+    "  /sonarqube issues [target]       browse issues for a project target",
+    "  /sonarqube open [target] <n>     preview positional issue #n",
+    "  /sonarqube open [target] issue:<key>[,<key>] preview stable issue keys",
     "  /sonarqube metrics [target]      show project metrics (no scanner)",
     "  /sonarqube duplications [target] browse duplicated files and blocks",
     "  /sonarqube                       show this help",
@@ -620,6 +617,8 @@ export function helpText(): string {
     "  type /sonarqube and press Tab to complete the subcommand or filters",
     "",
     "Notes:",
+    "  [target] is a configured alias or SonarQube project root.",
+    "  Use in:<path> for a file or directory relative to that project root.",
     "  Legacy filters (severity, type) and MQR filters (quality, impactSeverity)",
     "  cannot be combined in the same command. Use one filter family per query.",
     "",
@@ -638,16 +637,33 @@ export function sonarErrorMessage(error: unknown): string {
   return error instanceof Error ? error.message : String(error);
 }
 
+export function assertIssueSelection(
+  issueIndex?: number,
+  issueKeys?: string[],
+): void {
+  if (issueIndex !== undefined && issueKeys?.length) {
+    throw new Error("Use either issueIndex or issueKeys, not both.");
+  }
+  if (issueKeys && issueKeys.length > 10) {
+    throw new Error("At most 10 issue keys can be opened at once.");
+  }
+}
+
 // ── Issue formatting ────────────────────────────────────────────────────────
 
-export function formatIssue(issue: SonarIssue, index?: number): string {
+export function formatIssue(
+  issue: SonarIssue,
+  index?: number,
+  includeKey = true,
+): string {
   const loc = issue.line ? `${issue.filePath}:${issue.line}` : issue.filePath;
   const prefix =
     typeof index === "number" ? `${String(index).padStart(2, "0")}. ` : "";
   const rule = issue.ruleName
     ? `${issue.rule} (${issue.ruleName})`
     : issue.rule;
-  return `${prefix}${issue.severity} ${loc} — ${rule} — ${issue.message}`;
+  const key = includeKey ? `[${issue.key}] ` : "";
+  return `${prefix}${key}${issue.severity} ${loc} — ${rule} — ${issue.message}`;
 }
 
 export function formatMetricsOutput(metrics: {

package/src/config.ts

@@ -11,13 +11,28 @@ import type {
 
 // ── Generic helpers ─────────────────────────────────────────────────────────
 
+/** Remove trailing characters in `chars` from `value`. */
+export function trimTrailing(value: string, chars: string): string {
+  let end = value.length;
+  while (end > 0 && chars.includes(value[end - 1])) end--;
+  return value.slice(0, end);
+}
+
+/** Remove leading and trailing characters in `chars` from `value`. */
+export function trimChars(value: string, chars: string): string {
+  let start = 0;
+  let end = value.length;
+  while (start < end && chars.includes(value[start])) start++;
+  while (end > start && chars.includes(value[end - 1])) end--;
+  return value.slice(start, end);
+}
+
 export function slugify(input: string): string {
   return (
-    input
-      .toLowerCase()
-      .replace(/[^a-z0-9]+/g, "-")
-      .replace(/^-+|-+$/g, "")
-      .slice(0, 80) || "sonarqube"
+    trimChars(input.toLowerCase().replace(/[^a-z0-9]+/g, "-"), "-").slice(
+      0,
+      80,
+    ) || "sonarqube"
   );
 }
 
@@ -43,7 +58,7 @@ export function parseProperties(text: string): Record<string, string> {
 export function normalizeServerUrl(url: string | undefined): string {
   const fallback = "http://localhost:9000";
   if (!url?.trim()) return fallback;
-  return url.trim().replace(/\/+$/, "");
+  return trimTrailing(url.trim(), "/");
 }
 
 export function resolveProjectKey(
@@ -131,7 +146,17 @@ export function mergeCommaSeparatedValues(
   return [...merged].join(",");
 }
 
-const EXCLUSION_RE = /^(\s*)(sonar\.(?:sources|exclusions))\s*=\s*(.*)$/;
+function matchSonarProperty(
+  line: string,
+): { indent: string; key: string; value: string } | undefined {
+  const trimmedStart = line.trimStart();
+  const eq = trimmedStart.indexOf("=");
+  if (eq < 0) return undefined;
+  const key = trimmedStart.slice(0, eq).trimEnd();
+  if (key !== "sonar.sources" && key !== "sonar.exclusions") return undefined;
+  const indent = line.slice(0, line.length - trimmedStart.length);
+  return { indent, key, value: trimmedStart.slice(eq + 1).trim() };
+}
 
 export async function ensureDefaultSonarProjectProperties(
   baseDir: string,
@@ -149,12 +174,10 @@ export async function ensureDefaultSonarProjectProperties(
   let changed = false;
 
   const updatedLines = lines.map((line) => {
-    const match = EXCLUSION_RE.exec(line);
-    if (!match) return line;
+    const property = matchSonarProperty(line);
+    if (!property) return line;
 
-    const indent = match[1] ?? "";
-    const key = match[2];
-    const value = match[3] ?? "";
+    const { indent, key, value } = property;
 
     if (key === "sonar.sources") {
       hasSources = true;
@@ -188,7 +211,7 @@ export async function ensureDefaultSonarProjectProperties(
     return "unchanged";
   }
 
-  const normalized = updatedLines.join("\n").replace(/\n*$/, "\n");
+  const normalized = trimTrailing(updatedLines.join("\n"), "\n") + "\n";
   await writeFile(path, normalized, "utf8");
   return existing.includes("sonar.sources") ||
     existing.includes("sonar.exclusions")