@jonathan0823/pi-sonarqube 0.4.0 → 0.6.0

package/src/types.ts

@@ -41,6 +41,7 @@ export interface FileDuplication {
   filePath: string;
   fileKey: string;
   duplicatedLines: number;
+  duplicatedLinesDensity: number;
   duplicatedBlocks: number;
 }
 
@@ -85,6 +86,8 @@ export interface SonarIssueFetchOptions {
   rules?: string[];
   softwareQualities?: string[];
   impactSeverities?: string[];
+  pathScope?: string;
+  componentKeys?: string[];
 }
 
 export interface SonarInitConfig {
@@ -119,8 +122,30 @@ export interface InitCommandOptions {
 
 // ── Constants shared by adapter and extension ───────────────────────────────
 
-export const SONAR_SEVERITIES = ["BLOCKER", "CRITICAL", "MAJOR", "MINOR", "INFO"] as const;
-export const SONAR_STATUSES = ["OPEN", "CONFIRMED", "REOPENED", "RESOLVED", "CLOSED"] as const;
+export const SONAR_SEVERITIES = [
+  "BLOCKER",
+  "CRITICAL",
+  "MAJOR",
+  "MINOR",
+  "INFO",
+] as const;
+export const SONAR_STATUSES = [
+  "OPEN",
+  "CONFIRMED",
+  "REOPENED",
+  "RESOLVED",
+  "CLOSED",
+] as const;
 export const SONAR_TYPES = ["BUG", "VULNERABILITY", "CODE_SMELL"] as const;
-export const SONAR_SOFTWARE_QUALITIES = ["MAINTAINABILITY", "RELIABILITY", "SECURITY"] as const;
-export const SONAR_IMPACT_SEVERITIES = ["BLOCKER", "HIGH", "MEDIUM", "LOW", "INFO"] as const;
+export const SONAR_SOFTWARE_QUALITIES = [
+  "MAINTAINABILITY",
+  "RELIABILITY",
+  "SECURITY",
+] as const;
+export const SONAR_IMPACT_SEVERITIES = [
+  "BLOCKER",
+  "HIGH",
+  "MEDIUM",
+  "LOW",
+  "INFO",
+] as const;

package/src/ui.ts

@@ -1,14 +1,34 @@
-import type { Theme, ExtensionContext, ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
-import { Key, matchesKey, truncateToWidth } from "@earendil-works/pi-tui";
+import type {
+  Theme,
+  ExtensionContext,
+  ExtensionCommandContext,
+} from "@earendil-works/pi-coding-agent";
+import { Input, Key, matchesKey, truncateToWidth, type Focusable } from "@earendil-works/pi-tui";
 import { readFile } from "node:fs/promises";
 import { resolve } from "node:path";
-import type { SonarIssue, SonarAnalysisState, SonarIssueFetchOptions, FileDuplication, DuplicationBlockGroup } from "./types.js";
-import { issueFilterLabel, fetchIssues, createAnalysisState, normalizeIssueFilters, fetchCleanCodeMode } from "./api.js";
+import type {
+  SonarIssue,
+  SonarAnalysisState,
+  SonarIssueFetchOptions,
+  FileDuplication,
+  DuplicationBlockGroup,
+} from "./types.js";
+import {
+  issueFilterLabel,
+  fetchIssues,
+  createAnalysisState,
+  normalizeIssueFilters,
+  fetchCleanCodeMode,
+} from "./api.js";
 import { resolveConfig, resolveTarget } from "./config.js";
 
 // ── Issue preview ───────────────────────────────────────────────────────────
 
-export async function buildIssuePreview(baseDir: string, issue: SonarIssue, radius = 3): Promise<string> {
+export async function buildIssuePreview(
+  baseDir: string,
+  issue: SonarIssue,
+  radius = 3,
+): Promise<string> {
   const filePath = resolve(baseDir, issue.filePath);
   const content = await readFile(filePath, "utf8");
   const lines = content.split(/\r?\n/);
@@ -40,7 +60,11 @@ export async function buildDuplicationPreview(
     cache.set(absolutePath, content);
     return content.split(/\r?\n/);
   };
-  const renderRange = (lines: string[], from: number, size: number): string[] => {
+  const renderRange = (
+    lines: string[],
+    from: number,
+    size: number,
+  ): string[] => {
     const start = Math.max(1, from);
     const end = Math.min(lines.length, from + size - 1);
     const width = String(end).length;
@@ -76,7 +100,18 @@ export async function buildDuplicationPreview(
 
 // ── Analysis UI ─────────────────────────────────────────────────────────────
 
-const ANALYSIS_SPINNER = ["⠋", "⠙", "⠹", "⠸", "⠼", "⠴", "⠦", "⠧", "⠇", "⠏"] as const;
+const ANALYSIS_SPINNER = [
+  "⠋",
+  "⠙",
+  "⠹",
+  "⠸",
+  "⠼",
+  "⠴",
+  "⠦",
+  "⠧",
+  "⠇",
+  "⠏",
+] as const;
 const ANALYSIS_WIDGET_KEY = "sonarqube-analysis";
 
 export interface AnalysisUiHandle {
@@ -84,16 +119,25 @@ export interface AnalysisUiHandle {
   stop(): void;
 }
 
-export function startAnalysisUi(ctx: ExtensionContext, projectKey: string): AnalysisUiHandle {
+export function startAnalysisUi(
+  ctx: ExtensionContext,
+  projectKey: string,
+): AnalysisUiHandle {
   let frameIndex = 0;
   let phase = "Starting...";
   const render = () => {
     const frame = ANALYSIS_SPINNER[frameIndex];
-    ctx.ui.setWidget(ANALYSIS_WIDGET_KEY, [`${frame} SonarQube ${projectKey}`, phase]);
+    ctx.ui.setWidget(ANALYSIS_WIDGET_KEY, [
+      `${frame} SonarQube ${projectKey}`,
+      phase,
+    ]);
   };
 
   ctx.ui.setWorkingMessage(`Analyzing ${projectKey}...`);
-  ctx.ui.setWorkingIndicator({ frames: ANALYSIS_SPINNER as unknown as string[], intervalMs: 80 });
+  ctx.ui.setWorkingIndicator({
+    frames: ANALYSIS_SPINNER as unknown as string[],
+    intervalMs: 80,
+  });
   render();
 
   const timer = setInterval(() => {
@@ -115,46 +159,177 @@ export function startAnalysisUi(ctx: ExtensionContext, projectKey: string): Anal
   };
 }
 
-// ── Issue Browser UI component ──────────────────────────────────────────────
+// ── Searchable browser helpers ─────────────────────────────────────────────
+
+function normalizeSearchQuery(query: string): string[] {
+  return query
+    .trim()
+    .toLowerCase()
+    .split(/\s+/)
+    .filter(Boolean);
+}
+
+function matchesSearchQuery(haystack: string, query: string): boolean {
+  const tokens = normalizeSearchQuery(query);
+  if (tokens.length === 0) return true;
+  const text = haystack.toLowerCase();
+  return tokens.every((token) => text.includes(token));
+}
 
-export class IssueBrowser {
+function filterSearchItems<T>(
+  items: readonly T[],
+  query: string,
+  searchText: (item: T) => string,
+): T[] {
+  if (!query.trim()) return [...items];
+  return items.filter((item) => matchesSearchQuery(searchText(item), query));
+}
+
+interface SearchableBrowserConfig<T> {
+  title: string;
+  subtitle: (query: string, totalCount: number, filteredCount: number) => string;
+  searchHint: string;
+  emptyMessage: string;
+  footer: string;
+  pageSize: number;
+  searchText: (item: T) => string;
+  renderItem: (item: T, index: number, isSelected: boolean) => string;
+}
+
+class SearchableListBrowser<T> implements Focusable {
   private selected = 0;
+  private query = "";
+  private filteredItems: T[];
+  private _focused = false;
+  private readonly searchInput = new Input();
 
   constructor(
-    private readonly state: SonarAnalysisState,
+    private readonly items: readonly T[],
     private readonly theme: Theme,
     private readonly done: (result: number | null) => void,
-  ) {}
+    private readonly config: SearchableBrowserConfig<T>,
+  ) {
+    this.filteredItems = [...items];
+  }
 
-  invalidate(): void {} // NOSONAR - required by TUI interface
+  get focused(): boolean {
+    return this._focused;
+  }
+
+  set focused(value: boolean) {
+    this._focused = value;
+    this.searchInput.focused = value;
+  }
+
+  invalidate(): void {
+    this.searchInput.invalidate();
+  }
 
   handleInput(data: string): void {
-    this.selected = handleListBrowserInput(data, this.selected, this.state.issues.length, this.done);
+    if (matchesKey(data, Key.escape) || matchesKey(data, "ctrl+c")) {
+      this.done(null);
+      return;
+    }
+
+    if (matchesKey(data, Key.up)) {
+      this.selected = Math.max(0, this.selected - 1);
+      return;
+    }
+
+    if (matchesKey(data, Key.down)) {
+      this.selected = Math.min(
+        Math.max(0, this.filteredItems.length - 1),
+        this.selected + 1,
+      );
+      return;
+    }
+
+    if (matchesKey(data, Key.enter)) {
+      if (this.filteredItems.length > 0) this.done(this.selected);
+      return;
+    }
+
+    this.searchInput.handleInput(data);
+    this.syncFilter();
   }
 
   render(width: number): string[] {
-    const filterSuffix = this.state.filters ? ` • ${issueFilterLabel(this.state.filters)}` : "";
-    return renderListBrowser(this.theme, width, {
+    const subtitle = this.config.subtitle(
+      this.query,
+      this.items.length,
+      this.filteredItems.length,
+    );
+    return [
+      truncateToWidth(this.theme.fg("dim", this.config.searchHint), width),
+      ...this.searchInput.render(width),
+      "",
+      ...renderListBrowser(this.theme, width, {
+        title: this.config.title,
+        subtitle,
+        items: this.filteredItems,
+        selected: this.selected,
+        pageSize: this.config.pageSize,
+        emptyMessage: this.config.emptyMessage,
+        footer: this.config.footer,
+        renderItem: this.config.renderItem,
+      }),
+    ];
+  }
+
+  private syncFilter(): void {
+    const nextQuery = this.searchInput.getValue();
+    if (nextQuery === this.query) return;
+    this.query = nextQuery;
+    this.filteredItems = filterSearchItems(
+      this.items,
+      nextQuery,
+      this.config.searchText,
+    );
+    this.selected = 0;
+  }
+}
+
+export class IssueBrowser extends SearchableListBrowser<SonarIssue> {
+  constructor(
+    state: SonarAnalysisState,
+    theme: Theme,
+    done: (result: number | null) => void,
+  ) {
+    const filterSuffix = state.filters ? ` • ${issueFilterLabel(state.filters)}` : "";
+    super(state.issues, theme, done, {
       title: "SonarQube Issues",
-      subtitle: `${this.state.projectKey} • ${this.state.totalIssues} issue(s)${filterSuffix}`,
-      items: this.state.issues,
-      selected: this.selected,
-      pageSize: 20,
-      emptyMessage: "No open issues found.",
+      subtitle: (_query, totalCount, filteredCount) =>
+        `${state.projectKey} • ${totalCount} issue(s) • ${filteredCount} match(es)${filterSuffix}`,
+      searchHint: "Search issues by file, rule, severity, status, or message",
+      emptyMessage: "No matching issues found.",
       footer: "Up/Down to move, Enter to preview, Esc to close",
+      pageSize: 20,
+      searchText: (issue) =>
+        [
+          issue.filePath,
+          issue.rule,
+          issue.ruleName ?? "",
+          issue.severity,
+          issue.status ?? "",
+          issue.message,
+        ].join(" "),
       renderItem: (issue, issueIndex, isSelected) => {
-        const marker = isSelected ? this.theme.fg("accent", ">") : this.theme.fg("dim", " ");
+        const marker = isSelected
+          ? theme.fg("accent", ">")
+          : theme.fg("dim", " ");
         const location = issue.line ? `${issue.filePath}:${issue.line}` : issue.filePath;
-        const rule = issue.ruleName ? `${issue.rule} (${issue.ruleName})` : issue.rule;
-        const severity = severityColor(this.theme, issue.severity);
+        const rule = issue.ruleName
+          ? `${issue.rule} (${issue.ruleName})`
+          : issue.rule;
+        const severity = severityColor(theme, issue.severity);
         return [
           marker,
           String(issueIndex + 1).padStart(2, " "),
           ".",
           severity,
-          this.theme.fg("accent", location),
-          this.theme.fg("muted", rule),
-          this.theme.fg("text", `— ${issue.message}`),
+          theme.fg("accent", location),
+          theme.fg("muted", rule),
+          theme.fg("text", `— ${issue.message}`),
         ].join(" ");
       },
     });
@@ -177,29 +352,11 @@ function severityColor(theme: Theme, severity: string): string {
   }
 }
 
-function handleListBrowserInput(
-  data: string,
+function getBrowserWindow(
   selected: number,
-  count: number,
-  done: (result: number | null) => void,
-): number {
-  if (matchesKey(data, Key.escape) || matchesKey(data, "ctrl+c")) {
-    done(null);
-    return selected;
-  }
-  if (matchesKey(data, Key.up)) {
-    return Math.max(0, selected - 1);
-  }
-  if (matchesKey(data, Key.down)) {
-    return Math.min(Math.max(0, count - 1), selected + 1);
-  }
-  if (matchesKey(data, Key.enter)) {
-    done(selected);
-  }
-  return selected;
-}
-
-function getBrowserWindow(selected: number, total: number, pageSize: number): { start: number; end: number } {
+  total: number,
+  pageSize: number,
+): { start: number; end: number } {
   const halfWindow = Math.floor(pageSize / 2);
   const maxStart = Math.max(0, total - pageSize);
   const start = Math.max(0, Math.min(selected - halfWindow, maxStart));
@@ -230,7 +387,11 @@ function renderListBrowser<T>(
   ];
 
   const pageSize = Math.min(config.pageSize, config.items.length);
-  const { start, end } = getBrowserWindow(config.selected, config.items.length, pageSize);
+  const { start, end } = getBrowserWindow(
+    config.selected,
+    config.items.length,
+    pageSize,
+  );
   const visible = config.items.slice(start, end);
 
   if (visible.length === 0) {
@@ -243,50 +404,61 @@ function renderListBrowser<T>(
   }
 
   if (start > 0) {
-    lines.push(truncateToWidth(theme.fg("dim", `... ${start} more above`), width));
+    lines.push(
+      truncateToWidth(theme.fg("dim", `... ${start} more above`), width),
+    );
   }
   for (const [offset, item] of visible.entries()) {
     const index = start + offset;
-    lines.push(truncateToWidth(config.renderItem(item, index, index === config.selected), width));
+    lines.push(
+      truncateToWidth(
+        config.renderItem(item, index, index === config.selected),
+        width,
+      ),
+    );
   }
   if (end < config.items.length) {
-    lines.push(truncateToWidth(theme.fg("dim", `... ${config.items.length - end} more below`), width));
+    lines.push(
+      truncateToWidth(
+        theme.fg("dim", `... ${config.items.length - end} more below`),
+        width,
+      ),
+    );
   }
 
   lines.push("", truncateToWidth(theme.fg("dim", config.footer), width));
   return lines;
 }
 
-// ── Duplication browser (used by index.ts) ─────────────────────────────────
-
-export class DuplicationBrowser {
-  private selected = 0;
-
+export class DuplicationBrowser extends SearchableListBrowser<FileDuplication> {
   constructor(
-    private readonly files: FileDuplication[],
-    private readonly theme: Theme,
-    private readonly done: (result: number | null) => void,
-  ) {}
-
-  invalidate(): void {} // NOSONAR - required by TUI interface
-
-  handleInput(data: string): void {
-    this.selected = handleListBrowserInput(data, this.selected, this.files.length, this.done);
-  }
-
-  render(width: number): string[] {
-    return renderListBrowser(this.theme, width, {
+    files: FileDuplication[],
+    theme: Theme,
+    done: (result: number | null) => void,
+    scopeLabel?: string,
+  ) {
+    const scopeSuffix = scopeLabel ? ` • ${scopeLabel}` : "";
+    super(files, theme, done, {
       title: "SonarQube Duplications",
-      subtitle: `${this.files.length} file(s) with duplicate code`,
-      items: this.files,
-      selected: this.selected,
-      pageSize: 15,
-      emptyMessage: "No duplicate code found.",
+      subtitle: (_query, totalCount, filteredCount) =>
+        `${totalCount} file(s) with duplicate code${scopeSuffix} • ${filteredCount} match(es)`,
+      searchHint: "Search duplications by file path, duplicated lines, blocks, or density",
+      emptyMessage: "No matching duplicated files found.",
       footer: "Up/Down to move, Enter for details, Esc to close",
+      pageSize: 15,
+      searchText: (file) =>
+        [
+          file.filePath,
+          `dup%=${file.duplicatedLinesDensity.toFixed(1)}`,
+          `blocks=${file.duplicatedBlocks}`,
+          `lines=${file.duplicatedLines}`,
+        ].join(" "),
       renderItem: (file, index, isSelected) => {
-        const marker = isSelected ? this.theme.fg("accent", ">") : this.theme.fg("dim", " ");
-        const detail = `blocks=${file.duplicatedBlocks}  lines=${file.duplicatedLines}`;
-        return `${marker} ${String(index + 1).padStart(2, " ")}. ${this.theme.fg("accent", file.filePath)}  ${this.theme.fg("dim", detail)}`;
+        const marker = isSelected
+          ? theme.fg("accent", ">")
+          : theme.fg("dim", " ");
+        const detail = `dup%=${file.duplicatedLinesDensity.toFixed(1)}  blocks=${file.duplicatedBlocks}  lines=${file.duplicatedLines}`;
+        return `${marker} ${String(index + 1).padStart(2, " ")}. ${theme.fg("accent", file.filePath)}  ${theme.fg("dim", detail)}`;
       },
     });
   }
@@ -295,9 +467,13 @@ export class DuplicationBrowser {
 export async function showDuplicationBrowser(
   ctx: ExtensionCommandContext,
   files: FileDuplication[],
+  scopeLabel?: string,
 ): Promise<number | null> {
   if (ctx.mode !== "tui" || files.length === 0) return null;
-  return await ctx.ui.custom<number | null>((_tui, theme, _kb, done) => new DuplicationBrowser(files, theme, done));
+  return await ctx.ui.custom<number | null>(
+    (_tui, theme, _kb, done) =>
+      new DuplicationBrowser(files, theme, done, scopeLabel),
+  );
 }
 
 // ── Issue browser / preview helpers (used by index.ts) ──────────────────────
@@ -308,7 +484,9 @@ export async function showIssueBrowser(
 ): Promise<number | null> {
   if (ctx.mode !== "tui") return null;
   if (state.issues.length === 0) return null;
-  return await ctx.ui.custom<number | null>((_tui, theme, _kb, done) => new IssueBrowser(state, theme, done));
+  return await ctx.ui.custom<number | null>(
+    (_tui, theme, _kb, done) => new IssueBrowser(state, theme, done),
+  );
 }
 
 export async function openIssuePreview(
@@ -340,9 +518,17 @@ export async function loadProjectIssuesFromApi(
     config.projectKey,
     ctx.signal,
     normalizedFilters,
+    config.baseDir,
+  );
+  const cleanCodeMode = await fetchCleanCodeMode(
+    config.serverUrl,
+    config.token,
+    ctx.signal,
   );
-  const cleanCodeMode = await fetchCleanCodeMode(config.serverUrl, config.token, ctx.signal);
-  return createAnalysisState(config, issues, { filters: normalizedFilters, cleanCodeMode });
+  return createAnalysisState(config, issues, {
+    filters: normalizedFilters,
+    cleanCodeMode,
+  });
 }
 
 export async function resolveTargetState(