@joist/observable 2.0.0-alpha.11 → 2.0.0-alpha.14

package/README.md

@@ -96,6 +96,6 @@ class TestElement extends HTMLElement {
     read: (val: string) => new Date(val),
     write: (val: Date) => val.toString()
   })
-  count: number = 0;
+  count: Date = 0;
 }
 ```

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@joist/observable",
-  "version": "2.0.0-alpha.11",
+  "version": "2.0.0-alpha.14",
   "main": "./target/build/lib.js",
   "module": "./target/build/lib.js",
   "exports": {
@@ -34,5 +34,5 @@
     "test": "tsc -p tsconfig.test.json && wtr --config ../../wtr.config.mjs --port 8002",
     "build": "tsc -p tsconfig.build.json"
   },
-  "gitHead": "3f15fe5148301888ea1b79e0877bdc5df43f7f4f"
+  "gitHead": "ee3d50d547903a8ddefbd66a700ab11df8fecfaf"
 }

package/target/build/lib/observable.js

@@ -32,16 +32,13 @@ export function observable(Base) {
             Object.defineProperties(this, descriptors);
         }
         connectedCallback() {
-            attributes.forEach((attribute) => {
-                const { read, write } = parsers[attribute];
-                const val = this.getAttribute(attribute);
-                if (val !== null) {
-                    Reflect.set(this, attribute, read(val));
-                }
-                else {
-                    const propVal = Reflect.get(this, attribute);
-                    if (propVal !== undefined && propVal !== null) {
-                        this.setAttribute(attribute, write(propVal));
+            attributes.forEach((key) => {
+                const { write } = parsers[key];
+                const attrVal = this.getAttribute(key);
+                if (attrVal === null) {
+                    const propVal = Reflect.get(this, key);
+                    if (propVal !== undefined && propVal !== null && propVal !== '') {
+                        this.setAttribute(key, write(propVal));
                     }
                 }
             });
@@ -61,7 +58,10 @@ export function observable(Base) {
                 for (let change in changes) {
                     if (attributes.includes(change)) {
                         const { write } = parsers[change];
-                        this.setAttribute(change, write(changes[change].value));
+                        const value = write(changes[change].value);
+                        if (value !== this.getAttribute(change)) {
+                            this.setAttribute(change, write(changes[change].value));
+                        }
                     }
                 }
             }