@joint/core 4.2.2 → 4.2.4

package/src/V/transform.mjs

@@ -109,6 +109,25 @@ export function matrixToTransformString(matrixInit = {}) {
     return `matrix(${a},${b},${c},${d},${e},${f})`;
 }
 
+/**
+ * @param {SVGElement} node
+ * @returns {SVGSVGElement|null}
+ * @description Returns the root SVG element for the given node,
+ * walking up through nested SVG elements.
+ * Returns `null` if the node is not part of an SVG document.
+ */
+function getRootSVG(node) {
+    let svg = node.ownerSVGElement;
+    if (!svg) {
+        // The node itself may be an <svg> element
+        return node instanceof SVGSVGElement ? node : null;
+    }
+    while (svg.ownerSVGElement) {
+        svg = svg.ownerSVGElement;
+    }
+    return svg;
+}
+
 /**
  *
  * @param {SVGElement} a
@@ -119,9 +138,12 @@ export function matrixToTransformString(matrixInit = {}) {
  * in order to calculate the correct transformation matrix.
  */
 export function getRelativeTransformation(a, b) {
-    // Different SVG elements, no transformation possible
-    // Note: SVGSVGElement has no `ownerSVGElement`
-    if ((a.ownerSVGElement || a) !== (b.ownerSVGElement || b)) return null;
+    // Elements must be part of an SVG document
+    const rootA = getRootSVG(a);
+    const rootB = getRootSVG(b);
+    if (!rootA || !rootB) return null;
+    // Different SVG documents, no transformation possible
+    if (rootA !== rootB) return null;
     // Get the transformation matrix from `a` to `b`.
     const am = b.getScreenCTM();
     if (!am) return null;

package/src/cellTools/Button.mjs

@@ -33,7 +33,9 @@ export const Button = ToolView.extend({
     },
     getElementMatrix() {
         const { relatedView: view } = this;
-        let { x = 0, y = 0, offset = {}, useModelGeometry, rotate, scale, relative } = getToolOptions(this);
+        const toolOptions = getToolOptions(this);
+        let { x = 0, y = 0 } = toolOptions;
+        const { useModelGeometry, offset = {}, rotate, scale, relative } = toolOptions;
         let bbox = getViewBBox(view, { useModelGeometry, relative });
         const angle = view.model.angle();
         if (!rotate) bbox = bbox.bbox(angle);

package/src/cellTools/Control.mjs

@@ -76,7 +76,7 @@ export const Control = ToolView.extend({
         const { options: { handleAttributes }} = this;
         handleNode.setAttribute('transform', this.getHandleTransformString());
         if (handleAttributes) {
-            for (let attrName in handleAttributes) {
+            for (const attrName in handleAttributes) {
                 handleNode.setAttribute(attrName, handleAttributes[attrName]);
             }
         }

package/src/connectionPoints/index.mjs

@@ -71,7 +71,7 @@ function alignLine(line, type, offset = 0) {
 // Connection Points
 
 function anchorConnectionPoint(line, _view, _magnet, opt) {
-    let { offset, alignOffset, align } = opt;
+    const { offset, alignOffset, align } = opt;
     if (align) alignLine(line, align, alignOffset);
     return offsetPoint(line.end, line.start, offset);
 }

package/src/connectors/curve.mjs

@@ -490,17 +490,15 @@ function createCatmullRomCurves(points, sourceTangent, targetTangent, options) {
         const vAngle = angleBetweenVectors(v1, v2);
 
         let rot = (Math.PI - vAngle) / 2;
-        let t;
         const vectorDeterminant = determinant(v1, v2);
-        let pointsDeterminant;
-        pointsDeterminant = determinant(points[i].difference(points[i + 1]), points[i].difference(points[i - 1]));
+        const pointsDeterminant = determinant(points[i].difference(points[i + 1]), points[i].difference(points[i - 1]));
         if (vectorDeterminant < 0) {
             rot = -rot;
         }
         if ((vAngle < Math.PI / 2) && ((rot < 0 && pointsDeterminant < 0) || (rot > 0 && pointsDeterminant > 0))) {
             rot = rot - Math.PI;
         }
-        t = v2.clone();
+        const t = v2.clone();
         rotateVector(t, rot);
 
         const t1 = t.clone();

package/src/dia/Cell.mjs

@@ -100,7 +100,7 @@ export const Cell = Model.extend({
         }
 
         let defaultAttributes = {};
-        let attributes = cloneDeep(this.attributes);
+        const attributes = cloneDeep(this.attributes);
 
         if (ignoreDefaults === true) {
             // Compare all attributes with the defaults
@@ -747,9 +747,8 @@ export const Cell = Model.extend({
         }.bind(this);
 
         const { _scheduledTransitionIds } = this;
-        let initialId;
 
-        var initiator = (callback) => {
+        const initiator = (callback) => {
 
             if (_scheduledTransitionIds[transitionKey]) {
                 _scheduledTransitionIds[transitionKey] = without(_scheduledTransitionIds[transitionKey], initialId);
@@ -768,7 +767,7 @@ export const Cell = Model.extend({
 
         };
 
-        initialId = setTimeout(initiator, opt.delay, setter);
+        const initialId = setTimeout(initiator, opt.delay, setter);
 
         _scheduledTransitionIds[transitionKey] || (_scheduledTransitionIds[transitionKey] = []);
         _scheduledTransitionIds[transitionKey].push(initialId);
@@ -975,11 +974,11 @@ export const Cell = Model.extend({
 
         var Cell = this.extend(protoProps, staticProps);
         // es5 backward compatibility
-        /* eslint-disable no-undef */
+        // eslint-disable-next-line no-undef
         if (typeof joint !== 'undefined' && has(joint, 'shapes')) {
+            // eslint-disable-next-line no-undef
             setByPath(joint.shapes, type, Cell, '.');
         }
-        /* eslint-enable no-undef */
         return Cell;
     }
 });

package/src/dia/Graph.mjs

@@ -147,7 +147,7 @@ export const Graph = Model.extend({
 
         } while (sortedCells.length > 0);
 
-        this.stopBatch('clear');
+        this.stopBatch('clear', opt);
 
         return this;
     },
@@ -329,7 +329,7 @@ export const Graph = Model.extend({
     removeCells: function(cellRefs, options) {
         if (!cellRefs.length) return this;
         // Remove multiple cells in a single batch
-        this.startBatch('remove');
+        this.startBatch('remove', options);
         for (const cellRef of cellRefs) {
             if (!cellRef) continue;
             let cell;
@@ -344,7 +344,7 @@ export const Graph = Model.extend({
             }
             this.layerCollection.removeCell(cell, options);
         }
-        this.stopBatch('remove');
+        this.stopBatch('remove', options);
         return this;
     },
 
@@ -376,7 +376,7 @@ export const Graph = Model.extend({
 
         // 3. Add the replacement cell
         this.addCell(replacement, replaceOptions);
-        this.stopBatch(batchName);
+        this.stopBatch(batchName, opt);
     },
 
     /**
@@ -472,7 +472,7 @@ export const Graph = Model.extend({
             }
         }
 
-        this.stopBatch(batchName);
+        this.stopBatch(batchName, opt);
     },
 
     /**
@@ -499,27 +499,27 @@ export const Graph = Model.extend({
             throw new Error('dia.Graph: cell to remove does not exist in the graph.');
         }
         if (cell.graph !== this) return;
-        this.startBatch('remove');
+        this.startBatch('remove', options);
         cell.collection.remove(cell, options);
-        this.stopBatch('remove');
+        this.stopBatch('remove', options);
     },
 
     transferCellEmbeds: function(sourceCell, targetCell, opt = {}) {
 
         const batchName = 'transfer-embeds';
-        this.startBatch(batchName);
+        this.startBatch(batchName, opt);
 
         // Embed children of the source cell in the target cell.
         const children = sourceCell.getEmbeddedCells();
         targetCell.embed(children, { ...opt, reparent: true });
 
-        this.stopBatch(batchName);
+        this.stopBatch(batchName, opt);
     },
 
     transferCellConnectedLinks: function(sourceCell, targetCell, opt = {}) {
 
         const batchName = 'transfer-connected-links';
-        this.startBatch(batchName);
+        this.startBatch(batchName, opt);
 
         // Reconnect all the links connected to the old cell to the new cell.
         const connectedLinks = this.getConnectedLinks(sourceCell, opt);
@@ -534,7 +534,7 @@ export const Graph = Model.extend({
             }
         });
 
-        this.stopBatch(batchName);
+        this.stopBatch(batchName, opt);
     },
 
     /**
@@ -542,8 +542,8 @@ export const Graph = Model.extend({
      * Helper method for addLayer and moveLayer methods
      */
     _getBeforeLayerIdFromOptions(options, layer = null) {
-        let { before = null, index } = options;
-
+        let { index } = options;
+        const { before = null } = options;
         if (before && index !== undefined) {
             throw new Error('dia.Graph: Options "before" and "index" are mutually exclusive.');
         }

package/src/dia/GraphLayerCollection.mjs

@@ -28,9 +28,8 @@ export const GraphLayerCollection = Collection.extend({
         if (cellNamespace) {
             this.cellNamespace = cellNamespace;
         } else {
-            /* eslint-disable no-undef */
-            this.cellNamespace = typeof joint !== 'undefined' && util.has(joint, 'shapes') ? joint.shapes : null;
-            /* eslint-enable no-undef */
+            // eslint-disable-next-line no-undef
+            this.cellNamespace = (((typeof joint !== 'undefined') && util.has(joint, 'shapes')) ? joint.shapes : null);
         }
 
         this.graph = graph;

package/src/dia/HighlighterView.mjs

@@ -244,7 +244,7 @@ export const HighlighterView = mvc.View.extend({
             // all highlighters
             const views = [];
             if (!refs) return views;
-            for (let hid in refs) {
+            for (const hid in refs) {
                 const ref = refs[hid];
                 if (ref instanceof this) {
                     views.push(ref);
@@ -271,7 +271,7 @@ export const HighlighterView = mvc.View.extend({
         if (!refs) return false;
         if (id === null) {
             // any highlighter
-            for (let hid in refs) {
+            for (const hid in refs) {
                 if (refs[hid] instanceof this) return true;
             }
             return false;
@@ -311,7 +311,7 @@ export const HighlighterView = mvc.View.extend({
         const refs = _views[cid];
         if (!refs) return;
         if (id) delete refs[id];
-        for (let _ in refs) return;
+        for (const _ in refs) return;
         delete _views[cid];
     },
 
@@ -324,8 +324,8 @@ export const HighlighterView = mvc.View.extend({
     getAll(paper, id = null) {
         const views = [];
         const { _views } = this;
-        for (let cid in _views) {
-            for (let hid in _views[cid]) {
+        for (const cid in _views) {
+            for (const hid in _views[cid]) {
                 const view = _views[cid][hid];
                 if (view.cellView.paper === paper && view instanceof this && (id === null || hid === id)) {
                     views.push(view);

package/src/dia/LayerView.mjs

@@ -99,7 +99,7 @@ export const LayerView = View.extend({
 
     removePivots: function() {
         const { el, pivotNodes } = this;
-        for (let z in pivotNodes) el.removeChild(pivotNodes[z]);
+        for (const z in pivotNodes) el.removeChild(pivotNodes[z]);
         this.pivotNodes = {};
     },
 

package/src/dia/LinkView.mjs

@@ -933,7 +933,7 @@ export const LinkView = CellView.extend({
         const { metrics, _labelSelectors } = this;
         const selectors = _labelSelectors[index];
         if (!selectors) return;
-        for (let selector in selectors) {
+        for (const selector in selectors) {
             const { id } = selectors[selector];
             if (id && (id in metrics)) delete metrics[id].magnetMatrix;
         }

package/src/dia/Paper.mjs

@@ -637,9 +637,8 @@ export const Paper = View.extend({
 
         const { options } = this;
         if (!options.cellViewNamespace) {
-            /* eslint-disable no-undef */
-            options.cellViewNamespace = typeof joint !== 'undefined' && has(joint, 'shapes') ? joint.shapes : null;
-            /* eslint-enable no-undef */
+            // eslint-disable-next-line no-undef
+            options.cellViewNamespace = (((typeof joint !== 'undefined') && has(joint, 'shapes')) ? joint.shapes : null);
         }
 
         const defaultLayerViewNamespace = {
@@ -720,6 +719,9 @@ export const Paper = View.extend({
         var position = opt.position;
         if (this.isAsync() || !isNumber(position)) {
             this.renderView(cell, opt);
+            // Wake up the paper in case it was idle
+            // When using initializeUnmounted: true the paper won't wake up by itself
+            this.wakeUp();
         } else {
             if (opt.maxPosition === position) this.freeze({ key: 'addCells' });
             this.renderView(cell, opt);
@@ -867,11 +869,11 @@ export const Paper = View.extend({
         } = options;
 
         // Default cellView namespace for ES5
-        /* eslint-disable no-undef */
-        if (!cellViewNamespace && typeof joint !== 'undefined' && has(joint, 'shapes')) {
+        // eslint-disable-next-line no-undef
+        if (!cellViewNamespace && (typeof joint !== 'undefined') && has(joint, 'shapes')) {
+            // eslint-disable-next-line no-undef
             options.cellViewNamespace = joint.shapes;
         }
-        /* eslint-enable no-undef */
 
         // Here if a function was provided, we can not clone it, as this would result in loosing the function.
         // If the default is used, the cloning is necessary in order to prevent modifying the options on prototype.
@@ -1108,7 +1110,8 @@ export const Paper = View.extend({
      * Helper method for addLayerView and moveLayerView methods
      */
     _getBeforeLayerViewFromOptions(layerView, options) {
-        let { before = null, index } = options;
+        const { before = null } = options;
+        let { index } = options;
 
         if (before && index !== undefined) {
             throw new Error('dia.Paper: Options "before" and "index" are mutually exclusive.');
@@ -1568,7 +1571,7 @@ export const Paper = View.extend({
                 delete prevPriorityUpdates[cid];
             }
         }
-        let currentType = priorityUpdates[cid] || 0;
+        const currentType = priorityUpdates[cid] || 0;
         // Prevent cycling
         if ((currentType & type) === type) return;
         if (!currentType) updates.count++;
@@ -1710,7 +1713,7 @@ export const Paper = View.extend({
         let i = priorityIndexes.length;
         while (i > 0 && i--) {
             // a faster way how to check if an object is empty
-            for (let _key in priorities[priorityIndexes[i]]) return true;
+            for (const _key in priorities[priorityIndexes[i]]) return true;
         }
         return false;
     },
@@ -2030,8 +2033,12 @@ export const Paper = View.extend({
         var updates = this._updates;
         var unmountedList = updates.unmountedList;
         for (var i = 0, n = Math.min(unmountedList.length, batchSize); i < n; i++) {
+            // stop if there are no more unmounted views
+            // this can happen when another view was mounted in the onViewUpdate() callback
+            if (unmountedList.length === 0) break;
+
             const { key: cid } = unmountedList.peekHead();
-            let view = viewsRegistry[cid] || this._viewPlaceholders[cid];
+            const view = viewsRegistry[cid] || this._viewPlaceholders[cid];
             if (!view) {
                 // This should not occur
                 // Prevent looping over this invalid cid
@@ -2267,8 +2274,8 @@ export const Paper = View.extend({
     setDimensions: function(width, height, data = {}) {
         const { options } = this;
         const { width: currentWidth, height: currentHeight } = options;
-        let w = (width === undefined) ? currentWidth : width;
-        let h = (height === undefined) ? currentHeight : height;
+        const w = (width === undefined) ? currentWidth : width;
+        const h = (height === undefined) ? currentHeight : height;
         if (currentWidth === w && currentHeight === h) return;
         options.width = w;
         options.height = h;
@@ -3243,7 +3250,8 @@ export const Paper = View.extend({
 
     resolveHighlighter: function(opt = {}) {
 
-        let { highlighter: highlighterDef, type } = opt;
+        let { highlighter: highlighterDef } = opt;
+        const { type } = opt;
         const { highlighting,highlighterNamespace  } = this.options;
 
         /*
@@ -3499,7 +3507,8 @@ export const Paper = View.extend({
         if (view) {
             // The view could have been disposed during dragging
             // e.g. dragged outside of the viewport and hidden
-            view = this.findViewByModel(view.model);
+            // The model can be removed in previous mousemove event handlers
+            view = this.findViewByModel(view.model) || view;
             view.pointermove(evt, localPoint.x, localPoint.y);
         } else {
             this.trigger('blank:pointermove', evt, localPoint.x, localPoint.y);
@@ -3520,7 +3529,8 @@ export const Paper = View.extend({
         if (view) {
             // The view could have been disposed during dragging
             // e.g. dragged outside of the viewport and hidden
-            view = this.findViewByModel(view.model);
+            // The model can be removed in previous mouseup event handlers (e.g. when deleting an element after dragging)
+            view = this.findViewByModel(view.model) || view;
             view.pointerup(normalizedEvt, localPoint.x, localPoint.y);
         } else {
             this.trigger('blank:pointerup', normalizedEvt, localPoint.x, localPoint.y);

package/src/dia/attributes/eval.mjs

@@ -45,7 +45,7 @@ const positiveValueAttributes = positiveValueList.reduce((acc, attrName) => {
 
 export function evalAttributes(attrs, refBBox) {
     const evalAttrs = {};
-    for (let attrName in attrs) {
+    for (const attrName in attrs) {
         if (!attrs.hasOwnProperty(attrName)) continue;
         evalAttrs[attrName] = evalAttribute(attrName, attrs[attrName], refBBox);
     }

package/src/dia/ports.mjs

@@ -98,7 +98,7 @@ PortData.prototype = {
             groupPortTransformations = this._getGroupPortTransformations(group, portsArgs, elBBox);
         }
 
-        let accumulator = {
+        const accumulator = {
             ports: ports,
             result: {}
         };
@@ -264,7 +264,7 @@ PortData.prototype = {
         evaluated.position = this._evaluatePortPositionProperty(group, evaluated);
         evaluated.label = this._evaluatePortLabelProperty(group, evaluated);
         evaluated.z = this._evaluatePortZProperty(group, evaluated);
-        evaluated.size = util.assign({}, group.size, evaluated.size);
+        evaluated.size = util.assign({ width: 0, height: 0 }, group.size, evaluated.size);
         return evaluated;
     },
 

package/src/elementTools/HoverConnect.mjs

@@ -8,11 +8,12 @@ export const HoverConnect = LinkHoverConnect.extend({
 
     getTrackPath() {
         const { relatedView: view } = this;
-        let {
+        const {
             useModelGeometry,
             relative,
-            trackPath = 'M 0 0 H calc(w) V calc(h) H 0 Z'
+            trackPath: initialTrackPath = 'M 0 0 H calc(w) V calc(h) H 0 Z'
         } = getToolOptions(this);
+        let trackPath = initialTrackPath;
         if (typeof trackPath === 'function') {
             trackPath = trackPath.call(this, view);
         }
@@ -30,7 +31,7 @@ export const HoverConnect = LinkHoverConnect.extend({
 
     getTrackMatrixAbsolute() {
         const { relatedView: view } = this;
-        let { useModelGeometry, rotate } = getToolOptions(this);
+        const { useModelGeometry, rotate } = getToolOptions(this);
         let bbox = getViewBBox(view, { useModelGeometry });
         const angle = view.model.angle();
         if (!rotate) bbox = bbox.bbox(angle);

package/src/layout/ports/port.mjs

@@ -75,7 +75,7 @@ function ellipseLayout(ports, elBBox, startAngle, stepFn) {
 }
 
 function argTransform(bbox, args) {
-    let { x, y, angle } = args;
+    const { x, y, angle } = args;
 
     return {
         x: parseCoordinate('x', 'width', bbox, x),

package/src/linkTools/RotateLabel.mjs

@@ -52,7 +52,8 @@ export const RotateLabel = Control.extend({
         const label = this.getLabel();
         const labelPosition = this.getLabelPosition(label);
         const coords = view.getLabelCoordinates(labelPosition);
-        let { angle = 0, args = {}} = labelPosition;
+        let { angle = 0 } = labelPosition;
+        const { args = {}} = labelPosition;
         const keepGradient = args.keepGradient;
         if (keepGradient) {
             const tangent = view.getTangentAtRatio(

package/src/linkTools/Segments.mjs

@@ -235,7 +235,7 @@ export const Segments = ToolView.extend({
                 const isSingleVertex = data.originalVertices.length === 1;
                 const origVIndex = isSingleVertex ? 0 : handleIndex;
                 const additionalOffset = data.firstHandleShifted && !isSingleVertex ? 1 : 0;
-                let nextVIndex = 1 + indexOffset;
+                const nextVIndex = 1 + indexOffset;
                 vertices.splice(handleIndex + nextVIndex, 0, data.originalVertices[origVIndex - additionalOffset]);
             }
         }

package/src/mvc/Dom/Dom.mjs

@@ -44,7 +44,7 @@ $.guid = 1;
 $.data = dataUser;
 
 $.merge = function(first, second) {
-    let len = +second.length;
+    const len = +second.length;
     let i = first.length;
     for (let j = 0; j < len; j++) {
         first[i++] = second[j];
@@ -227,7 +227,7 @@ $.event.on = function(elem, types, selector, data, fn, one) {
             data = data || selector;
             selector = undefined;
         }
-        for (let type in types) {
+        for (const type in types) {
             $.event.on(elem, type, selector, data, types[type], one);
         }
         return elem;

package/src/mvc/Dom/animations.mjs

@@ -23,12 +23,8 @@ export function animate(properties, opt = {}) {
 
 function animateNode(el, properties, opt = {}) {
 
-    let {
-        duration = 400,
-        easing = 'ease-in-out',
-        delay = 0,
-        complete
-    } = opt;
+    let { duration = 400, delay = 0 } = opt;
+    const { easing = 'ease-in-out', complete } = opt;
 
     const delayId = setTimeout(function() {
 

package/src/mvc/Dom/methods.mjs

@@ -158,7 +158,7 @@ export function css(name, value) {
     } else {
         styles = name;
     }
-    for (let style in styles) {
+    for (const style in styles) {
         if (styles.hasOwnProperty(style)) {
             for (let i = 0; i < this.length; i++) {
                 setCSSProperty(this[i], style, styles[style]);
@@ -274,7 +274,7 @@ export function off(types, selector, fn) {
     }
     if (typeof types === 'object') {
         // ( types-object [, selector] )
-        for (let type in types) {
+        for (const type in types) {
             this.off(type, selector, types[type]);
         }
         return this;
@@ -321,7 +321,7 @@ export function height() {
 export function position() {
     const [el] = this;
     if (!el) return;
-    let $el = $(el);
+    const $el = $(el);
     let offsetParent;
     let offset;
     let doc;

package/src/mvc/Dom/props.mjs

@@ -44,7 +44,7 @@ function attr(name, value) {
     } else {
         attributes = name;
     }
-    for (let attr in attributes) {
+    for (const attr in attributes) {
         if (attributes.hasOwnProperty(attr)) {
             const value = attributes[attr];
             if (propertiesMap[attr]) {

package/src/mvc/Listener.mjs

@@ -19,6 +19,7 @@ export class Listener {
         }
         // signature 2 - (object, event, callback, context)
         else if (typeof evt === 'string' && typeof args[0] === 'function') {
+            // eslint-disable-next-line prefer-const
             let [cb, context = null] = args;
             // Invoke the callback with callbackArguments passed first
             if (context || callbackArguments.length > 0) cb = cb.bind(context, ...callbackArguments);

package/src/mvc/Model.mjs

@@ -132,7 +132,9 @@ assign(Model.prototype, Events, {
         if (this.idAttribute in attrs) {
             var prevId = this.id;
             this.id = this.get(this.idAttribute);
-            this.trigger(this.eventPrefix + 'changeId', this, prevId, options);
+            if (this.id !== prevId) {
+                this.trigger(this.eventPrefix + 'changeId', this, prevId, options);
+            }
         }
 
         // Trigger all relevant attribute changes.

package/src/routers/rightAngle.mjs

@@ -776,8 +776,8 @@ function routeBetweenPoints(source, target, opt = {}) {
         }
 
         let x;
-        let y1 = Math.min((sy1 + ty0) / 2, toy);
-        let y2 = Math.min((sy0 + ty1) / 2, soy);
+        const y1 = Math.min((sy1 + ty0) / 2, toy);
+        const y2 = Math.min((sy0 + ty1) / 2, soy);
 
         if (toy < soy) {
             // Use the shortest path along the connections on horizontal sides
@@ -816,8 +816,8 @@ function routeBetweenPoints(source, target, opt = {}) {
         }
 
         let x;
-        let y1 = Math.max((sy0 + ty1) / 2, toy);
-        let y2 = Math.max((sy1 + ty0) / 2, soy);
+        const y1 = Math.max((sy0 + ty1) / 2, toy);
+        const y2 = Math.max((sy1 + ty0) / 2, soy);
 
         if (toy > soy) {
             // Use the shortest path along the connections on horizontal sides
@@ -856,8 +856,8 @@ function routeBetweenPoints(source, target, opt = {}) {
         }
 
         let y;
-        let x1 = Math.min((sx1 + tx0) / 2, tox);
-        let x2 = Math.min((sx0 + tx1) / 2, sox);
+        const x1 = Math.min((sx1 + tx0) / 2, tox);
+        const x2 = Math.min((sx0 + tx1) / 2, sox);
 
         if (tox > sox) {
             if (topD <= bottomD) {
@@ -895,8 +895,8 @@ function routeBetweenPoints(source, target, opt = {}) {
         }
 
         let y;
-        let x1 = Math.max((sx0 + tx1) / 2, tox);
-        let x2 = Math.max((sx1 + tx0) / 2, sox);
+        const x1 = Math.max((sx0 + tx1) / 2, tox);
+        const x2 = Math.max((sx1 + tx0) / 2, sox);
 
         if (tox <= sox) {
             if (topD <= bottomD) {
@@ -1518,7 +1518,7 @@ function rightAngleRouter(vertices, opt, linkView) {
     const isTargetPort = !!linkView.model.target().port;
     const targetPoint = pointDataFromAnchor(linkView.targetView, linkView.targetAnchor, linkView.targetBBox, targetDirection, isTargetPort, linkView.targetAnchor, margin);
 
-    let resultVertices = [];
+    const resultVertices = [];
 
     if (!useVertices || vertices.length === 0) {
         return simplifyPoints(routeBetweenPoints(sourcePoint, targetPoint));