@joint/core 4.1.1 → 4.1.3

package/dist/vectorizer.js

@@ -1,4 +1,4 @@
-/*! JointJS v4.1.1 (2024-12-02) - JavaScript diagramming library
+/*! JointJS v4.1.3 (2025-02-04) - JavaScript diagramming library
 
 
 This Source Code Form is subject to the terms of the Mozilla Public
@@ -5721,8 +5721,8 @@ file, You can obtain one at http://mozilla.org/MPL/2.0/.
           case 'bottom':
             dy = -(0.25 * llMaxFont) - rLineHeights;
             break;
-          default:
           case 'top':
+          default:
             dy = 0.8 * flMaxFont;
             break;
         }

package/dist/vectorizer.min.js

@@ -1,4 +1,4 @@
-/*! JointJS v4.1.1 (2024-12-02) - JavaScript diagramming library
+/*! JointJS v4.1.3 (2025-02-04) - JavaScript diagramming library
 
 
 This Source Code Form is subject to the terms of the Mozilla Public

package/dist/version.mjs

@@ -1,3 +1,3 @@
-var version = "4.1.1";
+var version = "4.1.3";
 
 export { version };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@joint/core",
   "title": "JointJS",
-  "version": "4.1.1",
+  "version": "4.1.3",
   "description": "JavaScript diagramming library",
   "sideEffects": false,
   "main": "./dist/joint.min.js",

package/src/V/index.mjs

@@ -472,8 +472,8 @@ const V = (function() {
             case 'bottom':
                 dy = -(0.25 * llMaxFont) - rLineHeights;
                 break;
-            default:
             case 'top':
+            default:
                 dy = (0.8 * flMaxFont);
                 break;
         }

package/src/dia/ElementView.mjs

@@ -142,7 +142,7 @@ export const ElementView = CellView.extend({
      * @abstract
      */
     _initializePorts: function() {
-
+        // implemented in ports.js
     },
 
     update: function(_, renderingOnlyAttrs) {
@@ -804,17 +804,23 @@ export const ElementView = CellView.extend({
 
     // Drag Handlers
 
+    snapToGrid: function(evt, x, y) {
+        const grid = this.paper.options.gridSize;
+        return {
+            x: snapToGrid(x, grid),
+            y: snapToGrid(y, grid)
+        };
+    },
+
     drag: function(evt, x, y) {
 
         var paper = this.paper;
-        var grid = paper.options.gridSize;
         var element = this.model;
         var data = this.eventData(evt);
         var { pointerOffset, restrictedArea, embedding } = data;
 
         // Make sure the new element's position always snaps to the current grid
-        var elX = snapToGrid(x + pointerOffset.x, grid);
-        var elY = snapToGrid(y + pointerOffset.y, grid);
+        const { x: elX, y: elY } = this.snapToGrid(evt, x + pointerOffset.x, y + pointerOffset.y);
 
         element.position(elX, elY, { restrictedArea, deep: true, ui: true });
 

package/src/dia/HighlighterView.mjs

@@ -42,13 +42,13 @@ export const HighlighterView = mvc.View.extend({
         // The cellView is now rendered/updated since it has a higher update priority.
         this.updateRequested = false;
         const { cellView, nodeSelector } = this;
-        if (!cellView.isMounted()) {
+        if (cellView.isMounted()) {
+            this.update(cellView, nodeSelector);
+            this.mount();
+            this.transform();
+        } else {
             this.postponedUpdate = true;
-            return 0;
         }
-        this.update(cellView, nodeSelector);
-        this.mount();
-        this.transform();
         return 0;
     },
 

package/src/mvc/Collection.mjs

@@ -59,11 +59,15 @@ assign(Collection.prototype, Events, {
 
     // preinitialize is an empty function by default. You can override it with a function
     // or object.  preinitialize will run before any instantiation logic is run in the Collection.
-    preinitialize: function(){},
+    preinitialize: function(){
+        // No implementation.
+    },
 
     // Initialize is an empty function by default. Override it with your own
     // initialization logic.
-    initialize: function(){},
+    initialize: function(){
+        // No implementation.
+    },
 
     // The JSON representation of a Collection is an array of the
     // models' attributes.

package/src/mvc/Dom/Dom.mjs

@@ -109,8 +109,8 @@ $.fn.find = function(selector) {
     return ret;
 };
 
-$.fn.add = function(selector, context) {
-    const newElements = $(selector, context).toArray();
+$.fn.add = function(selector) {
+    const newElements = $(selector).toArray();
     const prevElements = this.toArray();
     const ret = this.pushStack([]);
     $.merge(ret, uniq(prevElements.concat(newElements)));

package/src/mvc/Dom/methods.mjs

@@ -65,7 +65,7 @@ export function html(html) {
     if (!el) return null;
     if (arguments.length === 0) return el.innerHTML;
     if (html === undefined) return this; // do nothing
-    cleanNodesData(dataPriv, el.getElementsByTagName('*'));
+    cleanNodesData(el.getElementsByTagName('*'));
     if (typeof html === 'string' || typeof html === 'number') {
         el.innerHTML = html;
     } else {
@@ -336,17 +336,19 @@ export function position() {
         // when a statically positioned element is identified
         doc = el.ownerDocument;
         offsetParent = el.offsetParent || doc.documentElement;
-        const $parentOffset = $(offsetParent);
-        const parentOffsetElementPosition = $parentOffset.css('position') || 'static';
-        while ( offsetParent && (offsetParent === doc.body || offsetParent === doc.documentElement) && parentOffsetElementPosition === 'static') {
-            offsetParent = offsetParent.parentNode;
+        const isStaticallyPositioned = (el) => {
+            const { position } = getComputedStyle(el);
+            return position === 'static';
+        };
+        while (offsetParent && offsetParent !== doc.documentElement && isStaticallyPositioned(offsetParent)) {
+            offsetParent = offsetParent.offsetParent || doc.documentElement;
         }
-        if (offsetParent && offsetParent !== el && offsetParent.nodeType === 1) {
+        if (offsetParent && offsetParent !== el && offsetParent.nodeType === 1 && !isStaticallyPositioned(offsetParent)) {
             // Incorporate borders into its offset, since they are outside its content origin
             const offsetParentStyles = window.getComputedStyle(offsetParent);
             const borderTopWidth = parseFloat(offsetParentStyles.borderTopWidth) || 0;
             const borderLeftWidth = parseFloat(offsetParentStyles.borderLeftWidth) || 0;
-            parentOffset = $parentOffset.offset();
+            parentOffset = $(offsetParent).offset();
             parentOffset.top += borderTopWidth;
             parentOffset.left += borderLeftWidth;
         }

package/src/mvc/Listener.mjs

@@ -1,4 +1,3 @@
-import V from '../V/index.mjs';
 import { Events } from './Events.mjs';
 
 export class Listener {
@@ -9,7 +8,7 @@ export class Listener {
     listenTo(object, evt, ...args) {
         const { callbackArguments } = this;
         // signature 1 - (object, eventHashMap, context)
-        if (V.isObject(evt)) {
+        if (evt && typeof evt === 'object') {
             const [context = null] = args;
             Object.entries(evt).forEach(([eventName, cb]) => {
                 if (typeof cb !== 'function') return;

package/src/mvc/Model.mjs

@@ -59,11 +59,15 @@ assign(Model.prototype, Events, {
 
     // preinitialize is an empty function by default. You can override it with a function
     // or object.  preinitialize will run before any instantiation logic is run in the Model.
-    preinitialize: function(){},
+    preinitialize: function(){
+        // No implementation.
+    },
 
     // Initialize is an empty function by default. Override it with your own
     // initialization logic.
-    initialize: function(){},
+    initialize: function(){
+        // No implementation.
+    },
 
     // Return a copy of the model's `attributes` object.
     toJSON: function(options) {

package/src/mvc/ViewBase.mjs

@@ -52,11 +52,15 @@ assign(ViewBase.prototype, Events, {
 
     // preinitialize is an empty function by default. You can override it with a function
     // or object.  preinitialize will run before any instantiation logic is run in the View
-    preinitialize: function(){},
+    preinitialize: function(){
+        // No implementation.
+    },
 
     // Initialize is an empty function by default. Override it with your own
     // initialization logic.
-    initialize: function(){},
+    initialize: function(){
+        // No implementation.
+    },
 
     // **render** is the core function that your view should override, in order
     // to populate its element (`this.el`), with the appropriate HTML. The

package/src/util/util.mjs

@@ -79,10 +79,10 @@ export const parseDOMJSON = function(json, namespace) {
     const groupSelectors = {};
     const svgNamespace = V.namespace.svg;
 
-    const ns = namespace || svgNamespace;
+    const initialNS = namespace || svgNamespace;
     const fragment = document.createDocumentFragment();
 
-    const parseNode = function(siblingsDef, parentNode, ns) {
+    const parseNode = function(siblingsDef, parentNode, parentNS) {
         for (let i = 0; i < siblingsDef.length; i++) {
             const nodeDef = siblingsDef[i];
 
@@ -100,7 +100,7 @@ export const parseDOMJSON = function(json, namespace) {
             let node;
 
             // Namespace URI
-            if (nodeDef.hasOwnProperty('namespaceURI')) ns = nodeDef.namespaceURI;
+            const ns = (nodeDef.hasOwnProperty('namespaceURI')) ? nodeDef.namespaceURI : parentNS;
             node = document.createElementNS(ns, tagName);
             const svg = (ns === svgNamespace);
 
@@ -152,7 +152,7 @@ export const parseDOMJSON = function(json, namespace) {
             }
         }
     };
-    parseNode(json, fragment, ns);
+    parseNode(json, fragment, initialNS);
     return {
         fragment: fragment,
         selectors: selectors,
@@ -1790,4 +1790,5 @@ export {
 };
 
 export const noop = function() {
+    // Do nothing.
 };

package/src/util/utilHelpers.mjs

@@ -389,7 +389,7 @@ const initCloneByTag = (object, tag, isDeep) => {
     const Constructor = object.constructor;
     switch(tag) {
         case arrayBufferTag:
-            return cloneArrayBuffer(object, isDeep);
+            return cloneArrayBuffer(object);
         case boolTag:
         case dateTag:
             return new Constructor(+object);
@@ -1168,7 +1168,7 @@ const baseMerge = (object, source, srcIndex, customizer, stack) => {
 
             assignMergeValue(object, key, newValue);
         }
-    }, keysIn);
+    });
 };
 
 const baseMergeDeep = (object, source, key, srcIndex, mergeFunc, customizer, stack) => {
@@ -1281,7 +1281,7 @@ function last(array) {
 
 const createSet = (Set && (1 / setToArray(new Set([undefined,-0]))[1]) == 1 / 0)
     ? (values) => new Set(values)
-    : () => {};
+    : () => { /* no-op */ };
 
 function customDefaultsMerge(objValue, srcValue, key, object, source, stack) {
     if (isObject(objValue) && isObject(srcValue)) {
@@ -2236,8 +2236,8 @@ export function debounce(func, wait, opt) {
 export const groupBy = (collection, iteratee) => {
     iteratee = getIteratee(iteratee, 2);
 
-    return reduce(collection, (result, value, key) => {
-        key = iteratee(value);
+    return reduce(collection, (result, value) => {
+        const key = iteratee(value);
         if (hasOwnProperty.call(result, key)) {
             result[key].push(value);
         } else {

package/types/joint.d.ts

@@ -1090,6 +1090,8 @@ export namespace dia {
 
         protected dragMagnetEnd(evt: dia.Event, x: number, y: number): void;
 
+        protected snapToGrid(evt: dia.Event, x: number, y: number): dia.Point;
+
         protected prepareEmbedding(data: any): void;
 
         protected processEmbedding(data: any, evt: dia.Event, x: number, y: number): void;