@joinezco/markdown-editor 0.0.3 → 0.0.5

package/src/test/extensions.test.ts

@@ -96,25 +96,18 @@ describe('MarkdownEditor Extensions', () => {
             const table = editor.view.dom.querySelector('table')
             expect(table).toBeTruthy()
 
-            const thead = table?.querySelector('thead')
-            const tbody = table?.querySelector('tbody')
-            expect(thead).toBeTruthy()
-            expect(tbody).toBeTruthy()
-
-            const headers = thead?.querySelectorAll('th')
+            // Tiptap renders header cells as <th> directly in <tr>, without <thead>/<tbody> wrappers
+            const headers = table?.querySelectorAll('th')
             expect(headers?.length).toBe(3)
             expect(headers?.[0].textContent?.trim()).toBe('Header 1')
             expect(headers?.[1].textContent?.trim()).toBe('Header 2')
             expect(headers?.[2].textContent?.trim()).toBe('Header 3')
 
-            const rows = tbody?.querySelectorAll('tr')
-            expect(rows?.length).toBe(2)
-
-            const firstRowCells = rows?.[0].querySelectorAll('td')
-            expect(firstRowCells?.length).toBe(3)
-            expect(firstRowCells?.[0].textContent?.trim()).toBe('Cell 1')
-            expect(firstRowCells?.[1].textContent?.trim()).toBe('Cell 2')
-            expect(firstRowCells?.[2].textContent?.trim()).toBe('Cell 3')
+            const dataCells = table?.querySelectorAll('td')
+            expect(dataCells?.length).toBe(6)
+            expect(dataCells?.[0].textContent?.trim()).toBe('Cell 1')
+            expect(dataCells?.[1].textContent?.trim()).toBe('Cell 2')
+            expect(dataCells?.[2].textContent?.trim()).toBe('Cell 3')
         })
 
         it('should handle table navigation', () => {
@@ -181,38 +174,33 @@ describe('MarkdownEditor Extensions', () => {
             const codeBlock = '```javascript\nfunction hello() {\n  console.log("Hello, World!");\n}\n```'
             editor.commands.setContent(codeBlock)
 
-            const preElement = editor.view.dom.querySelector('pre')
-            expect(preElement).toBeTruthy()
-
-            const codeContent = preElement?.textContent || ''
-            expect(codeContent).toContain('function hello')
-            expect(codeContent).toContain('console.log')
-            expect(codeContent).toContain('Hello, World!')
+            // Code blocks render via CodeMirror node view, not <pre>
+            const json = editor.getJSON()
+            const codeNode = json.content?.find((n: any) => n.type === 'ezcodeBlock' || n.type === 'codeBlock')
+            expect(codeNode).toBeTruthy()
+            expect(codeNode?.attrs?.language).toBe('javascript')
+            expect(codeNode?.content?.[0]?.text).toContain('function hello')
         })
 
         it('should handle different programming languages', () => {
             const pythonCode = '```python\ndef hello():\n    print("Hello, World!")\n```'
             editor.commands.setContent(pythonCode)
 
-            const preElement = editor.view.dom.querySelector('pre')
-            expect(preElement).toBeTruthy()
-
-            const codeContent = preElement?.textContent || ''
-            expect(codeContent).toContain('def hello')
-            expect(codeContent).toContain('print')
-            expect(codeContent).toContain('Hello, World!')
+            const json = editor.getJSON()
+            const codeNode = json.content?.find((n: any) => n.type === 'ezcodeBlock' || n.type === 'codeBlock')
+            expect(codeNode).toBeTruthy()
+            expect(codeNode?.attrs?.language).toBe('python')
+            expect(codeNode?.content?.[0]?.text).toContain('def hello')
         })
 
         it('should handle code blocks without language specification', () => {
             const plainCode = '```\nplain text code\nno syntax highlighting\n```'
             editor.commands.setContent(plainCode)
 
-            const preElement = editor.view.dom.querySelector('pre')
-            expect(preElement).toBeTruthy()
-
-            const codeContent = preElement?.textContent || ''
-            expect(codeContent).toContain('plain text code')
-            expect(codeContent).toContain('no syntax highlighting')
+            const json = editor.getJSON()
+            const codeNode = json.content?.find((n: any) => n.type === 'ezcodeBlock' || n.type === 'codeBlock')
+            expect(codeNode).toBeTruthy()
+            expect(codeNode?.content?.[0]?.text).toContain('plain text code')
         })
 
         it('should handle inline code', () => {
@@ -242,12 +230,12 @@ describe('MarkdownEditor Extensions', () => {
             const fileReference = '```src/example.js\nconsole.log("File content");\n```'
             editor.commands.setContent(fileReference)
 
-            const preElement = editor.view.dom.querySelector('pre')
-            expect(preElement).toBeTruthy()
-
-            const codeContent = preElement?.textContent || ''
-            expect(codeContent).toContain('console.log')
-            expect(codeContent).toContain('File content')
+            // Verify via JSON — CodeMirror node view doesn't render <pre>
+            const json = editor.getJSON()
+            const codeNode = json.content?.find((n: any) => n.type === 'ezcodeBlock' || n.type === 'codeBlock')
+            expect(codeNode).toBeTruthy()
+            expect(codeNode?.content?.[0]?.text).toContain('console.log')
+            expect(codeNode?.content?.[0]?.text).toContain('File content')
         })
 
         it('should maintain file system state', () => {
@@ -313,10 +301,11 @@ Visit [our website](https://example.com) for more info.`
             expect(editor.view.dom.querySelector('[data-checked="false"]')).toBeTruthy()
             expect(editor.view.dom.querySelector('[data-checked="true"]')).toBeTruthy()
 
-            // Code blocks
-            const preElement = editor.view.dom.querySelector('pre')
-            expect(preElement).toBeTruthy()
-            expect(preElement?.textContent).toContain('function example')
+            // Code blocks (verified via JSON since CodeMirror node view replaces <pre>)
+            const json = editor.getJSON()
+            const codeNode = json.content?.find((n: any) => n.type === 'ezcodeBlock' || n.type === 'codeBlock')
+            expect(codeNode).toBeTruthy()
+            expect(codeNode?.content?.[0]?.text).toContain('function example')
 
             // Tables
             const table = editor.view.dom.querySelector('table')

package/src/test/multiview-sync.test.ts

@@ -0,0 +1,137 @@
+import { describe, it, expect, beforeEach, afterEach } from 'vitest'
+import { fileChangeBus } from '@joinezco/codeblock'
+import { EditorView } from '@codemirror/view'
+import { EditorState } from '@codemirror/state'
+
+describe('FileChangeBus', () => {
+    let viewA: EditorView
+    let viewB: EditorView
+    let containerA: HTMLElement
+    let containerB: HTMLElement
+
+    beforeEach(() => {
+        containerA = document.createElement('div')
+        containerB = document.createElement('div')
+        document.body.appendChild(containerA)
+        document.body.appendChild(containerB)
+
+        viewA = new EditorView({
+            state: EditorState.create({ doc: 'initial' }),
+            parent: containerA,
+        })
+        viewB = new EditorView({
+            state: EditorState.create({ doc: 'initial' }),
+            parent: containerB,
+        })
+    })
+
+    afterEach(() => {
+        viewA.destroy()
+        viewB.destroy()
+        containerA.remove()
+        containerB.remove()
+    })
+
+    it('should notify other subscribers but not the source', () => {
+        const received: { view: string; content: string }[] = []
+
+        fileChangeBus.subscribe('test.txt', viewA, (content) => {
+            received.push({ view: 'A', content })
+        })
+        fileChangeBus.subscribe('test.txt', viewB, (content) => {
+            received.push({ view: 'B', content })
+        })
+
+        // Notify from view A — only B should receive
+        fileChangeBus.notify('test.txt', 'hello from A', viewA)
+
+        expect(received).toEqual([{ view: 'B', content: 'hello from A' }])
+    })
+
+    it('should not notify after unsubscribe', () => {
+        const received: string[] = []
+
+        const unsub = fileChangeBus.subscribe('test.txt', viewA, (content) => {
+            received.push(content)
+        })
+        fileChangeBus.subscribe('test.txt', viewB, () => {})
+
+        unsub()
+        fileChangeBus.notify('test.txt', 'hello', viewB)
+
+        expect(received).toEqual([])
+    })
+
+    it('should handle multiple files independently', () => {
+        const received: string[] = []
+
+        fileChangeBus.subscribe('a.txt', viewA, (content) => {
+            received.push('a:' + content)
+        })
+        fileChangeBus.subscribe('b.txt', viewA, (content) => {
+            received.push('b:' + content)
+        })
+
+        fileChangeBus.notify('a.txt', 'one', viewB)
+        fileChangeBus.notify('b.txt', 'two', viewB)
+
+        expect(received).toEqual(['a:one', 'b:two'])
+    })
+
+    it('should sync document content between views via the bus', () => {
+        // Simulate two views on the same file using the bus to sync
+
+        const unsubA = fileChangeBus.subscribe('shared.txt', viewA, (content) => {
+            if (viewA.state.doc.toString() !== content) {
+                viewA.dispatch({ changes: { from: 0, to: viewA.state.doc.length, insert: content } })
+            }
+        })
+        const unsubB = fileChangeBus.subscribe('shared.txt', viewB, (content) => {
+            if (viewB.state.doc.toString() !== content) {
+                viewB.dispatch({ changes: { from: 0, to: viewB.state.doc.length, insert: content } })
+            }
+        })
+
+        // Edit view A and "save" (notify the bus)
+        viewA.dispatch({ changes: { from: 0, to: viewA.state.doc.length, insert: 'updated content' } })
+        fileChangeBus.notify('shared.txt', 'updated content', viewA)
+
+        // View B should have received the update
+        expect(viewB.state.doc.toString()).toBe('updated content')
+        // View A should NOT have been re-dispatched (it was the source)
+        expect(viewA.state.doc.toString()).toBe('updated content')
+
+        unsubA()
+        unsubB()
+    })
+
+    it('should not create infinite loops when both views subscribe', () => {
+        let dispatchCountA = 0
+        let dispatchCountB = 0
+
+        fileChangeBus.subscribe('shared.txt', viewA, (content) => {
+            if (viewA.state.doc.toString() !== content) {
+                dispatchCountA++
+                viewA.dispatch({ changes: { from: 0, to: viewA.state.doc.length, insert: content } })
+                // In the real codeblockView, this dispatch would NOT trigger save because
+                // receivingExternalUpdate is true. So we do NOT re-notify.
+            }
+        })
+        fileChangeBus.subscribe('shared.txt', viewB, (content) => {
+            if (viewB.state.doc.toString() !== content) {
+                dispatchCountB++
+                viewB.dispatch({ changes: { from: 0, to: viewB.state.doc.length, insert: content } })
+            }
+        })
+
+        // Simulate save from A
+        viewA.dispatch({ changes: { from: 0, to: viewA.state.doc.length, insert: 'final' } })
+        fileChangeBus.notify('shared.txt', 'final', viewA)
+
+        // Only B should have dispatched once
+        expect(dispatchCountA).toBe(0)
+        expect(dispatchCountB).toBe(1)
+        expect(viewA.state.doc.toString()).toBe('final')
+        expect(viewB.state.doc.toString()).toBe('final')
+    })
+})

package/vitest.config.ts

@@ -1,4 +1,5 @@
 import { defineConfig } from 'vitest/config'
+import { playwright } from '@vitest/browser-playwright'
 import path from 'path'
 
 export default defineConfig({
@@ -6,15 +7,17 @@ export default defineConfig({
         // Enable browser testing
         browser: {
             enabled: true,
-            name: 'chromium',
-            provider: 'playwright',
-            // Headless mode for CI, can be disabled for debugging
+            provider: playwright(),
             headless: true,
-            // Browser viewport
-            viewport: {
-                width: 1280,
-                height: 720,
-            },
+            instances: [
+                {
+                    browser: 'chromium',
+                    viewport: {
+                        width: 1280,
+                        height: 720,
+                    },
+                },
+            ],
         },
         // Test environment setup
         environment: 'happy-dom',
@@ -51,9 +54,53 @@ export default defineConfig({
             '@/lib': path.resolve(__dirname, './src/lib'),
         },
     },
-    // Optimize deps for testing
+    // @joinezco/codeblock is a workspace link — exclude it from optimization so
+    // Vite serves its source directly. Its transitive deps must be listed with
+    // the "package > dep" syntax so Vite can resolve them through the excluded package.
     optimizeDeps: {
         exclude: ['@joinezco/codeblock'],
+        include: [
+            '@joinezco/codeblock > @codemirror/autocomplete',
+            '@joinezco/codeblock > @codemirror/commands',
+            '@joinezco/codeblock > @codemirror/lang-cpp',
+            '@joinezco/codeblock > @codemirror/lang-css',
+            '@joinezco/codeblock > @codemirror/lang-html',
+            '@joinezco/codeblock > @codemirror/lang-java',
+            '@joinezco/codeblock > @codemirror/lang-javascript',
+            '@joinezco/codeblock > @codemirror/lang-less',
+            '@joinezco/codeblock > @codemirror/lang-markdown',
+            '@joinezco/codeblock > @codemirror/lang-php',
+            '@joinezco/codeblock > @codemirror/lang-python',
+            '@joinezco/codeblock > @codemirror/lang-rust',
+            '@joinezco/codeblock > @codemirror/lang-sass',
+            '@joinezco/codeblock > @codemirror/lang-sql',
+            '@joinezco/codeblock > @codemirror/lang-xml',
+            '@joinezco/codeblock > @codemirror/lang-yaml',
+            '@joinezco/codeblock > @codemirror/language',
+            '@joinezco/codeblock > @codemirror/legacy-modes/mode/clike',
+            '@joinezco/codeblock > @codemirror/legacy-modes/mode/cmake',
+            '@joinezco/codeblock > @codemirror/legacy-modes/mode/dockerfile',
+            '@joinezco/codeblock > @codemirror/legacy-modes/mode/go',
+            '@joinezco/codeblock > @codemirror/legacy-modes/mode/haskell',
+            '@joinezco/codeblock > @codemirror/legacy-modes/mode/lua',
+            '@joinezco/codeblock > @codemirror/legacy-modes/mode/perl',
+            '@joinezco/codeblock > @codemirror/legacy-modes/mode/properties',
+            '@joinezco/codeblock > @codemirror/legacy-modes/mode/ruby',
+            '@joinezco/codeblock > @codemirror/legacy-modes/mode/shell',
+            '@joinezco/codeblock > @codemirror/legacy-modes/mode/swift',
+            '@joinezco/codeblock > @codemirror/legacy-modes/mode/toml',
+            '@joinezco/codeblock > @codemirror/legacy-modes/mode/vb',
+            '@joinezco/codeblock > @codemirror/lint',
+            '@joinezco/codeblock > @codemirror/search',
+            '@joinezco/codeblock > @lezer/highlight',
+            '@joinezco/codeblock > @m234/nerd-fonts/fs',
+            '@joinezco/codeblock > @volar/language-service',
+            '@joinezco/codeblock > comlink',
+            '@joinezco/codeblock > lodash',
+            '@joinezco/codeblock > minisearch',
+            '@joinezco/codeblock > path-browserify',
+            'marked',
+        ],
     },
     // Server configuration for tests
     server: {