@jobber/components-native 0.89.1-JOB-139857-e7771b4.7 → 0.89.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jobber/components-native",
-  "version": "0.89.1-JOB-139857-e7771b4.7+e7771b4e1",
+  "version": "0.89.2",
   "license": "MIT",
   "description": "React Native implementation of Atlantis",
   "repository": {
@@ -94,5 +94,5 @@
     "react-native-safe-area-context": "^5.4.0",
     "react-native-svg": ">=12.0.0"
   },
-  "gitHead": "e7771b4e1b4363a1f41119579a03282032c2f1fe"
+  "gitHead": "33e1f533d1cf64dc6746f5db8f00763994fe5895"
 }

package/src/BottomSheet/BottomSheet.test.tsx

@@ -43,42 +43,42 @@ function setup({
 }
 
 it("renders a BottomSheet", async () => {
-  const { getByText } = setup({});
+  const { findByText } = setup({});
 
   await waitForUntestableRender(
     "Wait for AccessibilityInfo.isScreenReaderEnabled to resolve",
   );
 
-  act(() => {
+  await act(async () => {
     ref.current?.open();
   });
 
-  expect(getByText("BottomSheet")).toBeDefined();
+  expect(await findByText("BottomSheet")).toBeDefined();
 });
 
 it("renders a BottomSheet with a header", async () => {
   const header = "Hello this is header";
-  const { getByText } = setup({ heading: header });
+  const { findByText } = setup({ heading: header });
 
   await waitForUntestableRender(
     "Wait for AccessibilityInfo.isScreenReaderEnabled to resolve",
   );
 
-  act(() => {
+  await act(async () => {
     ref.current?.open();
   });
 
-  expect(getByText(header)).toBeDefined();
+  expect(await findByText(header)).toBeDefined();
 });
 
 it("BottomSheet can be closed with the cancel action", async () => {
-  const { getByText, queryByText } = setup({ showCancel: true });
+  const { findByLabelText, queryByText } = setup({ showCancel: true });
 
-  act(() => {
+  await act(async () => {
     ref.current?.open();
   });
 
-  fireEvent.press(getByText("Cancel"));
+  fireEvent.press(await findByLabelText("Cancel"));
 
   await waitFor(() => {
     expect(queryByText("BottomSheet")).toBeNull();
@@ -93,7 +93,7 @@ describe("when loading is provided and true", () => {
       "Wait for AccessibilityInfo.isScreenReaderEnabled to resolve",
     );
 
-    act(() => {
+    await act(async () => {
       ref.current?.open();
     });
 
@@ -104,25 +104,25 @@ describe("when loading is provided and true", () => {
 it("calls onClose when BottomSheet is closed", async () => {
   setup({});
 
-  act(() => {
+  await act(async () => {
     ref.current?.open();
     ref.current?.close();
   });
 
   await waitFor(() => {
-    expect(mockOnClose).toHaveBeenCalled();
+    expect(mockOnClose).toHaveBeenCalledTimes(1);
   });
 });
 
 it("calls onOpen when BottomSheet is opened", async () => {
   setup({});
 
-  act(() => {
+  await act(async () => {
     ref.current?.open();
   });
 
   await waitFor(() => {
-    expect(mockOnOpen).toHaveBeenCalled();
+    expect(mockOnOpen).toHaveBeenCalledTimes(1);
   });
 });
 
@@ -132,17 +132,17 @@ describe("when there is a screen reader enabled", () => {
       .spyOn(AccessibilityInfo, "isScreenReaderEnabled")
       .mockImplementation(() => Promise.resolve(true));
 
-    const { getByText, queryByText } = setup({});
+    const { findByLabelText, queryByText } = setup({});
 
     await waitForUntestableRender(
       "Wait for AccessibilityInfo.isScreenReaderEnabled to resolve",
     );
 
-    act(() => {
+    await act(async () => {
       ref.current?.open();
     });
 
-    fireEvent.press(getByText("Cancel"));
+    fireEvent.press(await findByLabelText("Cancel"));
 
     await waitFor(() => {
       expect(queryByText("BottomSheet")).toBeNull();

package/src/ButtonGroup/ButtonGroup.test.tsx

@@ -1,5 +1,5 @@
 import React from "react";
-import { fireEvent, render } from "@testing-library/react-native";
+import { fireEvent, render, waitFor } from "@testing-library/react-native";
 import { Host } from "react-native-portalize";
 import { Alert } from "react-native";
 import type { ButtonGroupProps } from "./ButtonGroup";
@@ -168,7 +168,7 @@ it("fires the press handlers when the primary action buttons are pressed", () =>
   expect(editAction).toHaveBeenCalled();
 });
 
-it("opens the secondary action menu when the More button is pressed", () => {
+it("opens the secondary action menu when the More button is pressed", async () => {
   const createAction = jest.fn();
   const editAction = jest.fn();
   const deleteAction = jest.fn();
@@ -196,11 +196,11 @@ it("opens the secondary action menu when the More button is pressed", () => {
 
   fireEvent.press(getByLabelText("More"));
 
-  expect(findByText("Edit")).not.toBeNull();
-  expect(findByText("Delete")).not.toBeNull();
+  expect(await findByText("Edit")).not.toBeNull();
+  expect(await findByText("Delete")).not.toBeNull();
 });
 
-it("renders heading and cancel options if passed in", () => {
+it("renders heading and cancel options if passed in", async () => {
   const createAction = jest.fn();
   const editAction = jest.fn();
   const { findByText, getByLabelText } = render(
@@ -223,8 +223,8 @@ it("renders heading and cancel options if passed in", () => {
 
   fireEvent.press(getByLabelText("More"));
 
-  expect(findByText("Heading")).not.toBeNull();
-  expect(findByText("Cancel")).not.toBeNull();
+  expect(await findByText("Heading")).not.toBeNull();
+  expect(await findByText("Cancel")).not.toBeNull();
 });
 
 it("renders custom button for primary action if passed in", () => {
@@ -249,7 +249,7 @@ it("renders custom button for primary action if passed in", () => {
   expect(queryByText("Create")).toBeNull();
 });
 
-it("calls onOpenBottomSheet when the secondary actions are opened", () => {
+it("calls onOpenBottomSheet when the secondary actions are opened", async () => {
   const createAction = jest.fn();
   const editAction = jest.fn();
   const deleteAction = jest.fn();
@@ -275,7 +275,9 @@ it("calls onOpenBottomSheet when the secondary actions are opened", () => {
 
   fireEvent.press(getByLabelText("More"));
 
-  expect(mockOnOpen).toHaveBeenCalled();
+  await waitFor(() => {
+    expect(mockOnOpen).toHaveBeenCalledTimes(1);
+  });
 });
 
 describe("ButtonGroup Offline/Online", () => {

package/src/ContentOverlay/UNSAFE_WrappedModalize.tsx

@@ -23,11 +23,9 @@ export const UNSAFE_WrappedModalize = forwardRef<IHandles | undefined, Props>(
           requestAnimationFrame(() => {
             innerRef.current?.open(dest);
           });
-          props.onOpen?.();
         },
         close(dest) {
           innerRef.current?.close(dest);
-          props.onClose?.();
         },
       }),
       [],

package/src/Form/components/FormSaveButton/FormSaveButton.test.tsx

@@ -127,7 +127,7 @@ describe("when a secondaryActions is passed in", () => {
     const beforeSubmitMock = jest.fn().mockImplementation(() => {
       return Promise.resolve(true);
     });
-    const { getByLabelText } = render(
+    const { findByLabelText, getByLabelText } = render(
       <ButtonGroupForTest
         primaryAction={pressHandler}
         loading={false}
@@ -145,7 +145,7 @@ describe("when a secondaryActions is passed in", () => {
       />,
     );
     fireEvent.press(getByLabelText("More"));
-    expect(getByLabelText("hi")).toBeDefined();
+    expect(await findByLabelText("hi")).toBeDefined();
     fireEvent.press(getByLabelText("hi"));
     expect(beforeSubmitMock).toHaveBeenCalled();
     await waitFor(() => {

package/src/FormatFile/FormatFile.test.tsx

@@ -210,17 +210,17 @@ function basicRenderTestWithValue() {
         jest.advanceTimersByTime(progressBarAnimationTime);
       });
 
-      it("shows a BottomSheet with a remove option when tapped", () => {
-        const { getByTestId, getByLabelText } = tree;
+      it("shows a BottomSheet with a remove option when tapped", async () => {
+        const { getByTestId, findByLabelText } = tree;
         fireEvent.press(getByTestId(testId));
-        expect(getByLabelText(removeLabel)).toBeDefined();
+        expect(await findByLabelText(removeLabel)).toBeDefined();
       });
 
       describe("when the BottomSheet remove option is tapped", () => {
-        it("calls the onRemove action", () => {
-          const { getByTestId, getByLabelText } = tree;
+        it("calls the onRemove action", async () => {
+          const { getByTestId, findByLabelText } = tree;
           fireEvent.press(getByTestId(testId));
-          fireEvent.press(getByLabelText(removeLabel));
+          fireEvent.press(await findByLabelText(removeLabel));
           expect(onRemove).toHaveBeenCalledTimes(1);
         });
       });
@@ -233,36 +233,36 @@ function basicRenderTestWithValue() {
   );
 
   describe("when the preview option is tapped", () => {
-    it("calls onPreview with a valid image", () => {
+    it("calls onPreview with a valid image", async () => {
       const previewLabel = "Preview image";
-      const { getByTestId, getByLabelText } = renderFormatFile(
+      const { getByTestId, findByLabelText } = renderFormatFile(
         FILE_UPLOAD_MOCK_IMAGE({ progress: 1, status: StatusCode.Completed }),
         "image",
       );
       fireEvent.press(getByTestId("test-image"));
-      fireEvent.press(getByLabelText(previewLabel));
+      fireEvent.press(await findByLabelText(previewLabel));
       expect(mockOnPreview).toHaveBeenCalledTimes(1);
     });
 
-    it("calls onPreview with a valid pdf file", () => {
+    it("calls onPreview with a valid pdf file", async () => {
       const previewLabel = "Preview file";
-      const { getByTestId, getByLabelText } = renderFormatFile(
+      const { getByTestId, findByLabelText } = renderFormatFile(
         FILE_UPLOAD_MOCK_PDF({ progress: 1, status: StatusCode.Completed }),
         "file",
       );
       fireEvent.press(getByTestId("test-file"));
-      fireEvent.press(getByLabelText(previewLabel));
+      fireEvent.press(await findByLabelText(previewLabel));
       expect(mockOnPreview).toHaveBeenCalledTimes(1);
     });
 
-    it("calls onPreview with a valid external PDF file", () => {
+    it("calls onPreview with a valid external PDF file", async () => {
       const previewLabel = "Preview file";
-      const { getByTestId, getByLabelText } = renderFormatFile(
+      const { getByTestId, findByLabelText } = renderFormatFile(
         FILE_MOCK_PDF,
         "file",
       );
       fireEvent.press(getByTestId("test-file"));
-      fireEvent.press(getByLabelText(previewLabel));
+      fireEvent.press(await findByLabelText(previewLabel));
       expect(mockOnPreview).toHaveBeenCalledTimes(1);
     });
 

package/src/FormatFile/components/FormatFileBottomSheet/FormatFileBottomSheet.test.tsx

@@ -52,29 +52,29 @@ const basicRenderTestWithValue = () => {
       });
 
       describe("onPreviewPress", () => {
-        it("renders the preview option", () => {
-          const { getByLabelText } = tree;
+        it("renders the preview option", async () => {
+          const { findByLabelText } = tree;
 
-          expect(getByLabelText(previewLabel)).toBeDefined();
+          expect(await findByLabelText(previewLabel)).toBeDefined();
         });
 
-        it("is called when pressed", () => {
-          const { getByLabelText } = tree;
-          fireEvent.press(getByLabelText(previewLabel));
+        it("is called when pressed", async () => {
+          const { findByLabelText } = tree;
+          fireEvent.press(await findByLabelText(previewLabel));
           expect(onPreview).toHaveBeenCalledTimes(1);
         });
       });
 
       describe("onRemovePress", () => {
-        it("renders the remove option", () => {
-          const { getByLabelText } = tree;
+        it("renders the remove option", async () => {
+          const { findByLabelText } = tree;
 
-          expect(getByLabelText(removeLabel)).toBeDefined();
+          expect(await findByLabelText(removeLabel)).toBeDefined();
         });
 
-        it("is called when pressed", () => {
-          const { getByLabelText } = tree;
-          fireEvent.press(getByLabelText(removeLabel));
+        it("is called when pressed", async () => {
+          const { findByLabelText } = tree;
+          fireEvent.press(await findByLabelText(removeLabel));
 
           expect(onRemove).toHaveBeenCalledTimes(1);
         });