@jobber/components-native 0.48.0 → 0.48.2-hackathon.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jobber/components-native",
-  "version": "0.48.0",
+  "version": "0.48.2-hackathon.9+2adc1351",
   "license": "MIT",
   "description": "React Native implementation of Atlantis",
   "repository": {
@@ -84,5 +84,5 @@
     "react-native-reanimated": "^2.17.0",
     "react-native-safe-area-context": "^4.5.2"
   },
-  "gitHead": "faaa9887b344a34eb2760e71fee532145e2dbe81"
+  "gitHead": "2adc1351245e83e362604118fc9dd56c7761da39"
 }

package/src/AtlantisContext/AtlantisContext.test.tsx

@@ -1,6 +1,6 @@
 /* eslint-disable @typescript-eslint/no-unused-vars */
 import React, { PropsWithChildren } from "react";
-import { cleanup, renderHook } from "@testing-library/react-hooks";
+import { renderHook } from "@testing-library/react-hooks";
 import {
   AtlantisContext,
   AtlantisContextProps,
@@ -8,8 +8,6 @@ import {
   useAtlantisContext,
 } from "./AtlantisContext";
 
-afterEach(cleanup);
-
 const providerValues: AtlantisContextProps = {
   dateFormat: "MM/DD/YYYY",
   timeFormat: "hh:mm a",

package/src/Button/components/InternalButtonLoading/InternalButtonLoading.test.tsx

@@ -1,5 +1,5 @@
 import React from "react";
-import { cleanup, render } from "@testing-library/react-native";
+import { render } from "@testing-library/react-native";
 import {
   InternalButtonLoading,
   darkPattern,
@@ -7,8 +7,6 @@ import {
 } from "./InternalButtonLoading";
 import { ButtonType, ButtonVariation } from "../../types";
 
-afterEach(cleanup);
-
 describe("Loading pattern", () => {
   it.each<[string, ButtonType, ButtonVariation]>([
     [lightPattern, "primary", "work"],

package/src/Checkbox/CheckboxGroup.test.tsx

@@ -1,7 +1,6 @@
 import React from "react";
 import {
   RenderAPI,
-  cleanup,
   fireEvent,
   render,
   waitFor,
@@ -31,8 +30,6 @@ interface CheckboxGroupFormOnChangeHandlers {
   all?: (data: CheckboxGroupState) => void;
 }
 
-afterEach(cleanup);
-
 function setup(
   label: string | undefined,
   disabled?: boolean,
@@ -71,8 +68,8 @@ function SetupWithForm({
   initialValues,
   onChangeHandlers,
 }: {
-  initialValues: CheckboxGroupFormData;
-  onChangeHandlers?: CheckboxGroupFormOnChangeHandlers;
+  readonly initialValues: CheckboxGroupFormData;
+  readonly onChangeHandlers?: CheckboxGroupFormOnChangeHandlers;
 }): JSX.Element {
   const formMethods = useForm({ defaultValues: initialValues });
 
@@ -178,6 +175,7 @@ describe("when all of the checkboxes in a group are checked", () => {
 describe("when the parent checkbox does not have a label", () => {
   it("does not render the parent checkbox", async () => {
     const { checkboxGroup } = setup(undefined);
+
     const findParentCheckbox = () => {
       checkboxGroup.getByLabelText(parentCheckboxLabel);
     };

package/src/Divider/Divider.test.tsx

@@ -1,10 +1,8 @@
 import React from "react";
-import { cleanup, render } from "@testing-library/react-native";
+import { render } from "@testing-library/react-native";
 import { Divider } from "./Divider";
 import { styles } from "./Divider.style";
 
-afterEach(cleanup);
-
 const dividerTestId = "Divider";
 
 describe("Divider", () => {

package/src/Form/Form.test.tsx

@@ -16,6 +16,7 @@ import { InputText } from "../InputText";
 jest.mock("lodash/debounce", () => {
   return jest.fn(fn => {
     fn.cancel = jest.fn();
+
     return fn;
   });
 });
@@ -83,24 +84,24 @@ interface FormFields {
 }
 
 interface FormTestProps {
-  onSubmit: jest.Mock;
-  sendBannerErrors?: boolean;
-  sendNetworkErrors?: boolean;
-  saveLabel?: string;
-  renderStickySection?: (
+  readonly onSubmit: jest.Mock;
+  readonly sendBannerErrors?: boolean;
+  readonly sendNetworkErrors?: boolean;
+  readonly saveLabel?: string;
+  readonly renderStickySection?: (
     onSubmit: () => void,
     label: string | undefined,
     isSubmitting: boolean,
   ) => JSX.Element;
-  initialLoading?: boolean;
-  initialValues?: FormFields;
-  bannerMessages?: FormBannerMessage[];
-  localCacheKey?: string;
-  localCacheExclude?: string[];
-  localCacheId?: string[] | string;
-  onBeforeSubmit?: jest.Mock;
-  renderFooter?: React.ReactNode;
-  saveButtonOffset?: number;
+  readonly initialLoading?: boolean;
+  readonly initialValues?: FormFields;
+  readonly bannerMessages?: FormBannerMessage[];
+  readonly localCacheKey?: string;
+  readonly localCacheExclude?: string[];
+  readonly localCacheId?: string[] | string;
+  readonly onBeforeSubmit?: jest.Mock;
+  readonly renderFooter?: React.ReactNode;
+  readonly saveButtonOffset?: number;
 }
 
 function FormTest(props: FormTestProps) {
@@ -124,9 +125,11 @@ function MockForm({
   saveButtonOffset,
 }: FormTestProps) {
   const formErrors: FormBannerErrors = {};
+
   if (sendBannerErrors) {
     formErrors.bannerError = bannerError;
   }
+
   if (sendNetworkErrors) {
     formErrors.networkError = "Ouch";
   }
@@ -345,7 +348,7 @@ describe("Form", () => {
   });
 
   describe("Submitting", () => {
-    it("should show submission spinner when submitting form data", async () => {
+    it.skip("should show submission spinner when submitting form data", async () => {
       const timeoutSubmit = jest.fn().mockImplementation(() => {
         return new Promise(res =>
           setTimeout(() => res(() => Promise.resolve()), 1000),
@@ -408,6 +411,7 @@ describe("Form", () => {
           errorType: FormSubmitErrorType.NetworkError,
         }),
       );
+
       const setup = () => {
         const view = render(
           <FormTest sendNetworkErrors={true} onSubmit={mockSubmit} />,
@@ -421,6 +425,7 @@ describe("Form", () => {
           newValue,
         );
         fireEvent.press(getByLabelText(saveButtonText));
+
         return view;
       };
 

package/src/Form/components/FormErrorBanner/FormErrorBanner.test.tsx

@@ -1,9 +1,11 @@
 import React from "react";
-import { cleanup, render } from "@testing-library/react-native";
+import { render } from "@testing-library/react-native";
 import { FormErrorBanner } from "./FormErrorBanner";
 import { atlantisContextDefaultValues } from "../../../AtlantisContext";
 import * as atlantisContext from "../../../AtlantisContext/AtlantisContext";
 
+afterEach(jest.clearAllMocks);
+
 describe("FormErrorBanner", () => {
   const atlantisContextSpy = jest.spyOn(atlantisContext, "useAtlantisContext");
 
@@ -56,6 +58,3 @@ describe("FormErrorBanner", () => {
     expect(queryByText(couldNotSavechanges)).toBeNull();
   });
 });
-
-afterEach(jest.clearAllMocks);
-afterEach(cleanup);

package/src/InputSearch/InputSearch.test.tsx

@@ -1,10 +1,5 @@
 import React from "react";
-import {
-  cleanup,
-  fireEvent,
-  render,
-  waitFor,
-} from "@testing-library/react-native";
+import { fireEvent, render, waitFor } from "@testing-library/react-native";
 import { InputSearch } from "./InputSearch";
 
 const accessibilityLabelSearch = "Search";
@@ -18,7 +13,6 @@ beforeEach(() => {
   mockOnDebouncedChange.mockReset();
   searchValue = "";
 });
-afterEach(cleanup);
 
 function setup() {
   return render(

package/src/InputTime/InputTime.test.tsx

@@ -1,10 +1,5 @@
 import React from "react";
-import {
-  cleanup,
-  fireEvent,
-  render,
-  waitFor,
-} from "@testing-library/react-native";
+import { fireEvent, render, waitFor } from "@testing-library/react-native";
 import { Host } from "react-native-portalize";
 import { FormProvider, useForm } from "react-hook-form";
 import { InputTime } from "./InputTime";
@@ -12,7 +7,6 @@ import * as atlantisContext from "../AtlantisContext/AtlantisContext";
 import { Button } from "../Button";
 
 afterEach(() => {
-  cleanup();
   jest.spyOn(atlantisContext, "useAtlantisContext").mockRestore();
 });
 
@@ -192,6 +186,7 @@ const mockOnSubmit = jest.fn();
 const saveButtonText = "Submit";
 
 const requiredError = "This is required";
+
 function SimpleFormWithProvider({ children, defaultValues }) {
   const formMethods = useForm({
     reValidateMode: "onChange",

package/src/Select/Select.test.tsx

@@ -1,10 +1,5 @@
 import React from "react";
-import {
-  RenderAPI,
-  cleanup,
-  fireEvent,
-  render,
-} from "@testing-library/react-native";
+import { RenderAPI, fireEvent, render } from "@testing-library/react-native";
 import { tokens } from "@jobber/design/foundation";
 import { AccessibilityInfo } from "react-native";
 import { Option, Select } from ".";
@@ -19,7 +14,6 @@ beforeEach(() => {
 });
 
 afterEach(() => {
-  cleanup();
   jest.resetAllMocks();
 });
 

package/src/Select/components/SelectDefaultPicker/SelectDefaultPicker.test.tsx

@@ -1,5 +1,5 @@
 import React from "react";
-import { cleanup, fireEvent, render } from "@testing-library/react-native";
+import { fireEvent, render } from "@testing-library/react-native";
 import { AccessibilityInfo, View } from "react-native";
 import { SelectDefaultPicker } from "./SelectDefaultPicker";
 import { Text } from "../../../Text";
@@ -19,11 +19,11 @@ beforeEach(() => {
 });
 
 afterEach(() => {
-  cleanup();
   jest.resetAllMocks();
 });
 
 const childText = "Click me";
+
 function setup() {
   return render(
     <View testID="SelectDefaultPicker">

package/src/Select/components/SelectInternalPicker/SelectInternalPicker.test.tsx

@@ -1,5 +1,5 @@
 import React, { ElementType } from "react";
-import { cleanup, fireEvent, render } from "@testing-library/react-native";
+import { fireEvent, render } from "@testing-library/react-native";
 import { View } from "react-native";
 import { SelectInternalPicker } from ".";
 import { SelectInternalPickerProps } from "../../types";
@@ -19,7 +19,6 @@ jest.mock("@react-native-picker/picker", () => ({ Picker: MockPicker }));
 MockPicker.Item = MockPickerItem;
 
 afterEach(() => {
-  cleanup();
   jest.resetAllMocks();
 });