@jobber/components-native 0.116.1 → 0.116.2

package/dist/types/src/AutoLink/hooks/useTokenGenerator.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/types/src/hooks/useFormController.test.d.ts

@@ -0,0 +1 @@
+export {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jobber/components-native",
-  "version": "0.116.1",
+  "version": "0.116.2",
   "license": "MIT",
   "description": "React Native implementation of Atlantis",
   "repository": {
@@ -125,5 +125,5 @@
     "react-native-screens": ">=4.18.0",
     "react-native-svg": ">=12.0.0"
   },
-  "gitHead": "d324e138d0e3c27cf0e54dac5d40b2c2d7e9ab82"
+  "gitHead": "028f5c6483614c4409dbb96015b0d1b00cea1eb7"
 }

package/src/AutoLink/hooks/useTokenGenerator.test.ts

@@ -0,0 +1,28 @@
+import { renderHook } from "@testing-library/react-native";
+import uuid from "react-native-uuid";
+import { useTokenGenerator } from "./useTokenGenerator";
+
+describe("useTokenGenerator", () => {
+  it("generates tokens that its pattern matches", () => {
+    const { result } = renderHook(() => useTokenGenerator());
+    const [generateToken, tokenRegexp] = result.current;
+
+    const text = `${generateToken()} and ${generateToken()}`;
+
+    expect(text.match(tokenRegexp)).toHaveLength(2);
+  });
+
+  it("still renders late in a long session", () => {
+    // Exhaust react-native-uuid's argument-less v1() budget, which throws on
+    // its 10,000th call in a JS session.
+    for (let i = 0; i < 10_000; i++) {
+      try {
+        uuid.v1();
+      } catch {
+        break;
+      }
+    }
+
+    expect(() => renderHook(() => useTokenGenerator())).not.toThrow();
+  });
+});

package/src/AutoLink/hooks/useTokenGenerator.ts

@@ -3,7 +3,7 @@ import uuid from "react-native-uuid";
 
 export function useTokenGenerator(): [() => string, RegExp] {
   let counter = 0;
-  const [identifier] = useState(uuid.v1());
+  const [identifier] = useState(() => uuid.v4());
 
   return [
     () => `@__ELEMENT-${identifier}-${counter++}__@`,

package/src/hooks/useFormController.test.tsx

@@ -0,0 +1,38 @@
+import { renderHook } from "@testing-library/react-native";
+import uuid from "react-native-uuid";
+import { useFormController } from "./useFormController";
+
+// react-native-uuid's v1() only resets its counter when given options, so its
+// 10,000th argument-less call in a JS session throws. Exhaust it the way a long
+// session with large forms does.
+function exhaustUuidV1Budget() {
+  for (let i = 0; i < 10_000; i++) {
+    try {
+      uuid.v1();
+    } catch {
+      return;
+    }
+  }
+}
+
+describe("useFormController", () => {
+  it("keeps the generated field name stable across re-renders", () => {
+    const { result, rerender } = renderHook(() =>
+      useFormController({ value: "" }),
+    );
+    const initialName = result.current.field.name;
+
+    rerender({});
+
+    expect(initialName).toMatch(/^generatedName--/);
+    expect(result.current.field.name).toBe(initialName);
+  });
+
+  it("still renders unnamed fields late in a long session", () => {
+    exhaustUuidV1Budget();
+
+    expect(() =>
+      renderHook(() => useFormController({ value: "" })),
+    ).not.toThrow();
+  });
+});

package/src/hooks/useFormController.ts

@@ -54,7 +54,7 @@ export function useFormController<T>({
 }
 
 function useControlName(name?: string): UseControllerReturn["field"]["name"] {
-  const [identifier] = useState(uuid.v1());
+  const [identifier] = useState(() => uuid.v4());
   const prefix = `generatedName--${identifier}`;
 
   return `${name || prefix}` as const;