@jmruthers/pace-core 0.6.9 → 0.6.11

package/src/__tests__/integration/UserProfile.test.tsx

@@ -1,124 +0,0 @@
-/**
- * @file User Profile Integration Tests
- * @description Example integration test patterns
- */
-
-import React from 'react';
-import { screen, waitFor } from '@testing-library/react';
-import userEvent from '@testing-library/user-event';
-import { describe, it, expect, vi, beforeEach } from 'vitest';
-import { renderWithProviders } from '../helpers/test-utils';
-import { testData } from '../fixtures/mocks';
-
-// Mock components for demonstration
-const UserProfile = ({ userId }: { userId: string }) => {
-  const [user, setUser] = React.useState<any>(null);
-  const [loading, setLoading] = React.useState(true);
-  const [error, setError] = React.useState<string | null>(null);
-
-  React.useEffect(() => {
-    // Simulate API call
-    const fetchUser = async () => {
-      try {
-        setLoading(true);
-        const userData = testData.users.find(u => u.id === userId);
-        if (userData) {
-          setUser(userData);
-        } else {
-          setError('User not found');
-        }
-      } catch (err) {
-        setError('Failed to fetch user');
-      } finally {
-        setLoading(false);
-      }
-    };
-
-    fetchUser();
-  }, [userId]);
-
-  if (loading) return <p>Loading...</p>;
-  if (error) return <p>Error: {error}</p>;
-  if (!user) return <p>No user found</p>;
-
-  return (
-    <section data-testid="user-profile">
-      <h1>{user.name}</h1>
-      <p>{user.email}</p>
-      <button onClick={() => setUser({ ...user, name: 'Updated Name' })}>
-        Update Name
-      </button>
-    </section>
-  );
-};
-
-describe('User Profile Integration Tests', () => {
-    describe('Data Loading', () => {
-    it('loads and displays user data', async () => {
-      renderWithProviders(<UserProfile userId="1" />);
-      
-      // The component loads data synchronously in this mock, so we just check the final state
-      await waitFor(() => {
-        expect(screen.getByText('John Doe')).toBeDefined();
-      });
-      
-      expect(screen.getByText('john@example.com')).toBeDefined();
-    });
-
-    it('handles user not found', async () => {
-      renderWithProviders(<UserProfile userId="999" />);
-      
-      await waitFor(() => {
-        expect(screen.getByText('Error: User not found')).toBeDefined();
-      });
-    });
-  });
-
-  describe('User Interactions', () => {
-    it('allows updating user name', async () => {
-      const user = userEvent.setup();
-      renderWithProviders(<UserProfile userId="1" />);
-      
-      await waitFor(() => {
-        expect(screen.getByText('John Doe')).toBeDefined();
-      });
-      
-      await user.click(screen.getByText('Update Name'));
-      
-      expect(screen.getByText('Updated Name')).toBeDefined();
-      expect(screen.queryByText('John Doe')).toBeNull();
-    });
-  });
-
-  describe('Component State Management', () => {
-    it('maintains state across re-renders', async () => {
-      const { rerender } = renderWithProviders(<UserProfile userId="1" />);
-      
-      await waitFor(() => {
-        expect(screen.getByText('John Doe')).toBeDefined();
-      });
-      
-      rerender(<UserProfile userId="1" />);
-      
-      expect(screen.getByText('John Doe')).toBeDefined();
-    });
-  });
-});
-
-// Example of testing with different user IDs
-describe('User Profile - Different Users', () => {
-  const testCases = [
-    { userId: '1', expectedName: 'John Doe' },
-    { userId: '2', expectedName: 'Jane Smith' },
-  ];
-
-  testCases.forEach(({ userId, expectedName }) => {
-    it(`displays correct data for user ${userId}`, async () => {
-      renderWithProviders(<UserProfile userId={userId} />);
-      
-      await waitFor(() => {
-        expect(screen.getByText(expectedName)).toBeDefined();
-      });
-    });
-  });
-});

package/src/__tests__/public-recipe-view.test.ts

@@ -1,228 +0,0 @@
-/**
- * @file Public Recipe View Tests
- * @package @jmruthers/pace-core
- * @module RLS/Tests/PublicViews
- * @since 0.5.181
- * 
- * Regression tests for the public_recipe_details view to verify:
- * - Anonymous access works only when event.public_readable = true
- * - View exposes only expected columns
- * - Respects diet/meal filters
- * - Performance is acceptable (< 500ms)
- */
-
-import { describe, it, expect, beforeAll } from 'vitest';
-import { createClient, SupabaseClient } from '@supabase/supabase-js';
-import type { Database } from '../../types/database';
-
-// Following testing standards: use timeout parameter to prevent hanging
-// See: packages/core/docs/standards/04-testing-standards.md
-const TEST_TIMEOUT = 5000; // 5 seconds per test (matches rls-policies.test.ts pattern)
-const PERFORMANCE_THRESHOLD = 500; // 500ms for public view queries
-
-// Check if we're using real test-db (via environment variables)
-const USE_REAL_DB = !!(process.env.SUPABASE_URL && process.env.VITE_SUPABASE_PUBLISHABLE_KEY);
-const TEST_SUPABASE_URL = process.env.SUPABASE_URL || process.env.VITE_SUPABASE_URL;
-const TEST_SUPABASE_PUBLISHABLE_KEY = process.env.VITE_SUPABASE_PUBLISHABLE_KEY;
-const TEST_SUPABASE_SERVICE_ROLE_KEY = process.env.SUPABASE_SERVICE_ROLE_KEY;
-
-let anonClient: SupabaseClient<Database>;
-let authenticatedClient: SupabaseClient<Database>;
-
-const publicEvent = {
-  event_id: 'public-event-1',
-  event_name: 'Public Event',
-  public_readable: true,
-  is_visible: true,
-  organisation_id: 'org-1' as any
-};
-
-const privateEvent = {
-  event_id: 'private-event-1',
-  event_name: 'Private Event',
-  public_readable: false,
-  is_visible: true,
-  organisation_id: 'org-1' as any
-};
-
-// TODO: Fix hanging tests - Supabase queries are blocking indefinitely despite timeout configuration
-// Issue: Queries to cake_public_recipe_details view hang and prevent vitest timeout from firing
-// Investigation needed:
-//   1. Check if view exists and is accessible
-//   2. Verify RLS policies aren't causing deadlocks
-//   3. Investigate Supabase client connection pooling in test environment
-//   4. Consider using AbortController for query cancellation
-// Reference: packages/core/docs/standards/04-testing-standards.md
-// Related: These tests follow the rls-policies.test.ts pattern but queries hang instead of timing out
-describe.skip('Public Recipe View - Anonymous Access', () => {
-  // Following testing standards: initialize clients once in beforeAll (matches rls-policies.test.ts pattern)
-  beforeAll(() => {
-    if (USE_REAL_DB && TEST_SUPABASE_URL && TEST_SUPABASE_PUBLISHABLE_KEY) {
-      anonClient = createClient<Database>(TEST_SUPABASE_URL, TEST_SUPABASE_PUBLISHABLE_KEY, {
-        auth: { persistSession: false, autoRefreshToken: false }
-      });
-      authenticatedClient = createClient<Database>(TEST_SUPABASE_URL, TEST_SUPABASE_SERVICE_ROLE_KEY || TEST_SUPABASE_PUBLISHABLE_KEY, {
-        auth: { persistSession: false, autoRefreshToken: false }
-      });
-    } else {
-      // This should not happen due to skipIf, but provide fallback
-      throw new Error('Test database credentials not available. Set SUPABASE_URL and VITE_SUPABASE_PUBLISHABLE_KEY environment variables.');
-    }
-  });
-
-  describe('Public Event Access', () => {
-    it('should allow anonymous access when event.public_readable = true', async () => {
-      const start = Date.now();
-      const { data, error } = await anonClient
-        .from('cake_public_recipe_details')
-        .select('*')
-        .eq('event_id', publicEvent.event_id);
-      const duration = Date.now() - start;
-
-      expect(error).toBeNull();
-      expect(data).toBeDefined();
-      expect(duration).toBeLessThan(PERFORMANCE_THRESHOLD);
-    }, TEST_TIMEOUT);
-
-    it('should block anonymous access when event.public_readable = false', async () => {
-      const { data, error } = await anonClient
-        .from('cake_public_recipe_details')
-        .select('*')
-        .eq('event_id', privateEvent.event_id);
-
-      // Should return empty (view filters by public_readable = true)
-      expect(data).toEqual([]);
-    }, TEST_TIMEOUT);
-
-    it('should block anonymous access when event.is_visible = false', async () => {
-      const { data, error } = await anonClient
-        .from('cake_public_recipe_details')
-        .select('*')
-        .eq('event_id', 'hidden-event-1');
-
-      // Should return empty (view filters by is_visible = true)
-      expect(data).toEqual([]);
-    }, TEST_TIMEOUT);
-  });
-
-  describe('View Column Exposure', () => {
-    it('should expose only expected columns', async () => {
-      const { data, error } = await anonClient
-        .from('cake_public_recipe_details')
-        .select('*')
-        .eq('event_id', publicEvent.event_id)
-        .limit(1)
-        .single();
-
-      expect(error).toBeNull();
-      if (data) {
-        // Verify expected columns exist
-        expect(data).toHaveProperty('dish_id');
-        expect(data).toHaveProperty('dish_name');
-        expect(data).toHaveProperty('dish_code');
-        expect(data).toHaveProperty('event_id');
-        expect(data).toHaveProperty('organisation_id');
-        
-        // Verify sensitive columns are NOT exposed
-        // (adjust based on actual view definition)
-        // expect(data).not.toHaveProperty('created_by');
-        // expect(data).not.toHaveProperty('updated_by');
-      }
-    }, TEST_TIMEOUT);
-  });
-
-  describe('Diet/Meal Filters', () => {
-    it('should filter by meal type', async () => {
-      const start = Date.now();
-      const { data, error } = await anonClient
-        .from('cake_public_recipe_details')
-        .select('*')
-        .eq('event_id', publicEvent.event_id)
-        .eq('mealtype_name', 'Breakfast');
-      const duration = Date.now() - start;
-
-      expect(error).toBeNull();
-      expect(data).toBeDefined();
-      expect(duration).toBeLessThan(PERFORMANCE_THRESHOLD);
-    }, TEST_TIMEOUT);
-
-    it('should filter by diet requirements', async () => {
-      // This test would verify that diet filters work correctly
-      // Adjust based on actual view structure
-      const { data, error } = await anonClient
-        .from('cake_public_recipe_details')
-        .select('*')
-        .eq('event_id', publicEvent.event_id)
-        .eq('dish_dietnote', 'Vegetarian');
-
-      expect(error).toBeNull();
-      expect(data).toBeDefined();
-    }, TEST_TIMEOUT);
-  });
-
-  describe('Performance', () => {
-    it('should complete view queries in < 500ms', async () => {
-      const start = Date.now();
-      await anonClient
-        .from('cake_public_recipe_details')
-        .select('*')
-        .eq('event_id', publicEvent.event_id)
-        .limit(100);
-      const duration = Date.now() - start;
-
-      expect(duration).toBeLessThan(PERFORMANCE_THRESHOLD);
-    }, TEST_TIMEOUT);
-
-    it('should handle filtered queries efficiently', async () => {
-      const start = Date.now();
-      await anonClient
-        .from('cake_public_recipe_details')
-        .select('*')
-        .eq('event_id', publicEvent.event_id)
-        .eq('mealtype_name', 'Breakfast')
-        .limit(50);
-      const duration = Date.now() - start;
-
-      expect(duration).toBeLessThan(PERFORMANCE_THRESHOLD);
-    }, TEST_TIMEOUT);
-  });
-});
-
-// TODO: Fix hanging tests - Supabase queries are blocking indefinitely despite timeout configuration
-// Issue: Queries to cake_public_recipe_details view hang and prevent vitest timeout from firing
-// Investigation needed:
-//   1. Check if view exists and is accessible
-//   2. Verify RLS policies aren't causing deadlocks
-//   3. Investigate Supabase client connection pooling in test environment
-//   4. Consider using AbortController for query cancellation
-// Reference: packages/core/docs/standards/04-testing-standards.md
-// Related: These tests follow the rls-policies.test.ts pattern but queries hang instead of timing out
-describe.skip('Public Recipe View - Authenticated Access', () => {
-  // Following testing standards: initialize clients once in beforeAll (matches rls-policies.test.ts pattern)
-  // Note: Clients are already initialized in the previous describe block's beforeAll
-  // This describe block reuses the same clients
-
-  it.skip('should allow authenticated users to view public recipes', async () => {
-    const { data, error } = await authenticatedClient
-      .from('cake_public_recipe_details')
-      .select('*')
-      .eq('event_id', publicEvent.event_id);
-
-    expect(error).toBeNull();
-    expect(data).toBeDefined();
-  }, TEST_TIMEOUT);
-
-  it.skip('should allow authenticated users to view private events they have access to', async () => {
-    // Authenticated users with organisation access should be able to view
-    // recipes from events in their organisation, even if not public_readable
-    // (This depends on the view definition and RLS policies)
-    const { data, error } = await authenticatedClient
-      .from('cake_public_recipe_details')
-      .select('*')
-      .eq('event_id', privateEvent.event_id);
-
-    // Result depends on RLS policies and view definition
-    expect(error).toBeNull();
-  }, TEST_TIMEOUT);
-});
-

package/src/__tests__/rbac/PagePermissionGuard.test.tsx

@@ -1,220 +0,0 @@
-/**
- * @file PagePermissionGuard Tests
- * @package @jmruthers/pace-core
- * @module RBAC/Components/PagePermissionGuard
- * @since 2.0.0
- *
- * Comprehensive tests for PagePermissionGuard component to ensure:
- * - UI state management works correctly
- * - Permission checks are properly handled
- * - No infinite re-renders occur
- * - Scope resolution is robust
- */
-
-import React from 'react';
-import { render, screen, waitFor, act } from '@testing-library/react';
-import { vi } from 'vitest';
-import { PagePermissionGuard } from '../../rbac/components/PagePermissionGuard';
-import { useUnifiedAuth } from '../../providers';
-import { useCan } from '../../rbac/hooks';
-
-// Mock the hooks
-const mockUseUnifiedAuthFn = vi.fn();
-vi.mock('../../providers/services/UnifiedAuthProvider', () => ({
-  useUnifiedAuth: () => mockUseUnifiedAuthFn(),
-  UnifiedAuthProvider: ({ children }: { children: React.ReactNode }) => <>{children}</>,
-}));
-vi.mock('../../rbac/hooks', () => ({
-  useCan: vi.fn()
-}));
-vi.mock('../../utils/appNameResolver');
-
-const mockUseCan = vi.mocked(useCan);
-
-describe('PagePermissionGuard', () => {
-  const mockUser = {
-    id: 'user-123',
-    email: 'test@example.com'
-  };
-
-  const mockScope = {
-    organisationId: 'org-123',
-    eventId: 'event-123',
-    appId: 'app-123'
-  };
-
-  beforeEach(() => {
-    // Reset all mocks
-    vi.clearAllMocks();
-    
-    // Default mock implementations
-    mockUseUnifiedAuthFn.mockReturnValue({
-      user: mockUser,
-      selectedOrganisation: { id: 'org-123' },
-      selectedEvent: { event_id: 'event-123' },
-      selectedOrganisationId: 'org-123',
-      selectedEventId: 'event-123',
-      supabase: {} as any,
-      session: {} as any,
-      appName: 'test-app',
-      isAuthenticated: true,
-      signOut: vi.fn(),
-      // Add other required properties
-    } as any);
-
-    mockUseCan.mockReturnValue({
-      can: false,
-      isLoading: false,
-      error: null,
-      refetch: vi.fn()
-    });
-  });
-
-  describe('UI State Management', () => {
-    it('should render without crashing', async () => {
-      render(
-        <PagePermissionGuard 
-          pageName="test" 
-          operation="read"
-          scope={mockScope}
-        >
-          <p>Protected Content</p>
-        </PagePermissionGuard>
-      );
-
-      // Should render something (either loading, content, or fallback)
-      // With default mock (can: false), should show access denied
-      await waitFor(() => {
-        expect(screen.getByText('Access Denied')).toBeInTheDocument();
-      });
-    });
-
-    it('should show protected content when permission is granted', async () => {
-      mockUseCan.mockReturnValue({
-        can: true,
-        isLoading: false,
-        error: null,
-        refetch: vi.fn()
-      });
-
-      render(
-        <PagePermissionGuard 
-          pageName="test" 
-          operation="read"
-          scope={mockScope}
-        >
-          <p>Protected Content</p>
-        </PagePermissionGuard>
-      );
-
-      await waitFor(() => {
-        expect(screen.getByText('Protected Content')).toBeInTheDocument();
-      }, { timeout: 3000 });
-    });
-  });
-
-  describe('Permission State Transitions', () => {
-    it('should handle permission state changes', async () => {
-      mockUseCan.mockReturnValue({
-        can: true,
-        isLoading: false,
-        error: null,
-        refetch: vi.fn()
-      });
-
-      render(
-        <PagePermissionGuard 
-          pageName="test" 
-          operation="read"
-          scope={mockScope}
-        >
-          <p>Protected Content</p>
-        </PagePermissionGuard>
-      );
-
-      await waitFor(() => {
-        expect(screen.getByText('Protected Content')).toBeInTheDocument();
-      }, { timeout: 3000 });
-    });
-  });
-
-  describe('Error Handling', () => {
-    it('should handle errors gracefully', async () => {
-      mockUseCan.mockReturnValue({
-        can: false,
-        isLoading: false,
-        error: new Error('Permission check failed'),
-        refetch: vi.fn()
-      });
-
-      render(
-        <PagePermissionGuard 
-          pageName="test" 
-          operation="read"
-          scope={mockScope}
-        >
-          <p>Protected Content</p>
-        </PagePermissionGuard>
-      );
-
-      // Should render access denied when there's an error
-      await waitFor(() => {
-        expect(screen.getByText('Access Denied')).toBeInTheDocument();
-      }, { timeout: 3000 });
-    });
-  });
-
-  describe('Hook Stability', () => {
-    it('should render without infinite re-renders', () => {
-      let renderCount = 0;
-      
-      const TestComponent = () => {
-        renderCount++;
-        return (
-          <PagePermissionGuard 
-            pageName="test" 
-            operation="read"
-            scope={mockScope}
-          >
-            <p>Protected Content</p>
-          </PagePermissionGuard>
-        );
-      };
-
-      render(<TestComponent />);
-
-      // Should not have excessive re-renders
-      expect(renderCount).toBeLessThan(10);
-    });
-  });
-
-  describe('Scope Resolution', () => {
-    it('should work with organisation context', async () => {
-      mockUseUnifiedAuthFn.mockReturnValue({
-        user: mockUser,
-        selectedOrganisationId: 'org-123',
-        selectedEventId: null,
-        supabase: {} as any,
-        session: {} as any,
-        appName: 'test-app',
-        isAuthenticated: true,
-        signOut: vi.fn(),
-      } as any);
-
-      render(
-        <PagePermissionGuard 
-          pageName="test" 
-          operation="read"
-          scope={mockScope}
-        >
-          <p>Protected Content</p>
-        </PagePermissionGuard>
-      );
-
-      // Should render access denied with default mock (can: false)
-      await waitFor(() => {
-        expect(screen.getByText('Access Denied')).toBeInTheDocument();
-      }, { timeout: 3000 });
-    });
-  });
-});