@jmruthers/pace-core 0.6.7 → 0.6.8

package/src/components/PaceAppLayout/PaceAppLayout.security.test.tsx

@@ -444,7 +444,7 @@ describe('PaceAppLayout Security', () => {
       });
     });
 
-    it('prevents access when user lacks permission', async () => {
+    it('prevents access when user lacks permission', { timeout: 3000 }, async () => {
       // Ensure super admin check completes first
       mockIsSuperAdmin.mockResolvedValueOnce(false);
       
@@ -465,7 +465,7 @@ describe('PaceAppLayout Security', () => {
       // Wait for super admin check to complete and component to re-render
       await waitFor(() => {
         expect(mockIsSuperAdmin).toHaveBeenCalled();
-      }, { timeout: 1000 });
+      });
       
       // Wait a bit for the component to process the super admin check result
       await new Promise(resolve => setTimeout(resolve, 100));
@@ -474,8 +474,8 @@ describe('PaceAppLayout Security', () => {
       await waitFor(() => {
         expect(screen.getByText('Access Denied')).toBeInTheDocument();
         expect(screen.getByText("You don't have permission to access this page.")).toBeInTheDocument();
-      }, { timeout: 2000 });
-    }, { timeout: 3000 });
+      });
+    });
 
     it('enforces route-specific permissions', async () => {
       const routePermissions: Record<string, Operation> = {
@@ -501,7 +501,7 @@ describe('PaceAppLayout Security', () => {
       });
     });
 
-    it('handles permission check failures securely', async () => {
+    it('handles permission check failures securely', { timeout: 3000 }, async () => {
       // Ensure super admin check completes first
       mockIsSuperAdmin.mockResolvedValueOnce(false);
       
@@ -522,7 +522,7 @@ describe('PaceAppLayout Security', () => {
       // Wait for super admin check to complete and component to re-render
       await waitFor(() => {
         expect(mockIsSuperAdmin).toHaveBeenCalled();
-      }, { timeout: 1000 });
+      });
       
       // Wait a bit for the component to process the super admin check result
       await new Promise(resolve => setTimeout(resolve, 100));
@@ -531,8 +531,8 @@ describe('PaceAppLayout Security', () => {
         // When permission check throws an error, should show Permission Error page
         expect(screen.getByText('Permission Error')).toBeInTheDocument();
         expect(screen.getByText('Permission check failed')).toBeInTheDocument();
-      }, { timeout: 2000 });
-    }, { timeout: 3000 });
+      });
+    });
 
     it('prevents bypassing permission checks', async () => {
       // Test that permission checks cannot be bypassed by manipulating props
@@ -562,7 +562,7 @@ describe('PaceAppLayout Security', () => {
   });
 
   describe('Navigation Security', () => {
-    it('filters navigation items based on permissions', async () => {
+    it('filters navigation items based on permissions', { timeout: 3000 }, async () => {
       // Mock permission check to allow all permissions for navigation filtering
       // The navigation filtering uses getPermissionMap which is already mocked
       render(
@@ -582,8 +582,8 @@ describe('PaceAppLayout Security', () => {
         // With permission enforcement enabled, the component should render normally
         expect(screen.getByTestId('mock-header')).toBeInTheDocument();
         expect(screen.getByTestId('mock-outlet')).toBeInTheDocument();
-      }, { timeout: 2000 });
-    }, { timeout: 3000 });
+      });
+    });
 
     it('prevents navigation to unauthorized routes', () => {
       render(
@@ -843,7 +843,7 @@ describe('PaceAppLayout Security', () => {
       });
     });
 
-    it('handles permission errors securely', async () => {
+    it('handles permission errors securely', { timeout: 3000 }, async () => {
       // Ensure super admin check completes first
       mockIsSuperAdmin.mockResolvedValueOnce(false);
       
@@ -864,17 +864,17 @@ describe('PaceAppLayout Security', () => {
       // Wait for super admin check to complete and component to re-render
       await waitFor(() => {
         expect(mockIsSuperAdmin).toHaveBeenCalled();
-      }, { timeout: 1000 });
+      });
       
       // Wait a bit for the component to process the super admin check result
       await new Promise(resolve => setTimeout(resolve, 100));
       
       await waitFor(() => {
         expect(screen.getByText('Access Denied')).toBeInTheDocument();
-      }, { timeout: 2000 });
-    }, { timeout: 3000 });
+      });
+    });
 
-    it('prevents information leakage in error messages', async () => {
+    it('prevents information leakage in error messages', { timeout: 3000 }, async () => {
       // Ensure super admin check completes first
       mockIsSuperAdmin.mockResolvedValueOnce(false);
       
@@ -902,7 +902,7 @@ describe('PaceAppLayout Security', () => {
       // Wait for super admin check to complete and component to re-render
       await waitFor(() => {
         expect(mockIsSuperAdmin).toHaveBeenCalled();
-      }, { timeout: 1000 });
+      });
       
       // Wait a bit for the component to process the super admin check result
       await new Promise(resolve => setTimeout(resolve, 100));
@@ -911,8 +911,8 @@ describe('PaceAppLayout Security', () => {
         expect(screen.getByText('Permission Error')).toBeInTheDocument();
         // Should not expose sensitive information
         expect(screen.queryByText('password=secret123')).not.toBeInTheDocument();
-      }, { timeout: 2000 });
-    }, { timeout: 3000 });
+      });
+    });
   });
 
   describe('Session Security', () => {
@@ -987,7 +987,7 @@ describe('PaceAppLayout Security', () => {
       });
     });
 
-    it('allows super admin to bypass all permission checks', async () => {
+    it('allows super admin to bypass all permission checks', { timeout: 3000 }, async () => {
       // Mock super admin status
       mockIsSuperAdmin.mockResolvedValueOnce(true);
       
@@ -1017,10 +1017,10 @@ describe('PaceAppLayout Security', () => {
         expect(screen.getByTestId('mock-outlet')).toBeInTheDocument();
         // Should NOT show access denied
         expect(screen.queryByText('Access Denied')).not.toBeInTheDocument();
-      }, { timeout: 2000 });
-    }, { timeout: 3000 });
+      });
+    });
 
-    it('does not log strict mode violations for super admins', async () => {
+    it('does not log strict mode violations for super admins', { timeout: 5000 }, async () => {
       // Mock super admin status (resolve immediately)
       mockIsSuperAdmin.mockResolvedValueOnce(true);
       
@@ -1052,12 +1052,12 @@ describe('PaceAppLayout Security', () => {
       // Wait for super admin check to complete
       await waitFor(() => {
         expect(mockIsSuperAdmin).toHaveBeenCalled();
-      }, { timeout: 1000 });
+      });
       
       // Wait for component to fully render (super admin should bypass checks)
       await waitFor(() => {
         expect(screen.getByTestId('mock-header')).toBeInTheDocument();
-      }, { timeout: 2000 });
+      });
       
       // Clear any violations that might have been logged before super admin check completed
       consoleSpy.mockClear();
@@ -1073,9 +1073,9 @@ describe('PaceAppLayout Security', () => {
       expect(violationLogs).toHaveLength(0);
       
       consoleSpy.mockRestore();
-    }, { timeout: 5000 });
+    });
 
-    it('prevents privilege escalation', async () => {
+    it('prevents privilege escalation', { timeout: 3000 }, async () => {
       // Test that users cannot escalate their privileges
       // Create a test wrapper with admin path for privilege escalation test
       const AdminTestWrapper = ({ children }: { children: React.ReactNode }) => (
@@ -1115,7 +1115,7 @@ describe('PaceAppLayout Security', () => {
       // Wait for super admin check to complete and component to re-render
       await waitFor(() => {
         expect(mockIsSuperAdmin).toHaveBeenCalled();
-      }, { timeout: 1000 });
+      });
       
       // Wait a bit for the component to process the super admin check result
       await new Promise(resolve => setTimeout(resolve, 100));
@@ -1124,7 +1124,7 @@ describe('PaceAppLayout Security', () => {
         // With privilege escalation prevention, should show access denied for admin
         expect(screen.getByText('Access Denied')).toBeInTheDocument();
         expect(screen.getByText("You don't have permission to access this page.")).toBeInTheDocument();
-      }, { timeout: 2000 });
-    }, { timeout: 3000 });
+      });
+    });
   });
 }); 

package/src/components/PaceAppLayout/PaceAppLayout.test.tsx

@@ -873,7 +873,7 @@ describe('PaceAppLayout Component', () => {
   });
 
   describe('Route-Specific Permissions', () => {
-    it('uses route-specific permissions when provided', async () => {
+    it('uses route-specific permissions when provided', { timeout: 3000 }, async () => {
       renderWithProviders(
         <TestWrapper>
           <PaceAppLayout 
@@ -906,9 +906,9 @@ describe('PaceAppLayout Component', () => {
           'Test App'
         );
       }, { timeout: 2000 });
-    }, { timeout: 3000 });
+    });
 
-    it('uses default permission when route not in routePermissions', async () => {
+    it('uses default permission when route not in routePermissions', { timeout: 3000 }, async () => {
       renderWithProviders(
         <TestWrapper>
           <PaceAppLayout 
@@ -940,7 +940,7 @@ describe('PaceAppLayout Component', () => {
           'Test App'
         );
       }, { timeout: 2000 });
-    }, { timeout: 3000 });
+    });
   });
 
   describe('Super Admin Bypass', () => {

package/src/components/PaceLoginPage/PaceLoginPage.test.tsx

@@ -673,7 +673,9 @@ describe('PaceLoginPage Component', () => {
     });
 
     it('shows access error when required app configuration is missing', async () => {
+      vi.mocked(isSuperAdmin).mockResolvedValue(false);
       mockAuthContext.isAuthenticated = true;
+      mockAuthContext.isLoading = false;
       mockAuthContext.user = { id: 'user-1' } as User;
       const missingAppSupabase = {
         from: vi.fn((table: string) => {
@@ -707,12 +709,15 @@ describe('PaceLoginPage Component', () => {
       );
 
       await waitFor(() => {
+        // Error message format: Application "${appName}" is not configured. Please contact your administrator.
         expect(screen.getByText(/is not configured/i)).toBeInTheDocument();
-      });
+      }, { timeout: 5000 });
     });
 
     it('shows organisation access error when user lacks active organisations', async () => {
+      vi.mocked(isSuperAdmin).mockResolvedValue(false);
       mockAuthContext.isAuthenticated = true;
+      mockAuthContext.isLoading = false;
       mockAuthContext.user = { id: 'user-2' } as User;
 
       const createOrganisationRolesQuery = (result: { data: unknown; error: unknown }) => {
@@ -779,6 +784,7 @@ describe('PaceLoginPage Component', () => {
       );
 
       await waitFor(() => {
+        // Error message format: You do not have permission to access ${appName}. You are not assigned to any organisation. Please contact your administrator.
         expect(screen.getByText(/not assigned to any organisation/i)).toBeInTheDocument();
       }, { timeout: 5000 });
     });

package/src/hooks/__tests__/useDataTablePerformance.unit.test.ts

@@ -67,11 +67,14 @@ vi.mock('../../components/DataTable/utils/errorHandling', () => ({
       // Constructor
     }
   } as any,
-  CircuitBreaker: vi.fn().mockImplementation(() => ({
-    isOpen: false,
-    recordSuccess: vi.fn(),
-    recordFailure: vi.fn()
-  })),
+  CircuitBreaker: vi.fn(function CircuitBreaker() {
+    return {
+      isOpen: vi.fn(() => false),
+      recordSuccess: vi.fn(),
+      recordFailure: vi.fn(),
+      reset: vi.fn()
+    };
+  }) as any,
   DEFAULT_FALLBACK_CONFIG: {
     enableFallbacks: true,
     maxRetries: 3

package/src/hooks/__tests__/useFileUrl.unit.test.ts

@@ -820,12 +820,16 @@ describe('useFileUrl Hook', () => {
         }
       );
 
+      // Wait for initial URL to load
       await waitFor(
         () => {
           expect(result.current.url).not.toBe(null);
         },
         { timeout: 2000 }
       );
+      
+      // Verify initial URL is set
+      expect(result.current.url).toBe('https://example.com/org-123/logos/logo.png');
 
       const newFile = { ...mockPublicFileReference, id: 'file-999', file_path: 'org-123/logos/new-logo.png' };
       rerender({ fileRef: newFile });

package/src/hooks/__tests__/useFocusTrap.unit.test.tsx

@@ -634,7 +634,7 @@ describe('useFocusTrap', () => {
         getByTestId('toggle').click();
       });
       
-      expect(screen.queryByTestId('container')).not.toBeInTheDocument();
+      expect(screen.queryByTestId('container')).toBeNull();
     });
   });
 
@@ -711,13 +711,13 @@ describe('useFocusTrap', () => {
       
       // Wait for React to update the DOM after state change
       await waitFor(() => {
-        expect(screen.queryByTestId('button-Button 2')).not.toBeInTheDocument();
+        expect(screen.queryByTestId('button-Button 2')).toBeNull();
       });
       
       // Verify the removed button is gone and others remain
       expect(screen.getByTestId('button-Button 1')).toBeDefined();
       expect(screen.getByTestId('button-Button 3')).toBeDefined();
-        expect(screen.queryByTestId('button-Button 2')).not.toBeInTheDocument();
+      expect(screen.queryByTestId('button-Button 2')).toBeNull();
     });
 
     it('should handle elements becoming disabled/enabled', () => {

package/src/hooks/__tests__/useInactivityTracker.unit.test.ts

@@ -288,15 +288,29 @@ describe('useInactivityTracker', () => {
   });
 
   it('broadcasts activity to other tabs', () => {
-    const { result } = renderHook(() => 
-      useInactivityTracker({ 
-        enabled: true,
+    // Ensure no persisted time to force resetActivity call
+    localStorageMock.getItem.mockReturnValue(null);
+    
+    // Start with enabled: true to allow tracking
+    const { result } = renderHook(
+      ({ enabled }) => useInactivityTracker({ 
+        enabled,
         channelName: 'test-channel'
-      })
+      }),
+      { initialProps: { enabled: true } }
     );
     
+    // Wait for automatic initialization
     act(() => {
-      result.current.startTracking();
+      vi.advanceTimersByTime(0);
+    });
+    
+    // Clear any existing calls from initialization
+    mockBroadcastChannel.postMessage.mockClear();
+    
+    // Trigger activity reset which should broadcast
+    act(() => {
+      result.current.resetActivity();
     });
     
     expect(mockBroadcastChannel.postMessage).toHaveBeenCalledWith({
@@ -337,16 +351,39 @@ describe('useInactivityTracker', () => {
 
   it('cleans up timers and listeners on unmount', () => {
     const { result, unmount } = renderHook(() => 
-      useInactivityTracker({ enabled: true })
+      useInactivityTracker({ enabled: true, channelName: 'test-channel' })
     );
     
+    // Wait for automatic initialization
     act(() => {
-      result.current.startTracking();
+      vi.advanceTimersByTime(0);
+    });
+    
+    // Ensure tracking is active and channel/listeners are set up
+    expect(result.current.isTracking).toBe(true);
+    expect(mockAddEventListener).toHaveBeenCalled();
+    
+    // Verify channel was created
+    expect(window.BroadcastChannel).toHaveBeenCalled();
+    
+    // Clear mocks to track cleanup calls
+    mockRemoveEventListener.mockClear();
+    mockBroadcastChannel.close.mockClear();
+    
+    // Unmount should trigger cleanup
+    act(() => {
+      unmount();
     });
     
-    unmount();
+    // Advance timers to ensure cleanup completes
+    act(() => {
+      vi.advanceTimersByTime(100);
+    });
     
+    // Verify cleanup was called
+    // The hook should remove all event listeners that were added
     expect(mockRemoveEventListener).toHaveBeenCalled();
+    // Channel cleanup happens in the unmount effect
     expect(mockBroadcastChannel.close).toHaveBeenCalled();
   });
 

package/src/hooks/__tests__/usePerformanceMonitor.unit.test.ts

@@ -610,7 +610,13 @@ describe('useOperationPerformance', () => {
         useOperationPerformance('testOperation', 'OPERATION')
       );
 
-      mockPerformanceNow.mockReturnValueOnce(0).mockReturnValueOnce(20);
+      // Clear any previous calls
+      vi.clearAllMocks();
+      
+      // Use mockReturnValueOnce to ensure exact sequence
+      mockPerformanceNow
+        .mockReturnValueOnce(0)   // Start time
+        .mockReturnValueOnce(20); // End time
 
       const operation = () => 'result';
 
@@ -623,12 +629,22 @@ describe('useOperationPerformance', () => {
           operation: 'testOperation',
         })
       );
+      
+      // Reset mock
+      mockPerformanceNow.mockImplementation(() => mockPerformanceNowValue);
     });
 
     it('includes context in measurement', async () => {
       const { result } = renderHook(() => useOperationPerformance('testOperation'));
 
-      mockPerformanceNow.mockReturnValueOnce(0).mockReturnValueOnce(15);
+      // Use a sequence to ensure correct values are returned
+      let callCount = 0;
+      mockPerformanceNow.mockImplementation(() => {
+        callCount++;
+        if (callCount === 1) return 0;   // Start time
+        if (callCount === 2) return 15;  // End time
+        return mockPerformanceNowValue; // Fallback
+      });
 
       const operation = () => 'result';
       const context = { userId: '123', action: 'test' };
@@ -644,6 +660,10 @@ describe('useOperationPerformance', () => {
           action: 'test',
         })
       );
+      
+      // Reset mock
+      callCount = 0;
+      mockPerformanceNow.mockImplementation(() => mockPerformanceNowValue);
     });
 
     it('handles operation errors', async () => {

package/src/hooks/public/usePublicRouteParams.ts

@@ -182,16 +182,20 @@ export function usePublicRouteParams(
 
   // Determine the final error state
   const finalError = useMemo(() => {
+    // Always show validation errors (format validation)
     if (error) return error;
-    if (eventError) return eventError;
+    // When validation is disabled, ignore event errors (invalid codes are allowed)
+    if (!validateEventCode) return null;
+    // Include eventError if we're fetching event data and validation is enabled
+    if (fetchEventData && eventError) return eventError;
     return null;
-  }, [error, eventError]);
+  }, [error, eventError, fetchEventData, validateEventCode]);
 
   // Extract event ID from event data
   const eventId = useMemo(() => {
-    if (!event) return null;
+    if (!fetchEventData || !event) return null;
     return event.event_id || event.id;
-  }, [event]);
+  }, [fetchEventData, event]);
 
   // Refetch function
   const refetch = useCallback(async (): Promise<void> => {

package/src/hooks/useAddressAutocomplete.test.ts

@@ -45,17 +45,17 @@ describe('useAddressAutocomplete', () => {
   });
 
   describe('Initial state', () => {
-    it('returns initial state with empty suggestions', () => {
+    it('returns initial state with empty suggestions', { timeout: 5000 }, () => {
       const { result } = renderHook(() => useAddressAutocomplete(mockApiKey, ''));
 
       expect(result.current.suggestions).toEqual([]);
       expect(result.current.isLoading).toBe(false);
       expect(result.current.error).toBeNull();
-    }, { timeout: 5000 });
+    });
   });
 
   describe('Autocomplete suggestions', () => {
-    it('fetches suggestions when input value changes', async () => {
+    it('fetches suggestions when input value changes', { timeout: 5000 }, async () => {
       const mockPredictions = [
         {
           description: '123 Main St, Melbourne VIC, Australia',
@@ -81,9 +81,9 @@ describe('useAddressAutocomplete', () => {
       );
 
       expect(result.current.suggestions[0].place_id).toBe('ChIJ123');
-    }, { timeout: 5000 });
+    });
 
-    it('debounces input value', async () => {
+    it('debounces input value', { timeout: 5000 }, async () => {
       vi.mocked(googlePlacesUtils.fetchPlaceAutocomplete).mockResolvedValue([]);
 
       // Since we're mocking useDebounce to return immediately, this test verifies
@@ -108,9 +108,9 @@ describe('useAddressAutocomplete', () => {
 
       // With mocked debounce, it will be called for each change
       expect(googlePlacesUtils.fetchPlaceAutocomplete).toHaveBeenCalled();
-    }, { timeout: 5000 });
+    });
 
-    it('clears suggestions when input is empty', async () => {
+    it('clears suggestions when input is empty', { timeout: 5000 }, async () => {
       vi.mocked(googlePlacesUtils.fetchPlaceAutocomplete).mockResolvedValueOnce([
         { description: '123 Main St', place_id: 'ChIJ123' },
       ]);
@@ -137,9 +137,9 @@ describe('useAddressAutocomplete', () => {
         },
         { timeout: 1000 }
       );
-    }, { timeout: 5000 });
+    });
 
-    it('handles API errors', async () => {
+    it('handles API errors', { timeout: 5000 }, async () => {
       const error = new Error('API request denied');
       vi.mocked(googlePlacesUtils.fetchPlaceAutocomplete).mockRejectedValueOnce(error);
 
@@ -156,11 +156,11 @@ describe('useAddressAutocomplete', () => {
 
       expect(result.current.error?.message).toBe('API request denied');
       expect(result.current.suggestions).toEqual([]);
-    }, { timeout: 5000 });
+    });
   });
 
   describe('Address selection', () => {
-    it('selects address by place_id', async () => {
+    it('selects address by place_id', { timeout: 5000 }, async () => {
       const mockPlaceDetails = {
         place_id: 'ChIJ123',
         formatted_address: '123 Main St, Melbourne VIC 3000, Australia',
@@ -191,7 +191,7 @@ describe('useAddressAutocomplete', () => {
       expect(address).not.toBeNull();
       expect(address?.place_id).toBe('ChIJ123');
       expect(googlePlacesUtils.fetchPlaceDetails).toHaveBeenCalledWith('ChIJ123', mockApiKey);
-    }, { timeout: 5000 });
+    });
 
     it('returns null when place_id is invalid', async () => {
       vi.mocked(googlePlacesUtils.fetchPlaceDetails).mockRejectedValueOnce(new Error('Place not found'));
@@ -205,7 +205,7 @@ describe('useAddressAutocomplete', () => {
   });
 
   describe('getAddressByPlaceId', () => {
-    it('retrieves address by place_id', async () => {
+    it('retrieves address by place_id', { timeout: 5000 }, async () => {
       const mockAddress = {
         place_id: 'ChIJ123',
         full_address: '123 Main St',
@@ -227,7 +227,7 @@ describe('useAddressAutocomplete', () => {
 
       expect(address).not.toBeNull();
       expect(address?.place_id).toBe('ChIJ123');
-    }, { timeout: 5000 });
+    });
 
     it('returns null on error', async () => {
       vi.mocked(googlePlacesUtils.getAddressByPlaceId).mockResolvedValueOnce(null);
@@ -237,11 +237,11 @@ describe('useAddressAutocomplete', () => {
       const address = await result.current.getAddressByPlaceId('invalid');
 
       expect(address).toBeNull();
-    }, { timeout: 5000 });
+    });
   });
 
   describe('clearSuggestions', () => {
-    it('clears suggestions', async () => {
+    it('clears suggestions', { timeout: 5000 }, async () => {
       vi.mocked(googlePlacesUtils.fetchPlaceAutocomplete).mockResolvedValueOnce([
         { description: '123 Main St', place_id: 'ChIJ123' },
       ]);
@@ -268,7 +268,7 @@ describe('useAddressAutocomplete', () => {
         },
         { timeout: 1000 }
       );
-    }, { timeout: 5000 });
+    });
   });
 
   describe('Caching', () => {
@@ -312,7 +312,7 @@ describe('useAddressAutocomplete', () => {
       );
 
       expect(googlePlacesUtils.fetchPlaceAutocomplete).toHaveBeenCalled();
-    }, { timeout: 5000 });
+    });
   });
 });
 

package/src/hooks/useEventTheme.ts

@@ -43,8 +43,11 @@ import { useLocation } from 'react-router-dom';
 import { EventServiceContext } from '../providers/services/EventServiceProvider';
 import { applyPalette, clearPalette } from '../theming/runtime';
 import { parseAndNormalizeEventColours } from '../theming/parseEventColours';
+import { createLogger } from '../utils/core/logger';
 import type { Event } from '../types/event';
 
+const log = createLogger('useEventTheme');
+
 /**
  * Hook that automatically applies event-specific theming
  * 
@@ -144,7 +147,8 @@ export function useEventTheme(event?: Event | null): void {
     try {
       applyPalette(normalized);
     } catch (error) {
-      // Silently fail - theming is not critical
+      // Log error but don't throw - theming is not critical
+      log.error('Failed to apply event palette:', error);
     }
 
     // Cleanup function to clear palette when component unmounts or event changes