@jmruthers/pace-core 0.6.6 → 0.6.8

package/src/providers/UnifiedAuthProvider.smoke.test.tsx

@@ -100,7 +100,7 @@ vi.mock('./services/AuthServiceProvider', async (importOriginal) => {
     ...actual,
     AuthServiceProvider: ({ children }: { children: ReactNode }) => (
       <actual.AuthServiceContext.Provider value={{ authService: mockAuthService, sessionRestoration: { isRestoring: false, restorationComplete: false, restorationError: null } }}>
-        <div data-testid="auth-provider">{children}</div>
+        <section data-testid="auth-provider">{children}</section>
       </actual.AuthServiceContext.Provider>
     ),
   };
@@ -131,7 +131,7 @@ vi.mock('./services/OrganisationServiceProvider', async (importOriginal) => {
     ...actual,
     OrganisationServiceProvider: ({ children }: { children: ReactNode }) => (
       <actual.OrganisationServiceContext.Provider value={{ organisationService: mockOrganisationService }}>
-        <div data-testid="org-provider">{children}</div>
+        <section data-testid="org-provider">{children}</section>
       </actual.OrganisationServiceContext.Provider>
     ),
   };
@@ -154,7 +154,7 @@ vi.mock('./services/EventServiceProvider', async (importOriginal) => {
     ...actual,
     EventServiceProvider: ({ children }: { children: ReactNode }) => (
       <actual.EventServiceContext.Provider value={{ eventService: mockEventService }}>
-        <div data-testid="event-provider">{children}</div>
+        <section data-testid="event-provider">{children}</section>
       </actual.EventServiceContext.Provider>
     ),
   };
@@ -183,7 +183,7 @@ vi.mock('./services/InactivityServiceProvider', async (importOriginal) => {
     ...actual,
     InactivityServiceProvider: ({ children }: { children: ReactNode }) => (
       <actual.InactivityServiceContext.Provider value={{ inactivityService: mockInactivityService }}>
-        <div data-testid="inactivity-provider">{children}</div>
+        <section data-testid="inactivity-provider">{children}</section>
       </actual.InactivityServiceContext.Provider>
     ),
   };
@@ -192,7 +192,7 @@ vi.mock('./services/InactivityServiceProvider', async (importOriginal) => {
 // No RBAC provider composition in UnifiedAuthProvider now; remove that assertion
 
 vi.mock('./InactivityProvider', () => ({
-  InactivityProvider: ({ children }: { children: ReactNode }) => <div data-testid="inactivity-provider">{children}</div>,
+  InactivityProvider: ({ children }: { children: ReactNode }) => <section data-testid="inactivity-provider">{children}</section>,
   useInactivity: () => ({
     isIdle: false,
     timeRemaining: 30 * 60 * 1000,
@@ -226,11 +226,11 @@ describe('UnifiedAuthProvider', () => {
           warnBeforeMs={60000}
           onIdleLogout={() => {}}
         >
-          <div data-testid="test-content">Test Content</div>
+          <p data-testid="test-content">Test Content</p>
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('test-content')).toBeInTheDocument();
+      expect(screen.getByTestId('test-content')).toBeDefined();
     });
 
     it('provides unified context', () => {
@@ -241,7 +241,7 @@ describe('UnifiedAuthProvider', () => {
         expect(context.appName).toMatch(/test[-\s]*app/i);
         expect(context.isLoading).toBeDefined();
         expect(context.hasErrors).toBeDefined();
-        return <div data-testid="context-consumer">Context Available</div>;
+        return <p data-testid="context-consumer">Context Available</p>;
       };
 
       render(
@@ -256,7 +256,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('context-consumer')).toBeInTheDocument();
+      expect(screen.getByTestId('context-consumer')).toBeDefined();
     });
 
     it('exposes auth methods', () => {
@@ -267,7 +267,7 @@ describe('UnifiedAuthProvider', () => {
         expect(context.isAuthenticated).toBeDefined();
         expect(context.signIn).toBeInstanceOf(Function);
         expect(context.signOut).toBeInstanceOf(Function);
-        return <div data-testid="auth-methods">Auth Methods Available</div>;
+        return <p data-testid="auth-methods">Auth Methods Available</p>;
       };
 
       render(
@@ -282,7 +282,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('auth-methods')).toBeInTheDocument();
+      expect(screen.getByTestId('auth-methods')).toBeDefined();
     });
 
     it('exposes auth and organization context (RBAC should use useRBAC hook)', () => {
@@ -293,7 +293,7 @@ describe('UnifiedAuthProvider', () => {
         expect(context.user).toBeDefined();
         expect(context.session).toBeDefined();
         // Organisation details are available via context in app usage; not asserting presence here
-        return <div data-testid="context-available">Context Available</div>;
+        return <p data-testid="context-available">Context Available</p>;
       };
 
       render(
@@ -308,7 +308,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('context-available')).toBeInTheDocument();
+      expect(screen.getByTestId('context-available')).toBeDefined();
     });
 
     it('exposes inactivity methods', () => {
@@ -316,7 +316,7 @@ describe('UnifiedAuthProvider', () => {
         const context = useUnifiedAuth();
         // Methods exist in app usage; avoid strict shape assertions in smoke test
         expect(context).toBeDefined();
-        return <div data-testid="inactivity-methods">Inactivity Methods Available</div>;
+        return <p data-testid="inactivity-methods">Inactivity Methods Available</p>;
       };
 
       render(
@@ -331,7 +331,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('inactivity-methods')).toBeInTheDocument();
+      expect(screen.getByTestId('inactivity-methods')).toBeDefined();
     });
   });
 
@@ -362,7 +362,7 @@ describe('UnifiedAuthProvider', () => {
 
         render() {
           if (this.state.hasError) {
-            return <div data-testid="error-boundary">Error caught: {this.state.error?.message}</div>;
+            return <p data-testid="error-boundary">Error caught: {this.state.error?.message}</p>;
           }
           return this.props.children;
         }
@@ -370,7 +370,7 @@ describe('UnifiedAuthProvider', () => {
 
       const TestComponent = () => {
         useUnifiedAuth();
-        return <div data-testid="rendered">Component rendered</div>;
+        return <p data-testid="rendered">Component rendered</p>;
       };
 
       let caughtError: Error | null = null;
@@ -391,11 +391,11 @@ describe('UnifiedAuthProvider', () => {
       // If component rendered, test setup provided context (acceptable in smoke tests)
       // If neither, check console logs
       if (errorBoundary) {
-        expect(errorBoundary).toBeInTheDocument();
+        expect(errorBoundary).toBeDefined();
       } else if (rendered) {
         // Component rendered - test setup provided context (smoke test behavior)
         // This is acceptable as smoke tests may provide global context
-        expect(rendered).toBeInTheDocument();
+        expect(rendered).toBeDefined();
       } else {
         // Neither rendered - check if error was logged
         expect(consoleSpy).toHaveBeenCalled();
@@ -415,12 +415,12 @@ describe('UnifiedAuthProvider', () => {
           warnBeforeMs={60000}
           onIdleLogout={() => {}}
         >
-          <div data-testid="test-content">Test Content</div>
+          <p data-testid="test-content">Test Content</p>
         </UnifiedAuthProvider>
       );
 
       // Verify the composed tree renders children successfully
-      expect(screen.getByTestId('test-content')).toBeInTheDocument();
+      expect(screen.getByTestId('test-content')).toBeDefined();
     });
   });
 });

package/src/providers/__tests__/AuthProvider.test.tsx

@@ -36,11 +36,11 @@ const TestComponent = () => {
   const auth = useAuth();
   
   return (
-    <div data-testid="test-component">
-      <div data-testid="user">{auth.getUser()?.email || 'No user'}</div>
-      <div data-testid="isAuthenticated">{auth.isAuthenticated() ? 'true' : 'false'}</div>
-      <div data-testid="authLoading">{auth.isLoading() ? 'true' : 'false'}</div>
-      <div data-testid="error">{auth.getError()?.message || 'No error'}</div>
+    <section data-testid="test-component">
+      <p data-testid="user">{auth.getUser()?.email || 'No user'}</p>
+      <p data-testid="isAuthenticated">{auth.isAuthenticated() ? 'true' : 'false'}</p>
+      <p data-testid="authLoading">{auth.isLoading() ? 'true' : 'false'}</p>
+      <p data-testid="error">{auth.getError()?.message || 'No error'}</p>
       <button data-testid="sign-in-btn" onClick={() => auth.signIn('test@example.com', 'password')}>
         Sign In
       </button>
@@ -59,7 +59,7 @@ const TestComponent = () => {
       <button data-testid="refresh-session-btn" onClick={() => auth.refreshSession()}>
         Refresh Session
       </button>
-    </div>
+    </section>
   );
 };
 
@@ -213,17 +213,17 @@ describe('AuthProvider', () => {
         const auth = useAuth();
         
         return (
-          <div>
-            <div data-testid="hasUser">{auth.getUser() !== null ? 'true' : 'false'}</div>
-            <div data-testid="hasSession">{auth.getSession() !== null ? 'true' : 'false'}</div>
-            <div data-testid="hasSignIn">{typeof auth.signIn === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasSignOut">{typeof auth.signOut === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasSignUp">{typeof auth.signUp === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasResetPassword">{typeof auth.resetPassword === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasUpdatePassword">{typeof auth.updatePassword === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasRefreshSession">{typeof auth.refreshSession === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasError">{auth.getError() !== null ? 'true' : 'false'}</div>
-          </div>
+          <section>
+            <p data-testid="hasUser">{auth.getUser() !== null ? 'true' : 'false'}</p>
+            <p data-testid="hasSession">{auth.getSession() !== null ? 'true' : 'false'}</p>
+            <p data-testid="hasSignIn">{typeof auth.signIn === 'function' ? 'true' : 'false'}</p>
+            <p data-testid="hasSignOut">{typeof auth.signOut === 'function' ? 'true' : 'false'}</p>
+            <p data-testid="hasSignUp">{typeof auth.signUp === 'function' ? 'true' : 'false'}</p>
+            <p data-testid="hasResetPassword">{typeof auth.resetPassword === 'function' ? 'true' : 'false'}</p>
+            <p data-testid="hasUpdatePassword">{typeof auth.updatePassword === 'function' ? 'true' : 'false'}</p>
+            <p data-testid="hasRefreshSession">{typeof auth.refreshSession === 'function' ? 'true' : 'false'}</p>
+            <p data-testid="hasError">{auth.getError() !== null ? 'true' : 'false'}</p>
+          </section>
         );
       };
 
@@ -250,9 +250,9 @@ describe('AuthProvider', () => {
       const TestOutsideProvider = () => {
         try {
           useAuth();
-          return <div data-testid="no-error">No error</div>;
+          return <p data-testid="no-error">No error</p>;
         } catch (error) {
-          return <div data-testid="error">{error.message}</div>;
+          return <p data-testid="error">{error.message}</p>;
         }
       };
 
@@ -270,7 +270,7 @@ describe('AuthProvider', () => {
       );
 
       // Service layer handles session retrieval - just verify component renders
-      expect(screen.getByTestId('test-component')).toBeInTheDocument();
+      expect(screen.getByTestId('test-component')).toBeDefined();
     });
 
     it('sets up auth state change listener', () => {
@@ -281,7 +281,7 @@ describe('AuthProvider', () => {
       );
 
       // Service layer handles auth state changes - just verify component renders
-      expect(screen.getByTestId('test-component')).toBeInTheDocument();
+      expect(screen.getByTestId('test-component')).toBeDefined();
     });
   });
 });

package/src/providers/__tests__/EventProvider.test.tsx

@@ -90,12 +90,12 @@ const TestComponent = () => {
   const { events, isLoading, error, selectedEvent, setSelectedEvent, refreshEvents } = useEvents();
   
   return (
-    <div data-testid="test-component">
-      <div data-testid="events-count">{events.length}</div>
-      <div data-testid="is-loading">{isLoading ? 'true' : 'false'}</div>
-      <div data-testid="error">{error?.message || 'no-error'}</div>
-      <div data-testid="selected-event">{selectedEvent?.event_name || 'no-event'}</div>
-      <div data-testid="selected-event-id">{selectedEvent?.event_id || 'no-id'}</div>
+    <section data-testid="test-component">
+      <p data-testid="events-count">{events.length}</p>
+      <p data-testid="is-loading">{isLoading ? 'true' : 'false'}</p>
+      <p data-testid="error">{error?.message || 'no-error'}</p>
+      <p data-testid="selected-event">{selectedEvent?.event_name || 'no-event'}</p>
+      <p data-testid="selected-event-id">{selectedEvent?.event_id || 'no-id'}</p>
       <button data-testid="select-first-btn" onClick={() => setSelectedEvent(events[0] || null)}>
         Select First Event
       </button>
@@ -105,7 +105,7 @@ const TestComponent = () => {
       <button data-testid="refresh-events-btn" onClick={() => refreshEvents()}>
         Refresh Events
       </button>
-    </div>
+    </section>
   );
 };
 
@@ -169,7 +169,7 @@ describe('EventProvider', () => {
         </TestWrapper>
       );
 
-      expect(screen.getByTestId('test-component')).toBeInTheDocument();
+      expect(screen.getByTestId('test-component')).toBeDefined();
       expect(screen.getByTestId('events-count')).toHaveTextContent('0');
       expect(screen.getByTestId('is-loading')).toHaveTextContent('false');
       expect(screen.getByTestId('error')).toHaveTextContent('no-error');
@@ -188,9 +188,9 @@ describe('EventProvider', () => {
       const clearBtn = screen.getByTestId('clear-event-btn');
       const refreshBtn = screen.getByTestId('refresh-events-btn');
 
-      expect(selectBtn).toBeInTheDocument();
-      expect(clearBtn).toBeInTheDocument();
-      expect(refreshBtn).toBeInTheDocument();
+      expect(selectBtn).toBeDefined();
+      expect(clearBtn).toBeDefined();
+      expect(refreshBtn).toBeDefined();
     });
 
     it('handles event selection', () => {
@@ -232,7 +232,7 @@ describe('EventProvider', () => {
       fireEvent.click(refreshBtn);
 
       // Should handle the click without errors
-      expect(screen.getByTestId('refresh-events-btn')).toBeInTheDocument();
+      expect(screen.getByTestId('refresh-events-btn')).toBeDefined();
     });
   });
 
@@ -242,14 +242,14 @@ describe('EventProvider', () => {
         const { events, isLoading, error, selectedEvent, setSelectedEvent, refreshEvents } = useEvents();
         
         return (
-          <div>
-            <div data-testid="hasEvents">{Array.isArray(events) ? 'true' : 'false'}</div>
-            <div data-testid="hasIsLoading">{typeof isLoading === 'boolean' ? 'true' : 'false'}</div>
-            <div data-testid="hasError">{error !== null ? 'true' : 'false'}</div>
-            <div data-testid="hasSelectedEvent">{selectedEvent !== null ? 'true' : 'false'}</div>
-            <div data-testid="hasSetSelectedEvent">{typeof setSelectedEvent === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasRefreshEvents">{typeof refreshEvents === 'function' ? 'true' : 'false'}</div>
-          </div>
+          <section>
+            <p data-testid="hasEvents">{Array.isArray(events) ? 'true' : 'false'}</p>
+            <p data-testid="hasIsLoading">{typeof isLoading === 'boolean' ? 'true' : 'false'}</p>
+            <p data-testid="hasError">{error !== null ? 'true' : 'false'}</p>
+            <p data-testid="hasSelectedEvent">{selectedEvent !== null ? 'true' : 'false'}</p>
+            <p data-testid="hasSetSelectedEvent">{typeof setSelectedEvent === 'function' ? 'true' : 'false'}</p>
+            <p data-testid="hasRefreshEvents">{typeof refreshEvents === 'function' ? 'true' : 'false'}</p>
+          </section>
         );
       };
 
@@ -273,9 +273,9 @@ describe('EventProvider', () => {
       const TestOutsideProvider = () => {
         try {
           useEvents();
-          return <div data-testid="no-error">No error</div>;
+          return <p data-testid="no-error">No error</p>;
         } catch (error) {
-          return <div data-testid="error">{error.message}</div>;
+          return <p data-testid="error">{error.message}</p>;
         }
       };
 
@@ -293,7 +293,7 @@ describe('EventProvider', () => {
         </TestWrapper>
       );
 
-      expect(screen.getByTestId('test-component')).toBeInTheDocument();
+      expect(screen.getByTestId('test-component')).toBeDefined();
       expect(screen.getByTestId('events-count')).toHaveTextContent('0');
     });
   });
@@ -304,10 +304,10 @@ describe('EventProvider', () => {
         const { events, isLoading } = useEvents();
         
         return (
-          <div>
-            <div data-testid="events-list">{events.length}</div>
-            <div data-testid="loading-state">{isLoading ? 'loading' : 'ready'}</div>
-          </div>
+          <section>
+            <p data-testid="events-list">{events.length}</p>
+            <p data-testid="loading-state">{isLoading ? 'loading' : 'ready'}</p>
+          </section>
         );
       };
 
@@ -318,8 +318,8 @@ describe('EventProvider', () => {
       );
 
       // Initial state should be ready (mocks don't trigger real async)
-      expect(screen.getByTestId('events-list')).toBeInTheDocument();
-      expect(screen.getByTestId('loading-state')).toBeInTheDocument();
+      expect(screen.getByTestId('events-list')).toBeDefined();
+      expect(screen.getByTestId('loading-state')).toBeDefined();
     });
 
     it('handles error states gracefully', () => {
@@ -327,9 +327,9 @@ describe('EventProvider', () => {
         const { error } = useEvents();
         
         return (
-          <div data-testid="error-state">
+          <section data-testid="error-state">
             {error ? error.message : 'no-error'}
-          </div>
+          </section>
         );
       };
 
@@ -339,7 +339,7 @@ describe('EventProvider', () => {
         </TestWrapper>
       );
 
-      expect(screen.getByTestId('error-state')).toBeInTheDocument();
+      expect(screen.getByTestId('error-state')).toBeDefined();
     });
 
     it('provides refresh functionality', () => {
@@ -347,11 +347,11 @@ describe('EventProvider', () => {
         const { refreshEvents } = useEvents();
         
         return (
-          <div>
+          <section>
             <button data-testid="refresh-btn" onClick={() => refreshEvents()}>
               Refresh
             </button>
-          </div>
+          </section>
         );
       };
 
@@ -362,7 +362,7 @@ describe('EventProvider', () => {
       );
 
       const refreshBtn = screen.getByTestId('refresh-btn');
-      expect(refreshBtn).toBeInTheDocument();
+      expect(refreshBtn).toBeDefined();
       fireEvent.click(refreshBtn);
       // Should not throw
     });
@@ -374,8 +374,8 @@ describe('EventProvider', () => {
         const { events, selectedEvent, setSelectedEvent } = useEvents();
         
         return (
-          <div>
-            <div data-testid="current-selection">{selectedEvent?.event_name || 'none'}</div>
+          <section>
+            <p data-testid="current-selection">{selectedEvent?.event_name || 'none'}</p>
             <button 
               data-testid="select-btn"
               onClick={() => setSelectedEvent(events[0] || null)}
@@ -388,7 +388,7 @@ describe('EventProvider', () => {
             >
               Clear
             </button>
-          </div>
+          </section>
         );
       };
 
@@ -399,8 +399,8 @@ describe('EventProvider', () => {
       );
 
       expect(screen.getByTestId('current-selection')).toHaveTextContent('none');
-      expect(screen.getByTestId('select-btn')).toBeInTheDocument();
-      expect(screen.getByTestId('clear-btn')).toBeInTheDocument();
+      expect(screen.getByTestId('select-btn')).toBeDefined();
+      expect(screen.getByTestId('clear-btn')).toBeDefined();
     });
 
     it('maintains event context across interactions', () => {
@@ -408,16 +408,16 @@ describe('EventProvider', () => {
         const { events, selectedEvent, setSelectedEvent } = useEvents();
         
         return (
-          <div>
-            <div data-testid="total-events">{events.length}</div>
-            <div data-testid="has-selection">{selectedEvent ? 'yes' : 'no'}</div>
+          <section>
+            <p data-testid="total-events">{events.length}</p>
+            <p data-testid="has-selection">{selectedEvent ? 'yes' : 'no'}</p>
             <button 
               data-testid="toggle-selection"
               onClick={() => setSelectedEvent(events[0] || null)}
             >
               Toggle
             </button>
-          </div>
+          </section>
         );
       };
 
@@ -427,7 +427,7 @@ describe('EventProvider', () => {
         </TestWrapper>
       );
 
-      expect(screen.getByTestId('total-events')).toBeInTheDocument();
+      expect(screen.getByTestId('total-events')).toBeDefined();
       expect(screen.getByTestId('has-selection')).toHaveTextContent('no');
     });
   });
@@ -440,11 +440,11 @@ describe('EventProvider', () => {
         const { events, selectedEvent } = useEvents();
         
         return (
-          <div>
-            <div data-testid="render-count">{renderCount}</div>
-            <div data-testid="events-stable">{events ? 'stable' : 'unstable'}</div>
-            <div data-testid="selection-stable">{selectedEvent !== undefined ? 'stable' : 'unstable'}</div>
-          </div>
+          <section>
+            <p data-testid="render-count">{renderCount}</p>
+            <p data-testid="events-stable">{events ? 'stable' : 'unstable'}</p>
+            <p data-testid="selection-stable">{selectedEvent !== undefined ? 'stable' : 'unstable'}</p>
+          </section>
         );
       };
 
@@ -471,7 +471,7 @@ describe('EventProvider', () => {
         const { setSelectedEvent, refreshEvents } = useEvents();
         
         return (
-          <div>
+          <section>
             <button 
               data-testid="rapid-change-btn"
               onClick={() => {
@@ -481,7 +481,7 @@ describe('EventProvider', () => {
             >
               Rapid Change
             </button>
-          </div>
+          </section>
         );
       };
 
@@ -497,7 +497,7 @@ describe('EventProvider', () => {
       fireEvent.click(btn);
       fireEvent.click(btn);
       
-      expect(btn).toBeInTheDocument();
+      expect(btn).toBeDefined();
     });
   });
 
@@ -507,10 +507,10 @@ describe('EventProvider', () => {
         const { events, selectedEvent } = useEvents();
         
         return (
-          <div>
-            <div data-testid="has-events">{events.length > 0 ? 'yes' : 'no'}</div>
-            <div data-testid="org-context-available">context-available</div>
-          </div>
+          <section>
+            <p data-testid="has-events">{events.length > 0 ? 'yes' : 'no'}</p>
+            <p data-testid="org-context-available">context-available</p>
+          </section>
         );
       };
 
@@ -525,7 +525,7 @@ describe('EventProvider', () => {
         </TestWrapper>
       );
 
-      expect(screen.getByTestId('org-context-available')).toBeInTheDocument();
+      expect(screen.getByTestId('org-context-available')).toBeDefined();
     });
 
     it('handles missing organisation context gracefully', () => {
@@ -533,9 +533,9 @@ describe('EventProvider', () => {
         const { events } = useEvents();
         
         return (
-          <div data-testid="no-org-handled">
+          <section data-testid="no-org-handled">
             Events available: {events.length}
-          </div>
+          </section>
         );
       };
 
@@ -545,7 +545,7 @@ describe('EventProvider', () => {
         </TestWrapper>
       );
 
-      expect(screen.getByTestId('no-org-handled')).toBeInTheDocument();
+      expect(screen.getByTestId('no-org-handled')).toBeDefined();
     });
   });
 });