@jmruthers/pace-core 0.6.5 → 0.6.7

package/src/providers/__tests__/UnifiedAuthProvider.test.tsx

@@ -58,15 +58,15 @@ const TestComponent = () => {
   const auth = useUnifiedAuth();
   
   return (
-    <div data-testid="test-component">
-      <div data-testid="hasUser">{auth.user !== null ? 'true' : 'false'}</div>
-      <div data-testid="hasSession">{auth.session !== null ? 'true' : 'false'}</div>
-      <div data-testid="hasSignIn">{typeof auth.signIn === 'function' ? 'true' : 'false'}</div>
-      <div data-testid="hasSignOut">{typeof auth.signOut === 'function' ? 'true' : 'false'}</div>
-      <div data-testid="hasOrganisation">{typeof auth.selectedOrganisation === 'object' && auth.selectedOrganisation !== null ? 'true' : 'false'}</div>
-      <div data-testid="hasEvents">{Array.isArray(auth.events) ? 'true' : 'false'}</div>
-      <div data-testid="hasAppName">{typeof auth.appName === 'string' ? 'true' : 'false'}</div>
-    </div>
+    <section data-testid="test-component">
+      <p data-testid="hasUser">{auth.user !== null ? 'true' : 'false'}</p>
+      <p data-testid="hasSession">{auth.session !== null ? 'true' : 'false'}</p>
+      <p data-testid="hasSignIn">{typeof auth.signIn === 'function' ? 'true' : 'false'}</p>
+      <p data-testid="hasSignOut">{typeof auth.signOut === 'function' ? 'true' : 'false'}</p>
+      <p data-testid="hasOrganisation">{typeof auth.selectedOrganisation === 'object' && auth.selectedOrganisation !== null ? 'true' : 'false'}</p>
+      <p data-testid="hasEvents">{Array.isArray(auth.events) ? 'true' : 'false'}</p>
+      <p data-testid="hasAppName">{typeof auth.appName === 'string' ? 'true' : 'false'}</p>
+    </section>
   );
 };
 
@@ -91,7 +91,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('test-component')).toBeInTheDocument();
+      expect(screen.getByTestId('test-component')).toBeDefined();
     });
 
     it('renders with custom app name', () => {
@@ -101,7 +101,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('test-component')).toBeInTheDocument();
+      expect(screen.getByTestId('test-component')).toBeDefined();
     });
 
     it('renders without supabase client', () => {
@@ -111,7 +111,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('test-component')).toBeInTheDocument();
+      expect(screen.getByTestId('test-component')).toBeDefined();
     });
   });
 
@@ -148,9 +148,9 @@ describe('UnifiedAuthProvider', () => {
       const TestHookComponent = () => {
         try {
           const auth = useUnifiedAuth();
-          return <div data-testid="hook-success">Hook works</div>;
+          return <p data-testid="hook-success">Hook works</p>;
         } catch (error) {
-          return <div data-testid="hook-error">Hook failed</div>;
+          return <p data-testid="hook-error">Hook failed</p>;
         }
       };
 
@@ -160,7 +160,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('hook-success')).toBeInTheDocument();
+      expect(screen.getByTestId('hook-success')).toBeDefined();
     });
   });
 
@@ -177,7 +177,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('test-component')).toBeInTheDocument();
+      expect(screen.getByTestId('test-component')).toBeDefined();
     });
 
     it('uses default configuration', () => {
@@ -187,7 +187,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('test-component')).toBeInTheDocument();
+      expect(screen.getByTestId('test-component')).toBeDefined();
     });
   });
 
@@ -197,12 +197,12 @@ describe('UnifiedAuthProvider', () => {
         const auth = useUnifiedAuth();
         
         return (
-          <div>
-            <div data-testid="composition-success">composed</div>
-            <div data-testid="has-all-contexts">
+          <section>
+            <p data-testid="composition-success">composed</p>
+            <p data-testid="has-all-contexts">
               {auth.user && auth.session && auth.isAuthenticated ? 'yes' : 'no'}
-            </div>
-          </div>
+            </p>
+          </section>
         );
       };
 
@@ -225,13 +225,13 @@ describe('UnifiedAuthProvider', () => {
         const auth = useUnifiedAuth();
         
         return (
-          <div>
-            <div data-testid="user-context">{auth.user ? 'present' : 'missing'}</div>
-            <div data-testid="session-context">{auth.session ? 'present' : 'missing'}</div>
-            <div data-testid="organisation-context">{auth.selectedOrganisation ? 'present' : 'missing'}</div>
-            <div data-testid="event-context">{auth.selectedEvent ? 'missing' : 'present'}</div>
-            <div data-testid="app-context">{auth.appName ? 'present' : 'missing'}</div>
-          </div>
+          <section>
+            <p data-testid="user-context">{auth.user ? 'present' : 'missing'}</p>
+            <p data-testid="session-context">{auth.session ? 'present' : 'missing'}</p>
+            <p data-testid="organisation-context">{auth.selectedOrganisation ? 'present' : 'missing'}</p>
+            <p data-testid="event-context">{auth.selectedEvent ? 'missing' : 'present'}</p>
+            <p data-testid="app-context">{auth.appName ? 'present' : 'missing'}</p>
+          </section>
         );
       };
 
@@ -258,10 +258,10 @@ describe('UnifiedAuthProvider', () => {
         const auth = useUnifiedAuth();
         
         return (
-          <div>
-            <div data-testid="provider-hierarchy">valid</div>
-            <div data-testid="auth-available">{auth ? 'yes' : 'no'}</div>
-          </div>
+          <section>
+            <p data-testid="provider-hierarchy">valid</p>
+            <p data-testid="auth-available">{auth ? 'yes' : 'no'}</p>
+          </section>
         );
       };
 
@@ -282,14 +282,14 @@ describe('UnifiedAuthProvider', () => {
         const auth = useUnifiedAuth();
         
         return (
-          <div>
-            <div data-testid="loading-orchestration">
+          <section>
+            <p data-testid="loading-orchestration">
               {auth.isLoading ? 'loading' : 'ready'}
-            </div>
-            <div data-testid="context-ready">
+            </p>
+            <p data-testid="context-ready">
               {auth.user && auth.session ? 'ready' : 'initializing'}
-            </div>
-          </div>
+            </p>
+          </section>
         );
       };
 
@@ -299,8 +299,8 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('loading-orchestration')).toBeInTheDocument();
-      expect(screen.getByTestId('context-ready')).toBeInTheDocument();
+      expect(screen.getByTestId('loading-orchestration')).toBeDefined();
+      expect(screen.getByTestId('context-ready')).toBeDefined();
     });
 
     it('coordinates loading across multiple context sources', () => {
@@ -308,12 +308,12 @@ describe('UnifiedAuthProvider', () => {
         const auth = useUnifiedAuth();
         
         return (
-          <div>
-            <div data-testid="coordination">{auth.isLoading ? 'coordinating' : 'coordinated'}</div>
-            <div data-testid="all-contexts-loaded">
+          <section>
+            <p data-testid="coordination">{auth.isLoading ? 'coordinating' : 'coordinated'}</p>
+            <p data-testid="all-contexts-loaded">
               {auth.user && auth.session && !auth.isLoading ? 'loaded' : 'loading'}
-            </div>
-          </div>
+            </p>
+          </section>
         );
       };
 
@@ -323,8 +323,8 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('coordination')).toBeInTheDocument();
-      expect(screen.getByTestId('all-contexts-loaded')).toBeInTheDocument();
+      expect(screen.getByTestId('coordination')).toBeDefined();
+      expect(screen.getByTestId('all-contexts-loaded')).toBeDefined();
     });
   });
 
@@ -334,12 +334,12 @@ describe('UnifiedAuthProvider', () => {
         const auth = useUnifiedAuth();
         
         return (
-          <div>
-            <div data-testid="error-state">{auth.error ? 'has-error' : 'no-error'}</div>
-            <div data-testid="still-functional">
+          <section>
+            <p data-testid="error-state">{auth.error ? 'has-error' : 'no-error'}</p>
+            <p data-testid="still-functional">
               {auth.user || auth.session ? 'functional' : 'broken'}
-            </div>
-          </div>
+            </p>
+          </section>
         );
       };
 
@@ -349,8 +349,8 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('error-state')).toBeInTheDocument();
-      expect(screen.getByTestId('still-functional')).toBeInTheDocument();
+      expect(screen.getByTestId('error-state')).toBeDefined();
+      expect(screen.getByTestId('still-functional')).toBeDefined();
     });
 
     it('provides error recovery mechanisms', () => {
@@ -358,12 +358,12 @@ describe('UnifiedAuthProvider', () => {
         const auth = useUnifiedAuth();
         
         return (
-          <div>
-            <div data-testid="recovery-available">
+          <section>
+            <p data-testid="recovery-available">
               {auth.refreshSession ? 'available' : 'unavailable'}
-            </div>
-            <div data-testid="error-handled">{auth.error ? 'handled' : 'no-error'}</div>
-          </div>
+            </p>
+            <p data-testid="error-handled">{auth.error ? 'handled' : 'no-error'}</p>
+          </section>
         );
       };
 
@@ -373,8 +373,8 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('recovery-available')).toBeInTheDocument();
-      expect(screen.getByTestId('error-handled')).toBeInTheDocument();
+      expect(screen.getByTestId('recovery-available')).toBeDefined();
+      expect(screen.getByTestId('error-handled')).toBeDefined();
     });
 
     it('maintains stability during error states', () => {
@@ -382,12 +382,12 @@ describe('UnifiedAuthProvider', () => {
         const auth = useUnifiedAuth();
         
         return (
-          <div>
-            <div data-testid="stable-during-error">
+          <section>
+            <p data-testid="stable-during-error">
               {auth ? 'stable' : 'unstable'}
-            </div>
-            <div data-testid="re-render-safe">safe</div>
-          </div>
+            </p>
+            <p data-testid="re-render-safe">safe</p>
+          </section>
         );
       };
 
@@ -397,7 +397,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('stable-during-error')).toBeInTheDocument();
+      expect(screen.getByTestId('stable-during-error')).toBeDefined();
       
       // Re-render during error state
       rerender(
@@ -416,14 +416,14 @@ describe('UnifiedAuthProvider', () => {
         const auth = useUnifiedAuth();
         
         return (
-          <div>
-            <div data-testid="hook-access">
+          <section>
+            <p data-testid="hook-access">
               {auth.user && auth.session && auth.isAuthenticated ? 'full' : 'partial'}
-            </div>
-            <div data-testid="hook-methods">
+            </p>
+            <p data-testid="hook-methods">
               {auth.signIn && auth.signOut && auth.refreshSession ? 'complete' : 'incomplete'}
-            </div>
-          </div>
+            </p>
+          </section>
         );
       };
 
@@ -447,12 +447,12 @@ describe('UnifiedAuthProvider', () => {
         const auth = useUnifiedAuth();
         
         return (
-          <div>
-            <div data-testid="user-stable">{auth.user ? 'stable' : 'unstable'}</div>
-            <div data-testid="methods-stable">
+          <section>
+            <p data-testid="user-stable">{auth.user ? 'stable' : 'unstable'}</p>
+            <p data-testid="methods-stable">
               {auth.signIn && auth.signOut ? 'stable' : 'unstable'}
-            </div>
-          </div>
+            </p>
+          </section>
         );
       };
 
@@ -486,10 +486,10 @@ describe('UnifiedAuthProvider', () => {
         const isAuthenticated = auth.isAuthenticated;
         
         return (
-          <div>
-            <div data-testid="concurrent-safe">safe</div>
-            <div data-testid="all-reads">{user && session && isAuthenticated ? 'success' : 'fail'}</div>
-          </div>
+          <section>
+            <p data-testid="concurrent-safe">safe</p>
+            <p data-testid="all-reads">{user && session && isAuthenticated ? 'success' : 'fail'}</p>
+          </section>
         );
       };
 
@@ -514,13 +514,13 @@ describe('UnifiedAuthProvider', () => {
         const auth = useUnifiedAuth();
         
         return (
-          <div>
-            <div data-testid="custom-app-name">{auth.appName}</div>
-            <div data-testid="app-name-present">{auth.appName ? 'present' : 'missing'}</div>
-            <div data-testid="app-name-consistent">
+          <section>
+            <p data-testid="custom-app-name">{auth.appName}</p>
+            <p data-testid="app-name-present">{auth.appName ? 'present' : 'missing'}</p>
+            <p data-testid="app-name-consistent">
               {auth.appName && auth.appName.length > 0 ? 'consistent' : 'inconsistent'}
-            </div>
-          </div>
+            </p>
+          </section>
         );
       };
 
@@ -542,14 +542,14 @@ describe('UnifiedAuthProvider', () => {
         const auth = useUnifiedAuth();
         
         return (
-          <div>
-            <div data-testid="rbac-enabled">
+          <section>
+            <p data-testid="rbac-enabled">
               {auth.isAuthenticated ? 'enabled' : 'disabled'}
-            </div>
-            <div data-testid="session-available">
+            </p>
+            <p data-testid="session-available">
               {auth.session ? 'available' : 'unavailable'}
-            </div>
-          </div>
+            </p>
+          </section>
         );
       };
 
@@ -564,7 +564,7 @@ describe('UnifiedAuthProvider', () => {
         expect(screen.getByTestId('rbac-enabled')).toHaveTextContent('enabled');
       }, { timeout: 3000 });
       
-      expect(screen.getByTestId('session-available')).toBeInTheDocument();
+      expect(screen.getByTestId('session-available')).toBeDefined();
     });
 
     it('configures inactivity tracking when enabled', () => {
@@ -572,14 +572,14 @@ describe('UnifiedAuthProvider', () => {
         const auth = useUnifiedAuth();
         
         return (
-          <div>
-            <div data-testid="inactivity-config">
+          <section>
+            <p data-testid="inactivity-config">
               {auth.isLoading ? 'configuring' : 'configured'}
-            </div>
-            <div data-testid="context-complete">
+            </p>
+            <p data-testid="context-complete">
               {auth.user && auth.session ? 'complete' : 'incomplete'}
-            </div>
-          </div>
+            </p>
+          </section>
         );
       };
 
@@ -589,7 +589,7 @@ describe('UnifiedAuthProvider', () => {
         </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('inactivity-config')).toBeInTheDocument();
+      expect(screen.getByTestId('inactivity-config')).toBeDefined();
       expect(screen.getByTestId('context-complete')).toHaveTextContent('complete');
     });
   });

package/src/providers/services/EventServiceProvider.tsx

@@ -73,16 +73,7 @@ export function EventServiceProvider({
   useEffect(() => {
     let isMounted = true;
 
-    logger.debug('EventServiceProvider', 'useEffect triggered', {
-      hasUser: !!user,
-      userId: user?.id,
-      hasSession: !!session,
-      appName,
-      isInitializing: initializingRef.current
-    });
-
     if (initializingRef.current) {
-      logger.debug('EventServiceProvider', 'Skipping - already initializing');
       return;
     }
 
@@ -90,14 +81,6 @@ export function EventServiceProvider({
       initializingRef.current = true;
 
       try {
-        logger.debug('EventServiceProvider', 'Updating dependencies and initializing', {
-          hasUser: !!user,
-          userId: user?.id,
-          hasSession: !!session,
-          appName,
-          hasSelectedOrganisation: !!selectedOrganisation
-        });
-
         // Update dependencies (now async to handle user change cleanup)
         await eventService.updateDependencies(supabaseClient, user, session, appName, selectedOrganisation, setSelectedEventId);
 
@@ -106,19 +89,13 @@ export function EventServiceProvider({
         // Re-initialize service when dependencies change
         // Only initialize if we have a user (required for fetching events)
         if (user && session && supabaseClient && appName) {
-          logger.debug('EventServiceProvider', 'Initializing event service');
           await eventService.initialize().catch(error => {
             if (isMounted) {
               logger.error('EventServiceProvider', 'Failed to initialize event service:', error);
             }
           });
         } else {
-          logger.debug('EventServiceProvider', 'Skipping initialization - missing required dependencies', {
-            hasUser: !!user,
-            hasSession: !!session,
-            hasSupabaseClient: !!supabaseClient,
-            appName
-          });
+          // Skipping initialization - missing required dependencies
         }
       } finally {
         initializingRef.current = false;

package/src/providers/services/UnifiedAuthProvider.tsx

@@ -198,23 +198,10 @@ function UnifiedAuthContextProvider({
   
   // App config removed - scope is now page-level only (rbac_app_pages.scope_type)
 
-  // Try to get event service, but provide fallback if not available
-  let eventService;
-  try {
-    eventService = useEventService();
-  } catch (error) {
-    // EventService not available - provide fallback implementation
-    // Include subscribe method to match BaseService interface
-    eventService = {
-      getEvents: () => [],
-      getSelectedEvent: () => null,
-      isLoading: () => false,
-      getError: () => null,
-      setSelectedEvent: () => {},
-      refreshEvents: async () => {},
-      subscribe: () => () => {} // No-op subscribe/unsubscribe for fallback
-    };
-  }
+  // Call hook unconditionally - if provider is missing, it will throw
+  // Errors should be handled by error boundaries at a higher level
+  // We cannot conditionally call hooks
+  const eventService = useEventService();
 
   // Get current auth state - these will trigger re-renders when services change
   const currentUser = authService.getUser();
@@ -232,14 +219,6 @@ function UnifiedAuthContextProvider({
   // This makes appId available early for navigation menu filtering
   const [appId, setAppId] = useState<string | undefined>(undefined);
   
-  useEffect(() => {
-    logger.debug('UnifiedAuthContextProvider', `Rendering [AuthService ID:${authService.getInstanceId?.() || 'unknown'}]`, {
-      hasUser: !!currentUser,
-      userId: currentUser?.id,
-      hasSession: !!currentSession,
-      isAuth
-    });
-  }, [currentUser?.id, currentSession?.access_token, isAuth, authService]);
 
   const isResolvingAppIdRef = useRef(false);
   const resolvedAppIdRef = useRef<string | undefined>(undefined);
@@ -668,12 +647,7 @@ function EventServiceProviderWrapper({
   }, []);
 
   useEffect(() => {
-    logger.debug('EventServiceProviderWrapper', 'Rendering with props', {
-      hasUser: !!user,
-      userId: user?.id,
-      hasSession: !!session,
-      selectedOrganisationId: selectedOrganisation?.id
-    });
+    // Render tracking removed for performance
   }, [user?.id, session?.access_token, selectedOrganisation?.id]);
 
   return (
@@ -720,12 +694,6 @@ function ServiceAwareProviders({
       const newUser = authService.getUser();
       const newSession = authService.getSession();
       
-      logger.debug('ServiceAwareProviders', 'Auth service notified, updating state', {
-        hasUser: !!newUser,
-        userId: newUser?.id,
-        hasSession: !!newSession
-      });
-      
       setUserState(newUser);
       setSessionState(newSession);
     });
@@ -737,15 +705,6 @@ function ServiceAwareProviders({
   const user = userState;
   const session = sessionState;
   
-  // Log when user/session changes for debugging
-  useEffect(() => {
-    logger.debug('ServiceAwareProviders', `User/session state [AuthService ID:${authService.getInstanceId?.() || 'unknown'}]`, {
-      hasUser: !!user,
-      userId: user?.id,
-      hasSession: !!session,
-      sessionToken: session?.access_token ? 'present' : 'missing'
-    });
-  }, [user?.id, session?.access_token, authService]);
 
   return (
     <OrganisationServiceProvider
@@ -824,8 +783,6 @@ export function UnifiedAuthProvider({
         note: 'Ensure you create the Supabase client once and reuse it. Creating multiple clients can cause performance issues and the "Multiple GoTrueClient instances" warning.'
       });
       clientRef.current = supabaseClient;
-    } else {
-      logger.debug('UnifiedAuthProvider', 'Supabase client reference is stable');
     }
   }, [supabaseClient]);
 

package/src/providers/services/__tests__/AuthServiceProvider.integration.test.tsx

@@ -67,12 +67,12 @@ function TestComponent() {
   }, [authService]);
   
   return (
-    <div>
-      <div data-testid="user-id">{authService.getUser()?.id || 'no-user'}</div>
-      <div data-testid="is-authenticated">{authService.isAuthenticated().toString()}</div>
-      <div data-testid="is-loading">{authService.isLoading().toString()}</div>
-      <div data-testid="error">{authService.getError()?.message || 'no-error'}</div>
-    </div>
+    <section>
+      <p data-testid="user-id">{authService.getUser()?.id || 'no-user'}</p>
+      <p data-testid="is-authenticated">{authService.isAuthenticated().toString()}</p>
+      <p data-testid="is-loading">{authService.isLoading().toString()}</p>
+      <p data-testid="error">{authService.getError()?.message || 'no-error'}</p>
+    </section>
   );
 }
 
@@ -198,7 +198,7 @@ describe('AuthServiceProvider Integration', () => {
       // The subscription is set up in useEffect, so we need to wait for that
       await waitFor(() => {
         // Check if subscription is set up by verifying the component has rendered
-        expect(screen.getByTestId('user-id')).toBeInTheDocument();
+        expect(screen.getByTestId('user-id')).toBeDefined();
       }, { interval: 10, timeout: 1000 });
 
       // Wait a bit more to ensure subscription is fully set up

package/src/providers/services/__tests__/UnifiedAuthProvider.integration.test.tsx

@@ -14,6 +14,9 @@ import { UnifiedAuthProvider, useUnifiedAuth } from '../UnifiedAuthProvider';
 import { type SupabaseClient, type User, type Session } from '@supabase/supabase-js';
 import { Logger, LogLevel } from '../../../utils/core/logger';
 
+// Unmock UnifiedAuthProvider to test the real implementation
+vi.unmock('../../../providers/services/UnifiedAuthProvider');
+
 // Mock Supabase client
 const createMockSupabaseClient = (): SupabaseClient => ({
   auth: {
@@ -58,16 +61,16 @@ function TestComponent() {
   const auth = useUnifiedAuth();
   
   return (
-    <div>
-      <div data-testid="user-id">{auth.user?.id || 'no-user'}</div>
-      <div data-testid="is-authenticated">{auth.isAuthenticated.toString()}</div>
-      <div data-testid="is-loading">{auth.isLoading.toString()}</div>
-      <div data-testid="app-name">{auth.appName}</div>
-       <div data-testid="permissions-count">{0}</div>
-       <div data-testid="roles-count">{0}</div>
-      <div data-testid="organisations-count">{auth.organisations.length}</div>
-      <div data-testid="events-count">{auth.events.length}</div>
-    </div>
+    <section>
+      <p data-testid="user-id">{auth.user?.id || 'no-user'}</p>
+      <p data-testid="is-authenticated">{auth.isAuthenticated.toString()}</p>
+      <p data-testid="is-loading">{auth.isLoading.toString()}</p>
+      <p data-testid="app-name">{auth.appName}</p>
+       <p data-testid="permissions-count">{0}</p>
+       <p data-testid="roles-count">{0}</p>
+      <p data-testid="organisations-count">{auth.organisations.length}</p>
+      <p data-testid="events-count">{auth.events.length}</p>
+    </section>
   );
 }