@jmruthers/pace-core 0.5.73 → 0.5.75

package/src/hooks/__tests__/useIsMobile.unit.test.ts

@@ -0,0 +1,117 @@
+/**
+ * @file useIsMobile Hook Unit Tests
+ * @package @jmruthers/pace-core
+ * @module Hooks/__tests__/useIsMobile
+ * @since 0.4.0
+ * 
+ * Comprehensive tests for the useIsMobile hook covering all critical functionality.
+ */
+
+import { renderHook } from '@testing-library/react';
+import { vi, describe, it, expect, beforeEach } from 'vitest';
+import { useIsMobile } from '../useIsMobile';
+
+describe('useIsMobile', () => {
+  beforeEach(() => {
+    vi.clearAllMocks();
+    // Reset window properties for each test
+    Object.defineProperty(window, 'innerWidth', {
+      writable: true,
+      configurable: true,
+      value: 1024
+    });
+  });
+
+  describe('Initial detection', () => {
+    it('detects mobile viewport initially', () => {
+      window.innerWidth = 500;
+      
+      const mql = {
+        matches: true,
+        media: '(max-width: 767px)',
+        onchange: null,
+        addEventListener: vi.fn(),
+        removeEventListener: vi.fn(),
+        addListener: vi.fn(),
+        removeListener: vi.fn(),
+        dispatchEvent: vi.fn()
+      };
+
+      window.matchMedia = vi.fn(() => mql) as any;
+
+      const { result } = renderHook(() => useIsMobile());
+
+      expect(result.current).toBe(true);
+    });
+
+    it('detects desktop viewport initially', () => {
+      window.innerWidth = 1200;
+      
+      const mql = {
+        matches: false,
+        media: '(max-width: 767px)',
+        onchange: null,
+        addEventListener: vi.fn(),
+        removeEventListener: vi.fn(),
+        addListener: vi.fn(),
+        removeListener: vi.fn(),
+        dispatchEvent: vi.fn()
+      };
+
+      window.matchMedia = vi.fn(() => mql) as any;
+
+      const { result } = renderHook(() => useIsMobile());
+
+      expect(result.current).toBe(false);
+    });
+  });
+
+  describe('Event listener management', () => {
+    it('registers event listener for media query changes', () => {
+      const addEventListener = vi.fn();
+      const removeEventListener = vi.fn();
+
+      const mql = {
+        matches: false,
+        media: '(max-width: 767px)',
+        onchange: null,
+        addEventListener,
+        removeEventListener,
+        addListener: vi.fn(),
+        removeListener: vi.fn(),
+        dispatchEvent: vi.fn()
+      };
+
+      window.matchMedia = vi.fn(() => mql) as any;
+
+      const { unmount } = renderHook(() => useIsMobile());
+
+      expect(addEventListener).toHaveBeenCalledWith('change', expect.any(Function));
+      
+      unmount();
+      
+      expect(removeEventListener).toHaveBeenCalledWith('change', expect.any(Function));
+    });
+  });
+
+  describe('Hook returns boolean', () => {
+    it('returns a boolean value', () => {
+      const mql = {
+        matches: false,
+        media: '(max-width: 767px)',
+        onchange: null,
+        addEventListener: vi.fn(),
+        removeEventListener: vi.fn(),
+        addListener: vi.fn(),
+        removeListener: vi.fn(),
+        dispatchEvent: vi.fn()
+      };
+
+      window.matchMedia = vi.fn(() => mql) as any;
+
+      const { result } = renderHook(() => useIsMobile());
+
+      expect(typeof result.current).toBe('boolean');
+    });
+  });
+});

package/src/hooks/__tests__/useKeyboardShortcuts.unit.test.ts

@@ -0,0 +1,295 @@
+/**
+ * @file useKeyboardShortcuts Hook Unit Tests
+ * @package @jmruthers/pace-core
+ * @module Hooks/__tests__/useKeyboardShortcuts
+ * @since 0.4.0
+ * 
+ * Comprehensive tests for the useKeyboardShortcuts hook covering all critical functionality.
+ */
+
+import { renderHook } from '@testing-library/react';
+import { vi, describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { useKeyboardShortcuts } from '../useKeyboardShortcuts';
+import { fireEvent } from '@testing-library/react';
+
+describe('useKeyboardShortcuts', () => {
+  let mockElement: HTMLElement;
+  let addEventListenerSpy: ReturnType<typeof vi.spyOn>;
+  let removeEventListenerSpy: ReturnType<typeof vi.spyOn>;
+
+  beforeEach(() => {
+    mockElement = document.createElement('div');
+    addEventListenerSpy = vi.spyOn(document, 'addEventListener');
+    removeEventListenerSpy = vi.spyOn(document, 'removeEventListener');
+  });
+
+  afterEach(() => {
+    addEventListenerSpy.mockRestore();
+    removeEventListenerSpy.mockRestore();
+    vi.clearAllMocks();
+  });
+
+  describe('Event listener registration', () => {
+    it('registers keydown event listener on document', () => {
+      const shortcuts = [
+        {
+          key: 'Escape',
+          handler: vi.fn()
+        }
+      ];
+
+      renderHook(() => useKeyboardShortcuts(shortcuts));
+
+      expect(addEventListenerSpy).toHaveBeenCalledWith('keydown', expect.any(Function));
+    });
+
+    it('unregisters event listener on unmount', () => {
+      const shortcuts = [
+        {
+          key: 'Escape',
+          handler: vi.fn()
+        }
+      ];
+
+      const { unmount } = renderHook(() => useKeyboardShortcuts(shortcuts));
+      unmount();
+
+      expect(removeEventListenerSpy).toHaveBeenCalled();
+    });
+
+    it('registers listener on custom element', () => {
+      const mockAddEventListener = vi.fn();
+      const mockRemoveEventListener = vi.fn();
+      
+      const customElement = {
+        addEventListener: mockAddEventListener,
+        removeEventListener: mockRemoveEventListener
+      } as any;
+
+      const shortcuts = [
+        {
+          key: 'Escape',
+          handler: vi.fn()
+        }
+      ];
+
+      renderHook(() => useKeyboardShortcuts(shortcuts, { element: customElement }));
+
+      expect(mockAddEventListener).toHaveBeenCalledWith('keydown', expect.any(Function));
+    });
+  });
+
+  describe('Keyboard shortcut handling', () => {
+    it('triggers handler when Escape key is pressed', () => {
+      const handler = vi.fn();
+      const shortcuts = [
+        {
+          key: 'Escape',
+          handler
+        }
+      ];
+
+      renderHook(() => useKeyboardShortcuts(shortcuts));
+
+      const event = new KeyboardEvent('keydown', { key: 'Escape' });
+      document.dispatchEvent(event);
+
+      expect(handler).toHaveBeenCalledTimes(1);
+      expect(handler).toHaveBeenCalledWith(expect.objectContaining({ key: 'Escape' }));
+    });
+
+    it('does not trigger handler for wrong key', () => {
+      const handler = vi.fn();
+      const shortcuts = [
+        {
+          key: 'Escape',
+          handler
+        }
+      ];
+
+      renderHook(() => useKeyboardShortcuts(shortcuts));
+
+      const event = new KeyboardEvent('keydown', { key: 'Enter' });
+      document.dispatchEvent(event);
+
+      expect(handler).not.toHaveBeenCalled();
+    });
+
+    it('triggers handler for Enter key', () => {
+      const handler = vi.fn();
+      const shortcuts = [
+        {
+          key: 'Enter',
+          handler
+        }
+      ];
+
+      renderHook(() => useKeyboardShortcuts(shortcuts));
+
+      const event = new KeyboardEvent('keydown', { key: 'Enter' });
+      document.dispatchEvent(event);
+
+      expect(handler).toHaveBeenCalledTimes(1);
+    });
+
+    it('handles multiple shortcuts and triggers the first matching one', () => {
+      const handler1 = vi.fn();
+      const handler2 = vi.fn();
+      
+      const shortcuts = [
+        {
+          key: 'Escape',
+          handler: handler1
+        },
+        {
+          key: 'Escape',
+          handler: handler2
+        }
+      ];
+
+      renderHook(() => useKeyboardShortcuts(shortcuts));
+
+      const event = new KeyboardEvent('keydown', { key: 'Escape' });
+      document.dispatchEvent(event);
+
+      expect(handler1).toHaveBeenCalledTimes(1);
+      expect(handler2).not.toHaveBeenCalled();
+    });
+  });
+
+  describe('Modifier key combinations', () => {
+    it('handles Ctrl+key combination', () => {
+      const handler = vi.fn();
+      const shortcuts = [
+        {
+          key: 'ctrl+s',
+          handler
+        }
+      ];
+
+      renderHook(() => useKeyboardShortcuts(shortcuts));
+
+      const event = new KeyboardEvent('keydown', {
+        key: 's',
+        ctrlKey: true,
+        bubbles: true
+      });
+      document.dispatchEvent(event);
+
+      expect(handler).toHaveBeenCalledTimes(1);
+    });
+
+    it('does not trigger when modifiers do not match', () => {
+      const handler = vi.fn();
+      const shortcuts = [
+        {
+          key: 'ctrl+s',
+          handler
+        }
+      ];
+
+      renderHook(() => useKeyboardShortcuts(shortcuts));
+
+      const event = new KeyboardEvent('keydown', {
+        key: 's',
+        ctrlKey: false,
+        bubbles: true
+      });
+      document.dispatchEvent(event);
+
+      expect(handler).not.toHaveBeenCalled();
+    });
+  });
+
+  describe('Options', () => {
+    it('does not register listeners when disabled', () => {
+      const shortcuts = [
+        {
+          key: 'Escape',
+          handler: vi.fn()
+        }
+      ];
+
+      renderHook(() => useKeyboardShortcuts(shortcuts, { enabled: false }));
+
+      const event = new KeyboardEvent('keydown', { key: 'Escape' });
+      document.dispatchEvent(event);
+
+      expect(addEventListenerSpy).not.toHaveBeenCalled();
+    });
+
+    it('skips disabled shortcuts', () => {
+      const handler = vi.fn();
+      const shortcuts = [
+        {
+          key: 'Escape',
+          handler,
+          enabled: false
+        }
+      ];
+
+      renderHook(() => useKeyboardShortcuts(shortcuts));
+
+      const event = new KeyboardEvent('keydown', { key: 'Escape' });
+      document.dispatchEvent(event);
+
+      expect(handler).not.toHaveBeenCalled();
+    });
+
+    it('calls preventDefault when option is set', () => {
+      const handler = vi.fn();
+      const shortcuts = [
+        {
+          key: 'Escape',
+          handler,
+          preventDefault: true
+        }
+      ];
+
+      renderHook(() => useKeyboardShortcuts(shortcuts));
+
+      const event = new KeyboardEvent('keydown', { key: 'Escape', cancelable: true });
+      document.dispatchEvent(event);
+
+      expect(handler).toHaveBeenCalled();
+      // Note: preventDefault() is called on the event object by the handler
+    });
+  });
+
+  describe('Case insensitivity', () => {
+    it('handles lowercase key correctly', () => {
+      const handler = vi.fn();
+      const shortcuts = [
+        {
+          key: 'escape',
+          handler
+        }
+      ];
+
+      renderHook(() => useKeyboardShortcuts(shortcuts));
+
+      const event = new KeyboardEvent('keydown', { key: 'Escape' });
+      document.dispatchEvent(event);
+
+      expect(handler).toHaveBeenCalledTimes(1);
+    });
+
+    it('handles uppercase key correctly', () => {
+      const handler = vi.fn();
+      const shortcuts = [
+        {
+          key: 'ESCAPE',
+          handler
+        }
+      ];
+
+      renderHook(() => useKeyboardShortcuts(shortcuts));
+
+      const event = new KeyboardEvent('keydown', { key: 'Escape' });
+      document.dispatchEvent(event);
+
+      expect(handler).toHaveBeenCalledTimes(1);
+    });
+  });
+});
+

package/src/hooks/__tests__/useOrganisationSecurity.unit.test.tsx

@@ -1,11 +1,20 @@
 import { renderHook, act } from '@testing-library/react';
 import { vi, describe, it, expect, beforeEach } from 'vitest';
 import { useOrganisationSecurity } from '../useOrganisationSecurity';
-import { useUnifiedAuth } from '../../providers/UnifiedAuthProvider';
-import { useOrganisations } from '../../providers/OrganisationProvider';
+import { useUnifiedAuth } from '../../providers';
+import { useOrganisations } from '../../hooks/useOrganisations';
 // Mock dependencies
-vi.mock('../../providers/UnifiedAuthProvider');
-vi.mock('../../providers/OrganisationProvider');
+vi.mock('../../providers', () => ({
+  useUnifiedAuth: vi.fn(),
+}));
+
+vi.mock('../../providers/services/UnifiedAuthProvider', () => ({
+  useUnifiedAuth: vi.fn(),
+}));
+
+vi.mock('../../hooks/useOrganisations', () => ({
+  useOrganisations: vi.fn(),
+}));
 
 // Mock the RBAC API
 vi.mock('../../rbac/api', () => ({
@@ -45,16 +54,17 @@ describe('useOrganisationSecurity', () => {
     it('should detect super admin from user metadata', () => {
       const mockUser = {
         id: 'user-123',
-        user_metadata: { globalRole: 'super_admin' }
+        user_metadata: { globalRole: 'super_admin' },
+        app_metadata: { globalRole: 'super_admin' }
       };
       vi.mocked(useUnifiedAuth).mockReturnValue({
         ...mockUseUnifiedAuth,
         user: mockUser
       } as any);
-      // Global role now derived from user metadata directly
 
       const { result } = renderHook(() => useOrganisationSecurity());
-
+      
+      console.log('User metadata:', result.current);
       expect(result.current.superAdminContext.isSuperAdmin).toBe(true);
       expect(result.current.superAdminContext.hasGlobalAccess).toBe(true);
       expect(result.current.superAdminContext.canManageAllOrganisations).toBe(true);
@@ -98,7 +108,8 @@ describe('useOrganisationSecurity', () => {
     it('should return true for super admin', async () => {
       const mockUser = {
         id: 'user-123',
-        user_metadata: { globalRole: 'super_admin' }
+        user_metadata: { globalRole: 'super_admin' },
+        app_metadata: { globalRole: 'super_admin' }
       };
       const mockSession = { access_token: 'test-token' };
       const mockSupabase = { from: vi.fn() };
@@ -109,7 +120,6 @@ describe('useOrganisationSecurity', () => {
         session: mockSession,
         supabase: mockSupabase
       } as any);
-      // Global role now derived from user metadata directly
 
       const { result } = renderHook(() => useOrganisationSecurity());
 
@@ -213,13 +223,13 @@ describe('useOrganisationSecurity', () => {
     it('should return true for super admin regardless of role', () => {
       const mockUser = {
         id: 'user-123',
-        user_metadata: { globalRole: 'super_admin' }
+        user_metadata: { globalRole: 'super_admin' },
+        app_metadata: { globalRole: 'super_admin' }
       };
       vi.mocked(useUnifiedAuth).mockReturnValue({
         ...mockUseUnifiedAuth,
         user: mockUser
       } as any);
-      // Global role now derived from user metadata directly
 
       const { result } = renderHook(() => useOrganisationSecurity());
 
@@ -273,13 +283,13 @@ describe('useOrganisationSecurity', () => {
     it('should return true for super admin', () => {
       const mockUser = {
         id: 'user-123',
-        user_metadata: { globalRole: 'super_admin' }
+        user_metadata: { globalRole: 'super_admin' },
+        app_metadata: { globalRole: 'super_admin' }
       };
       vi.mocked(useUnifiedAuth).mockReturnValue({
         ...mockUseUnifiedAuth,
         user: mockUser
       } as any);
-      // Global role now derived from user metadata directly
 
       const { result } = renderHook(() => useOrganisationSecurity());
 
@@ -331,7 +341,8 @@ describe('useOrganisationSecurity', () => {
     it('should return true for super admin', async () => {
       const mockUser = {
         id: 'user-123',
-        user_metadata: { globalRole: 'super_admin' }
+        user_metadata: { globalRole: 'super_admin' },
+        app_metadata: { globalRole: 'super_admin' }
       };
       const mockSupabase = { rpc: vi.fn() };
       
@@ -340,7 +351,6 @@ describe('useOrganisationSecurity', () => {
         user: mockUser,
         supabase: mockSupabase
       } as any);
-      // Global role now derived from user metadata directly
 
       const { result } = renderHook(() => useOrganisationSecurity());
 
@@ -476,7 +486,8 @@ describe('useOrganisationSecurity', () => {
     it('should return all permissions for super admin', async () => {
       const mockUser = {
         id: 'user-123',
-        user_metadata: { globalRole: 'super_admin' }
+        user_metadata: { globalRole: 'super_admin' },
+        app_metadata: { globalRole: 'super_admin' }
       };
       const mockSupabase = { rpc: vi.fn() };
       
@@ -485,7 +496,6 @@ describe('useOrganisationSecurity', () => {
         user: mockUser,
         supabase: mockSupabase
       } as any);
-      // Global role now derived from user metadata directly
 
       const { result } = renderHook(() => useOrganisationSecurity());
 
@@ -744,7 +754,8 @@ describe('useOrganisationSecurity', () => {
     it('should return true for super admin', async () => {
       const mockUser = {
         id: 'user-123',
-        user_metadata: { globalRole: 'super_admin' }
+        user_metadata: { globalRole: 'super_admin' },
+        app_metadata: { globalRole: 'super_admin' }
       };
       const mockSupabase = { from: vi.fn() };
       
@@ -753,7 +764,6 @@ describe('useOrganisationSecurity', () => {
         user: mockUser,
         supabase: mockSupabase
       } as any);
-      // Global role now derived from user metadata directly
 
       const { result } = renderHook(() => useOrganisationSecurity());
 

package/src/hooks/__tests__/useRBAC.unit.test.ts

@@ -8,15 +8,19 @@ const mockUseUnifiedAuth = vi.fn();
 const mockUseOrganisations = vi.fn();
 const mockUseEvents = vi.fn();
 
-vi.mock('../../providers/UnifiedAuthProvider', () => ({
+vi.mock('../../providers', () => ({
   useUnifiedAuth: () => mockUseUnifiedAuth()
 }));
 
-vi.mock('../../providers/OrganisationProvider', () => ({
+vi.mock('../../providers/services/UnifiedAuthProvider', () => ({
+  useUnifiedAuth: () => mockUseUnifiedAuth()
+}));
+
+vi.mock('../../hooks/useOrganisations', () => ({
   useOrganisations: () => mockUseOrganisations()
 }));
 
-vi.mock('../../providers/EventProvider', () => ({
+vi.mock('../../hooks/useEvents', () => ({
   useEvents: () => mockUseEvents()
 }));