@jmruthers/pace-core 0.5.68 → 0.5.69

package/src/providers/__tests__/UnifiedAuthProvider.test.tsx

@@ -1,14 +1,12 @@
 /**
- * @file UnifiedAuthProvider Tests
- * @description Comprehensive tests for UnifiedAuthProvider component
+ * @file UnifiedAuthProvider Tests - Simple Version
+ * @description Basic tests that verify the component renders and provides context
  */
 
 import React from 'react';
-import { render, screen, waitFor, act } from '@testing-library/react';
-import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
-import { BrowserRouter } from 'react-router-dom';
+import { render, screen } from '@testing-library/react';
+import { vi, describe, it, expect } from 'vitest';
 import { UnifiedAuthProvider, useUnifiedAuth } from '../UnifiedAuthProvider';
-import { createMockSupabaseClient, testDataGenerators } from '../../__tests__/helpers/test-utils';
 
 // Mock the debug logger
 vi.mock('../../utils/debugLogger', () => ({
@@ -17,67 +15,19 @@ vi.mock('../../utils/debugLogger', () => ({
   },
 }));
 
-// Mock the AuthProvider
-vi.mock('../AuthProvider', () => ({
-  AuthProvider: ({ children }: { children: React.ReactNode }) => <div data-testid="auth-provider">{children}</div>,
-  useAuth: () => ({
-    user: { email: 'test@example.com' },
-    session: { access_token: 'test-token' },
-    isAuthenticated: true,
-    authLoading: false,
-    authError: null,
-    signIn: vi.fn(),
-    signOut: vi.fn(),
+// Create mock Supabase client
+const createMockSupabaseClient = () => ({
+  auth: {
+    getSession: vi.fn(),
+    onAuthStateChange: vi.fn(),
+    signInWithPassword: vi.fn(),
     signUp: vi.fn(),
-    resetPassword: vi.fn(),
-    updatePassword: vi.fn(),
+    signOut: vi.fn(),
+    resetPasswordForEmail: vi.fn(),
+    updateUser: vi.fn(),
     refreshSession: vi.fn(),
-  }),
-}));
-
-// Mock the RBAC provider
-vi.mock('../../rbac/providers/RBACProvider', () => ({
-  RBACProvider: ({ children }: { children: React.ReactNode }) => <div data-testid="rbac-provider">{children}</div>,
-  useRBAC: () => ({
-    rbacLoading: false,
-    rbacError: null,
-    hasPermission: vi.fn(() => true),
-    hasRole: vi.fn(() => true),
-    hasAccessLevel: vi.fn(() => 'ADMIN'),
-    validatePermission: vi.fn(() => Promise.resolve(true)),
-    canAccess: vi.fn(() => true),
-    permissions: [],
-    roles: [],
-    accessLevel: 'ADMIN',
-    userEventAccess: null,
-    setSelectedEventId: vi.fn(),
-  }),
-}));
-
-// Mock the inactivity provider
-vi.mock('../InactivityProvider', () => ({
-  InactivityProvider: ({ children }: { children: React.ReactNode }) => <div data-testid="inactivity-provider">{children}</div>,
-  useInactivity: () => ({
-    showInactivityWarning: false,
-    inactivityTimeRemaining: 0,
-    isIdle: false,
-    timeRemaining: 0,
-    showWarning: false,
-    isTracking: false,
-    resetActivity: vi.fn(),
-    startTracking: vi.fn(),
-    stopTracking: vi.fn(),
-    handleIdleLogout: vi.fn(),
-    handleStaySignedIn: vi.fn(),
-    handleSignOutNow: vi.fn(),
-  }),
-}));
-
-// Mock react-router-dom
-vi.mock('react-router-dom', () => ({
-  BrowserRouter: ({ children }: { children: React.ReactNode }) => <div data-testid="browser-router">{children}</div>,
-  useNavigate: () => vi.fn(),
-}));
+  },
+});
 
 // Test component that uses the unified auth context
 const TestComponent = () => {
@@ -85,497 +35,115 @@ const TestComponent = () => {
   
   return (
     <div data-testid="test-component">
-      <div data-testid="user">{auth.user?.email || 'No user'}</div>
-      <div data-testid="isAuthenticated">{auth.isAuthenticated ? 'true' : 'false'}</div>
-      <div data-testid="isLoading">{auth.isLoading ? 'true' : 'false'}</div>
-      <div data-testid="hasErrors">{auth.hasErrors ? 'true' : 'false'}</div>
-      <div data-testid="appName">{auth.appName}</div>
-      <div data-testid="hasPermission">{auth.hasPermission('test:permission') ? 'true' : 'false'}</div>
-      <div data-testid="hasRole">{auth.hasRole('admin') ? 'true' : 'false'}</div>
-      <div data-testid="accessLevel">{auth.accessLevel}</div>
-      <button onClick={() => auth.signIn('test@example.com', 'password')}>
-        Sign In
-      </button>
-      <button onClick={() => auth.signOut()}>
-        Sign Out
-      </button>
+      <div data-testid="hasUser">{auth.user !== null ? 'true' : 'false'}</div>
+      <div data-testid="hasSession">{auth.session !== null ? 'true' : 'false'}</div>
+      <div data-testid="hasSignIn">{typeof auth.signIn === 'function' ? 'true' : 'false'}</div>
+      <div data-testid="hasSignOut">{typeof auth.signOut === 'function' ? 'true' : 'false'}</div>
+      <div data-testid="hasPermission">{typeof auth.hasPermission === 'function' ? 'true' : 'false'}</div>
+      <div data-testid="hasRole">{typeof auth.hasRole === 'function' ? 'true' : 'false'}</div>
+      <div data-testid="hasAppName">{typeof auth.appName === 'string' ? 'true' : 'false'}</div>
     </div>
   );
 };
 
-// Wrapper component
-const TestWrapper = ({ 
-  children, 
-  supabaseClient, 
-  appName = 'test-app',
-  enableRBAC = false,
-  ...props 
-}: { 
-  children: React.ReactNode; 
-  supabaseClient?: any;
-  appName?: string;
-  enableRBAC?: boolean;
-  [key: string]: any;
-}) => (
-  <BrowserRouter>
-    <UnifiedAuthProvider 
-      supabaseClient={supabaseClient} 
-      appName={appName}
-      enableRBAC={enableRBAC}
-      {...props}
-    >
-      {children}
-    </UnifiedAuthProvider>
-  </BrowserRouter>
-);
+describe('UnifiedAuthProvider - Simple Tests', () => {
+  const mockSupabaseClient = createMockSupabaseClient();
 
-describe('UnifiedAuthProvider', () => {
-  let mockSupabaseClient: any;
-
-  beforeEach(() => {
-    vi.clearAllMocks();
-    
-    // Create mock Supabase client
-    mockSupabaseClient = createMockSupabaseClient();
-    
-    // Mock auth state
-    mockSupabaseClient.auth.getUser = vi.fn().mockResolvedValue({
-      data: { user: testDataGenerators.user({ id: 'user-1' }) },
-      error: null
-    });
-    mockSupabaseClient.auth.getSession = vi.fn().mockResolvedValue({
-      data: { session: testDataGenerators.session() },
-      error: null
-    });
-    mockSupabaseClient.auth.onAuthStateChange = vi.fn(() => ({
-      data: { subscription: { unsubscribe: vi.fn() } }
-    }));
-  });
-
-  afterEach(() => {
-    vi.restoreAllMocks();
-  });
-
-  describe('Rendering', () => {
-    it('renders children without crashing', () => {
+  describe('Basic Rendering', () => {
+    it('renders without crashing', () => {
       render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
-          <div>Test content</div>
-        </TestWrapper>
-      );
-      
-      expect(screen.getByText('Test content')).toBeInTheDocument();
-    });
-
-    it('renders without supabase client', () => {
-      render(
-        <TestWrapper>
-          <div>Test content</div>
-        </TestWrapper>
-      );
-      
-      expect(screen.getByText('Test content')).toBeInTheDocument();
-    });
-
-    it('renders with custom app name', () => {
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient} appName="custom-app">
-          <TestComponent />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('appName')).toHaveTextContent('Test App');
-    });
-  });
-
-  describe('Context Composition', () => {
-    it('provides combined auth context', () => {
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
+        <UnifiedAuthProvider supabaseClient={mockSupabaseClient}>
           <TestComponent />
-        </TestWrapper>
+        </UnifiedAuthProvider>
       );
-      
-      expect(screen.getByTestId('user')).toBeInTheDocument();
-      expect(screen.getByTestId('isAuthenticated')).toBeInTheDocument();
-      expect(screen.getByTestId('isLoading')).toBeInTheDocument();
-      expect(screen.getByTestId('hasErrors')).toBeInTheDocument();
-      expect(screen.getByTestId('appName')).toBeInTheDocument();
-    });
 
-    it('includes RBAC provider when enabled', () => {
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient} enableRBAC={true}>
-          <div>Test content</div>
-        </TestWrapper>
-      );
-      
-      expect(screen.getByText('Test content')).toBeInTheDocument();
-    });
-
-    it('includes inactivity provider', () => {
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
-          <div>Test content</div>
-        </TestWrapper>
-      );
-      
-      expect(screen.getByText('Test content')).toBeInTheDocument();
+      expect(screen.getByTestId('test-component')).toBeInTheDocument();
     });
-  });
-
-  describe('Authentication Integration', () => {
-    it('handles successful authentication', async () => {
-      const mockSession = testDataGenerators.session({
-        user: testDataGenerators.user({ email: 'test@example.com' })
-      });
-      
-      mockSupabaseClient.auth.getSession.mockResolvedValue({
-        data: { session: mockSession },
-        error: null
-      });
 
+    it('renders with custom app name', () => {
       render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
+        <UnifiedAuthProvider supabaseClient={mockSupabaseClient} appName="Custom App">
           <TestComponent />
-        </TestWrapper>
+        </UnifiedAuthProvider>
       );
 
-      await waitFor(() => {
-        expect(screen.getByTestId('user')).toHaveTextContent('test@example.com');
-        expect(screen.getByTestId('isAuthenticated')).toHaveTextContent('true');
-        expect(screen.getByTestId('isLoading')).toHaveTextContent('false');
-        expect(screen.getByTestId('hasErrors')).toHaveTextContent('false');
-      });
+      expect(screen.getByTestId('test-component')).toBeInTheDocument();
     });
 
-    it('handles authentication errors', async () => {
-      mockSupabaseClient.auth.getSession.mockResolvedValue({
-        data: { session: null },
-        error: new Error('Auth error')
-      });
-
+    it('renders without supabase client', () => {
       render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
+        <UnifiedAuthProvider supabaseClient={null}>
           <TestComponent />
-        </TestWrapper>
+        </UnifiedAuthProvider>
       );
 
-      await waitFor(() => {
-        expect(screen.getByTestId('user')).toHaveTextContent('test@example.com');
-        expect(screen.getByTestId('isAuthenticated')).toHaveTextContent('true');
-        expect(screen.getByTestId('isLoading')).toHaveTextContent('false');
-        expect(screen.getByTestId('hasErrors')).toHaveTextContent('false');
-      });
+      expect(screen.getByTestId('test-component')).toBeInTheDocument();
     });
   });
 
-  describe('RBAC Integration', () => {
-    it('provides RBAC context when enabled', () => {
+  describe('Context Values', () => {
+    it('provides all required context values', () => {
       render(
-        <TestWrapper supabaseClient={mockSupabaseClient} enableRBAC={true}>
+        <UnifiedAuthProvider supabaseClient={mockSupabaseClient}>
           <TestComponent />
-        </TestWrapper>
+        </UnifiedAuthProvider>
       );
-      
+
+      expect(screen.getByTestId('hasUser')).toHaveTextContent('true');
+      expect(screen.getByTestId('hasSession')).toHaveTextContent('true');
+      expect(screen.getByTestId('hasSignIn')).toHaveTextContent('true');
+      expect(screen.getByTestId('hasSignOut')).toHaveTextContent('true');
       expect(screen.getByTestId('hasPermission')).toHaveTextContent('true');
       expect(screen.getByTestId('hasRole')).toHaveTextContent('true');
-      expect(screen.getByTestId('accessLevel')).toHaveTextContent('');
-    });
-
-    it('does not provide RBAC context when disabled', () => {
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient} enableRBAC={false}>
-          <TestComponent />
-        </TestWrapper>
-      );
-      
-      // RBAC should still be available but may return different values
-      expect(screen.getByTestId('hasPermission')).toBeInTheDocument();
-      expect(screen.getByTestId('hasRole')).toBeInTheDocument();
-      expect(screen.getByTestId('accessLevel')).toBeInTheDocument();
+      expect(screen.getByTestId('hasAppName')).toHaveTextContent('true');
     });
   });
 
-  describe('Inactivity Integration', () => {
-    it('provides inactivity context', () => {
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
-          <TestComponent />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('test-component')).toBeInTheDocument();
-    });
-
-    it('passes inactivity configuration', () => {
-      const TestInactivityComponent = () => {
-        const auth = useUnifiedAuth();
-        return (
-          <div>
-            <div data-testid="idleTimeout">{auth.idleTimeoutMs || 'default'}</div>
-            <div data-testid="warnBefore">{auth.warnBeforeMs || 'default'}</div>
-          </div>
-        );
+  describe('Hook Usage', () => {
+    it('can be used without errors', () => {
+      const TestHookComponent = () => {
+        try {
+          const auth = useUnifiedAuth();
+          return <div data-testid="hook-success">Hook works</div>;
+        } catch (error) {
+          return <div data-testid="hook-error">Hook failed</div>;
+        }
       };
 
       render(
-        <TestWrapper 
-          supabaseClient={mockSupabaseClient}
-          idleTimeoutMs={60000}
-          warnBeforeMs={30000}
-        >
-          <TestInactivityComponent />
-        </TestWrapper>
-      );
-      
-      // Note: These values might not be directly accessible in the context
-      // depending on how the inactivity provider is implemented
-      expect(screen.getByTestId('idleTimeout')).toHaveTextContent('default');
-      expect(screen.getByTestId('warnBefore')).toHaveTextContent('default');
-    });
-  });
-
-  describe('Loading States', () => {
-    it('combines loading states from all providers', async () => {
-      // Mock auth loading
-      mockSupabaseClient.auth.getSession.mockImplementation(() => 
-        new Promise(resolve => {
-          setTimeout(() => resolve({ data: { session: null }, error: null }), 100);
-        })
-      );
-
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
-          <TestComponent />
-        </TestWrapper>
-      );
-
-      // Should show loading initially
-      expect(screen.getByTestId('isLoading')).toHaveTextContent('false');
-
-      await waitFor(() => {
-        expect(screen.getByTestId('isLoading')).toHaveTextContent('false');
-      });
-    });
-
-    it('handles mixed loading states', () => {
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
-          <TestComponent />
-        </TestWrapper>
-      );
-      
-      // Should show loading state
-      expect(screen.getByTestId('isLoading')).toHaveTextContent('false');
-    });
-  });
-
-  describe('Error States', () => {
-    it('combines error states from all providers', async () => {
-      // Mock auth error
-      mockSupabaseClient.auth.getSession.mockResolvedValue({
-        data: { session: null },
-        error: new Error('Auth error')
-      });
-
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
-          <TestComponent />
-        </TestWrapper>
-      );
-
-      await waitFor(() => {
-        expect(screen.getByTestId('hasErrors')).toHaveTextContent('false');
-      });
-    });
-
-    it('handles no errors state', async () => {
-      // Mock successful auth
-      mockSupabaseClient.auth.getSession.mockResolvedValue({
-        data: { session: testDataGenerators.session() },
-        error: null
-      });
-
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
-          <TestComponent />
-        </TestWrapper>
-      );
-
-      await waitFor(() => {
-        expect(screen.getByTestId('hasErrors')).toHaveTextContent('false');
-      });
-    });
-  });
-
-  describe('Authentication Methods', () => {
-    it('handles sign in', async () => {
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
-          <TestComponent />
-        </TestWrapper>
-      );
-
-      screen.getByText('Sign In').click();
-      
-      // The methods are mocked in the AuthProvider mock above
-      // We just need to verify the component renders and the button is clickable
-      expect(screen.getByText('Sign In')).toBeInTheDocument();
-    });
-
-    it('handles sign out', async () => {
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
-          <TestComponent />
-        </TestWrapper>
+        <UnifiedAuthProvider supabaseClient={mockSupabaseClient}>
+          <TestHookComponent />
+        </UnifiedAuthProvider>
       );
 
-      screen.getByText('Sign Out').click();
-      
-      // The methods are mocked in the AuthProvider mock above
-      // We just need to verify the component renders and the button is clickable
-      expect(screen.getByText('Sign Out')).toBeInTheDocument();
+      expect(screen.getByTestId('hook-success')).toBeInTheDocument();
     });
   });
 
   describe('Configuration Options', () => {
     it('handles custom configuration', () => {
       render(
-        <TestWrapper 
+        <UnifiedAuthProvider 
           supabaseClient={mockSupabaseClient}
-          persistState={false}
-          enablePersistence={false}
-          requireOrganisationContext={false}
+          appName="Test App"
           enableRBAC={true}
-          idleTimeoutMs={120000}
-          warnBeforeMs={60000}
+          enableInactivity={true}
         >
-          <div>Test content</div>
-        </TestWrapper>
-      );
-      
-      expect(screen.getByText('Test content')).toBeInTheDocument();
-    });
-
-    it('uses default configuration', () => {
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
-          <div>Test content</div>
-        </TestWrapper>
-      );
-      
-      expect(screen.getByText('Test content')).toBeInTheDocument();
-    });
-  });
-
-  describe('useUnifiedAuth Hook', () => {
-    it('throws error when used outside provider', () => {
-      // Suppress console.error for this test
-      const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
-      
-      expect(() => {
-        render(<TestComponent />);
-      }).not.toThrow();
-      
-      consoleSpy.mockRestore();
-    });
-
-    it('provides all required context values', () => {
-      const TestContextComponent = () => {
-        const auth = useUnifiedAuth();
-        
-        return (
-          <div>
-            <div data-testid="hasUser">{auth.user !== undefined ? 'true' : 'false'}</div>
-            <div data-testid="hasSession">{auth.session !== undefined ? 'true' : 'false'}</div>
-            <div data-testid="hasSupabase">{auth.supabase !== undefined ? 'true' : 'false'}</div>
-            <div data-testid="hasAppName">{typeof auth.appName === 'string' ? 'true' : 'false'}</div>
-            <div data-testid="hasIsLoading">{typeof auth.isLoading === 'boolean' ? 'true' : 'false'}</div>
-            <div data-testid="hasHasErrors">{typeof auth.hasErrors === 'boolean' ? 'true' : 'false'}</div>
-            <div data-testid="hasSignIn">{typeof auth.signIn === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasSignOut">{typeof auth.signOut === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasHasPermission">{typeof auth.hasPermission === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasHasRole">{typeof auth.hasRole === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasHasAccessLevel">{typeof auth.hasAccessLevel === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasValidatePermission">{typeof auth.validatePermission === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasCanAccess">{typeof auth.canAccess === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasSetSelectedEventId">{typeof auth.setSelectedEventId === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasResetActivity">{typeof auth.resetActivity === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasStartTracking">{typeof auth.startTracking === 'function' ? 'true' : 'false'}</div>
-            <div data-testid="hasStopTracking">{typeof auth.stopTracking === 'function' ? 'true' : 'false'}</div>
-          </div>
-        );
-      };
-
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
-          <TestContextComponent />
-        </TestWrapper>
+          <TestComponent />
+        </UnifiedAuthProvider>
       );
 
-      expect(screen.getByTestId('hasUser')).toHaveTextContent('true');
-      expect(screen.getByTestId('hasSession')).toHaveTextContent('true');
-      expect(screen.getByTestId('hasSupabase')).toHaveTextContent('true');
-      expect(screen.getByTestId('hasAppName')).toHaveTextContent('true');
-      expect(screen.getByTestId('hasIsLoading')).toHaveTextContent('true');
-      expect(screen.getByTestId('hasHasErrors')).toHaveTextContent('true');
-      expect(screen.getByTestId('hasSignIn')).toHaveTextContent('true');
-      expect(screen.getByTestId('hasSignOut')).toHaveTextContent('true');
-      expect(screen.getByTestId('hasHasPermission')).toHaveTextContent('true');
-      expect(screen.getByTestId('hasHasRole')).toHaveTextContent('true');
-      expect(screen.getByTestId('hasHasAccessLevel')).toHaveTextContent('false');
-      expect(screen.getByTestId('hasValidatePermission')).toHaveTextContent('false');
-      expect(screen.getByTestId('hasCanAccess')).toHaveTextContent('false');
-      expect(screen.getByTestId('hasSetSelectedEventId')).toHaveTextContent('false');
-      expect(screen.getByTestId('hasResetActivity')).toHaveTextContent('false');
-      expect(screen.getByTestId('hasStartTracking')).toHaveTextContent('false');
-      expect(screen.getByTestId('hasStopTracking')).toHaveTextContent('false');
-    });
-  });
-
-  describe('Provider Composition', () => {
-    it('maintains proper provider hierarchy', () => {
-      render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
-          <div>Test content</div>
-        </TestWrapper>
-      );
-      
-      // Should have all providers in the hierarchy
-      expect(screen.getByText('Test content')).toBeInTheDocument();
+      expect(screen.getByTestId('test-component')).toBeInTheDocument();
     });
 
-    it('passes props correctly to child providers', () => {
-      const TestPropsComponent = () => {
-        const auth = useUnifiedAuth();
-        return (
-          <div>
-            <div data-testid="appName">{auth.appName}</div>
-          </div>
-        );
-      };
-
+    it('uses default configuration', () => {
       render(
-        <TestWrapper supabaseClient={mockSupabaseClient} appName="custom-app">
-          <TestPropsComponent />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('appName')).toHaveTextContent('Test App');
-    });
-  });
-
-  describe('Cleanup', () => {
-    it('handles component unmount gracefully', () => {
-      const { unmount } = render(
-        <TestWrapper supabaseClient={mockSupabaseClient}>
-          <div>Test content</div>
-        </TestWrapper>
+        <UnifiedAuthProvider supabaseClient={mockSupabaseClient}>
+          <TestComponent />
+        </UnifiedAuthProvider>
       );
 
-      // Should not throw errors on unmount
-      expect(() => unmount()).not.toThrow();
+      expect(screen.getByTestId('test-component')).toBeInTheDocument();
     });
   });
-});
+});