@jmruthers/pace-core 0.5.54 → 0.5.56

package/src/hooks/__tests__/useRBAC.unit.test.ts

@@ -23,11 +23,39 @@ vi.mock('../../providers/EventProvider', () => ({
 // Mock Supabase client
 const mockSupabase = createMockSupabaseClient();
 
-// Ensure rpc is properly mocked
-vi.spyOn(mockSupabase, 'rpc').mockResolvedValue({
-  data: { permissions: {}, roles: [], access_level: 'viewer' },
-  error: null
-});
+// Helper to setup RPC mocks for useRBAC hook
+// useRBAC makes TWO RPC calls: rbac_app_resolve and rbac_permissions_get
+const setupRBACMock = (permissions: any[] = []) => {
+  mockSupabase.rpc.mockImplementation((functionName: string, params?: any) => {
+    if (functionName === 'rbac_app_resolve') {
+      return Promise.resolve({
+        data: [{
+          app_id: 'test-app-id',
+          app_name: 'test-app',
+          has_access: true,
+          is_active: true
+        }],
+        error: null
+      });
+    }
+    
+    if (functionName === 'rbac_permissions_get') {
+      return Promise.resolve({
+        data: permissions,
+        error: null
+      });
+    }
+    
+    if (functionName === 'rbac_page_access_check') {
+      return Promise.resolve({ data: true, error: null });
+    }
+    
+    return Promise.resolve({ data: null, error: null });
+  });
+};
+
+// Setup default RPC mock
+setupRBACMock();
 
 describe('useRBAC', () => {
   beforeEach(() => {
@@ -111,10 +139,7 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
+      setupRBACMock(mockPermissions);
 
       const { result } = renderHook(() => useRBAC());
 
@@ -135,10 +160,7 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
+      setupRBACMock(mockPermissions);
 
       const { result } = renderHook(() => useRBAC());
 
@@ -159,11 +181,9 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
-
+      
+      setupRBACMock(mockPermissions);
+      
       const { result } = renderHook(() => useRBAC());
 
       await waitFor(() => {
@@ -195,11 +215,9 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
-
+      
+      setupRBACMock(mockPermissions);
+      
       const { result } = renderHook(() => useRBAC());
 
       await waitFor(() => {
@@ -236,11 +254,9 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
-
+      
+      setupRBACMock(mockPermissions);
+      
       const { result } = renderHook(() => useRBAC());
 
       await waitFor(() => {
@@ -261,15 +277,22 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc
-        .mockResolvedValueOnce({
-          data: mockPermissions,
-          error: null
-        })
-        .mockResolvedValueOnce({
-          data: true,
-          error: null
-        });
+      // Fully mock RPC responses for this test
+      mockSupabase.rpc.mockImplementation((functionName: string, params?: any) => {
+        if (functionName === 'rbac_app_resolve') {
+          return Promise.resolve({
+            data: [{ app_id: 'test-app-id', app_name: 'test-app', has_access: true, is_active: true }],
+            error: null
+          });
+        }
+        if (functionName === 'rbac_permissions_get') {
+          return Promise.resolve({ data: mockPermissions, error: null });
+        }
+        if (functionName === 'rbac_page_access_check') {
+          return Promise.resolve({ data: true, error: null });
+        }
+        return Promise.resolve({ data: null, error: null });
+      });
 
       const { result } = renderHook(() => useRBAC());
 
@@ -279,7 +302,7 @@ describe('useRBAC', () => {
 
       const hasPermission = await result.current.hasPermission('read', 'dashboard');
       expect(hasPermission).toBe(true);
-      expect(mockSupabase.rpc).toHaveBeenCalledWith('check_page_permission', {
+      expect(mockSupabase.rpc).toHaveBeenCalledWith('rbac_page_access_check', {
         p_user_id: 'test-user-id',
         p_app_id: 'test-app-id',
         p_page_id: 'dashboard',
@@ -299,15 +322,22 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc
-        .mockResolvedValueOnce({
-          data: mockPermissions,
-          error: null
-        })
-        .mockResolvedValueOnce({
-          data: false,
-          error: null
-        });
+      // Fully mock RPC responses for this test
+      mockSupabase.rpc.mockImplementation((functionName: string, params?: any) => {
+        if (functionName === 'rbac_app_resolve') {
+          return Promise.resolve({
+            data: [{ app_id: 'test-app-id', app_name: 'test-app', has_access: true, is_active: true }],
+            error: null
+          });
+        }
+        if (functionName === 'rbac_permissions_get') {
+          return Promise.resolve({ data: mockPermissions, error: null });
+        }
+        if (functionName === 'rbac_page_access_check') {
+          return Promise.resolve({ data: false, error: null });
+        }
+        return Promise.resolve({ data: null, error: null });
+      });
 
       const { result } = renderHook(() => useRBAC());
 
@@ -331,12 +361,22 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc
-        .mockResolvedValueOnce({
-          data: mockPermissions,
-          error: null
-        })
-        .mockRejectedValueOnce(new Error('Database error'));
+      // Fully mock RPC responses (reject on access check)
+      mockSupabase.rpc.mockImplementation((functionName: string, params?: any) => {
+        if (functionName === 'rbac_app_resolve') {
+          return Promise.resolve({
+            data: [{ app_id: 'test-app-id', app_name: 'test-app', has_access: true, is_active: true }],
+            error: null
+          });
+        }
+        if (functionName === 'rbac_permissions_get') {
+          return Promise.resolve({ data: mockPermissions, error: null });
+        }
+        if (functionName === 'rbac_page_access_check') {
+          return Promise.reject(new Error('Database error'));
+        }
+        return Promise.resolve({ data: null, error: null });
+      });
 
       const { result } = renderHook(() => useRBAC());
 
@@ -360,15 +400,22 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc
-        .mockResolvedValueOnce({
-          data: mockPermissions,
-          error: null
-        })
-        .mockResolvedValueOnce({
-          data: true,
-          error: null
-        });
+      // Fully mock RPC responses
+      mockSupabase.rpc.mockImplementation((functionName: string, params?: any) => {
+        if (functionName === 'rbac_app_resolve') {
+          return Promise.resolve({
+            data: [{ app_id: 'test-app-id', app_name: 'test-app', has_access: true, is_active: true }],
+            error: null
+          });
+        }
+        if (functionName === 'rbac_permissions_get') {
+          return Promise.resolve({ data: mockPermissions, error: null });
+        }
+        if (functionName === 'rbac_page_access_check') {
+          return Promise.resolve({ data: true, error: null });
+        }
+        return Promise.resolve({ data: null, error: null });
+      });
 
       const { result } = renderHook(() => useRBAC('default-page'));
 
@@ -378,7 +425,7 @@ describe('useRBAC', () => {
 
       await result.current.hasPermission('read');
       
-      expect(mockSupabase.rpc).toHaveBeenCalledWith('check_page_permission', {
+      expect(mockSupabase.rpc).toHaveBeenCalledWith('rbac_page_access_check', {
         p_user_id: 'test-user-id',
         p_app_id: 'test-app-id',
         p_page_id: 'default-page',
@@ -400,11 +447,9 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
-
+      
+      setupRBACMock(mockPermissions);
+      
       const { result } = renderHook(() => useRBAC());
 
       await waitFor(() => {
@@ -426,11 +471,9 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
-
+      
+      setupRBACMock(mockPermissions);
+      
       const { result } = renderHook(() => useRBAC());
 
       await waitFor(() => {
@@ -452,11 +495,9 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
-
+      
+      setupRBACMock(mockPermissions);
+      
       const { result } = renderHook(() => useRBAC());
 
       expect(result.current.hasGlobalPermission('super_admin')).toBe(false);
@@ -476,11 +517,9 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
-
+      
+      setupRBACMock(mockPermissions);
+      
       const { result } = renderHook(() => useRBAC());
 
       await waitFor(() => {
@@ -498,11 +537,9 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
-
+      
+      setupRBACMock(mockPermissions);
+      
       const { result } = renderHook(() => useRBAC());
 
       await waitFor(() => {
@@ -520,11 +557,9 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
-
+      
+      setupRBACMock(mockPermissions);
+      
       const { result } = renderHook(() => useRBAC());
 
       await waitFor(() => {
@@ -542,11 +577,9 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
-
+      
+      setupRBACMock(mockPermissions);
+      
       const { result } = renderHook(() => useRBAC());
 
       await waitFor(() => {
@@ -564,11 +597,9 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
-
+      
+      setupRBACMock(mockPermissions);
+      
       const { result } = renderHook(() => useRBAC());
 
       await waitFor(() => {
@@ -586,11 +617,9 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
-
+      
+      setupRBACMock(mockPermissions);
+      
       const { result } = renderHook(() => useRBAC());
 
       await waitFor(() => {
@@ -639,9 +668,26 @@ describe('useRBAC', () => {
     it('handles RPC errors gracefully', async () => {
       const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
       
-      mockSupabase.rpc.mockResolvedValue({
-        data: null,
-        error: { message: 'Database connection failed' }
+      // Mock the app resolve to succeed, but permissions to fail
+      mockSupabase.rpc.mockImplementation((functionName: string) => {
+        if (functionName === 'rbac_app_resolve') {
+          return Promise.resolve({
+            data: [{
+              app_id: 'test-app-id',
+              app_name: 'test-app',
+              has_access: true,
+              is_active: true
+            }],
+            error: null
+          });
+        }
+        if (functionName === 'rbac_permissions_get') {
+          return Promise.resolve({
+            data: null,
+            error: { message: 'Database connection failed' }
+          });
+        }
+        return Promise.resolve({ data: null, error: null });
       });
 
       const { result } = renderHook(() => useRBAC());
@@ -657,9 +703,26 @@ describe('useRBAC', () => {
     it('handles network errors gracefully', async () => {
       const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
       
-      mockSupabase.rpc.mockResolvedValue({
-        data: null,
-        error: { message: 'Network timeout' }
+      // Mock the app resolve to succeed, but permissions to fail
+      mockSupabase.rpc.mockImplementation((functionName: string) => {
+        if (functionName === 'rbac_app_resolve') {
+          return Promise.resolve({
+            data: [{
+              app_id: 'test-app-id',
+              app_name: 'test-app',
+              has_access: true,
+              is_active: true
+            }],
+            error: null
+          });
+        }
+        if (functionName === 'rbac_permissions_get') {
+          return Promise.resolve({
+            data: null,
+            error: { message: 'Network timeout' }
+          });
+        }
+        return Promise.resolve({ data: null, error: null });
       });
 
       const { result } = renderHook(() => useRBAC());
@@ -699,10 +762,7 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
+      setupRBACMock(mockPermissions);
 
       const { result, rerender } = renderHook(() => useRBAC());
 
@@ -721,7 +781,7 @@ describe('useRBAC', () => {
       rerender();
 
       await waitFor(() => {
-        expect(mockSupabase.rpc).toHaveBeenCalledTimes(2);
+        expect(mockSupabase.rpc).toHaveBeenCalledTimes(4);
       });
     });
 
@@ -735,10 +795,7 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
+      setupRBACMock(mockPermissions);
 
       const { result, rerender } = renderHook(() => useRBAC());
 
@@ -754,7 +811,7 @@ describe('useRBAC', () => {
       rerender();
 
       await waitFor(() => {
-        expect(mockSupabase.rpc).toHaveBeenCalledTimes(2);
+        expect(mockSupabase.rpc).toHaveBeenCalledTimes(4);
       });
     });
 
@@ -768,10 +825,7 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
+      setupRBACMock(mockPermissions);
 
       const { result, rerender } = renderHook(() => useRBAC());
 
@@ -787,7 +841,7 @@ describe('useRBAC', () => {
       rerender();
 
       await waitFor(() => {
-        expect(mockSupabase.rpc).toHaveBeenCalledTimes(2);
+        expect(mockSupabase.rpc).toHaveBeenCalledTimes(4);
       });
     });
 
@@ -808,11 +862,9 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
-
+      
+      setupRBACMock(mockPermissions);
+      
       const { result } = renderHook(() => useRBAC());
 
       expect(result.current.eventAppRole).toBeNull();
@@ -841,10 +893,11 @@ describe('useRBAC', () => {
         }
       ];
 
-      mockSupabase.rpc.mockResolvedValue({
-        data: mockPermissions,
-        error: null
-      });
+      
+
+      setupRBACMock(mockPermissions);
+
+      
 
       const { result } = renderHook(() => useRBAC());
 

package/src/hooks/public/usePublicEvent.ts

@@ -117,8 +117,8 @@ export function usePublicEvent(
   } catch {
     // Fallback to direct environment variable access if not in PublicPageProvider
     environment = {
-      supabaseUrl: (import.meta as any).env?.VITE_SUPABASE_URL || process.env.VITE_SUPABASE_URL || process.env.NEXT_PUBLIC_SUPABASE_URL || null,
-      supabaseKey: (import.meta as any).env?.VITE_SUPABASE_ANON_KEY || process.env.VITE_SUPABASE_ANON_KEY || process.env.NEXT_PUBLIC_SUPABASE_ANON_KEY || null
+      supabaseUrl: (import.meta as any).env?.VITE_SUPABASE_URL || (import.meta as any).env?.NEXT_PUBLIC_SUPABASE_URL || null,
+      supabaseKey: (import.meta as any).env?.VITE_SUPABASE_ANON_KEY || (import.meta as any).env?.NEXT_PUBLIC_SUPABASE_ANON_KEY || null
     };
   }
   

package/src/hooks/useAppConfig.ts

@@ -58,9 +58,9 @@ export function useAppConfig(): UseAppConfigReturn {
                'PACE';
       }
       // Check Node.js environment (server-side)
-      if (typeof process !== 'undefined' && process.env) {
-        return process.env.VITE_APP_NAME || 
-               process.env.NEXT_PUBLIC_APP_NAME || 
+      if (typeof import.meta !== 'undefined' && import.meta.env) {
+        return import.meta.env.VITE_APP_NAME || 
+               import.meta.env.NEXT_PUBLIC_APP_NAME || 
                'PACE';
       }
       return 'PACE';

package/src/hooks/useComponentPerformance.ts

@@ -9,7 +9,7 @@ interface PerformanceConfig {
 
 export function useComponentPerformance({ 
   componentName, 
-  enableLogging = process.env.NODE_ENV === 'development',
+  enableLogging = import.meta.env.MODE === 'development',
   threshold = 16 // 60fps = 16ms per frame
 }: PerformanceConfig) {
   const renderCount = useRef(0);

package/src/hooks/useDataTablePerformance.ts

@@ -273,7 +273,7 @@ export function useDataTablePerformance<TData extends DataRecord>({
     updateMemoryUsage();
     
     // Only set up interval in non-test environments to prevent memory leaks during testing
-    const interval = typeof process !== 'undefined' && process.env.NODE_ENV !== 'test' 
+    const interval = import.meta.env.MODE !== 'test' 
       ? setInterval(updateMemoryUsage, 5000) 
       : null;