@jmruthers/pace-core 0.5.191 → 0.6.1

package/scripts/check-pace-core-compliance.cjs

@@ -378,12 +378,20 @@ function scanFile(filePath, manifest) {
     providerSetupIssues: [],
     viteConfigIssues: [],
     routerSetupIssues: [],
-    unnecessaryWrappers: []
+    unnecessaryWrappers: [],
+    appDiscoveryIssues: []
   };
   
   const content = fs.readFileSync(filePath, 'utf8');
   const relativePath = path.relative(process.cwd(), filePath);
   
+  // Normalize path for cross-platform compatibility (handle both forward and backslash paths)
+  const normalizedPath = relativePath.replace(/\\/g, '/');
+  
+  // Skip Edge Functions - they run in Deno, not React, so React hooks aren't available
+  // Direct Supabase auth calls are the correct approach in Edge Functions
+  const isEdgeFunction = normalizedPath.includes('supabase/functions/');
+  
   // Check for restricted imports
   manifest.restrictedImports.forEach(({ module, reason }) => {
     const importPattern = new RegExp(`from\\s+['"]${module.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}['"]`, 'g');
@@ -513,9 +521,11 @@ function scanFile(filePath, manifest) {
                             /from\s+['"]@jmruthers\/pace-core\/providers/.test(content);
   
   authRbacPatterns.forEach(({ pattern, name, type, replacement }) => {
-    if (pattern.test(content)) {
-      // For custom RBAC hooks, always flag them even if they import from pace-core
-      // because they're duplicating functionality that should come from pace-core
+    // Create a new regex instance to avoid state issues
+    const testPattern = new RegExp(pattern.source, pattern.flags);
+    if (testPattern.test(content)) {
+      // For custom RBAC hooks, check if they're actually using pace-core APIs
+      // If they use pace-core RBAC APIs (useRoleManagement, useSecureSupabase, etc.), they're compliant
       const isCustomRBACHook = [
         'useUserRoles',
         'useUserOrganisationRoles',
@@ -526,6 +536,20 @@ function scanFile(filePath, manifest) {
         'useRole'
       ].includes(name);
       
+      // Check if the hook uses pace-core RBAC APIs (use a fresh regex to avoid state issues)
+      const rbacApiPattern = /useRoleManagement|useSecureSupabase|useSecureDataAccess|useRBAC|usePermissions|useCan|rbac_role_grant|rbac_role_revoke|rbac_roles_list|data_rbac_apps_list/;
+      const usesPaceCoreRBAC = isCustomRBACHook && rbacApiPattern.test(content);
+      
+      // Check for @pace-core-compliant comment (use a fresh regex)
+      const compliancePattern = /@pace-core-compliant|pace-core-compliant/i;
+      const hasComplianceComment = compliancePattern.test(content);
+      
+      // If it's a custom RBAC hook but uses pace-core APIs or has compliance comment, skip it
+      if (isCustomRBACHook && (usesPaceCoreRBAC || hasComplianceComment)) {
+        // This hook is compliant - it uses pace-core APIs
+        return; // Skip to next pattern
+      }
+      
       // Flag custom RBAC hooks even if they import from pace-core (they're still duplicating functionality)
       // For other hooks, only flag if they don't import from pace-core
       if (isCustomRBACHook || !hasPaceCoreImport) {
@@ -640,7 +664,26 @@ function scanFile(filePath, manifest) {
   // This includes all variations: supabase.auth.getUser(), client.auth.getUser(), etc.
   // Priority patterns - these are the most common violations
   // Using multiple patterns to catch all variations
-  const priorityAuthPatterns = [
+  
+  // Skip Edge Functions - they run in Deno, not React, so React hooks are not available
+  // Edge Functions MUST use direct supabase.auth.getUser() calls - this is correct and required
+  // isEdgeFunction is already defined above
+  
+  // Other auth patterns - defined here so it's accessible in all scopes
+  const otherAuthPatterns = [
+    { pattern: /\.auth\.signIn\s*\(/g, method: 'signIn' },
+    { pattern: /\.auth\.signUp\s*\(/g, method: 'signUp' },
+    { pattern: /\.auth\.signOut\s*\(/g, method: 'signOut' },
+    { pattern: /\.auth\.onAuthStateChange\s*\(/g, method: 'onAuthStateChange' }
+  ];
+  
+  // Skip all auth checks for Edge Functions - they cannot use React hooks
+  if (isEdgeFunction) {
+    // Edge Functions use service role client or direct auth calls - correct pattern
+    // Don't flag these as violations
+  } else {
+    // Only check for direct auth usage in client-side code (React components, hooks, etc.)
+    const priorityAuthPatterns = [
     // Most specific patterns first
     { pattern: /supabase\.auth\.getUser\s*\(/g, method: 'getUser', specific: true },
     { pattern: /supabase\.auth\.getSession\s*\(/g, method: 'getSession', specific: true },
@@ -654,59 +697,51 @@ function scanFile(filePath, manifest) {
     { pattern: /\w+\.auth\.getSession\s*\(/g, method: 'getSession', specific: false }
   ];
   
-  // Other auth patterns
-  const otherAuthPatterns = [
-    { pattern: /\.auth\.signIn\s*\(/g, method: 'signIn' },
-    { pattern: /\.auth\.signUp\s*\(/g, method: 'signUp' },
-    { pattern: /\.auth\.signOut\s*\(/g, method: 'signOut' },
-    { pattern: /\.auth\.onAuthStateChange\s*\(/g, method: 'onAuthStateChange' }
-  ];
-  
-  // Check if file actually uses useUnifiedAuth hook (not just imports it)
-  const usesUnifiedAuthHook = /useUnifiedAuth\s*\(/.test(content);
-  const hasUnifiedAuthImport = /UnifiedAuthProvider/.test(content) || 
-                               /useUnifiedAuth/.test(content) ||
-                               /from\s+['"]@jmruthers\/pace-core\/providers/.test(content);
-  
-  // Check for usage of useCurrentUser hook (even if imported from local file)
-  // This catches both local imports and direct usage
-  const useCurrentUserImportPattern = /import\s+.*useCurrentUser.*from\s+['"][^'"]*['"]/g;
-  const useCurrentUserUsagePattern = /useCurrentUser\s*\(/g;
-  
-  // Check for local import (not from pace-core)
-  const useCurrentUserImportMatch = content.match(useCurrentUserImportPattern);
-  if (useCurrentUserImportMatch) {
-    const isFromPaceCore = useCurrentUserImportMatch.some(match => match.includes('@jmruthers/pace-core'));
-    if (!isFromPaceCore) {
-      useCurrentUserImportMatch.forEach(match => {
+    // Check if file actually uses useUnifiedAuth hook (not just imports it)
+    const usesUnifiedAuthHook = /useUnifiedAuth\s*\(/.test(content);
+    const hasUnifiedAuthImport = /UnifiedAuthProvider/.test(content) || 
+                                 /useUnifiedAuth/.test(content) ||
+                                 /from\s+['"]@jmruthers\/pace-core\/providers/.test(content);
+    
+    // Check for usage of useCurrentUser hook (even if imported from local file)
+    // This catches both local imports and direct usage
+    const useCurrentUserImportPattern = /import\s+.*useCurrentUser.*from\s+['"][^'"]*['"]/g;
+    const useCurrentUserUsagePattern = /useCurrentUser\s*\(/g;
+    
+    // Check for local import (not from pace-core)
+    const useCurrentUserImportMatch = content.match(useCurrentUserImportPattern);
+    if (useCurrentUserImportMatch) {
+      const isFromPaceCore = useCurrentUserImportMatch.some(match => match.includes('@jmruthers/pace-core'));
+      if (!isFromPaceCore) {
+        useCurrentUserImportMatch.forEach(match => {
+          violations.customAuthCode.push({
+            name: 'useCurrentUser import',
+            type: 'hook import',
+            file: relativePath,
+            line: getLineNumber(content, match),
+            reason: 'useCurrentUser imported from local file. Replace with useUnifiedAuth from pace-core.',
+            replacement: 'useUnifiedAuth from @jmruthers/pace-core'
+          });
+        });
+      }
+    }
+    
+    // Check for usage (even if imported)
+    const useCurrentUserUsageMatches = content.match(useCurrentUserUsagePattern);
+    if (useCurrentUserUsageMatches && !usesUnifiedAuthHook) {
+      useCurrentUserUsageMatches.forEach(match => {
         violations.customAuthCode.push({
-          name: 'useCurrentUser import',
-          type: 'hook import',
+          name: 'useCurrentUser',
+          type: 'hook usage',
           file: relativePath,
           line: getLineNumber(content, match),
-          reason: 'useCurrentUser imported from local file. Replace with useUnifiedAuth from pace-core.',
-          replacement: 'useUnifiedAuth from @jmruthers/pace-core'
+          reason: 'useCurrentUser hook usage detected. Replace with useUnifiedAuth from pace-core.',
+          replacement: 'useUnifiedAuth'
         });
       });
     }
-  }
-  
-  // Check for usage (even if imported)
-  const useCurrentUserUsageMatches = content.match(useCurrentUserUsagePattern);
-  if (useCurrentUserUsageMatches && !usesUnifiedAuthHook) {
-    useCurrentUserUsageMatches.forEach(match => {
-      violations.customAuthCode.push({
-        name: 'useCurrentUser',
-        type: 'hook usage',
-        file: relativePath,
-        line: getLineNumber(content, match),
-        reason: 'useCurrentUser hook usage detected. Replace with useUnifiedAuth from pace-core.',
-        replacement: 'useUnifiedAuth'
-      });
-    });
-  }
-  
-  // Check priority patterns first (getUser, getSession) - these should always be flagged
+    
+    // Check priority patterns first (getUser, getSession) - these should always be flagged
   // Use exec in a loop to get all matches with their correct positions
   priorityAuthPatterns.forEach(({ pattern, method, specific }) => {
     // Reset regex for each pattern
@@ -730,7 +765,8 @@ function scanFile(filePath, manifest) {
       const isInLineComment = /\/\/[^\n]*$/.test(lineUpToMatch);
       
       // Only skip if clearly in a comment - be conservative
-      if (!isInLineComment) {
+      // Also skip Edge Functions - they run in Deno, not React, so React hooks aren't available
+      if (!isInLineComment && !isEdgeFunction) {
         violations.directSupabaseAuth.push({
           file: relativePath,
           line: getLineNumber(content, matchText),
@@ -745,8 +781,11 @@ function scanFile(filePath, manifest) {
       }
     }
   });
+  } // End of else block for non-Edge Functions
   
   // Additional simple pattern check as fallback - look for literal strings
+  // Skip for Edge Functions
+  if (!isEdgeFunction) {
   // This catches cases where the regex might miss due to formatting
   const simpleAuthPatterns = [
     { search: 'supabase.auth.getUser(', method: 'getUser' },
@@ -761,7 +800,8 @@ function scanFile(filePath, manifest) {
       const lineUpToMatch = content.substring(lineStart, searchIndex);
       const isInLineComment = /\/\/[^\n]*$/.test(lineUpToMatch);
       
-      if (!isInLineComment) {
+      // Skip Edge Functions - they run in Deno, not React, so React hooks aren't available
+      if (!isInLineComment && !isEdgeFunction) {
         // Calculate line number from index
         const lineNum = content.substring(0, searchIndex).split('\n').length;
         
@@ -787,8 +827,11 @@ function scanFile(filePath, manifest) {
       searchIndex += search.length; // Move past this match
     }
   });
+  } // End of Edge Function check for simple patterns
   
   // Check other auth patterns - flag if not using useUnifiedAuth
+  // Skip for Edge Functions
+  if (!isEdgeFunction) {
   otherAuthPatterns.forEach(({ pattern, method }) => {
     let match;
     const regex = new RegExp(pattern.source, pattern.flags);
@@ -819,7 +862,8 @@ function scanFile(filePath, manifest) {
                         (doubleQuotes % 2 === 1 && beforeMatch.endsWith('"')) ||
                         (backticks % 2 === 1 && beforeMatch.endsWith('`'));
       
-      if (!isInLineComment && !isInBlockComment && !isInString && !usesUnifiedAuthHook) {
+      // Skip Edge Functions - they run in Deno, not React, so React hooks aren't available
+      if (!isInLineComment && !isInBlockComment && !isInString && !usesUnifiedAuthHook && !isEdgeFunction) {
         violations.directSupabaseAuth.push({
           file: relativePath,
           line: getLineNumber(content, matchText),
@@ -829,6 +873,7 @@ function scanFile(filePath, manifest) {
       }
     }
   });
+  } // End of Edge Function check for other auth patterns
   
   // Check for direct RBAC table queries (should use pace-core RBAC APIs/RPC functions)
   // List of all RBAC tables with specific recommendations
@@ -1143,6 +1188,16 @@ function scanFile(filePath, manifest) {
       const matchIndex = match.index;
       const matchText = match[0];
       
+      // Check if this is an edge function (supabase/functions directory) - check early to skip
+      // Handle both forward and backslash paths (Windows vs Unix)
+      const normalizedPath = relativePath.replace(/\\/g, '/');
+      const isEdgeFunction = normalizedPath.includes('supabase/functions/');
+      
+      // Skip edge functions - they use service role client which is correct for server-side operations
+      if (isEdgeFunction) {
+        continue; // Edge functions use service role client - correct pattern
+      }
+      
       // Extract table name
       const afterMatch = content.substring(matchIndex, Math.min(content.length, matchIndex + 100));
       const tableMatch = afterMatch.match(/['"]rbac_([^'"]+)['"]/);
@@ -1155,7 +1210,8 @@ function scanFile(filePath, manifest) {
       
       // Extract variable name if pattern matches variable.from() (handle newlines)
       let variableName = null;
-      const beforeMatch = content.substring(Math.max(0, matchIndex - 200), matchIndex);
+      // Use wider context to find function signatures (up to 500 chars before)
+      const beforeMatch = content.substring(Math.max(0, matchIndex - 500), matchIndex);
       // Find the last word/identifier before .from (same logic as main pattern)
       const parts = beforeMatch.split('.from');
       if (parts.length > 0) {
@@ -1169,9 +1225,28 @@ function scanFile(filePath, manifest) {
       // Check if using secure variable (check both set and direct pattern match)
       // Escape special regex characters in variable name and use multiline flag to handle newlines
       const escapedVarName = variableName ? variableName.replace(/[.*+?^${}()|[\]\\]/g, '\\$&') : '';
-      const isUsingSecureVariable = (variableName && secureVariables.has(variableName)) ||
+      // Check if variable is declared with useSecureSupabase or useSecureDataAccess
+      const isDeclaredSecure = (variableName && secureVariables.has(variableName)) ||
         (variableName && new RegExp(`(const|let)\\s+${escapedVarName}\\s*=\\s*useSecureSupabase\\s*\\(`, 'm').test(content)) ||
         (variableName && new RegExp(`(const|let)\\s+${escapedVarName}\\s*=\\s*useSecureDataAccess\\s*\\(`, 'm').test(content));
+      // Check if variable is passed as parameter with useSecureSupabase type annotation
+      // Look for the parameter in function signatures (check both beforeMatch and full content)
+      const isParameterSecure = variableName && (
+        // Check in beforeMatch (500 chars before)
+        new RegExp(`\\b${escapedVarName}\\s*:\\s*.*useSecureSupabase`, 'm').test(beforeMatch) ||
+        new RegExp(`\\b${escapedVarName}\\s*:\\s*.*ReturnType`, 'm').test(beforeMatch) ||
+        new RegExp(`\\b${escapedVarName}\\s*:\\s*.*secureSupabase`, 'i').test(beforeMatch) ||
+        // Also check the full function signature area (wider context in full content)
+        new RegExp(`(function|=>|async\\s+function)[^(]*\\([^)]*\\b${escapedVarName}\\s*:\\s*.*(useSecureSupabase|ReturnType|secureSupabase)`, 'm').test(content) ||
+        // Check for ReturnType<typeof import pattern (common in TypeScript)
+        new RegExp(`\\b${escapedVarName}\\s*:\\s*.*ReturnType.*useSecureSupabase`, 'm').test(content)
+      );
+      // Check for comments indicating secureSupabase usage
+      const hasSecureComment = variableName && (
+        new RegExp(`secureSupabase|useSecureSupabase`, 'i').test(beforeMatch) ||
+        new RegExp(`COMPLIANCE.*secureSupabase|pace-core.*secureSupabase`, 'i').test(beforeMatch)
+      );
+      const isUsingSecureVariable = isDeclaredSecure || isParameterSecure || hasSecureComment;
       
       // Skip if we already reported this specific table
       const alreadyReported = violations.customAuthCode.some(v => 
@@ -1776,6 +1851,119 @@ function scanFile(filePath, manifest) {
     violations.unnecessaryWrappers.push(...wrapperIssues);
   }
   
+  // ============================================
+  // App Discovery Compliance Checks
+  // ============================================
+  // Check for direct queries to rbac_apps table or hardcoded app names
+  // Should use data_rbac_apps_list RPC function instead
+  
+  // Check for direct queries to rbac_apps table
+  const rbacAppsQueryPatterns = [
+    // Supabase client queries
+    /\.from\s*\(\s*['"]rbac_apps['"]\s*\)/g,
+    /\.from\s*\(\s*['"]rbac_apps['"]\s*\)/g,
+    // SQL queries (less common but possible)
+    /FROM\s+rbac_apps\b/gi,
+    /SELECT\s+.*\s+FROM\s+rbac_apps\b/gi
+  ];
+  
+  // Check if file uses data_rbac_apps_list RPC function
+  const usesRpcFunction = /data_rbac_apps_list|rpc\s*\(\s*['"]data_rbac_apps_list['"]/gi.test(content);
+  
+  rbacAppsQueryPatterns.forEach(pattern => {
+    let match;
+    while ((match = pattern.exec(content)) !== null) {
+      // Skip if in a line comment
+      const lineStart = content.lastIndexOf('\n', match.index) + 1;
+      const lineUpToMatch = content.substring(lineStart, match.index);
+      const isInLineComment = /\/\/[^\n]*$/.test(lineUpToMatch);
+      
+      if (isInLineComment) {
+        continue;
+      }
+      
+      // Check what comes after .from('rbac_apps') to determine if it's a SELECT query or CRUD operation
+      const afterMatch = content.substring(match.index, Math.min(content.length, match.index + 200));
+      const isSelectQuery = /\.(select|selectAll)\s*\(/i.test(afterMatch);
+      const isCrudOperation = /\.(update|insert|delete|upsert)\s*\(/i.test(afterMatch);
+      
+      // Only flag SELECT queries - UPDATE/INSERT/DELETE operations are acceptable with secureSupabase
+      if (isSelectQuery && !isCrudOperation) {
+        violations.appDiscoveryIssues.push({
+          type: 'direct_table_query',
+          file: relativePath,
+          line: getLineNumber(content, match[0]),
+          reason: 'Direct query to rbac_apps table detected. Use data_rbac_apps_list RPC function for dynamic app discovery.',
+          recommendation: 'Replace with: const { data } = await supabase.rpc(\'data_rbac_apps_list\');',
+          severity: 'warning'
+        });
+      }
+      // Skip CRUD operations (UPDATE/INSERT/DELETE) - these are acceptable with secureSupabase
+    }
+  });
+  
+  // Check for hardcoded app names in arrays or string literals
+  // Known app names: BASE, CAKE, PACE, MINT, TRAC, PORTAL, MEDI
+  // Only flag if they appear to be used for app discovery (arrays, comparisons, etc.)
+  const hardcodedAppNamePatterns = [
+    // Array of app names (likely used for iteration/discovery)
+    /\[['"]\s*(BASE|CAKE|PACE|MINT|TRAC|PORTAL|MEDI)\s*['"]/gi,
+    // String literals in comparisons or includes checks (app discovery patterns)
+    /(app|apps|appName|app_name)\s*[=!]==?\s*['"]\s*(BASE|CAKE|PACE|MINT|TRAC|PORTAL|MEDI)\s*['"]/gi,
+    /(app|apps|appName|app_name)\s*\.(includes|indexOf|find|filter)\s*\([^)]*['"]\s*(BASE|CAKE|PACE|MINT|TRAC|PORTAL|MEDI)\s*['"]/gi,
+    /['"]\s*(BASE|CAKE|PACE|MINT|TRAC|PORTAL|MEDI)\s*['"]\s*\.(includes|indexOf)/gi
+  ];
+  
+  hardcodedAppNamePatterns.forEach(pattern => {
+    let match;
+    while ((match = pattern.exec(content)) !== null) {
+      // Skip if it's in a get_app_id call (acceptable usage)
+      const beforeMatch = content.substring(Math.max(0, match.index - 50), match.index);
+      const isInGetAppId = /get_app_id\s*\(/i.test(beforeMatch);
+      
+      // Skip if in a line comment
+      const lineStart = content.lastIndexOf('\n', match.index) + 1;
+      const lineUpToMatch = content.substring(lineStart, match.index);
+      const isInLineComment = /\/\/[^\n]*$/.test(lineUpToMatch);
+      
+      // Skip if it's a comment about app names
+      const isInComment = /\/\*[\s\S]*?\*\//.test(beforeMatch + match[0]);
+      
+      // Skip if it's in a data_rbac_apps_list call (already using the function)
+      const isInRpcCall = /data_rbac_apps_list/i.test(beforeMatch);
+      
+      // Extract app name (could be in different capture groups depending on pattern)
+      const appName = match[1] || match[2] || match[3];
+      
+      if (!isInGetAppId && !isInLineComment && !isInComment && !isInRpcCall && appName) {
+        violations.appDiscoveryIssues.push({
+          type: 'hardcoded_app_name',
+          file: relativePath,
+          line: getLineNumber(content, match[0]),
+          appName: appName,
+          reason: `Hardcoded app name '${appName}' detected. Use data_rbac_apps_list RPC function for dynamic app discovery.`,
+          recommendation: 'Use data_rbac_apps_list() to discover apps dynamically instead of hardcoding app names.',
+          severity: 'warning'
+        });
+      }
+    }
+  });
+  
+  // If file has app discovery code but doesn't use the RPC function, suggest it
+  if (violations.appDiscoveryIssues.length > 0 && !usesRpcFunction) {
+    // Add a general suggestion if there are multiple issues
+    if (violations.appDiscoveryIssues.length > 1) {
+      violations.appDiscoveryIssues.push({
+        type: 'suggestion',
+        file: relativePath,
+        line: 1,
+        reason: 'Multiple app discovery issues found. Consider using data_rbac_apps_list RPC function for all app discovery needs.',
+        recommendation: 'Replace all hardcoded app names and direct table queries with: const { data: apps } = await supabase.rpc(\'data_rbac_apps_list\');',
+        severity: 'info'
+      });
+    }
+  }
+  
   return violations;
 }
 
@@ -1985,7 +2173,8 @@ function generateReport(allViolations, manifest) {
     allViolations.viteConfigIssues.length +
     allViolations.routerSetupIssues.length;
   const totalUnnecessaryWrappers = allViolations.unnecessaryWrappers.length;
-  const totalIssues = totalRestricted + totalDuplicates + totalSuggestions + totalRbacAuth + totalSetupIssues + totalUnnecessaryWrappers;
+  const totalAppDiscovery = allViolations.appDiscoveryIssues.length;
+  const totalIssues = totalRestricted + totalDuplicates + totalSuggestions + totalRbacAuth + totalSetupIssues + totalUnnecessaryWrappers + totalAppDiscovery;
   
   console.log(`\n${colors.bold}${colors.cyan}═══════════════════════════════════════════════════════════${colors.reset}`);
   console.log(`${colors.bold}${colors.cyan}  pace-core Compliance Report${colors.reset}`);
@@ -2065,6 +2254,52 @@ function generateReport(allViolations, manifest) {
     });
   }
   
+  // App Discovery Issues
+  if (totalAppDiscovery > 0) {
+    console.log(`\n${colors.bold}${colors.cyan}═══════════════════════════════════════════════════════════${colors.reset}`);
+    console.log(`${colors.bold}${colors.cyan}  App Discovery Compliance${colors.reset}`);
+    console.log(`${colors.bold}${colors.cyan}═══════════════════════════════════════════════════════════${colors.reset}\n`);
+    
+    // Separate by type
+    const directQueries = allViolations.appDiscoveryIssues.filter(v => v.type === 'direct_table_query');
+    const hardcodedNames = allViolations.appDiscoveryIssues.filter(v => v.type === 'hardcoded_app_name');
+    const suggestions = allViolations.appDiscoveryIssues.filter(v => v.type === 'suggestion');
+    
+    if (directQueries.length > 0) {
+      console.log(`${colors.yellow}${colors.bold}⚠️  Direct rbac_apps Queries: ${directQueries.length}${colors.reset}\n`);
+      directQueries.forEach(({ file, line, reason, recommendation }) => {
+        console.log(`  ${colors.yellow}•${colors.reset} ${colors.yellow}${file}:${line}${colors.reset}`);
+        console.log(`    ${colors.yellow}Issue:${colors.reset} ${reason}`);
+        console.log(`    ${colors.green}Fix:${colors.reset} ${recommendation}\n`);
+      });
+    }
+    
+    if (hardcodedNames.length > 0) {
+      console.log(`${colors.yellow}${colors.bold}⚠️  Hardcoded App Names: ${hardcodedNames.length}${colors.reset}\n`);
+      hardcodedNames.forEach(({ file, line, appName, reason, recommendation }) => {
+        console.log(`  ${colors.yellow}•${colors.reset} ${colors.yellow}${file}:${line}${colors.reset}`);
+        console.log(`    App Name: ${colors.cyan}${appName}${colors.reset}`);
+        console.log(`    ${colors.yellow}Issue:${colors.reset} ${reason}`);
+        console.log(`    ${colors.green}Fix:${colors.reset} ${recommendation}\n`);
+      });
+    }
+    
+    if (suggestions.length > 0) {
+      console.log(`${colors.cyan}${colors.bold}💡 Suggestions: ${suggestions.length}${colors.reset}\n`);
+      suggestions.forEach(({ file, reason, recommendation }) => {
+        console.log(`  ${colors.cyan}•${colors.reset} ${colors.yellow}${file}${colors.reset}`);
+        console.log(`    ${reason}`);
+        console.log(`    ${colors.green}Recommendation:${colors.reset} ${recommendation}\n`);
+      });
+    }
+    
+    console.log(`${colors.cyan}Example Usage:${colors.reset}`);
+    console.log(`  ${colors.green}const { data: apps } = await supabase.rpc('data_rbac_apps_list');${colors.reset}`);
+    console.log(`  ${colors.green}const appNames = apps?.map(app => app.name) || [];${colors.reset}\n`);
+  } else {
+    console.log(`${colors.green}✅ App discovery compliance: Using data_rbac_apps_list RPC function${colors.reset}\n`);
+  }
+  
   // RBAC/Auth Compliance Section
   if (totalRbacAuth > 0) {
     console.log(`\n${colors.bold}${colors.cyan}═══════════════════════════════════════════════════════════${colors.reset}`);
@@ -2115,7 +2350,11 @@ function generateReport(allViolations, manifest) {
                 console.log(`      ${colors.green}  p_user_id: userId,${colors.reset}`);
                 console.log(`      ${colors.green}  p_event_id: eventId${colors.reset}`);
                 console.log(`      ${colors.green}});${colors.reset}`);
-              } else if (type === 'rbac query' && (name.includes('rbac_apps') || name.includes('rbac_app_pages') || name.includes('rbac_page_permissions'))) {
+              } else if (type === 'rbac query' && name.includes('rbac_apps')) {
+                console.log(`    ${colors.cyan}Example (app discovery):${colors.reset}`);
+                console.log(`      ${colors.green}const { data: apps } = await supabase.rpc('data_rbac_apps_list');${colors.reset}`);
+                console.log(`      ${colors.yellow}Note:${colors.reset} Use data_rbac_apps_list RPC function for dynamic app discovery instead of querying rbac_apps directly.`);
+              } else if (type === 'rbac query' && (name.includes('rbac_app_pages') || name.includes('rbac_page_permissions'))) {
                 console.log(`    ${colors.cyan}Example (admin operations):${colors.reset}`);
                 console.log(`      ${colors.green}import { useSecureSupabase } from '@jmruthers/pace-core/rbac';${colors.reset}`);
                 console.log(`      ${colors.green}const supabase = useSecureSupabase();${colors.reset}`);
@@ -2243,6 +2482,8 @@ function generateReport(allViolations, manifest) {
   console.log(`  - Suggestions: ${colors.yellow}${totalSuggestions}${colors.reset}`);
   console.log(`  - RBAC/Auth Issues: ${totalRbacAuth > 0 ? colors.red : colors.green}${totalRbacAuth}${colors.reset}`);
   console.log(`  - Setup/Configuration Issues: ${totalSetupIssues > 0 ? colors.red : colors.green}${totalSetupIssues}${colors.reset}`);
+  console.log(`  - Unnecessary Wrappers: ${totalUnnecessaryWrappers > 0 ? colors.yellow : colors.green}${totalUnnecessaryWrappers}${colors.reset}`);
+  console.log(`  - App Discovery Issues: ${totalAppDiscovery > 0 ? colors.yellow : colors.green}${totalAppDiscovery}${colors.reset}`);
   
   if (totalIssues === 0) {
     console.log(`\n${colors.green}${colors.bold}✅ Excellent! Your codebase is fully compliant with pace-core standards.${colors.reset}\n`);
@@ -2267,6 +2508,10 @@ function findSourceFiles(dir, fileList = []) {
       const stat = fs.statSync(fullPath);
       
       if (stat.isDirectory()) {
+        // Skip Edge Functions directory - they run in Deno, not React, so React hooks aren't available
+        if (item === 'functions' && dir.includes('supabase')) {
+          return; // Skip supabase/functions directory
+        }
         if (!ignoreDirs.includes(item) && !item.startsWith('.')) {
           findSourceFiles(fullPath, fileList);
         }
@@ -2309,7 +2554,8 @@ function main() {
     providerSetupIssues: [],
     viteConfigIssues: [],
     routerSetupIssues: [],
-    unnecessaryWrappers: []
+    unnecessaryWrappers: [],
+    appDiscoveryIssues: []
   };
   
   files.forEach(file => {
@@ -2328,6 +2574,7 @@ function main() {
       allViolations.viteConfigIssues.push(...violations.viteConfigIssues);
       allViolations.routerSetupIssues.push(...violations.routerSetupIssues);
       allViolations.unnecessaryWrappers.push(...violations.unnecessaryWrappers);
+      allViolations.appDiscoveryIssues.push(...violations.appDiscoveryIssues);
     } catch (error) {
       console.error(`${colors.red}Error scanning ${file}: ${error.message}${colors.reset}`);
     }
@@ -2349,5 +2596,12 @@ if (require.main === module) {
   }
 }
 
-module.exports = { main, scanFile, generateReport };
+module.exports = { 
+  main, 
+  scanFile, 
+  generateReport,
+  loadManifest,
+  findProjectRoot,
+  findSourceFiles
+};