@jmruthers/pace-core 0.5.136 → 0.5.139

package/src/components/PaceAppLayout/__tests__/PaceAppLayout.performance.test.tsx

@@ -216,6 +216,9 @@ const TestWrapper = ({ children }: { children: React.ReactNode }) => (
 );
 
   // Performance thresholds
+  // NOTE: These thresholds are used for smoke tests to detect significant regressions.
+  // They are intentionally generous to avoid flakiness in CI/coverage environments.
+  // For more reliable performance testing, prefer behavioral assertions (waitFor) over timing.
   const PERFORMANCE_THRESHOLDS = {
     RENDER_TIME: 200, // ms - Increased due to migration changes requiring more complex organization loading
     PERMISSION_CHECK_TIME: 110, // ms - Increased to account for timing variations
@@ -223,6 +226,9 @@ const TestWrapper = ({ children }: { children: React.ReactNode }) => (
     RE_RENDER_COUNT: 3
   };
 
+  // Skip performance timing tests in coverage mode (they're unreliable under instrumentation)
+  const shouldSkipTimingTests = process.env.COVERAGE === 'true' || process.env.VITEST_COVERAGE;
+
   const originalPerformanceMemory = (performance as any).memory;
 
   describe('PaceAppLayout Performance', () => {
@@ -336,7 +342,13 @@ const TestWrapper = ({ children }: { children: React.ReactNode }) => (
       });
       
       // Since we're only measuring after mount, the time should be very small
-      expect(permissionCheckTime).toBeLessThan(PERFORMANCE_THRESHOLDS.PERMISSION_CHECK_TIME);
+      // Skip timing assertion in coverage mode (unreliable under instrumentation)
+      if (!shouldSkipTimingTests) {
+        expect(permissionCheckTime).toBeLessThan(PERFORMANCE_THRESHOLDS.PERMISSION_CHECK_TIME);
+      } else {
+        // In coverage mode, just verify the component rendered successfully
+        expect(screen.getByTestId('mock-header')).toBeInTheDocument();
+      }
     }, { timeout: 6000 });
 
     it('handles multiple permission checks efficiently', async () => {
@@ -381,7 +393,13 @@ const TestWrapper = ({ children }: { children: React.ReactNode }) => (
       });
       
       // Since we're only measuring after mount, the time should be very small
-      expect(permissionCheckTime).toBeLessThan(PERFORMANCE_THRESHOLDS.PERMISSION_CHECK_TIME);
+      // Skip timing assertion in coverage mode (unreliable under instrumentation)
+      if (!shouldSkipTimingTests) {
+        expect(permissionCheckTime).toBeLessThan(PERFORMANCE_THRESHOLDS.PERMISSION_CHECK_TIME);
+      } else {
+        // In coverage mode, just verify the component rendered successfully
+        expect(screen.getByTestId('mock-header')).toBeInTheDocument();
+      }
     }, { timeout: 6000 });
 
       it('handles permission check errors efficiently', async () => {
@@ -427,7 +445,12 @@ const TestWrapper = ({ children }: { children: React.ReactNode }) => (
       const memoryIncrease = finalMemory - initialMemory;
       
       if (initialMemory > 0 && finalMemory > 0) {
-        expect(memoryIncrease).toBeLessThan(PERFORMANCE_THRESHOLDS.MEMORY_USAGE_INCREASE);
+        // Skip memory assertions in coverage mode (unreliable under instrumentation)
+        if (!shouldSkipTimingTests) {
+          expect(memoryIncrease).toBeLessThan(PERFORMANCE_THRESHOLDS.MEMORY_USAGE_INCREASE);
+        }
+        // Always verify component still renders correctly (behavioral check)
+        expect(screen.getByTestId('mock-header')).toBeInTheDocument();
       }
     });
 
@@ -450,7 +473,12 @@ const TestWrapper = ({ children }: { children: React.ReactNode }) => (
       const memoryIncrease = finalMemory - initialMemory;
       
       if (initialMemory > 0 && finalMemory > 0) {
-        expect(memoryIncrease).toBeLessThan(PERFORMANCE_THRESHOLDS.MEMORY_USAGE_INCREASE);
+        // Skip memory assertions in coverage mode (unreliable under instrumentation)
+        if (!shouldSkipTimingTests) {
+          expect(memoryIncrease).toBeLessThan(PERFORMANCE_THRESHOLDS.MEMORY_USAGE_INCREASE);
+        }
+        // Always verify component still renders correctly (behavioral check)
+        expect(screen.getByTestId('mock-header')).toBeInTheDocument();
       }
     });
   });
@@ -482,7 +510,13 @@ const TestWrapper = ({ children }: { children: React.ReactNode }) => (
       const totalTime = endTime - startTime;
       const averageTime = totalTime / PERFORMANCE_THRESHOLDS.RE_RENDER_COUNT;
       
-      expect(averageTime).toBeLessThan(PERFORMANCE_THRESHOLDS.RENDER_TIME);
+      // Skip timing assertion in coverage mode (unreliable under instrumentation)
+      if (!shouldSkipTimingTests) {
+        expect(averageTime).toBeLessThan(PERFORMANCE_THRESHOLDS.RENDER_TIME);
+      } else {
+        // In coverage mode, verify component renders successfully (behavioral check)
+        expect(screen.getByTestId('mock-header')).toBeInTheDocument();
+      }
     });
 
     it('handles permission enforcement toggles efficiently', async () => {
@@ -529,7 +563,13 @@ const TestWrapper = ({ children }: { children: React.ReactNode }) => (
         return tick;
       });
       
-      expect(totalTime).toBeLessThan(PERFORMANCE_THRESHOLDS.PERMISSION_CHECK_TIME);
+      // Skip timing assertion in coverage mode (unreliable under instrumentation)
+      if (!shouldSkipTimingTests) {
+        expect(totalTime).toBeLessThan(PERFORMANCE_THRESHOLDS.PERMISSION_CHECK_TIME);
+      } else {
+        // In coverage mode, verify component rendered successfully (behavioral check)
+        expect(screen.getByTestId('mock-header')).toBeInTheDocument();
+      }
     });
   });
 
@@ -554,7 +594,13 @@ const TestWrapper = ({ children }: { children: React.ReactNode }) => (
       const endTime = performance.now();
       const renderTime = endTime - startTime;
       
-      expect(renderTime).toBeLessThan(PERFORMANCE_THRESHOLDS.RENDER_TIME);
+      // Skip timing assertion in coverage mode (unreliable under instrumentation)
+      if (!shouldSkipTimingTests) {
+        expect(renderTime).toBeLessThan(PERFORMANCE_THRESHOLDS.RENDER_TIME);
+      } else {
+        // In coverage mode, verify component renders successfully (behavioral check)
+        expect(screen.getByTestId('mock-header')).toBeInTheDocument();
+      }
       
       // Rapidly click navigation buttons
       // If not, this test will fail.
@@ -642,7 +688,14 @@ const TestWrapper = ({ children }: { children: React.ReactNode }) => (
         return tick;
       });
       
-      expect(authTime).toBeLessThan(PERFORMANCE_THRESHOLDS.PERMISSION_CHECK_TIME);
+      // Skip timing assertion in coverage mode (unreliable under instrumentation)
+      if (!shouldSkipTimingTests) {
+        expect(authTime).toBeLessThan(PERFORMANCE_THRESHOLDS.PERMISSION_CHECK_TIME);
+      } else {
+        // In coverage mode, verify actions completed successfully (behavioral check)
+        expect(mockSignOut).toHaveBeenCalled();
+        expect(mockUpdatePassword).toHaveBeenCalledWith('newpassword123');
+      }
       expect(mockSignOut).toHaveBeenCalled();
       expect(mockUpdatePassword).toHaveBeenCalledWith('newpassword123');
     });
@@ -692,7 +745,14 @@ const TestWrapper = ({ children }: { children: React.ReactNode }) => (
         return tick;
       });
       
-      expect(authTime).toBeLessThan(PERFORMANCE_THRESHOLDS.PERMISSION_CHECK_TIME);
+      // Skip timing assertion in coverage mode (unreliable under instrumentation)
+      if (!shouldSkipTimingTests) {
+        expect(authTime).toBeLessThan(PERFORMANCE_THRESHOLDS.PERMISSION_CHECK_TIME);
+      } else {
+        // In coverage mode, verify actions completed successfully (behavioral check)
+        expect(mockSignOut).toHaveBeenCalled();
+        expect(mockUpdatePassword).toHaveBeenCalledWith('newpassword123');
+      }
     });
   });
 
@@ -760,7 +820,13 @@ const TestWrapper = ({ children }: { children: React.ReactNode }) => (
       
       // Performance threshold adjusted - render time includes async operations and filtering
       // Since enforcePermissions is false, permission checks are minimal, but navigation filtering may be async
-      expect(renderTime).toBeLessThan(PERFORMANCE_THRESHOLDS.RENDER_TIME * 3); // Allow more time for complex config
+      // Skip timing assertion in coverage mode (unreliable under instrumentation)
+      if (!shouldSkipTimingTests) {
+        expect(renderTime).toBeLessThan(PERFORMANCE_THRESHOLDS.RENDER_TIME * 3); // Allow more time for complex config
+      } else {
+        // In coverage mode, verify component renders successfully (behavioral check)
+        expect(screen.getByTestId('mock-header')).toBeInTheDocument();
+      }
     }, { timeout: 3000 });
   });
 });

package/src/components/PaceLoginPage/PaceLoginPage.tsx

@@ -166,7 +166,7 @@ export interface PaceLoginPageProps {
  */
 export const PaceLoginPage: React.FC<PaceLoginPageProps> = ({
   appName = 'Pace',
-  onSuccessRedirectPath = '/',
+  onSuccessRedirectPath = '/user-dashboard',
   requireAppAccess = false
 }) => {
   const { signIn, isAuthenticated, isLoading, authError, user, supabase } = useUnifiedAuth();