@jmruthers/pace-core 0.5.118 → 0.5.120

package/src/components/DataTable/components/DataTableCore.tsx

@@ -42,6 +42,8 @@ import type { TableStateSnapshot } from '../hooks/useTableHandlers';
 import { ColumnFactory } from '../core/ColumnFactory';
 import { AccessDeniedPage } from './AccessDeniedPage';
 import { useCan, useResolvedScope } from '../../../rbac/hooks';
+// NOTE: All toast() calls in this component use the default timeout (5 seconds).
+// Do NOT set duration or timeout properties - let the toast system use its default.
 import { toast } from '../../../hooks/useToast';
 import { exportToCSV, exportToCSVWithTableRows } from '../utils/exportUtils';
 import { useUnifiedAuth } from '../../../providers/UnifiedAuthProvider';
@@ -708,6 +710,7 @@ function DataTableInternal<TData extends DataRecord>({
         label: 'Delete',
         onClick: async (row: TData) => {
           if (!permissions.canDelete.can) {
+            // NOTE: Toast notifications use default timeout (5 seconds) - do not set duration property
             toast({
               title: "Delete Failed",
               description: "Insufficient permissions to delete this resource",
@@ -1094,6 +1097,7 @@ function DataTableInternal<TData extends DataRecord>({
                   await exportToCSVWithTableRows(tableRows, visibleColumns, columnIdToTableColumn, filename);
                   
                   // Show success toast notification
+                  // NOTE: Toast notifications use default timeout (5 seconds) - do not set duration property
                   toast({
                     title: "Export Successful",
                     description: `Data exported to ${filename}`,
@@ -1384,6 +1388,7 @@ function DataTableInternal<TData extends DataRecord>({
               console.log('[DataTableCore] onImport completed successfully');
               
               // Show success toast
+              // NOTE: Toast notifications use default timeout (5 seconds) - do not set duration property
               toast({
                 title: "Import Successful",
                 description: `Successfully imported ${data.length} ${data.length === 1 ? 'row' : 'rows'}`,

package/src/components/DataTable/components/EditableRow.tsx

@@ -316,6 +316,12 @@ export function EditableRow<TData extends DataRecord>({
                 // Data columns: render edit fields
                 (() => {
                   const columnDef = cell.column.columnDef as EditableColumnDef<TData>;
+                  
+                  // CRITICAL FIX: For editable columns (editable !== false), ALWAYS use renderEditField
+                  // to ensure input fields are shown in edit mode. Custom cell renderers are only used
+                  // when the column is explicitly marked as editable: false (non-editable columns).
+                  // This ensures that editable fields always display as input fields in edit mode.
+                  
                   // If column is explicitly marked as not editable, check if custom cell renderer handles editing
                   if (columnDef.editable === false) {
                     // Not editable - use custom cell renderer if available, otherwise show static value
@@ -336,24 +342,9 @@ export function EditableRow<TData extends DataRecord>({
                     );
                   }
                   
-                  // Column is editable - check if custom cell renderer handles editing
-                  // Custom renderers can provide their own editing UI (e.g., Select dropdowns, multi-field editors)
-                  if (cell.column.columnDef.cell) {
-                    // Try using custom cell renderer with editing context
-                    return flexRender(cell.column.columnDef.cell, {
-                      ...cell.getContext(),
-                      getIsEditing: () => true,
-                      setValue: (value: CellValue | Record<string, CellValue>) => {
-                        if (typeof value === 'object' && value !== null && !Array.isArray(value) && !(value instanceof Date)) {
-                          onEditingDataChange({ ...editingData, ...(value as Record<string, CellValue>) });
-                        } else {
-                          onEditingDataChange({ ...editingData, [cell.column.id]: value as CellValue });
-                        }
-                      }
-                    });
-                  }
-                  
-                  // No custom renderer - use default renderEditField
+                  // Column is editable (editable !== false or undefined) - ALWAYS use renderEditField
+                  // This ensures input fields are always displayed in edit mode, regardless of custom cell renderers.
+                  // Custom cell renderers are for display purposes only and should not interfere with edit mode.
                   const shouldGetRef = !hasAssignedRef.current;
                   if (shouldGetRef) {
                     hasAssignedRef.current = true;