@jmruthers/pace-core 0.5.115 → 0.5.116

package/src/components/DataTable/components/__tests__/EditableRow.test.tsx

@@ -0,0 +1,454 @@
+/**
+ * @file Editable Row Component Tests
+ * @package @jmruthers/pace-core
+ * @module Components/DataTable/Components/__tests__
+ * @since 0.4.0
+ * 
+ * Comprehensive test suite for EditableRow component following testing guidelines.
+ * Tests cover observable behavior and user interactions.
+ */
+
+import React from 'react';
+import { render, screen, renderHook } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
+import { createColumnHelper, useReactTable, getCoreRowModel } from '@tanstack/react-table';
+import { EditableRow } from '../EditableRow';
+import type { DataRecord } from '../../types';
+
+// Mock Button component
+vi.mock('../../Button/Button', () => ({
+  Button: ({ children, onClick, size, variant, 'aria-label': ariaLabel }: any) => (
+    <button
+      onClick={onClick}
+      data-size={size}
+      data-variant={variant}
+      aria-label={ariaLabel}
+    >
+      {children}
+    </button>
+  ),
+}));
+
+// Mock Input component
+vi.mock('../../Input/Input', () => ({
+  Input: React.forwardRef(({ type, value, onChange, className, placeholder }: any, ref: any) => (
+    <input
+      ref={ref}
+      type={type}
+      value={value}
+      onChange={onChange}
+      className={className}
+      placeholder={placeholder}
+    />
+  )),
+}));
+
+// Mock Select components
+vi.mock('../../Select/Select', () => ({
+  Select: ({ children, value, onValueChange, onOpenChange }: any) => (
+    <div data-testid="select" data-value={value}>
+      {children}
+      <button onClick={() => onOpenChange(true)} data-testid="select-open">Open</button>
+      <button onClick={() => onValueChange('option1')} data-testid="select-change">Change</button>
+    </div>
+  ),
+  SelectTrigger: ({ children, className }: any) => (
+    <div data-testid="select-trigger" className={className}>{children}</div>
+  ),
+  SelectValue: ({ placeholder }: any) => <div data-testid="select-value">{placeholder}</div>,
+  SelectContent: ({ children, searchable, searchPlaceholder }: any) => (
+    <div data-testid="select-content" data-searchable={searchable} data-placeholder={searchPlaceholder}>
+      {children}
+    </div>
+  ),
+  SelectItem: ({ children, value }: any) => (
+    <div data-testid="select-item" data-value={value}>{children}</div>
+  ),
+  SelectGroup: ({ children }: any) => <div data-testid="select-group">{children}</div>,
+  SelectLabel: ({ children }: any) => <div data-testid="select-label">{children}</div>,
+  SelectSeparator: () => <div data-testid="select-separator" />,
+}));
+
+// Mock lucide-react icons - need to include ChevronDown for Select
+vi.mock('lucide-react', async () => {
+  const actual = await vi.importActual('lucide-react');
+  return {
+    ...actual,
+    X: ({ className }: { className?: string }) => (
+      <span data-testid="x-icon" className={className}>X</span>
+    ),
+    Check: ({ className }: { className?: string }) => (
+      <span data-testid="check-icon" className={className}>✓</span>
+    ),
+  };
+});
+
+interface TestData extends DataRecord {
+  id: string;
+  name: string;
+  email: string;
+  age: number;
+  status: string;
+}
+
+describe('[component] EditableRow', () => {
+  const columnHelper = createColumnHelper<TestData>();
+  
+  // Helper to create columns without default cell renderers
+  const createColumn = <T extends DataRecord>(id: string, config: any): ColumnDef<T> => ({
+    id,
+    accessorKey: id,
+    ...config,
+  });
+
+  const defaultColumns: ColumnDef<TestData>[] = [
+    {
+      id: 'name',
+      accessorKey: 'name',
+      header: 'Name',
+      editable: true,
+      cell: undefined, // Explicitly no cell renderer to force renderEditField
+    },
+    {
+      id: 'email',
+      accessorKey: 'email',
+      header: 'Email',
+      editable: true,
+      cell: undefined,
+    },
+    {
+      id: 'age',
+      accessorKey: 'age',
+      header: 'Age',
+      editable: true,
+      fieldType: 'number' as const,
+      cell: undefined,
+    },
+    {
+      id: 'status',
+      accessorKey: 'status',
+      header: 'Status',
+      editable: true,
+      fieldType: 'select' as const,
+      fieldOptions: [
+        { value: 'active', label: 'Active' },
+        { value: 'inactive', label: 'Inactive' },
+      ],
+      cell: undefined,
+    },
+  ];
+
+  const defaultData: TestData = {
+    id: '1',
+    name: 'John Doe',
+    email: 'john@example.com',
+    age: 30,
+    status: 'active',
+  };
+
+  const createMockRow = (data: TestData = defaultData, columns = defaultColumns) => {
+    // Use renderHook to call useReactTable hook properly
+    // Add actions column for EditableRow (it expects this column for save/cancel buttons)
+    const columnsWithActions: ColumnDef<TestData>[] = [
+      ...columns,
+      {
+        id: 'actions',
+        header: 'Actions',
+        cell: () => null, // Actions are rendered by EditableRow itself
+      },
+    ];
+    
+    const { result } = renderHook(() => {
+      return useReactTable({
+        data: [data],
+        columns: columnsWithActions,
+        getCoreRowModel: getCoreRowModel(),
+      });
+    });
+
+    return result.current.getRowModel().rows[0];
+  };
+
+  const getDefaultProps = () => ({
+    row: createMockRow(),
+    editingData: {},
+    onEditingDataChange: vi.fn(),
+    onSave: vi.fn(),
+    onCancel: vi.fn(),
+    actions: [],
+  });
+  
+  const defaultProps = getDefaultProps();
+
+  beforeEach(() => {
+    vi.clearAllMocks();
+  });
+
+  afterEach(() => {
+    vi.clearAllMocks();
+  });
+
+  describe('Rendering', () => {
+    it('renders editable row with table row structure', () => {
+      render(<EditableRow {...defaultProps} />);
+
+      const row = screen.getByRole('row');
+      expect(row).toBeInTheDocument();
+    });
+
+    it('renders input fields for editable columns', () => {
+      const props = getDefaultProps();
+      // Provide editingData with the values to trigger input rendering
+      props.editingData = {
+        name: 'John Doe',
+        email: 'john@example.com',
+      };
+      render(<EditableRow {...props} />);
+
+      const nameInput = screen.getByDisplayValue('John Doe');
+      const emailInput = screen.getByDisplayValue('john@example.com');
+      
+      expect(nameInput).toBeInTheDocument();
+      expect(emailInput).toBeInTheDocument();
+    });
+
+    it('renders number input for number field type', () => {
+      const props = getDefaultProps();
+      props.editingData = { age: 30 };
+      render(<EditableRow {...props} />);
+
+      const ageInput = screen.getByDisplayValue('30');
+      expect(ageInput).toHaveAttribute('type', 'number');
+    });
+
+    it('renders select for select field type', () => {
+      const props = getDefaultProps();
+      props.editingData = { status: 'active' };
+      render(<EditableRow {...props} />);
+
+      // Select is rendered as a form with data-testid="select-root" or as select-trigger
+      const selectTrigger = screen.getByTestId('select-trigger');
+      expect(selectTrigger).toBeInTheDocument();
+      expect(selectTrigger).toHaveAttribute('data-value', 'active');
+    });
+
+    it('renders save and cancel buttons', () => {
+      render(<EditableRow {...defaultProps} />);
+
+      expect(screen.getByRole('button', { name: /save changes/i })).toBeInTheDocument();
+      expect(screen.getByRole('button', { name: /cancel editing/i })).toBeInTheDocument();
+    });
+
+    it('auto-focuses first input field', () => {
+      const props = getDefaultProps();
+      props.editingData = { name: 'John Doe' };
+      render(<EditableRow {...props} />);
+
+      const nameInput = screen.getByDisplayValue('John Doe');
+      expect(nameInput).toHaveFocus();
+    });
+  });
+
+  describe('User Interactions', () => {
+    it('updates editing data when text input changes', async () => {
+      const user = userEvent.setup();
+      const onEditingDataChange = vi.fn();
+      const props = getDefaultProps();
+      props.editingData = { name: 'John Doe' };
+      props.onEditingDataChange = onEditingDataChange;
+
+      render(<EditableRow {...props} />);
+
+      const nameInput = screen.getByDisplayValue('John Doe');
+      await user.clear(nameInput);
+      await user.type(nameInput, 'Jane Doe');
+
+      expect(onEditingDataChange).toHaveBeenCalled();
+    });
+
+    it('calls onSave when save button is clicked', async () => {
+      const user = userEvent.setup();
+      const onSave = vi.fn();
+
+      render(<EditableRow {...defaultProps} onSave={onSave} />);
+
+      const saveButton = screen.getByRole('button', { name: /save changes/i });
+      await user.click(saveButton);
+
+      expect(onSave).toHaveBeenCalledTimes(1);
+    });
+
+    it('calls onCancel when cancel button is clicked', async () => {
+      const user = userEvent.setup();
+      const onCancel = vi.fn();
+      const props = getDefaultProps();
+      props.editingData = {};
+      props.onCancel = onCancel;
+
+      render(<EditableRow {...props} />);
+
+      const cancelButton = screen.getByRole('button', { name: /cancel editing/i });
+      await user.click(cancelButton);
+
+      expect(onCancel).toHaveBeenCalledTimes(1);
+    });
+
+    it('updates editing data when select value changes', async () => {
+      const user = userEvent.setup();
+      const onEditingDataChange = vi.fn();
+      const props = getDefaultProps();
+      props.editingData = { status: 'active' };
+      props.onEditingDataChange = onEditingDataChange;
+
+      render(<EditableRow {...props} />);
+
+      // Select renders with select-trigger
+      const selectTrigger = screen.getByTestId('select-trigger');
+      expect(selectTrigger).toBeInTheDocument();
+      
+      // The real Select component handles value changes internally
+      // We verify the select is rendered correctly with the current value
+      expect(selectTrigger).toHaveAttribute('data-value', 'active');
+      
+      // Note: Testing actual value changes would require opening the select and clicking an item
+      // which is more of an integration test. This test verifies the select is rendered.
+    });
+  });
+
+  describe('Field Types', () => {
+    it('renders date input for date field type', () => {
+      const dateColumn = columnHelper.accessor('createdAt', {
+        header: 'Created At',
+        editable: true,
+        fieldType: 'date',
+      });
+
+      const columns = [...defaultColumns, dateColumn];
+      const dateData: TestData = {
+        ...defaultData,
+        createdAt: new Date('2024-01-01'),
+      };
+      const row = createMockRow(dateData, columns);
+      const props = getDefaultProps();
+      props.row = row;
+      props.editingData = { createdAt: new Date('2024-01-01') };
+
+      render(<EditableRow {...props} />);
+
+      // Date input should be rendered
+      const inputs = screen.getAllByRole('textbox');
+      expect(inputs.length).toBeGreaterThan(0);
+    });
+
+    it('renders non-editable field as text when editable is false', () => {
+      const nonEditableColumn: ColumnDef<TestData> = {
+        id: 'id',
+        accessorKey: 'id',
+        header: 'ID',
+        editable: false,
+      };
+
+      const columns = [...defaultColumns, nonEditableColumn];
+      const row = createMockRow(defaultData, columns);
+      const props = getDefaultProps();
+      props.row = row;
+      props.editingData = {};
+
+      render(<EditableRow {...props} />);
+
+      // Should render static text, not input
+      expect(screen.getByText('1')).toBeInTheDocument();
+    });
+  });
+
+  describe('Editing Data', () => {
+    it('uses editingData values when provided', () => {
+      const editingData = {
+        name: 'Edited Name',
+        email: 'edited@example.com',
+      };
+
+      render(
+        <EditableRow
+          {...defaultProps}
+          editingData={editingData}
+        />
+      );
+
+      expect(screen.getByDisplayValue('Edited Name')).toBeInTheDocument();
+      expect(screen.getByDisplayValue('edited@example.com')).toBeInTheDocument();
+    });
+
+    it('falls back to original row values when editingData is empty', () => {
+      render(<EditableRow {...defaultProps} editingData={{}} />);
+
+      expect(screen.getByDisplayValue('John Doe')).toBeInTheDocument();
+      expect(screen.getByDisplayValue('john@example.com')).toBeInTheDocument();
+    });
+  });
+
+  describe('System Columns', () => {
+    it('renders system columns (select, actions) without edit fields', () => {
+      const props = getDefaultProps();
+      props.editingData = {};
+      render(<EditableRow {...props} />);
+
+      // System columns should render their normal content
+      expect(screen.getByRole('button', { name: /save changes/i })).toBeInTheDocument();
+      expect(screen.getByRole('button', { name: /cancel editing/i })).toBeInTheDocument();
+    });
+  });
+
+  describe('Accessibility', () => {
+    it('provides proper ARIA attributes for row', () => {
+      render(<EditableRow {...defaultProps} />);
+
+      const row = screen.getByRole('row');
+      expect(row).toHaveAttribute('role', 'row');
+    });
+
+    it('provides aria-label for save button', () => {
+      render(<EditableRow {...defaultProps} />);
+
+      const saveButton = screen.getByRole('button', { name: /save changes/i });
+      expect(saveButton).toHaveAttribute('aria-label', 'Save changes');
+    });
+
+    it('provides aria-label for cancel button', () => {
+      render(<EditableRow {...defaultProps} />);
+
+      const cancelButton = screen.getByRole('button', { name: /cancel editing/i });
+      expect(cancelButton).toHaveAttribute('aria-label', 'Cancel editing');
+    });
+  });
+
+  describe('Edge Cases', () => {
+    it('handles empty editingData gracefully', () => {
+      render(<EditableRow {...defaultProps} editingData={{}} />);
+
+      expect(screen.getByRole('row')).toBeInTheDocument();
+    });
+
+    it('handles null values in editingData', () => {
+      const props = getDefaultProps();
+      props.editingData = {
+        name: null,
+        email: null,
+      } as any;
+
+      render(<EditableRow {...props} />);
+
+      expect(screen.getByRole('row')).toBeInTheDocument();
+    });
+
+    it('handles missing column definitions', () => {
+      const row = createMockRow();
+
+      expect(() => {
+        render(<EditableRow {...defaultProps} row={row} />);
+      }).not.toThrow();
+    });
+  });
+});
+