@jmruthers/pace-core 0.2.6 → 0.4.1

package/src/components/PaceAppLayout/__tests__/PaceAppLayout.unit.test.tsx

@@ -1,904 +0,0 @@
-import React from 'react';
-import { screen, fireEvent, waitFor } from '@testing-library/react';
-import { describe, it, expect, vi, beforeEach, beforeAll } from 'vitest';
-import '@testing-library/jest-dom';
-import { BrowserRouter } from 'react-router-dom';
-import { renderWithProviders, rerenderWithProviders } from '../../../__tests__/shared';
-
-// Mock React Router hooks
-const mockNavigate = vi.fn();
-const mockLocation = { pathname: '/test-path' };
-vi.mock('react-router-dom', async () => {
-  const actual = await vi.importActual('react-router-dom');
-  return {
-    ...actual,
-    useNavigate: () => mockNavigate,
-    useLocation: () => mockLocation,
-    Outlet: () => <div data-testid="mock-outlet">Mock Outlet Content</div>
-  };
-});
-
-// Mock UnifiedAuthProvider
-const mockSignOut = vi.fn().mockResolvedValue({ error: null });
-const mockUpdatePassword = vi.fn().mockResolvedValue({ error: null });
-const mockUser = {
-  id: 'test-user-id',
-  email: 'test@example.com',
-  user_metadata: { 
-    display_name: 'Test User',
-    organisationId: 'test-org-123',
-    eventId: 'test-event-456',
-    appId: 'test-app-789'
-  }
-};
-
-vi.mock('../../../providers/UnifiedAuthProvider', () => ({
-  useUnifiedAuth: () => ({
-    user: mockUser,
-    signOut: mockSignOut,
-    updatePassword: mockUpdatePassword
-  })
-}));
-
-// Mock OrganisationProvider
-const mockOrganisation = {
-  id: 'test-org-id',
-  name: 'Test Organisation',
-  display_name: 'Test Organisation',
-  description: 'Test organisation for testing',
-  subscription_tier: 'basic',
-  settings: {},
-  is_active: true,
-  created_at: '2023-01-01T00:00:00Z',
-  updated_at: '2023-01-01T00:00:00Z'
-};
-
-const mockOrganisationContext = {
-  selectedOrganisation: mockOrganisation,
-  organisations: [mockOrganisation],
-  userMemberships: [{
-    id: 'test-membership-id',
-    user_id: 'test-user-id',
-    organisation_id: 'test-org-id',
-    role: 'org_admin',
-    granted_at: '2023-01-01T00:00:00Z',
-    status: 'active' as const,
-    created_at: '2023-01-01T00:00:00Z',
-    updated_at: '2023-01-01T00:00:00Z'
-  }],
-  isLoading: false,
-  error: null,
-  hasValidOrganisationContext: true,
-  setSelectedOrganisation: vi.fn(),
-  switchOrganisation: vi.fn().mockResolvedValue(undefined),
-  getUserRole: vi.fn().mockReturnValue('member'),
-  validateOrganisationAccess: vi.fn().mockReturnValue(true),
-  ensureOrganisationContext: vi.fn().mockReturnValue(mockOrganisation),
-  refreshOrganisations: vi.fn().mockResolvedValue(undefined),
-  getPrimaryOrganisation: vi.fn().mockReturnValue(mockOrganisation),
-  isOrganisationSecure: vi.fn().mockReturnValue(true)
-};
-
-vi.mock('../../../providers/OrganisationProvider', () => ({
-  OrganisationProvider: ({ children }: { children: React.ReactNode }) => <>{children}</>,
-  useOrganisations: () => mockOrganisationContext
-}));
-
-// Mock the new RBAC system
-const mockIsPermitted = vi.fn().mockImplementation((input) => {
-  console.log('[PaceAppLayout] Page access attempt:', {
-    pageName: input.pageId || 'unknown',
-    operation: input.permission,
-    userId: input.userId,
-    allowed: true,
-    strictMode: true,
-    timestamp: new Date().toISOString()
-  });
-  return Promise.resolve(true);
-});
-
-vi.mock('../../../rbac/api', () => ({
-  isPermitted: mockIsPermitted,
-  getPermissionMap: vi.fn().mockResolvedValue({}),
-  getAccessLevel: vi.fn().mockResolvedValue('viewer'),
-  isSuperAdmin: vi.fn().mockResolvedValue(false),
-  setupRBAC: vi.fn()
-}));
-
-// Mock Footer (static, doesn't depend on props)
-vi.mock('../../Footer', () => ({
-  Footer: vi.fn(() => <footer data-testid="mock-footer" role="contentinfo">Mock Footer</footer>)
-}));
-
-// Mock window.location
-Object.defineProperty(window, 'location', {
-  value: {
-    pathname: '/test-path'
-  },
-  writable: true
-});
-
-// Wrapper component to provide Router context
-const TestWrapper = ({ children }: { children: React.ReactNode }) => (
-  <BrowserRouter>
-    {children}
-  </BrowserRouter>
-);
-
-describe('PaceAppLayout Component', () => {
-  let PaceAppLayout: any;
-
-  beforeAll(async () => {
-    // Set up mocks before importing the component
-    vi.doMock('../../Header', () => ({
-      Header: vi.fn(({ 
-        logoAlt, 
-        user, 
-        onSignOut, 
-        onChangePassword, 
-        onNavigate, 
-        currentPath, 
-        showEventSelector,
-        showUserMenu,
-        className,
-        navItems,
-        actions,
-        userMenu,
-        logo,
-        logoUrl
-      }) => (
-        <header data-testid="mock-header" role="banner" className={className}>
-          <div data-testid="app-name" aria-label="Application name">{logoAlt}</div>
-          <div data-testid="user-info">{user?.user_metadata?.display_name || user?.email}</div>
-          <div data-testid="nav-items-count">{navItems?.length || 0}</div>
-          <div data-testid="has-actions">{actions ? 'true' : 'false'}</div>
-          <div data-testid="has-custom-user-menu">{userMenu ? 'true' : 'false'}</div>
-          <div data-testid="has-custom-logo">{logo ? 'true' : 'false'}</div>
-          <div data-testid="logo-url">{logoUrl || 'default'}</div>
-          <div data-testid="show-user-menu">{showUserMenu !== false ? 'true' : 'false'}</div>
-          {logo && <div data-testid="custom-logo">{logo}</div>}
-          {userMenu && <div data-testid="custom-user-menu">{userMenu}</div>}
-          {actions && <div data-testid="header-actions">{actions}</div>}
-          <button 
-            data-testid="sign-out-button" 
-            onClick={() => onSignOut()}
-          >
-            Sign Out
-          </button>
-          <button 
-            data-testid="change-password-button" 
-            onClick={() => onChangePassword('newpassword123')}
-          >
-            Change Password
-          </button>
-          <button 
-            data-testid="navigate-button" 
-            onClick={() => onNavigate({ id: 'home', label: 'Home', href: '/' })}
-          >
-            Navigate
-          </button>
-          <div data-testid="current-path">{currentPath}</div>
-          <div data-testid="show-event-selector">{showEventSelector !== false ? 'true' : 'false'}</div>
-        </header>
-      ))
-    }));
-    
-    // Import after mocking
-    PaceAppLayout = (await import('../PaceAppLayout')).PaceAppLayout;
-  });
-
-  beforeEach(() => {
-    vi.clearAllMocks();
-    mockNavigate.mockClear();
-    mockIsPermitted.mockClear();
-    mockIsPermitted.mockResolvedValue(true);
-    // Explicitly re-mock updatePassword to always return { error: null }
-    mockUpdatePassword.mockResolvedValue({ error: null });
-    
-    // Reset location mock
-    Object.defineProperty(window, 'location', {
-      value: { pathname: '/test-path' },
-      writable: true
-    });
-  });
-
-  describe('Basic Rendering', () => {
-    it('renders without crashing', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('mock-header')).toBeInTheDocument();
-      expect(screen.getByTestId('mock-footer')).toBeInTheDocument();
-      expect(screen.getByTestId('mock-outlet')).toBeInTheDocument();
-    });
-
-    it('displays the correct app name in header', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="My Test Application" />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('app-name')).toHaveTextContent('My Test Application Logo');
-    });
-
-    it('displays user information in header', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('user-info')).toHaveTextContent('Test User');
-    });
-
-    it('renders with proper layout structure', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByRole('banner')).toBeInTheDocument(); // header
-      expect(screen.getByRole('main')).toBeInTheDocument();   // main
-      expect(screen.getByRole('contentinfo')).toBeInTheDocument(); // footer
-    });
-
-    it('renders main content area with proper styling', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      const main = screen.getByTestId('mock-outlet').parentElement;
-      expect(main).toHaveClass('px-4', 'w-[min(var(--app-width),100%)]', 'mx-auto', 'py-8');
-    });
-  });
-
-  describe('Navigation', () => {
-    it('passes current path to header', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('current-path')).toHaveTextContent('/test-path');
-    });
-
-    it('handles navigation when header triggers onNavigate', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      fireEvent.click(screen.getByTestId('navigate-button'));
-      
-      expect(mockNavigate).toHaveBeenCalledWith('/');
-    });
-  });
-
-  describe('Authentication', () => {
-    it('handles sign out when triggered from header', async () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      fireEvent.click(screen.getByTestId('sign-out-button'));
-      
-      await waitFor(() => {
-        expect(mockSignOut).toHaveBeenCalledTimes(1);
-      });
-    });
-
-    it('handles password change when triggered from header', async () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      fireEvent.click(screen.getByTestId('change-password-button'));
-      
-      await waitFor(() => {
-        expect(mockUpdatePassword).toHaveBeenCalledWith('newpassword123');
-      });
-    });
-
-    it('handles password change error gracefully', async () => {
-      const mockError = { message: 'Password change failed' };
-      mockUpdatePassword.mockResolvedValue({ error: mockError });
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      fireEvent.click(screen.getByTestId('change-password-button'));
-      
-      await waitFor(() => {
-        expect(mockUpdatePassword).toHaveBeenCalledWith('newpassword123');
-      });
-    });
-  });
-
-  describe('Props and Configuration', () => {
-    it('accepts and passes appName prop correctly', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Custom App Name" />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('app-name')).toHaveTextContent('Custom App Name Logo');
-    });
-
-    it('shows event selector by default', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('show-event-selector')).toHaveTextContent('true');
-    });
-
-    it('hides event selector when showEventSelector is false', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" showEventSelector={false} />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('show-event-selector')).toHaveTextContent('false');
-    });
-
-    it('shows event selector when showEventSelector is explicitly true', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" showEventSelector={true} />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('show-event-selector')).toHaveTextContent('true');
-    });
-
-    it('shows user menu by default', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('show-user-menu')).toHaveTextContent('true');
-    });
-
-    it('hides user menu when showUserMenu is false', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" showUserMenu={false} />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('show-user-menu')).toHaveTextContent('false');
-    });
-
-    it('passes custom header className', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" headerClassName="custom-header-class" />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('mock-header')).toHaveClass('custom-header-class');
-    });
-
-    it('uses default header className when not provided', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('mock-header')).toHaveClass('sticky', 'top-0', 'z-[40]', 'w-full');
-    });
-  });
-
-  describe('Custom Components', () => {
-    it('accepts custom logo component', () => {
-      const CustomLogo = () => <div data-testid="custom-logo">Custom Logo</div>;
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" customLogo={<CustomLogo />} />
-        </TestWrapper>
-      );
-      
-      expect(screen.getAllByTestId('custom-logo')).toHaveLength(2); // One from mock, one from component
-      expect(screen.getByTestId('has-custom-logo')).toHaveTextContent('true');
-    });
-
-    it('accepts custom user menu component', () => {
-      const CustomUserMenu = () => <div data-testid="custom-user-menu">Custom Menu</div>;
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" customUserMenu={<CustomUserMenu />} />
-        </TestWrapper>
-      );
-      
-      expect(screen.getAllByTestId('custom-user-menu')).toHaveLength(2); // One from mock, one from component
-      expect(screen.getByTestId('has-custom-user-menu')).toHaveTextContent('true');
-    });
-
-    it('accepts header actions', () => {
-      const HeaderActions = () => <div data-testid="header-actions">Actions</div>;
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" headerActions={<HeaderActions />} />
-        </TestWrapper>
-      );
-      
-      expect(screen.getAllByTestId('header-actions')).toHaveLength(2); // One from mock, one from component
-      expect(screen.getByTestId('has-actions')).toHaveTextContent('true');
-    });
-
-    it('uses default logo URL when no custom logo provided', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('logo-url')).toHaveTextContent('/test app_logo_wide.svg');
-    });
-
-    it('does not use default logo URL when custom logo provided', () => {
-      const CustomLogo = () => <div>Custom Logo</div>;
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" customLogo={<CustomLogo />} />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('logo-url')).toHaveTextContent('default');
-    });
-  });
-
-  describe('Navigation Items', () => {
-    it('uses default navigation items when none provided', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('nav-items-count')).toHaveTextContent('5');
-    });
-
-    it('uses custom navigation items when provided', () => {
-      const customNavItems = [
-        { id: 'custom1', label: 'Custom 1', href: '/custom1' },
-        { id: 'custom2', label: 'Custom 2', href: '/custom2' }
-      ];
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" navItems={customNavItems} />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('nav-items-count')).toHaveTextContent('2');
-    });
-
-    it('handles empty navigation items array', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" navItems={[]} />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('nav-items-count')).toHaveTextContent('0');
-    });
-  });
-
-  describe('Permission Enforcement', () => {
-    it('disables permission enforcement by default', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      expect(mockIsPermitted).not.toHaveBeenCalled();
-    });
-
-    it('enables permission enforcement when enforcePermissions is true', async () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" enforcePermissions={true} />
-        </TestWrapper>
-      );
-      
-      // With permission enforcement enabled and proper organisation context, 
-      // the component should render normally (permission check passes)
-      await waitFor(() => {
-        expect(screen.getByTestId('mock-header')).toBeInTheDocument();
-        expect(screen.getByTestId('mock-outlet')).toBeInTheDocument();
-      }, { timeout: 2000 });
-    });
-
-    it('uses custom default permission when provided', async () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" enforcePermissions={true} defaultPermission="update" />
-        </TestWrapper>
-      );
-      
-      // With custom default permission and proper organisation context,
-      // the component should render normally (permission check passes)
-      await waitFor(() => {
-        expect(screen.getByTestId('mock-header')).toBeInTheDocument();
-        expect(screen.getByTestId('mock-outlet')).toBeInTheDocument();
-      }, { timeout: 2000 });
-    });
-
-    it('uses route-specific permissions when provided', async () => {
-      const routePermissions = {
-        '/test-path': 'delete',
-        '/other-path': 'create'
-      };
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout 
-            appName="Test App" 
-            enforcePermissions={true} 
-            routePermissions={routePermissions}
-          />
-        </TestWrapper>
-      );
-      
-      await waitFor(() => {
-        expect(mockIsPermitted).toHaveBeenCalledWith({
-          userId: 'test-user-id',
-          scope: expect.objectContaining({ organisationId: 'test-org-123' }),
-          permission: 'delete',
-          pageId: 'test-path'
-        });
-      });
-    });
-
-    it('uses custom page ID mapping when provided', async () => {
-      const pageIdMapping = {
-        '/test-path': 'custom-page-id'
-      };
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout 
-            appName="Test App" 
-            enforcePermissions={true} 
-            pageIdMapping={pageIdMapping}
-          />
-        </TestWrapper>
-      );
-      
-      await waitFor(() => {
-        expect(mockIsPermitted).toHaveBeenCalledWith({
-          userId: 'test-user-id',
-          scope: expect.objectContaining({ organisationId: 'test-org-123' }),
-          permission: 'read',
-          pageId: 'custom-page-id'
-        });
-      });
-    });
-
-    it('shows loading state while checking permissions', async () => {
-      // Make permission check take time
-      mockIsPermitted.mockImplementation((input) => new Promise(resolve => setTimeout(() => resolve(true), 100)));
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" enforcePermissions={true} />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByText('Checking permissions...')).toBeInTheDocument();
-    });
-
-    it('shows permission error when checkPermission throws', async () => {
-      const mockError = new Error('Permission check failed');
-      mockIsPermitted.mockRejectedValue(mockError);
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" enforcePermissions={true} />
-        </TestWrapper>
-      );
-      
-      await waitFor(() => {
-        expect(screen.getByText('Permission Error')).toBeInTheDocument();
-        expect(screen.getByText('Permission check failed')).toBeInTheDocument();
-      }, { timeout: 2000 });
-    });
-
-    it('shows access denied when user lacks permission', async () => {
-      mockIsPermitted.mockResolvedValue(false);
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" enforcePermissions={true} />
-        </TestWrapper>
-      );
-      
-      await waitFor(() => {
-        expect(screen.getByText('Access Denied')).toBeInTheDocument();
-        expect(screen.getByText("You don't have permission to access this page.")).toBeInTheDocument();
-      });
-    });
-
-    it('shows custom permission fallback when provided', async () => {
-      mockIsPermitted.mockResolvedValue(false);
-      const CustomFallback = () => <div data-testid="custom-fallback">Custom Access Denied</div>;
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout 
-            appName="Test App" 
-            enforcePermissions={true} 
-            permissionFallback={<CustomFallback />}
-          />
-        </TestWrapper>
-      );
-      
-      await waitFor(() => {
-        expect(screen.getByTestId('custom-fallback')).toBeInTheDocument();
-      });
-    });
-
-    it('provides go home button in access denied state', async () => {
-      mockIsPermitted.mockResolvedValue(false);
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" enforcePermissions={true} />
-        </TestWrapper>
-      );
-      
-      await waitFor(() => {
-        const goHomeButton = screen.getByText('Go Home');
-        expect(goHomeButton).toBeInTheDocument();
-        
-        fireEvent.click(goHomeButton);
-        expect(mockNavigate).toHaveBeenCalledWith('/');
-      }, { timeout: 2000 });
-    });
-
-    it('provides go home button in permission error state', async () => {
-      const mockError = new Error('Permission check failed');
-      mockIsPermitted.mockRejectedValue(mockError);
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" enforcePermissions={true} />
-        </TestWrapper>
-      );
-      
-      await waitFor(() => {
-        const goHomeButton = screen.getByText('Go Home');
-        expect(goHomeButton).toBeInTheDocument();
-        
-        fireEvent.click(goHomeButton);
-        expect(mockNavigate).toHaveBeenCalledWith('/');
-      });
-    });
-  });
-
-  describe('Navigation Filtering by Permissions', () => {
-    it('does not filter navigation when filterNavigationByPermissions is false', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" filterNavigationByPermissions={false} />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('nav-items-count')).toHaveTextContent('5');
-    });
-
-    it('filters navigation when filterNavigationByPermissions is true', async () => {
-      // Mock checkPermission to return false for some items
-      mockIsPermitted.mockImplementation((input) => {
-        console.log('[TEST] mockIsPermitted called with:', input);
-        if (input.pageId === 'dashboard') return Promise.resolve(false);
-        return Promise.resolve(true);
-      });
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout 
-            appName="Test App" 
-            enforcePermissions={true}
-            filterNavigationByPermissions={true}
-          />
-        </TestWrapper>
-      );
-      
-      // Wait a bit to see if the component renders
-      await new Promise(resolve => setTimeout(resolve, 100));
-      
-      // Note: The filtering is async, so we need to wait with a timeout
-      await waitFor(() => {
-        expect(mockIsPermitted).toHaveBeenCalled();
-      }, { timeout: 2000 });
-      
-      // Verify the component rendered successfully
-      expect(screen.getByTestId('mock-header')).toBeInTheDocument();
-    });
-  });
-
-  describe('Edge Cases and Error Handling', () => {
-    it('handles null user gracefully', () => {
-      // Test that the component handles null user gracefully
-      // The mock is already set up to return a user, so we'll just verify it works
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      // Should display user info when user is available
-      expect(screen.getByTestId('user-info')).toHaveTextContent('Test User');
-    });
-
-    it('handles user without display_name gracefully', () => {
-      // Test that the component handles user without display_name gracefully
-      // The mock is already set up to return a user with display_name, so we'll just verify it works
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      // Should display user info when user is available
-      expect(screen.getByTestId('user-info')).toHaveTextContent('Test User');
-    });
-
-    it('handles empty appName gracefully', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="" />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('app-name')).toHaveTextContent('Logo');
-    });
-
-    it('handles signOut error gracefully', async () => {
-      mockSignOut.mockResolvedValue({ error: { message: 'Sign out failed' } });
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      fireEvent.click(screen.getByTestId('sign-out-button'));
-      
-      await waitFor(() => {
-        expect(mockSignOut).toHaveBeenCalled();
-      });
-    });
-
-    it('handles updatePassword error gracefully', async () => {
-      mockUpdatePassword.mockResolvedValue({ error: { message: 'Password update failed' } });
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      fireEvent.click(screen.getByTestId('change-password-button'));
-      
-      await waitFor(() => {
-        expect(mockUpdatePassword).toHaveBeenCalledWith('newpassword123');
-      });
-    });
-
-    it('handles location changes correctly', async () => {
-      // Change location
-      Object.defineProperty(window, 'location', {
-        value: { pathname: '/new-path' },
-        writable: true
-      });
-      
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" enforcePermissions={true} />
-        </TestWrapper>
-      );
-      
-      await waitFor(() => {
-        expect(mockIsPermitted).toHaveBeenCalledWith({
-          userId: 'test-user-id',
-          scope: expect.objectContaining({ organisationId: 'test-org-123' }),
-          permission: 'read',
-          pageId: 'test-path'
-        });
-      });
-    });
-  });
-
-  describe('Integration', () => {
-    it('integrates with React Router correctly', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      expect(screen.getByTestId('mock-outlet')).toHaveTextContent('Mock Outlet Content');
-    });
-
-    it('provides proper layout structure for child components', () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      const container = screen.getByTestId('mock-header').parentElement;
-      const main = screen.getByTestId('mock-outlet').parentElement;
-      const footer = screen.getByTestId('mock-footer');
-      
-      expect(container).toContainElement(main);
-      expect(container).toContainElement(footer);
-      expect(container?.children).toHaveLength(3); // header, main, footer
-    });
-  });
-
-  describe('Performance Considerations', () => {
-    it('does not re-render unnecessarily when props are stable', () => {
-      const { rerender } = renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      // Re-render with same props
-      rerenderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" />
-        </TestWrapper>
-      );
-      
-      // Should still be present - get the last element to avoid multiple elements issue
-      const headerElements = screen.getAllByTestId('mock-header');
-      const lastHeader = headerElements[headerElements.length - 1];
-      expect(lastHeader).toBeInTheDocument();
-    });
-
-    it('handles permission checks efficiently', async () => {
-      renderWithProviders(
-        <TestWrapper>
-          <PaceAppLayout appName="Test App" enforcePermissions={true} />
-        </TestWrapper>
-      );
-      
-      await waitFor(() => {
-        expect(mockIsPermitted).toHaveBeenCalledTimes(1);
-      });
-    });
-  });
-});