@jmcombs/pi-1password 1.0.1 → 2.0.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jmcombs/pi-1password",
-  "version": "1.0.1",
+  "version": "2.0.0",
   "description": "1Password integration for the Pi coding agent. Read secrets and run commands with 1Password credential injection via the op CLI.",
   "homepage": "https://github.com/jmcombs/pi-extensions/tree/main/packages/1password",
   "repository": {
@@ -18,6 +18,7 @@
   "types": "./index.ts",
   "files": [
     "index.ts",
+    "credential-api.ts",
     "data/",
     "ui/",
     "README.md",
@@ -46,8 +47,8 @@
     "typebox": "*"
   },
   "devDependencies": {
-    "@earendil-works/pi-coding-agent": "^0.75.4",
+    "@earendil-works/pi-coding-agent": "^0.80.6",
     "@earendil-works/pi-tui": "*",
-    "typebox": "^1.1.37"
+    "typebox": "^1.3.6"
   }
 }

package/ui/bordered-popups.ts

@@ -51,7 +51,8 @@
  * are still perfectly acceptable and require less code.
  */
 
-import type { ExtensionCommandContext, Theme } from "@earendil-works/pi-coding-agent";
+import type { Theme } from "@earendil-works/pi-coding-agent";
+import type { UiContext } from "../credential-api.js";
 
 // No static imports from @earendil-works/pi-tui are used for types.
 // We rely on inference for ctx.ui.custom callback parameters (sourced via the
@@ -70,8 +71,8 @@ export function renderBorderedBox(
   truncateToWidthFn: (s: string, w: number, e?: string, pad?: boolean) => string,
 ): string[] {
   const innerWidth = Math.max(20, width - 4);
-  const top = theme.fg("accent", "╭" + "─".repeat(width - 2) + "╮");
-  const bottom = theme.fg("accent", "╰" + "─".repeat(width - 2) + "╯");
+  const top = theme.fg("accent", `╭${"─".repeat(width - 2)}╮`);
+  const bottom = theme.fg("accent", `╰${"─".repeat(width - 2)}╯`);
 
   const rawTitle = theme.fg("accent", theme.bold(title));
   const titlePadded = truncateToWidthFn(rawTitle, innerWidth, "", true);
@@ -99,9 +100,11 @@ export function renderBorderedBox(
  * Returns the chosen `.value` or `null` (on cancel / Esc).
  */
 export async function selectInBorderedPopup<T = string>(
-  ctx: ExtensionCommandContext,
+  ctx: UiContext,
   opts: {
     title: string;
+    /** Optional body text shown above the list. Split on `\n` into lines. */
+    message?: string;
     items: { value: T; label: string; description?: string }[];
     helpText?: string;
     maxVisible?: number;
@@ -121,8 +124,8 @@ export async function selectInBorderedPopup<T = string>(
     onCancel: () => void;
   }
 
-  // Let inference provide the exact callback parameter types from the
-  // ExtensionCommandContext (via coding-agent peer). Explicit annotations
+  // Let inference provide the exact callback parameter types from
+  // `ctx.ui.custom` (via the coding-agent peer). Explicit annotations
   // referencing TUI/KeybindingsManager etc. from pi-tui trigger the
   // "separate declarations of private property" tsc error in the monorepo.
   return await ctx.ui.custom<T | null>(
@@ -176,8 +179,18 @@ export async function selectInBorderedPopup<T = string>(
         dispose?(): void;
       } = {
         render(width: number) {
-          const listLines = currentList ? currentList.render(Math.max(20, width - 4)) : [];
-          return renderBorderedBox(width, opts.title, listLines, help, theme, truncateToWidthFn);
+          const innerWidth = Math.max(20, width - 4);
+          const body: string[] = [];
+          if (opts.message) {
+            for (const line of opts.message.split("\n")) {
+              body.push(theme.fg("text", line));
+            }
+            body.push("");
+          }
+          if (currentList) {
+            body.push(...currentList.render(innerWidth));
+          }
+          return renderBorderedBox(width, opts.title, body, help, theme, truncateToWidthFn);
         },
         invalidate() {
           container.invalidate();
@@ -197,7 +210,7 @@ export async function selectInBorderedPopup<T = string>(
 
 /** Yes/No (or custom labels) confirmation inside a bordered popup. */
 export async function confirmInBorderedPopup(
-  ctx: ExtensionCommandContext,
+  ctx: UiContext,
   opts: {
     title: string;
     message?: string;
@@ -214,6 +227,7 @@ export async function confirmInBorderedPopup(
 
   const choice = await selectInBorderedPopup(ctx, {
     title: opts.title,
+    message: opts.message,
     items,
     helpText: "↑↓ • Enter to confirm • Esc = cancel",
     maxVisible: 5,
@@ -225,14 +239,22 @@ export async function confirmInBorderedPopup(
 /**
  * Bordered popup text input powered by Pi's Editor component.
  * Good for free-text entry while staying inside the custom popup aesthetic.
+ *
+ * When `mask` is set the popup renders one `•` per typed code point **instead of**
+ * the Editor's own glyphs — the secret is never drawn on screen. The Editor is
+ * still used as the (headless) input model so key decoding, paste, and submit all
+ * work; we simply never call `editor.render()` in masked mode, so no plaintext is
+ * ever emitted. `prompt` is split on `\n` so a multi-line notice renders in full.
  */
 export async function inputInBorderedPopup(
-  ctx: ExtensionCommandContext,
+  ctx: UiContext,
   opts: {
     title: string;
     prompt?: string;
     defaultValue?: string;
     helpText?: string;
+    /** Render typed input as `•` bullets instead of the plaintext value. */
+    mask?: boolean;
   },
 ): Promise<string | undefined> {
   const help = opts.helpText ?? "Enter to confirm • Esc = cancel";
@@ -243,6 +265,7 @@ export async function inputInBorderedPopup(
     invalidate(): void;
     handleInput(d: string): void;
     setText(s: string): void;
+    getText(): string;
     onSubmit: (value: string) => void;
   }
 
@@ -289,12 +312,19 @@ export async function inputInBorderedPopup(
           const body: string[] = [];
 
           if (opts.prompt) {
-            body.push(theme.fg("text", opts.prompt));
+            for (const line of opts.prompt.split("\n")) {
+              body.push(theme.fg("text", line));
+            }
             body.push("");
           }
 
-          const editorLines = editor.render(innerWidth);
-          body.push(...editorLines);
+          if (opts.mask) {
+            // Never draw the Editor's glyphs; render one bullet per code point.
+            const masked = "•".repeat([...editor.getText()].length);
+            body.push(theme.fg("text", masked));
+          } else {
+            body.push(...editor.render(innerWidth));
+          }
 
           return renderBorderedBox(width, opts.title, body, help, theme, truncateToWidthFn);
         },