@jmcombs/pi-1password 1.0.0 → 1.0.2

package/index.ts

@@ -13,16 +13,19 @@
  *   - https://pi.dev/docs/extensions
  */
 
-import type { ExtensionAPI, ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
-import { createBashTool, createLocalBashOperations } from "@earendil-works/pi-coding-agent";
-import { Type, type Static } from "typebox";
-import { promisify } from "node:util";
 import { exec } from "node:child_process";
 import { chmod, mkdir, readFile, writeFile } from "node:fs/promises";
 import { homedir } from "node:os";
 import { dirname, join } from "node:path";
-import { getAgentDir } from "@earendil-works/pi-coding-agent";
 import { fileURLToPath } from "node:url";
+import { promisify } from "node:util";
+import type { ExtensionAPI, ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
+import {
+  createBashTool,
+  createLocalBashOperations,
+  getAgentDir,
+} from "@earendil-works/pi-coding-agent";
+import { type Static, Type } from "typebox";
 
 import {
   confirmInBorderedPopup,
@@ -133,7 +136,6 @@ async function inspectPluginIfRelevant(command: string): Promise<PluginInspectio
     return { plugin: firstWord, output: (stdout || "").trim() };
   } catch (e: unknown) {
     const error = e as { stderr?: string; message?: string };
-    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
     const msg = (error.stderr?.trim() ?? error.message) || "Unknown error";
     return { plugin: firstWord, error: msg };
   }
@@ -235,10 +237,9 @@ async function resolveShellValue(raw: unknown): Promise<string | null> {
 async function loadShellEnvMap(): Promise<Record<string, string>> {
   const home = homedir() || "/tmp";
   const authPath = join(home, ".pi", "agent", "auth.json");
-  const map: Record<string, string> = {};
+  const map = new Map<string, string>();
 
   try {
-    // eslint-disable-next-line security/detect-non-literal-fs-filename
     const raw = await readFile(authPath, "utf8");
     const parsed = JSON.parse(raw) as AuthJson;
 
@@ -248,15 +249,14 @@ async function loadShellEnvMap(): Promise<Record<string, string>> {
 
       const resolved = await resolveShellValue(val);
       if (resolved !== null) {
-        // eslint-disable-next-line security/detect-object-injection
-        map[key] = resolved;
+        map.set(key, resolved);
       }
     }
   } catch {
     // File missing or unreadable — no shell env injection this session
   }
 
-  return map;
+  return Object.fromEntries(map);
 }
 
 // In-memory map for the current session (populated on session_start)
@@ -299,19 +299,22 @@ async function addAuthEntry(
   const authDir = getAgentDir();
   const authPath = join(authDir, "auth.json");
 
-  // eslint-disable-next-line security/detect-non-literal-fs-filename
   await mkdir(authDir, { recursive: true });
 
-  let existing: Record<string, unknown> = {};
+  const existing = new Map<string, unknown>();
   try {
-    // eslint-disable-next-line security/detect-non-literal-fs-filename
     const raw = await readFile(authPath, "utf8");
-    existing = JSON.parse(raw) as Record<string, unknown>;
+    const parsed: unknown = JSON.parse(raw);
+    if (parsed && typeof parsed === "object" && !Array.isArray(parsed)) {
+      for (const [k, v] of Object.entries(parsed as Record<string, unknown>)) {
+        existing.set(k, v);
+      }
+    }
   } catch {
     // File missing or invalid JSON → start fresh
   }
 
-  const alreadyExists = existing[envVar] !== undefined;
+  const alreadyExists = existing.has(envVar);
 
   if (alreadyExists && !options.overwrite) {
     return {
@@ -322,13 +325,10 @@ async function addAuthEntry(
   }
 
   // Convention: single quotes around the op:// ref
-  // eslint-disable-next-line security/detect-object-injection
-  existing[envVar] = `!op read '${opRef}'`;
+  existing.set(envVar, `!op read '${opRef}'`);
 
-  const content = JSON.stringify(existing, null, 2) + "\n";
-  // eslint-disable-next-line security/detect-non-literal-fs-filename
+  const content = `${JSON.stringify(Object.fromEntries(existing), null, 2)}\n`;
   await writeFile(authPath, content, "utf8");
-  // eslint-disable-next-line security/detect-non-literal-fs-filename
   await chmod(authPath, 0o600);
 
   return { success: true, message: "Entry added.", path: authPath };
@@ -464,7 +464,7 @@ export default async function (pi: ExtensionAPI): Promise<void> {
       if (info) inspections.push(info);
     }
 
-    let report = formatOpStatus(status) + "\n\n";
+    let report = `${formatOpStatus(status)}\n\n`;
 
     if (inspections.length > 0) {
       report += "Plugin configuration:\n";
@@ -598,7 +598,7 @@ export default async function (pi: ExtensionAPI): Promise<void> {
     const itemItems = [
       ...items.map((it) => ({
         value: it.id,
-        label: `${it.title}${it.category ? " — " + it.category : ""}`,
+        label: `${it.title}${it.category ? ` — ${it.category}` : ""}`,
       })),
       { value: "__cancel", label: "Cancel" },
     ];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jmcombs/pi-1password",
-  "version": "1.0.0",
+  "version": "1.0.2",
   "description": "1Password integration for the Pi coding agent. Read secrets and run commands with 1Password credential injection via the op CLI.",
   "homepage": "https://github.com/jmcombs/pi-extensions/tree/main/packages/1password",
   "repository": {
@@ -46,7 +46,7 @@
     "typebox": "*"
   },
   "devDependencies": {
-    "@earendil-works/pi-coding-agent": "^0.75.4",
+    "@earendil-works/pi-coding-agent": "^0.80.2",
     "@earendil-works/pi-tui": "*",
     "typebox": "^1.1.37"
   }

package/ui/bordered-popups.ts

@@ -70,8 +70,8 @@ export function renderBorderedBox(
   truncateToWidthFn: (s: string, w: number, e?: string, pad?: boolean) => string,
 ): string[] {
   const innerWidth = Math.max(20, width - 4);
-  const top = theme.fg("accent", "╭" + "─".repeat(width - 2) + "╮");
-  const bottom = theme.fg("accent", "╰" + "─".repeat(width - 2) + "╯");
+  const top = theme.fg("accent", `╭${"─".repeat(width - 2)}╮`);
+  const bottom = theme.fg("accent", `╰${"─".repeat(width - 2)}╯`);
 
   const rawTitle = theme.fg("accent", theme.bold(title));
   const titlePadded = truncateToWidthFn(rawTitle, innerWidth, "", true);