@jkba/eslint-config-angular 1.0.1 → 1.2.0

package/README.md

@@ -21,6 +21,7 @@ npm i -D \
   eslint-plugin-prettier \
   eslint-plugin-rxjs \
   eslint-plugin-rxjs-angular \
+  eslint-import-resolver-typescript \
   @jkba/eslint-config-angular
 
 ```
@@ -30,7 +31,7 @@ npm i -D \
 
 Extend your eslint configuration with `"@jkba/angular"`:
 
-```javascript
+```js
 // .eslintrc.json
 
 {
@@ -49,14 +50,50 @@ module.exports = require('@jkba/eslint-config-angular/prettier.config');
 
 ### Modifying rules
 
-> :warning: Work in Progress
+Modify (add/disable/override) specific rules via the `rules` property:
+
+```js
+// .eslintrc.json
+
+{
+  "extends": [ "@jkba/angular" ],
+  "rules": {
+    "@typescript-eslint/prefer-nullish-coalescing": "off", // Requires the `strictNullChecks` compiler option to be turned on to function correctly.
+    "@typescript-eslint/no-unnecessary-condition": "off", // Requires the `strictNullChecks` compiler option to be turned on to function correctly.
+    "@angular-eslint/template/click-events-have-key-events": "off", // Accessibility is not supported on this project
+    "@angular-eslint/template/interactive-supports-focus": "off", // Accessibility is not supported on this project
+  }
+}
+```
+
+or using the `overrides` property:
+
+```js
+// .eslintrc.json
+
+{
+  "extends": [ "@jkba/angular" ],
+  "overrides": [
+    {
+      "files": [ "*.html" ],
+      "parserOptions": { "parser": "@angular-eslint/template-parser" },
+      "rules": {
+        "@angular-eslint/template/i18n": "off" // i18n is not supported on this project
+      }
+    }
+  ]
+}
+```
+
+Reference [Overriding Settings from Shareable Configs](https://eslint.org/docs/latest/extend/shareable-configs#overriding-settings-from-shareable-configs).
 
 
 ## Build
 
-> :warning: Work in Progress
+Use `npm link` and then `npm link @jkba/eslint-config-angular` in your project.
+PRs are welcome but keep in mind this is an opinionated configuration. 
 
-Refer to https://eslint.org/docs/latest/extend/shareable-configs.
+Reference [Share Configurations](https://eslint.org/docs/latest/extend/shareable-configs).
 
 
 ## License

package/eslint.config.js

@@ -24,7 +24,7 @@ module.exports = {
         // This rule might intentionally disable some rules declared above due to conflicts
         'plugin:prettier/recommended',
       ],
-      plugins: ['@typescript-eslint', '@angular-eslint', 'rxjs', 'rxjs-angular'],
+      plugins: ['@typescript-eslint', '@angular-eslint', 'rxjs', 'rxjs-angular', 'import'],
       settings: {
         // Reference https://www.npmjs.com/package/eslint-plugin-import
         'import/resolver': {
@@ -47,6 +47,29 @@ module.exports = {
         'rxjs-angular/prefer-async-pipe': 'error',
         'rxjs-angular/prefer-composition': 'error',
         'rxjs-angular/prefer-takeuntil': 'error',
+
+        // Reference https://github.com/cartant/eslint-plugin-rxjs/blob/main/docs/rules/finnish.md
+        'rxjs/finnish': [
+          'error',
+          {
+            'functions': false,
+            'methods': false,
+            'names': {
+                '^(canActivate|canActivateChild|canDeactivate|canLoad|intercept|resolve|validate)$': false
+            },
+            'parameters': true,
+            'properties': true,
+            'strict': false,
+            'types': {
+                '^EventEmitter$': false,
+                '^Store$': false
+            },
+            'variables': true
+          }
+        ],
+        'rxjs/no-exposed-subjects': [ 'error', { 'allowProtected': true } ],
+        'rxjs/no-compat': 'error',
+        'rxjs/throw-error': 'error',
         
         '@typescript-eslint/unbound-method': ['error', { ignoreStatic: true }], // Ignore `Validators.required` etc.
         '@typescript-eslint/no-confusing-void-expression': 'off', // I just simply disagree with this rule
@@ -79,7 +102,13 @@ module.exports = {
         'import/order': [
           'error',
           {
-            'groups': ['builtin', 'external', 'parent', 'sibling', 'index'],
+            'groups': [
+              ['builtin', 'external'],
+              'internal',
+              'parent',
+              'sibling',
+              'index',
+            ],          
             'newlines-between': 'always',
             'alphabetize': {
               'order': 'asc',
@@ -87,6 +116,9 @@ module.exports = {
             }
           }
         ],
+        'import/no-useless-path-segments': ['error', { noUselessIndex: true }],
+        // 'import/no-deprecated': 'error', // Throws false-positive for RxJS,
+        'import/no-self-import': 'error',
       },
     },
     {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jkba/eslint-config-angular",
-  "version": "1.0.1",
+  "version": "1.2.0",
   "description": "Opinionated ESLint config for Angular projects",
   "main": "index.js",
   "scripts": {
@@ -24,6 +24,7 @@
     "package.json",
     "prettier.config.js"
   ],
+  "readme": "README.md",
   "author": "Jakub Meinlschmidt",
   "license": "MIT",
   "bugs": {
@@ -31,18 +32,19 @@
   },
   "homepage": "https://github.com/jmeinlschmidt/eslint-config-angular#readme",
   "peerDependencies": {
-    "eslint": ">=8",
-    "typescript": ">=4",
-    "prettier": ">=3",
     "@angular-eslint/eslint-plugin": ">=16",
     "@angular-eslint/eslint-plugin-template": ">=16",
     "@angular-eslint/template-parser": ">=16",
     "@typescript-eslint/eslint-plugin": ">=6",
     "@typescript-eslint/parser": ">=6",
-    "eslint-plugin-import": ">=2.27.0",
+    "eslint": ">=8",
     "eslint-config-prettier": ">=8",
+    "eslint-plugin-import": ">=2.27.0",
     "eslint-plugin-prettier": ">=5",
     "eslint-plugin-rxjs": ">=5",
-    "eslint-plugin-rxjs-angular": ">=2"
+    "eslint-plugin-rxjs-angular": ">=2",
+    "eslint-import-resolver-typescript": ">= 3.5.5",
+    "prettier": ">=3",
+    "typescript": ">=4"
   }
 }