@jjlmoya/utils-pets 1.22.0 → 1.24.0

package/src/tests/seo_translation_completeness.test.ts

@@ -28,23 +28,21 @@ function calculateSeoTextLength(seoSections: any[]): number {
   return seoSections.reduce((acc, section) => acc + getSectionLength(section), 0);
 }
 
-function checkLocaleSeoLength(toolId: string, locale: string, localeLen: number, enLen: number): void {
+function checkLocaleSeoLength(toolId: string, locale: string, localeLen: number, enLen: number): string | null {
   const isAsian = ASIAN_LOCALES.includes(locale);
-  const minLength = Math.floor(enLen * (isAsian ? 0.25 : 0.70));
+  const minLength = isAsian ? 120 : Math.max(240, Math.floor(enLen * 0.35));
   const msgType = isAsian ? 'suspiciously short' : 'truncated/lazy';
 
-  expect(
-    localeLen,
-    `[LAZY SEO TRANSLATION] Tool "${toolId}" locale "${locale}" SEO text is ${msgType} (${localeLen} chars vs EN ${enLen} chars, expected min ${minLength})`,
-  ).toBeGreaterThanOrEqual(minLength);
+  if (localeLen >= minLength) return null;
+  return `[LAZY SEO TRANSLATION] Tool "${toolId}" locale "${locale}" SEO text is ${msgType} (${localeLen} chars vs EN ${enLen} chars, expected min ${minLength})`;
 }
 
-async function auditSingleLocale(toolId: string, locale: string, loader: any, enSeoLength: number): Promise<void> {
-  if (locale === 'en' || !loader) return;
+async function auditSingleLocale(toolId: string, locale: string, loader: any, enSeoLength: number): Promise<string | null> {
+  if (locale === 'en' || !loader) return null;
   const content = await loader();
-  if (!content.seo || !Array.isArray(content.seo)) return;
+  if (!content.seo || !Array.isArray(content.seo)) return null;
 
-  checkLocaleSeoLength(toolId, locale, calculateSeoTextLength(content.seo), enSeoLength);
+  return checkLocaleSeoLength(toolId, locale, calculateSeoTextLength(content.seo), enSeoLength);
 }
 
 describe('SEO Translation Completeness & Laziness Audit', () => {
@@ -58,12 +56,20 @@ describe('SEO Translation Completeness & Laziness Audit', () => {
         if (!enContent.seo || !Array.isArray(enContent.seo)) return;
 
         const enSeoLength = calculateSeoTextLength(enContent.seo);
+        const failures: string[] = [];
 
         for (const [locale, loader] of Object.entries(entry.i18n)) {
-          await auditSingleLocale(entry.id, locale, loader, enSeoLength);
+          const failure = await auditSingleLocale(entry.id, locale, loader, enSeoLength);
+          if (failure) failures.push(failure);
         }
+
+        expect(
+          failures,
+          failures.length > 0
+            ? `SEO translation completeness failures for "${entry.id}":\n${failures.map((failure, index) => `${index + 1}. ${failure}`).join('\n')}`
+            : undefined,
+        ).toEqual([]);
       });
     });
   });
 });
-

package/src/tests/seo_wellformed_export.test.ts

@@ -0,0 +1,65 @@
+import { describe, it, expect } from 'vitest';
+import { readdirSync, readFileSync, existsSync } from 'fs';
+import { join, relative } from 'path';
+
+function findSeoAstroFiles(dir: string): string[] {
+  const files: string[] = [];
+  if (!existsSync(dir)) return files;
+  const entries = readdirSync(dir, { withFileTypes: true });
+
+  for (const entry of entries) {
+    const fullPath = join(dir, entry.name);
+    if (entry.isDirectory()) {
+      files.push(...findSeoAstroFiles(fullPath));
+    } else if (entry.isFile() && entry.name === 'seo.astro') {
+      files.push(fullPath);
+    }
+  }
+
+  return files;
+}
+
+const toolDir = join(process.cwd(), 'src', 'tool');
+const seoFiles = findSeoAstroFiles(toolDir);
+
+describe('SEO Component Wellformed Export', () => {
+  it('found tool seo.astro components', () => {
+    expect(seoFiles.length).toBeGreaterThan(0);
+  });
+
+  seoFiles.forEach((file) => {
+    const relativePath = relative(process.cwd(), file);
+
+    it(`${relativePath} should dynamically load SEO sections and use SEORenderer`, () => {
+      const content = readFileSync(file, 'utf-8');
+
+      const usesSeoRenderer =
+        content.includes('@jjlmoya/utils-shared') &&
+        (content.includes('SEORenderer') || content.includes('SEOArticle'));
+
+      const acquiresDynamicContent =
+        content.includes('.i18n') ||
+        content.includes('loader') ||
+        content.includes('await loader') ||
+        content.includes('.seo');
+
+      const isBrokenPattern =
+        /sections\s*=\s*\[\s*\]/.test(content) && !acquiresDynamicContent;
+
+      expect(
+        usesSeoRenderer,
+        `File "${relativePath}" does not import or use SEORenderer from @jjlmoya/utils-shared.`,
+      ).toBe(true);
+
+      expect(
+        isBrokenPattern,
+        `File "${relativePath}" relies on a static sections=[] prop default without fetching content from entry.i18n, resulting in empty SEO text on consumers.`,
+      ).toBe(false);
+
+      expect(
+        acquiresDynamicContent,
+        `File "${relativePath}" does not fetch dynamic i18n content for SEO rendering.`,
+      ).toBe(true);
+    });
+  });
+});

package/src/tests/spanish_leakage.test.ts

@@ -1,175 +1,175 @@
-import { describe, expect, it } from 'vitest';
-import { ALL_ENTRIES } from '../entries';
-
-const STRUCTURAL_KEYS = new Set([
-  'id',
-  'slug',
-  'url',
-  'icon',
-  'image',
-  'imageUrl',
-  'keywords',
-  'category',
-  'tags',
-  'toolId',
-  'type',
-  'locale',
-  'language',
-  'direction',
-]);
-
-const TRANSLATABLE_KEYS = [
-  'title',
-  'description',
-  'faqTitle',
-  'faq',
-  'howTo',
-  'seo',
-  'schemas',
-] as const;
-
-const COPY_THRESHOLD = 0.9;
-
-const SPANISH_MARKERS = [
-  ['sangre', /\bsangre\b/gi],
-  ['molino', /\bmolino\b/gi],
-  ['grano', /\bgrano\b/gi],
-  ['paladar', /\bpaladar\b/gi],
-  ['cuchillas', /\bcuchillas\b/gi],
-  ['trozos', /\btrozos\b/gi],
-  ['frescura', /\bfrescura\b/gi],
-  ['ingresa', /\bingresa\b/gi],
-  ['selecciona', /\bselecciona\b/gi],
-  ['herramienta', /\bherramienta\b/gi],
-  ['según', /\bsegún\b/gi],
-  ['después', /\bdespués\b/gi],
-  ['puedes', /\bpuedes\b/gi],
-  ['debes', /\bdebes\b/gi],
-  ['tus', /\btus\b/gi],
-  ['a la vez', /\ba la vez\b/gi],
-  ['los datos', /\blos datos\b/gi],
-  ['las opciones', /\blas opciones\b/gi],
-  ['el resultado', /\bel resultado\b/gi],
-  ['método de extracción', /\bmétodo de extracción\b/gi],
-  ['uniformidad del molino', /\buniformidad del molino\b/gi],
-  ['café recién tostado', /\bcafé recién tostado\b/gi],
-] as const;
-
-type UnknownRecord = Record<string, unknown>;
-
-function normalize(value: string): string {
-  return value
-    .replace(/<[^>]*>/g, ' ')
-    .replace(/&nbsp;/gi, ' ')
-    .replace(/\s+/g, ' ')
-    .trim()
-    .toLocaleLowerCase('es');
-}
-
-function isTechnicalInvariant(text: string): boolean {
-  const ledUnitMatches = text.match(/\b\d+(?:-\d+)?\s*(?:w|lm)\b/g) ?? [];
-  return [
-    'data:image/svg+xml;base64',
-    'background-image: url',
-    '.layout-playground {',
-    'const samplerate =',
-  ].some((pattern) => text.includes(pattern)) ||
-    (text.includes('presets') && text.includes('hz')) ||
-    (text.includes('t_rectal') && text.includes('exp(-k * t)')) ||
-    (text.includes('led') && ledUnitMatches.length >= 3);
-}
-
-function collectString(value: string, output: string[]): void {
-  const text = normalize(value);
-  if (!isTechnicalInvariant(text) && text.length >= 20) output.push(text);
-}
-
-function collectObject(value: UnknownRecord, output: string[]): void {
-  Object.entries(value).forEach(([childKey, childValue]) => {
-    collectText(childValue, output, childKey);
-  });
-}
-
-function collectText(value: unknown, output: string[], key?: string): void {
-  if (key && STRUCTURAL_KEYS.has(key)) return;
-  if (typeof value === 'string') return collectString(value, output);
-  if (Array.isArray(value)) return value.forEach((item) => collectText(item, output));
-  if (value && typeof value === 'object') collectObject(value as UnknownRecord, output);
-}
-
-async function loadText(loader: unknown): Promise<string[]> {
-  if (typeof loader !== 'function') return [];
-  const module = await (loader as () => Promise<unknown>)();
-  const output: string[] = [];
-  if (module && typeof module === 'object') {
-    const record = module as UnknownRecord;
-    for (const key of TRANSLATABLE_KEYS) {
-      collectText(record[key], output, key);
-    }
-  }
-  return output;
-}
-
-function findSpanishMarkers(text: string[]): string[] {
-  const corpus = text.join(' ');
-  return SPANISH_MARKERS.flatMap(([label, pattern]) =>
-    pattern.test(corpus) ? [label] : [],
-  );
-}
-
-function similarity(left: string, right: string): number {
-  const leftTokens = left.split(/\s+/);
-  const rightCounts = new Map<string, number>();
-  right.split(/\s+/).forEach((token) => rightCounts.set(token, (rightCounts.get(token) ?? 0) + 1));
-  const matches = leftTokens.reduce((total, token) => {
-    const count = rightCounts.get(token) ?? 0;
-    if (count > 0) rightCounts.set(token, count - 1);
-    return total + (count > 0 ? 1 : 0);
-  }, 0);
-  return (2 * matches) / (leftTokens.length + right.split(/\s+/).length);
-}
-
-function findCopiedFragments(spanish: string[], translated: string[]): string[] {
-  return spanish
-    .filter((fragment) => fragment.length >= 80)
-    .filter((fragment) => translated.some((candidate) =>
-      candidate.length >= 80 &&
-      Math.min(fragment.length, candidate.length) / Math.max(fragment.length, candidate.length) >= COPY_THRESHOLD &&
-      similarity(fragment, candidate) >= COPY_THRESHOLD,
-    ))
-    .sort((a, b) => b.length - a.length)
-    .slice(0, 3);
-}
-
-describe('Locales must not contain copied Spanish content', () => {
-  for (const entry of ALL_ENTRIES) {
-    it(`${entry.id} has no untranslated Spanish blocks`, async () => {
-      const spanish = await loadText(entry.i18n.es);
-      const failures: string[] = [];
-
-      for (const [locale, loader] of Object.entries(entry.i18n)) {
-        if (locale === 'es') continue;
-
-        const translated = await loadText(loader);
-        const copiedFragments = findCopiedFragments(spanish, translated);
-        const markerHits = findSpanishMarkers(translated);
-
-        if (copiedFragments.length > 0 || markerHits.length >= 2) {
-          const details = [
-            copiedFragments.length > 0
-              ? `copied fragments: ${copiedFragments
-                  .map((fragment) => JSON.stringify(fragment.slice(0, 120)))
-                  .join(', ')}`
-              : '',
-            markerHits.length >= 2 ? `Spanish markers: ${markerHits.join(', ')}` : '',
-          ]
-            .filter(Boolean)
-            .join('; ');
-          failures.push(`${locale}: ${details}`);
-        }
-      }
-
-      expect(failures, failures.join('\n')).toEqual([]);
-    });
-  }
-});
+import { describe, expect, it } from 'vitest';
+import { ALL_ENTRIES } from '../entries';
+
+const STRUCTURAL_KEYS = new Set([
+  'id',
+  'slug',
+  'url',
+  'icon',
+  'image',
+  'imageUrl',
+  'keywords',
+  'category',
+  'tags',
+  'toolId',
+  'type',
+  'locale',
+  'language',
+  'direction',
+]);
+
+const TRANSLATABLE_KEYS = [
+  'title',
+  'description',
+  'faqTitle',
+  'faq',
+  'howTo',
+  'seo',
+  'schemas',
+] as const;
+
+const COPY_THRESHOLD = 0.9;
+
+const SPANISH_MARKERS = [
+  ['sangre', /\bsangre\b/gi],
+  ['molino', /\bmolino\b/gi],
+  ['grano', /\bgrano\b/gi],
+  ['paladar', /\bpaladar\b/gi],
+  ['cuchillas', /\bcuchillas\b/gi],
+  ['trozos', /\btrozos\b/gi],
+  ['frescura', /\bfrescura\b/gi],
+  ['ingresa', /\bingresa\b/gi],
+  ['selecciona', /\bselecciona\b/gi],
+  ['herramienta', /\bherramienta\b/gi],
+  ['según', /\bsegún\b/gi],
+  ['después', /\bdespués\b/gi],
+  ['puedes', /\bpuedes\b/gi],
+  ['debes', /\bdebes\b/gi],
+  ['tus', /\btus\b/gi],
+  ['a la vez', /\ba la vez\b/gi],
+  ['los datos', /\blos datos\b/gi],
+  ['las opciones', /\blas opciones\b/gi],
+  ['el resultado', /\bel resultado\b/gi],
+  ['método de extracción', /\bmétodo de extracción\b/gi],
+  ['uniformidad del molino', /\buniformidad del molino\b/gi],
+  ['café recién tostado', /\bcafé recién tostado\b/gi],
+] as const;
+
+type UnknownRecord = Record<string, unknown>;
+
+function normalize(value: string): string {
+  return value
+    .replace(/<[^>]*>/g, ' ')
+    .replace(/&nbsp;/gi, ' ')
+    .replace(/\s+/g, ' ')
+    .trim()
+    .toLocaleLowerCase('es');
+}
+
+function isTechnicalInvariant(text: string): boolean {
+  const ledUnitMatches = text.match(/\b\d+(?:-\d+)?\s*(?:w|lm)\b/g) ?? [];
+  return [
+    'data:image/svg+xml;base64',
+    'background-image: url',
+    '.layout-playground {',
+    'const samplerate =',
+  ].some((pattern) => text.includes(pattern)) ||
+    (text.includes('presets') && text.includes('hz')) ||
+    (text.includes('t_rectal') && text.includes('exp(-k * t)')) ||
+    (text.includes('led') && ledUnitMatches.length >= 3);
+}
+
+function collectString(value: string, output: string[]): void {
+  const text = normalize(value);
+  if (!isTechnicalInvariant(text) && text.length >= 20) output.push(text);
+}
+
+function collectObject(value: UnknownRecord, output: string[]): void {
+  Object.entries(value).forEach(([childKey, childValue]) => {
+    collectText(childValue, output, childKey);
+  });
+}
+
+function collectText(value: unknown, output: string[], key?: string): void {
+  if (key && STRUCTURAL_KEYS.has(key)) return;
+  if (typeof value === 'string') return collectString(value, output);
+  if (Array.isArray(value)) return value.forEach((item) => collectText(item, output));
+  if (value && typeof value === 'object') collectObject(value as UnknownRecord, output);
+}
+
+async function loadText(loader: unknown): Promise<string[]> {
+  if (typeof loader !== 'function') return [];
+  const module = await (loader as () => Promise<unknown>)();
+  const output: string[] = [];
+  if (module && typeof module === 'object') {
+    const record = module as UnknownRecord;
+    for (const key of TRANSLATABLE_KEYS) {
+      collectText(record[key], output, key);
+    }
+  }
+  return output;
+}
+
+function findSpanishMarkers(text: string[]): string[] {
+  const corpus = text.join(' ');
+  return SPANISH_MARKERS.flatMap(([label, pattern]) =>
+    pattern.test(corpus) ? [label] : [],
+  );
+}
+
+function similarity(left: string, right: string): number {
+  const leftTokens = left.split(/\s+/);
+  const rightCounts = new Map<string, number>();
+  right.split(/\s+/).forEach((token) => rightCounts.set(token, (rightCounts.get(token) ?? 0) + 1));
+  const matches = leftTokens.reduce((total, token) => {
+    const count = rightCounts.get(token) ?? 0;
+    if (count > 0) rightCounts.set(token, count - 1);
+    return total + (count > 0 ? 1 : 0);
+  }, 0);
+  return (2 * matches) / (leftTokens.length + right.split(/\s+/).length);
+}
+
+function findCopiedFragments(spanish: string[], translated: string[]): string[] {
+  return spanish
+    .filter((fragment) => fragment.length >= 80)
+    .filter((fragment) => translated.some((candidate) =>
+      candidate.length >= 80 &&
+      Math.min(fragment.length, candidate.length) / Math.max(fragment.length, candidate.length) >= COPY_THRESHOLD &&
+      similarity(fragment, candidate) >= COPY_THRESHOLD,
+    ))
+    .sort((a, b) => b.length - a.length)
+    .slice(0, 3);
+}
+
+describe('Locales must not contain copied Spanish content', () => {
+  for (const entry of ALL_ENTRIES) {
+    it(`${entry.id} has no untranslated Spanish blocks`, async () => {
+      const spanish = await loadText(entry.i18n.es);
+      const failures: string[] = [];
+
+      for (const [locale, loader] of Object.entries(entry.i18n)) {
+        if (locale === 'es') continue;
+
+        const translated = await loadText(loader);
+        const copiedFragments = findCopiedFragments(spanish, translated);
+        const markerHits = findSpanishMarkers(translated);
+
+        if (copiedFragments.length > 0 || markerHits.length >= 2) {
+          const details = [
+            copiedFragments.length > 0
+              ? `copied fragments: ${copiedFragments
+                  .map((fragment) => JSON.stringify(fragment.slice(0, 120)))
+                  .join(', ')}`
+              : '',
+            markerHits.length >= 2 ? `Spanish markers: ${markerHits.join(', ')}` : '',
+          ]
+            .filter(Boolean)
+            .join('; ');
+          failures.push(`${locale}: ${details}`);
+        }
+      }
+
+      expect(failures, failures.join('\n')).toEqual([]);
+    });
+  }
+});