@jiggai/recipes 0.4.19 → 0.4.21

package/docs/WORKFLOW_FIXES_2026-03-13.md

@@ -0,0 +1,23 @@
+# Workflow fixes (2026-03-13)
+
+This note summarizes the workflow reliability fixes merged on 2026-03-13.
+
+## Kitchen (workflow editor)
+- Persist real approval binding ids when saving workflows.
+  - Prevents saving synthetic ids like `telegram:dm:<peer>`.
+  - Ensures `meta.approvalBindingId` and the `human_approval` node config stay in sync.
+
+## Recipes / workflow runner
+### Approval ingestion
+- Robust parsing of approval replies (plain text and formatted/wrapped text).
+- Use the runtime hook name (`message_received`) and scan the canonical workspace root so approval lookup works even when the inbound message is routed to a role workspace (e.g. `workspace-<teamId>/roles/copywriter`).
+
+### Queue / worker durability
+- Skip stale recovered tasks so expired claim recovery cannot replay old nodes on runs that already advanced.
+
+### Worker cron execution
+- Removed `tools.deny: ["exec"]` from the default `marketing-team` recipe so isolated worker loops can actually execute `worker-tick` commands.
+
+## Known remaining issues / follow-ups
+- Completion Telegram notifier is still somewhat intermittent. When it fires, it includes the X URL and runId.
+  - If it remains flaky, likely fix is to add a deterministic notification node (workflow-level) or a runner-level `run.completed` notifier that uses the `post_to_platforms` artifact URLs.

package/index.ts

@@ -52,7 +52,7 @@ import {
   executeWorkspaceCleanup,
   planWorkspaceCleanup,
 } from "./src/lib/cleanup-workspaces";
-import { resolveWorkspaceRoot } from "./src/lib/workspace";
+import { resolveCanonicalWorkspaceRoot, resolveWorkspaceRoot } from "./src/lib/workspace";
 
 function isRecord(v: unknown): v is Record<string, unknown> {
   return !!v && typeof v === 'object' && !Array.isArray(v);
@@ -62,6 +62,73 @@ function asString(v: unknown, fallback = ''): string {
   return typeof v === 'string' ? v : (v == null ? fallback : String(v));
 }
 
+function extractEventText(evt: Record<string, unknown>, ctx: Record<string, unknown>, metadata: Record<string, unknown>): string {
+  const msg = isRecord(evt["message"]) ? (evt["message"] as Record<string, unknown>) : {};
+  const parts = Array.isArray(msg["content"]) ? (msg["content"] as unknown[]) : [];
+  const texts = parts
+    .map((part) => (isRecord(part) ? asString(part["text"]).trim() : ""))
+    .filter(Boolean);
+  if (texts.length) return texts.join("\n").trim();
+
+  const direct = [
+    evt["content"],
+    ctx["content"],
+    evt["text"],
+    evt["body"],
+    metadata["content"],
+    metadata["text"],
+    metadata["message"],
+  ]
+    .map((v) => asString(v).trim())
+    .filter(Boolean);
+  if (direct.length) return direct.join("\n");
+  return "";
+}
+
+type ApprovalReply = {
+  approved: boolean;
+  code: string;
+  note?: string;
+};
+
+function parseApprovalReply(text: string): ApprovalReply | null {
+  const raw = String(text ?? '');
+  const lines = raw
+    .split(/\r?\n/)
+    .map((line) => line.trim())
+    .filter(Boolean)
+    .reverse();
+
+  for (const line of lines) {
+    const m = line.match(/\b(approve|decline)\b\s+([A-Z0-9]{4,8})(?:\s+(.+))?$/i);
+    if (!m) continue;
+    const verb = String(m[1] ?? '').toLowerCase();
+    const code = String(m[2] ?? '').toUpperCase();
+    const note = asString(m[3]).trim();
+    return {
+      approved: verb === 'approve',
+      code,
+      ...(note ? { note } : {}),
+    };
+  }
+
+  const fallback = raw.match(/\b(approve|decline)\b\s+([A-Z0-9]{4,8})(?:\s+(.+))?/i);
+  if (!fallback) return null;
+  const verb = String(fallback[1] ?? '').toLowerCase();
+  const code = String(fallback[2] ?? '').toUpperCase();
+  const note = asString(fallback[3]).trim();
+  return {
+    approved: verb === 'approve',
+    code,
+    ...(note ? { note } : {}),
+  };
+}
+
+function shouldProcessApprovalReply(channelHints: string[]): boolean {
+  if (!channelHints.length) return true;
+  return channelHints.some((v) => v.includes("telegram"));
+}
+
 const recipesPlugin = {
   id: "recipes",
   name: "Recipes",
@@ -73,35 +140,60 @@ const recipesPlugin = {
   },
   register(api: OpenClawPluginApi) {
     // Auto-approval via chat reply (MVP):
-    // If a human replies `approve <runId>` or `decline <runId>` in the bound channel,
+    // If a human replies `approve <code>` or `decline <code>` in the bound channel,
     // record the decision and resume the run.
-    api.on(
-      "message_received" as never,
-      async (evt: unknown) => {
+    const approvalReplyHandler = async (evt: unknown, ctx: unknown) => {
         try {
           const e = isRecord(evt) ? evt : {};
-          const channel = asString(e["messageProvider"] ?? e["channelId"] ?? e["channel"]);
-          const text = asString(e["text"] ?? e["message"] ?? e["body"]).trim();
+          const c = isRecord(ctx) ? ctx : {};
+          const metadata = isRecord(e["metadata"]) ? (e["metadata"] as Record<string, unknown>) : {};
+          const text = extractEventText(e, c, metadata);
           if (!text) return;
 
-          // Only enable for Telegram for now (matches RJ's request).
-          if (channel !== "telegram") return;
+          const reply = parseApprovalReply(text);
+          if (!reply) return;
 
-          const m = text.match(/^(approve|decline)\s+([A-Z0-9]{4,8})\s*$/i);
-          if (!m) return;
-          const verb = String(m[1] ?? "").toLowerCase();
-          const code = String(m[2] ?? "").toUpperCase();
-          const approved = verb === "approve";
-
-          const workspaceRoot = resolveWorkspaceRoot(api);
+          const workspaceRoot = resolveCanonicalWorkspaceRoot(api);
           const parent = path.resolve(workspaceRoot, "..");
+          const roots = Array.from(new Set([parent, workspaceRoot, path.join(workspaceRoot, "workspace")]));
+          const channelHints = [
+            c["channelId"],
+            c["channel"],
+            metadata["channelId"],
+            metadata["channel"],
+            metadata["provider"],
+            metadata["source"],
+            e["messageProvider"],
+            e["channelId"],
+            e["channel"],
+            e["source"],
+          ]
+            .map((v) => asString(v).toLowerCase())
+            .filter(Boolean);
+          const isTelegram = shouldProcessApprovalReply(channelHints);
 
-          // Scan workspace-*/shared-context/workflow-runs/*/approvals/approval.json for a matching code.
-          const teamDirs = (await fs.readdir(parent, { withFileTypes: true }))
-            .filter((d) => d.isDirectory() && d.name.startsWith("workspace-"))
-            .map((d) => path.join(parent, d.name));
+          // Only reject when the event explicitly identifies a different channel.
+          // Some Telegram inbound payloads arrive without provider/channel metadata.
+          if (!isTelegram) {
+            console.error(`[recipes] approval reply ignored: non-telegram channel hints=${JSON.stringify(channelHints)} text=${JSON.stringify(text)}`);
+            return;
+          }
 
-          let found: { teamId: string; runId: string } | null = null;
+          const { approved, code, note } = reply;
+
+          const teamDirs: string[] = [];
+          for (const root of roots) {
+            try {
+              const entries = await fs.readdir(root, { withFileTypes: true });
+              for (const d of entries) {
+                if (d.isDirectory() && d.name.startsWith("workspace-")) teamDirs.push(path.join(root, d.name));
+              }
+            } catch {
+              // ignore root read errors
+            }
+          }
+
+          let found: { teamId: string; runId: string; approvalPath: string } | null = null;
 
           for (const teamDir of teamDirs) {
             const teamId = path.basename(teamDir).replace(/^workspace-/, "");
@@ -120,8 +212,8 @@ const recipesPlugin = {
               try {
                 const raw = await fs.readFile(approvalPath, "utf8");
                 const a = JSON.parse(raw) as { code?: string; status?: string; runId?: string; teamId?: string };
-                if (String(a?.code ?? "").toUpperCase() === code && String(a?.status ?? "") === "pending") {
-                  found = { teamId: String(a?.teamId ?? teamId), runId: String(a?.runId ?? runId) };
+                if (String(a?.code ?? "").trim().toUpperCase() === code && String(a?.status ?? "") === "pending") {
+                  found = { teamId: String(a?.teamId ?? teamId), runId: String(a?.runId ?? runId), approvalPath };
                   break;
                 }
               } catch {
@@ -131,10 +223,14 @@ const recipesPlugin = {
             if (found) break;
           }
 
-          if (!found) return;
+          if (!found) {
+            console.error(`[recipes] approval reply not matched: code=${code} text=${JSON.stringify(text)} hints=${JSON.stringify(channelHints)} roots=${JSON.stringify(roots)}`);
+            return;
+          }
 
-          await handleWorkflowsApprove(api, { teamId: found.teamId, runId: found.runId, approved, note: `Approved via Telegram (${code})` });
-          // Resume is best-effort: the worker may have already flipped the run status.
+          console.error(`[recipes] approval reply matched: code=${code} team=${found.teamId} run=${found.runId} path=${found.approvalPath} approved=${approved}`);
+          const approvalNote = note || `${approved ? 'Approved' : 'Declined'} via Telegram (${code})`;
+          await handleWorkflowsApprove(api, { teamId: found.teamId, runId: found.runId, approved, note: approvalNote });
           try {
             await handleWorkflowsResume(api, { teamId: found.teamId, runId: found.runId });
           } catch {
@@ -143,9 +239,11 @@ const recipesPlugin = {
         } catch (e) {
           console.error(`[recipes] approval reply handler error: ${(e as Error).message}`);
         }
-      },
-      { priority: 50 } as unknown as { priority: number }
-    );
+    };
+
+    api.on("message_received" as never, approvalReplyHandler as never, { priority: 50 } as unknown as { priority: number });
+    api.on("message:received" as never, approvalReplyHandler as never, { priority: 50 } as unknown as { priority: number });
+
 
     // On plugin load, ensure multi-agent config has an explicit agents.list with main at top.
     // This is idempotent and only writes if a change is required.
@@ -933,6 +1031,9 @@ workflows
 
 // Internal helpers used by unit tests. Not part of the public plugin API.
 export const __internal = {
+  extractEventText,
+  parseApprovalReply,
+  shouldProcessApprovalReply,
   ensureMainFirstInAgentsList,
   upsertBindingInConfig,
   removeBindingsInConfig,

package/openclaw.plugin.json

@@ -2,7 +2,7 @@
   "id": "recipes",
   "name": "Recipes",
   "description": "Markdown recipes that scaffold agents and teams (workspace-local).",
-  "version": "0.4.19",
+  "version": "0.4.21",
   "configSchema": {
     "type": "object",
     "additionalProperties": false,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jiggai/recipes",
-  "version": "0.4.19",
+  "version": "0.4.21",
   "description": "ClawRecipes plugin for OpenClaw (markdown recipes -> scaffold agents/teams)",
   "main": "index.ts",
   "type": "commonjs",

package/recipes/default/business-team.md

@@ -68,16 +68,16 @@ templates:
 
     ## Where to write things
     - Ticket = source of truth for a unit of work.
-    - `notes/plan.md` + `shared-context/priorities.md` are **lead-curated**.
-    - `notes/status.md` is **append-only** and updated after each work session (3–5 bullets).
-    - `shared-context/agent-outputs/` is **append-only** logs/output.
+    - `../notes/plan.md` + `../shared-context/priorities.md` are **lead-curated**.
+    - `../notes/status.md` is **append-only** and updated after each work session (3–5 bullets).
+    - `../shared-context/agent-outputs/` is **append-only** logs/output.
 
     ## End-of-session checklist (everyone)
     After meaningful work:
     1) Update the ticket with what changed + how to verify + rollback.
     2) Add a dated note in the ticket `## Comments`.
-    3) Append 3–5 bullets to `notes/status.md`.
-    4) Append logs/output to `shared-context/agent-outputs/`.
+    3) Append 3–5 bullets to `../notes/status.md`.
+    4) Append logs/output to `../shared-context/agent-outputs/`.
 
   sharedContext.plan: |
     # Plan (lead-curated)
@@ -110,16 +110,16 @@ templates:
     - `roles/<role>/memory/YYYY-MM-DD.md` (daily log)
 
     ## Plan vs status (team coordination)
-    - `notes/plan.md` + `shared-context/priorities.md` are lead-curated
-    - `notes/status.md` is append-only roll-up (everyone appends)
+    - `../notes/plan.md` + `../shared-context/priorities.md` are lead-curated
+    - `../notes/status.md` is append-only roll-up (everyone appends)
 
     ## Outputs / artifacts
     - `roles/<role>/agent-outputs/` (append-only)
-    - `shared-context/agent-outputs/` (optional team-level)
+    - `../shared-context/agent-outputs/` (team-level, read/write from role via `../`)
 
     ## Role work loop contract (safe-idle)
     - No-op unless explicit queued work exists for the role.
-    - If work happens, write back in order: ticket → `notes/status.md` → `roles/<role>/agent-outputs/`.
+    - If work happens, write back in order: ticket → `../notes/status.md` → `roles/<role>/agent-outputs/`.
 
   sharedContext.priorities: |
     # Priorities (lead-curated)
@@ -172,24 +172,24 @@ templates:
 
     Before you act:
     1) Read:
-       - `notes/plan.md`
-       - `notes/status.md`
-       - `shared-context/priorities.md`
+       - `../notes/plan.md`
+       - `../notes/status.md`
+       - `../shared-context/priorities.md`
        - the relevant ticket(s)
 
     After you act:
     1) Write back:
        - Update tickets with decisions/assignments.
-       - Keep `notes/status.md` current (3–5 bullets per active ticket).
+       - Keep `../notes/status.md` current (3–5 bullets per active ticket).
 
     ## Curator model
 
     You are the curator of:
-    - `notes/plan.md`
-    - `shared-context/priorities.md`
+    - `../notes/plan.md`
+    - `../shared-context/priorities.md`
 
     Everyone else should append to:
-    - `shared-context/agent-outputs/` (append-only)
+    - `../shared-context/agent-outputs/` (append-only)
     - `shared-context/feedback/`
 
     Your job is to periodically distill those inputs into the curated files.
@@ -204,8 +204,8 @@ templates:
     - `work/in-progress/` — tickets currently being executed
     - `work/testing/` — tickets awaiting QA verification
     - `work/done/` — completed tickets + completion notes
-    - `notes/plan.md` — current plan / priorities (curated)
-    - `notes/status.md` — current status snapshot
+    - `../notes/plan.md` — current plan / priorities (curated)
+    - `../notes/status.md` — current status snapshot
     - `shared-context/` — shared context + append-only outputs
 
     ### Ticket numbering (critical)
@@ -222,8 +222,8 @@ templates:
 
     ### Your responsibilities
     - For every new request in `inbox/`, create a normalized ticket in `work/backlog/`.
-    - Curate `notes/plan.md` and `shared-context/priorities.md`.
-    - Keep `notes/status.md` updated.
+    - Curate `../notes/plan.md` and `../shared-context/priorities.md`.
+    - Keep `../notes/status.md` updated.
     - When work is ready for QA, move the ticket to `work/testing/` and assign it to the tester.
     - Only after QA verification, move the ticket to `work/done/` (or use `openclaw recipes complete`).
     - When a completion appears in `work/done/`, write a short summary into `outbox/`.
@@ -244,8 +244,8 @@ templates:
     ## Guardrails (read → act → write)
     Before you act:
     1) Read:
-       - `notes/plan.md`
-       - `notes/status.md`
+       - `../notes/plan.md`
+       - `../notes/status.md`
        - relevant ticket(s) in `work/in-progress/`
        - any relevant shared context under `shared-context/`
 
@@ -274,8 +274,8 @@ templates:
     ## Guardrails (read → act → write)
     Before you act:
     1) Read:
-       - `notes/plan.md`
-       - `notes/status.md`
+       - `../notes/plan.md`
+       - `../notes/status.md`
        - relevant ticket(s) in `work/in-progress/`
        - any relevant shared context under `shared-context/`
 
@@ -304,8 +304,8 @@ templates:
     ## Guardrails (read → act → write)
     Before you act:
     1) Read:
-       - `notes/plan.md`
-       - `notes/status.md`
+       - `../notes/plan.md`
+       - `../notes/status.md`
        - relevant ticket(s) in `work/in-progress/`
        - any relevant shared context under `shared-context/`
 
@@ -334,8 +334,8 @@ templates:
     ## Guardrails (read → act → write)
     Before you act:
     1) Read:
-       - `notes/plan.md`
-       - `notes/status.md`
+       - `../notes/plan.md`
+       - `../notes/status.md`
        - relevant ticket(s) in `work/in-progress/`
        - any relevant shared context under `shared-context/`
 

package/recipes/default/customer-support-team.md

@@ -57,16 +57,16 @@ templates:
 
     ## Where to write things
     - Ticket = source of truth for a unit of work.
-    - `notes/plan.md` + `shared-context/priorities.md` are **lead-curated**.
-    - `notes/status.md` is **append-only** and updated after each work session (3–5 bullets).
-    - `shared-context/agent-outputs/` is **append-only** logs/output.
+    - `../notes/plan.md` + `../shared-context/priorities.md` are **lead-curated**.
+    - `../notes/status.md` is **append-only** and updated after each work session (3–5 bullets).
+    - `../shared-context/agent-outputs/` is **append-only** logs/output.
 
     ## End-of-session checklist (everyone)
     After meaningful work:
     1) Update the ticket with what changed + how to verify + rollback.
     2) Add a dated note in the ticket `## Comments`.
-    3) Append 3–5 bullets to `notes/status.md`.
-    4) Append logs/output to `shared-context/agent-outputs/`.
+    3) Append 3–5 bullets to `../notes/status.md`.
+    4) Append logs/output to `../shared-context/agent-outputs/`.
 
   sharedContext.plan: |
     # Plan (lead-curated)
@@ -99,16 +99,16 @@ templates:
     - `roles/<role>/memory/YYYY-MM-DD.md` (daily log)
 
     ## Plan vs status (team coordination)
-    - `notes/plan.md` + `shared-context/priorities.md` are lead-curated
-    - `notes/status.md` is append-only roll-up (everyone appends)
+    - `../notes/plan.md` + `../shared-context/priorities.md` are lead-curated
+    - `../notes/status.md` is append-only roll-up (everyone appends)
 
     ## Outputs / artifacts
     - `roles/<role>/agent-outputs/` (append-only)
-    - `shared-context/agent-outputs/` (optional team-level)
+    - `../shared-context/agent-outputs/` (team-level, read/write from role via `../`)
 
     ## Role work loop contract (safe-idle)
     - No-op unless explicit queued work exists for the role.
-    - If work happens, write back in order: ticket → `notes/status.md` → `roles/<role>/agent-outputs/`.
+    - If work happens, write back in order: ticket → `../notes/status.md` → `roles/<role>/agent-outputs/`.
 
   sharedContext.priorities: |
     # Priorities (lead-curated)
@@ -141,24 +141,24 @@ templates:
 
     Before you act:
     1) Read:
-       - `notes/plan.md`
-       - `notes/status.md`
-       - `shared-context/priorities.md`
+       - `../notes/plan.md`
+       - `../notes/status.md`
+       - `../shared-context/priorities.md`
        - the relevant ticket(s)
 
     After you act:
     1) Write back:
        - Update tickets with decisions/assignments.
-       - Keep `notes/status.md` current (3–5 bullets per active ticket).
+       - Keep `../notes/status.md` current (3–5 bullets per active ticket).
 
     ## Curator model
 
     You are the curator of:
-    - `notes/plan.md`
-    - `shared-context/priorities.md`
+    - `../notes/plan.md`
+    - `../shared-context/priorities.md`
 
     Everyone else should append to:
-    - `shared-context/agent-outputs/` (append-only)
+    - `../shared-context/agent-outputs/` (append-only)
     - `shared-context/feedback/`
 
     Your job is to periodically distill those inputs into the curated files.
@@ -173,8 +173,8 @@ templates:
     - `work/in-progress/` — tickets currently being executed
     - `work/testing/` — tickets awaiting QA verification
     - `work/done/` — completed tickets + completion notes
-    - `notes/plan.md` — current plan / priorities (curated)
-    - `notes/status.md` — current status snapshot
+    - `../notes/plan.md` — current plan / priorities (curated)
+    - `../notes/status.md` — current status snapshot
     - `shared-context/` — shared context + append-only outputs
 
     ### Ticket numbering (critical)
@@ -191,8 +191,8 @@ templates:
 
     ### Your responsibilities
     - For every new request in `inbox/`, create a normalized ticket in `work/backlog/`.
-    - Curate `notes/plan.md` and `shared-context/priorities.md`.
-    - Keep `notes/status.md` updated.
+    - Curate `../notes/plan.md` and `../shared-context/priorities.md`.
+    - Keep `../notes/status.md` updated.
     - When work is ready for QA, move the ticket to `work/testing/` and assign it to the tester.
     - Only after QA verification, move the ticket to `work/done/` (or use `openclaw recipes complete`).
     - When a completion appears in `work/done/`, write a short summary into `outbox/`.
@@ -216,8 +216,8 @@ templates:
     ## Guardrails (read → act → write)
     Before you act:
     1) Read:
-       - `notes/plan.md`
-       - `notes/status.md`
+       - `../notes/plan.md`
+       - `../notes/status.md`
        - relevant ticket(s) in `work/in-progress/`
        - any relevant shared context under `shared-context/`
 
@@ -246,8 +246,8 @@ templates:
     ## Guardrails (read → act → write)
     Before you act:
     1) Read:
-       - `notes/plan.md`
-       - `notes/status.md`
+       - `../notes/plan.md`
+       - `../notes/status.md`
        - relevant ticket(s) in `work/in-progress/`
        - any relevant shared context under `shared-context/`
 
@@ -276,8 +276,8 @@ templates:
     ## Guardrails (read → act → write)
     Before you act:
     1) Read:
-       - `notes/plan.md`
-       - `notes/status.md`
+       - `../notes/plan.md`
+       - `../notes/status.md`
        - relevant ticket(s) in `work/in-progress/`
        - any relevant shared context under `shared-context/`