@jiggai/recipes 0.3.3 → 0.3.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jiggai/recipes",
-  "version": "0.3.3",
+  "version": "0.3.4",
   "description": "ClawRecipes plugin for OpenClaw (markdown recipes -> scaffold agents/teams)",
   "main": "index.ts",
   "type": "commonjs",

package/src/handlers/team.ts

@@ -13,6 +13,7 @@ import { pickRecipeId } from "../lib/recipe-id";
 import { recipeIdTakenForTeam, validateRecipeAndSkills, writeWorkspaceRecipeFile } from "../lib/scaffold-utils";
 import { scaffoldAgentFromRecipe } from "./scaffold";
 import { reconcileRecipeCronJobs } from "./cron";
+import { lintRecipe } from "../lib/recipe-lint";
 
 async function ensureTeamDirectoryStructure(
   teamDir: string,
@@ -119,6 +120,19 @@ async function scaffoldTeamAgents(
 ): Promise<AgentScaffoldResult[]> {
   const agents = recipe.agents ?? [];
   if (!agents.length) throw new Error("Team recipe must include agents[]");
+
+  // Resilience: some custom recipes may define templates but forget files[].
+  // In that case, scaffold a minimal per-role file set.
+  const baseFiles = (recipe.files ?? []).length
+    ? (recipe.files ?? [])
+    : [
+        { path: "SOUL.md", template: "soul", mode: "createOnly" },
+        { path: "AGENTS.md", template: "agents", mode: "createOnly" },
+        { path: "TOOLS.md", template: "tools", mode: "createOnly" },
+        { path: "STATUS.md", template: "status", mode: "createOnly" },
+        { path: "NOTES.md", template: "notes", mode: "createOnly" },
+      ];
+
   const results: AgentScaffoldResult[] = [];
   for (const a of agents) {
     const role = a.role;
@@ -131,9 +145,9 @@ async function scaffoldTeamAgents(
       requiredSkills: recipe.requiredSkills,
       optionalSkills: recipe.optionalSkills,
       templates: recipe.templates,
-      files: (recipe.files ?? []).map((f) => ({
+      files: baseFiles.map((f) => ({
         ...f,
-        template: f.template.includes(".") ? f.template : `${role}.${f.template}`,
+        template: String(f.template).includes(".") ? f.template : `${role}.${f.template}`,
       })),
       tools: a.tools ?? recipe.tools,
     };
@@ -143,7 +157,8 @@ async function scaffoldTeamAgents(
       agentName,
       update: overwrite,
       filesRootDir: roleDir,
-      workspaceRootDir: teamDir,
+      // IMPORTANT: per-role workspace so the Kitchen UI / agent files panel reads the role files.
+      workspaceRootDir: roleDir,
       vars: { teamId, teamDir, role, agentId, agentName, roleDir },
     });
     results.push({ role, agentId, ...r });
@@ -178,6 +193,13 @@ export async function handleScaffoldTeam(
     };
   }
   const { loaded, recipe, cfg, workspaceRoot: baseWorkspace } = validation;
+
+  // Lint (warn-only) for common team scaffolding pitfalls.
+  for (const issue of lintRecipe(recipe)) {
+    if (issue.level === "warn") console.warn(`[recipes] WARN ${issue.code}: ${issue.message}`);
+    else console.warn(`[recipes] ${issue.code}: ${issue.message}`);
+  }
+
   const teamId = String(options.teamId);
   const teamDir = path.resolve(baseWorkspace, "..", `workspace-${teamId}`);
   await ensureDir(teamDir);

package/src/lib/recipe-lint.ts

@@ -0,0 +1,44 @@
+import type { RecipeFrontmatter } from "./recipe-frontmatter";
+
+export type RecipeLintIssue = { level: "warn" | "error"; code: string; message: string };
+
+/**
+ * Lightweight recipe lint for common scaffolding pitfalls.
+ * Intentionally conservative: warnings should be actionable and low-noise.
+ */
+export function lintRecipe(recipe: RecipeFrontmatter): RecipeLintIssue[] {
+  const issues: RecipeLintIssue[] = [];
+
+  if ((recipe.kind ?? "") === "team") {
+    const agents = recipe.agents ?? [];
+    const files = recipe.files ?? [];
+    const templates = recipe.templates ?? {};
+
+    if (agents.length && files.length === 0) {
+      const hasRoleTemplates = Object.keys(templates).some((k) => k.includes(".") && /(\.soul|\.agents|\.tools|\.status|\.notes)$/.test(k));
+      issues.push({
+        level: "warn",
+        code: "team.missing_files",
+        message:
+          `Team recipe has agents[] but no files[]. Per-role workspaces will be empty. ` +
+          `Add a files: section (e.g. SOUL.md/AGENTS.md/TOOLS.md/STATUS.md/NOTES.md) ` +
+          `or rely on scaffold defaults. ${hasRoleTemplates ? "(Detected role templates; likely meant to scaffold role files.)" : ""}`,
+      });
+    }
+
+    // Templates exist but won't be used if files[] doesn't reference them.
+    if (agents.length && Object.keys(templates).length && files.length) {
+      const baseTemplates = new Set(files.map((f) => String(f.template ?? "").trim()).filter(Boolean));
+      const missing = ["soul", "agents", "tools"].filter((t) => !baseTemplates.has(t) && ![...baseTemplates].some((x) => x.endsWith(`.${t}`)));
+      if (missing.length) {
+        issues.push({
+          level: "warn",
+          code: "team.files.missing_core_templates",
+          message: `Team recipe files[] is missing some common templates (${missing.join(", ")}). This may be intentional, but usually each role should have SOUL.md/AGENTS.md/TOOLS.md at minimum.`,
+        });
+      }
+    }
+  }
+
+  return issues;
+}