@jiggai/recipes 0.3.0 → 0.3.2

package/src/handlers/team.ts

@@ -39,14 +39,16 @@ async function ensureTeamDirectoryStructure(
   ]);
 }
 
-async function writeTeamBootstrapFiles(
-  teamId: string,
-  teamDir: string,
-  sharedContextDir: string,
-  notesDir: string,
-  goalsDir: string,
-  overwrite: boolean
-) {
+async function writeTeamBootstrapFiles(opts: {
+  teamId: string;
+  teamDir: string;
+  sharedContextDir: string;
+  notesDir: string;
+  goalsDir: string;
+  overwrite: boolean;
+  qaChecklist?: boolean;
+}) {
+  const { teamId, teamDir, sharedContextDir, notesDir, goalsDir, overwrite, qaChecklist } = opts;
   const mode = overwrite ? "overwrite" : "createOnly";
   await ensureDir(goalsDir);
   await writeFileSafely(
@@ -66,6 +68,14 @@ async function writeTeamBootstrapFiles(
     `# Goals folder — ${teamId}\n\nCreate one markdown file per goal in this directory.\n\nRecommended file naming:\n- short, kebab-case, no leading numbers (e.g. \`reduce-support-backlog.md\`)\n\nLink goals from:\n- notes/GOALS.md\n`,
     mode
   );
+
+  if (qaChecklist) {
+    await writeFileSafely(
+      path.join(notesDir, "QA_CHECKLIST.md"),
+      `# QA Checklist — ${teamId}\n\nUse this when verifying a ticket before moving it from work/testing/ → work/done/.\n\n## Checklist\n- [ ] Repro steps verified\n- [ ] Acceptance criteria met\n- [ ] No regressions in adjacent flows\n- [ ] Notes/screenshots attached (if relevant)\n\n## Verified by\n- QA: (name)\n- Date: (YYYY-MM-DD)\n\n## Links\n- Ticket: (path or URL)\n- PR/Commit: (optional)\n`,
+      mode,
+    );
+  }
   const ticketsMd = `# Tickets — ${teamId}\n\n## Naming\n- Backlog tickets live in work/backlog/\n- In-progress tickets live in work/in-progress/\n- Testing tickets live in work/testing/\n- Done tickets live in work/done/\n- Filename ordering is the queue: 0001-..., 0002-...\n\n## Stages\n- backlog → in-progress → testing → done\n\n## QA handoff\n- When work is ready for QA: move the ticket to \`work/testing/\` and assign to test.\n\n## Required fields\nEach ticket should include:\n- Title\n- Context\n- Requirements\n- Acceptance criteria\n- Owner (dev/devops/lead/test)\n- Status (queued/in-progress/testing/done)\n\n## Example\n\n\`\`\`md\n# 0001-example-ticket\n\nOwner: dev\nStatus: queued\n\n## Context\n...\n\n## Requirements\n- ...\n\n## Acceptance criteria\n- ...\n\`\`\`\n`;
   await writeFileSafely(path.join(teamDir, "TICKETS.md"), ticketsMd, mode);
 }
@@ -175,7 +185,6 @@ export async function handleScaffoldTeam(
   await ensureDir(recipesDir);
   const overwriteRecipe = !!options.overwriteRecipe;
   const autoIncrement = !!options.autoIncrement;
-
   const explicitRecipeId = typeof options.recipeIdExplicit === "string" ? String(options.recipeIdExplicit).trim() : "";
   const baseRecipeId = explicitRecipeId || teamId;
   const workspaceRecipeId = await pickRecipeId({
@@ -192,7 +201,6 @@ export async function handleScaffoldTeam(
       `Workspace recipe already exists: recipes/${id}.md. Choose --recipe-id (e.g. ${suggestions.join(", ")}) or --auto-increment or --overwrite-recipe.`,
   });
   await writeWorkspaceRecipeFile(loaded, recipesDir, workspaceRecipeId, overwriteRecipe);
-
   const rolesDir = path.join(teamDir, "roles");
   const notesDir = path.join(teamDir, "notes");
   const workDir = path.join(teamDir, "work");
@@ -200,9 +208,17 @@ export async function handleScaffoldTeam(
   const sharedContextDir = path.join(teamDir, "shared-context");
   const goalsDir = path.join(notesDir, "goals");
 
+  const qaChecklist = Boolean(recipe.qaChecklist ?? false) || (recipe.agents ?? []).some((a) => String(a.role ?? "").toLowerCase() === "test");
   await ensureTeamDirectoryStructure(teamDir, sharedContextDir, notesDir, workDir);
-  await writeTeamBootstrapFiles(teamId, teamDir, sharedContextDir, notesDir, goalsDir, overwrite);
-
+  await writeTeamBootstrapFiles({
+    teamId,
+    teamDir,
+    sharedContextDir,
+    notesDir,
+    goalsDir,
+    overwrite,
+    qaChecklist,
+  });
   const results = await scaffoldTeamAgents(api, recipe, teamId, teamDir, rolesDir, overwrite);
   await writeTeamMetadataAndConfig({ api, teamId, teamDir, recipe, results, applyConfig: !!options.applyConfig, overwrite });
 
@@ -365,6 +381,23 @@ export async function handleRemoveTeam(
   const cronJobsPath = path.resolve(workspaceRoot, "..", "cron", "jobs.json");
   const cfgObj = await loadOpenClawConfig(api);
   const cronStore = await loadCronStore(cronJobsPath);
+
+  // IMPORTANT: read cron provenance BEFORE deleting workspace.
+  // Teams/recipes track installed cron jobs via notes/cron-jobs.json.
+  const teamDir = path.resolve(workspaceRoot, "..", `workspace-${teamId}`);
+  const cronMappingPath = path.join(teamDir, "notes", "cron-jobs.json");
+  let installedCronIds: string[] = [];
+  try {
+    const raw = await fs.readFile(cronMappingPath, "utf8");
+    const json = JSON.parse(raw) as { entries?: Record<string, { installedCronId?: unknown; orphaned?: unknown }> };
+    installedCronIds = Object.values(json.entries ?? {})
+      .filter((e) => e && !e.orphaned)
+      .map((e) => String(e.installedCronId ?? "").trim())
+      .filter(Boolean);
+  } catch {
+    installedCronIds = [];
+  }
+
   const plan = await buildRemoveTeamPlan({
     teamId,
     workspaceRoot,
@@ -372,6 +405,7 @@ export async function handleRemoveTeam(
     cronJobsPath,
     cfgObj,
     cronStore,
+    installedCronIds,
   });
   if (options.plan) return { ok: true as const, plan };
   if (!options.yes && !process.stdin.isTTY) {

package/src/lib/agent-config.ts

@@ -16,7 +16,17 @@ export function upsertAgentInConfig(cfgObj: AgentsConfigMutable, snippet: AgentC
   const list = cfgObj.agents.list;
   const idx = list.findIndex((a) => a?.id === snippet.id);
   const prev = idx >= 0 ? list[idx] : {};
-  const prevTools = (prev as any)?.tools as undefined | { profile?: string; allow?: string[]; deny?: string[] };
+
+  const prevTools = (() => {
+    const v = (prev as { tools?: unknown } | null | undefined)?.tools;
+    if (!v || typeof v !== "object") return undefined;
+    const t = v as { profile?: unknown; allow?: unknown; deny?: unknown };
+    return {
+      profile: typeof t.profile === "string" ? t.profile : undefined,
+      allow: Array.isArray(t.allow) ? (t.allow as string[]) : undefined,
+      deny: Array.isArray(t.deny) ? (t.deny as string[]) : undefined,
+    } as { profile?: string; allow?: string[]; deny?: string[] };
+  })();
   const nextTools =
     snippet.tools === undefined
       ? prevTools

package/src/lib/recipe-frontmatter.ts

@@ -34,6 +34,13 @@ export type RecipeFrontmatter = {
   kind?: string;
   name?: string;
   cronJobs?: CronJobSpec[];
+
+  /**
+   * If true, scaffold `notes/QA_CHECKLIST.md` even if the team has no `test` role.
+   * If false/omitted, QA checklist is scaffolded only when the team recipe includes a `test` role.
+   */
+  qaChecklist?: boolean;
+
   [k: string]: unknown;
 };
 

package/src/lib/remove-team.ts

@@ -81,22 +81,34 @@ export function findAgentsToRemove(cfgObj: Record<string, unknown>, teamId: stri
     .filter((id: string) => id && id.startsWith(prefix));
 }
 
-export function planCronJobRemovals(jobs: CronJob[], teamId: string) {
+export function planCronJobRemovals(
+  jobs: CronJob[],
+  teamId: string,
+  opts?: { installedCronIds?: string[] | null }
+) {
   const stamp = stampTeamId(teamId);
   const exact: Array<{ id: string; name?: string }> = [];
   const ambiguous: Array<{ id: string; name?: string; reason: string }> = [];
 
+  const installed = new Set((opts?.installedCronIds ?? []).map((s) => String(s).trim()).filter(Boolean));
+
   for (const j of jobs) {
     const msg = String(j?.payload?.message ?? "");
     const name = String(j?.name ?? "");
 
-    // Exact: message contains the stamp.
+    // Exact (preferred): installedCronIds from the team provenance file.
+    if (installed.has(String(j.id))) {
+      exact.push({ id: j.id, name: j.name });
+      continue;
+    }
+
+    // Fallback exact: message contains the stamp.
     if (msg.includes(stamp)) {
       exact.push({ id: j.id, name: j.name });
       continue;
     }
 
-    // Ambiguous: name mentions teamId (helpful for manual review).
+    // Ambiguous: name/message mentions teamId (helpful for manual review).
     if (name.includes(teamId) || msg.includes(teamId)) {
       ambiguous.push({ id: j.id, name: j.name, reason: "mentions-teamId" });
     }
@@ -112,6 +124,7 @@ export async function buildRemoveTeamPlan(opts: {
   cronJobsPath: string; // e.g. ~/.openclaw/cron/jobs.json
   cfgObj: Record<string, unknown>;
   cronStore?: CronStore | null;
+  installedCronIds?: string[] | null;
 }) {
   const teamId = opts.teamId.trim();
   const workspaceDir = path.resolve(path.join(opts.workspaceRoot, "..", `workspace-${teamId}`));
@@ -122,7 +135,7 @@ export async function buildRemoveTeamPlan(opts: {
   const agentsToRemove = findAgentsToRemove(opts.cfgObj, teamId);
 
   const jobs = (opts.cronStore?.jobs ?? []) as CronJob[];
-  const cron = planCronJobRemovals(jobs, teamId);
+  const cron = planCronJobRemovals(jobs, teamId, { installedCronIds: opts.installedCronIds });
 
   const plan: RemoveTeamPlan = {
     teamId,

package/src/lib/workspace.ts

@@ -1,12 +1,25 @@
+import os from "node:os";
 import path from "node:path";
 import type { OpenClawPluginApi } from "openclaw/plugin-sdk";
 import { ensureDir } from "./fs-utils";
 import { ticketStageDir } from "./lanes";
 
+/**
+ * Resolve the OpenClaw workspace root.
+ *
+ * Priority:
+ *  1) config: agents.defaults.workspace
+ *  2) env: OPENCLAW_WORKSPACE
+ *  3) default: ~/.openclaw/workspace
+ */
 export function resolveWorkspaceRoot(api: OpenClawPluginApi): string {
   const root = api.config.agents?.defaults?.workspace;
-  if (!root) throw new Error("agents.defaults.workspace is not set in config");
-  return root;
+  if (root) return root;
+
+  const envRoot = process.env.OPENCLAW_WORKSPACE;
+  if (envRoot) return envRoot;
+
+  return path.join(os.homedir(), ".openclaw", "workspace");
 }
 
 export function resolveTeamDir(api: OpenClawPluginApi, teamId: string): string {