@jgardner04/ghost-mcp-server 1.13.1 → 1.13.3

package/src/services/__tests__/ghostServiceImproved.tags.test.js

@@ -403,7 +403,7 @@ describe('ghostServiceImproved - Tags', () => {
   });
 
   describe('updateTag', () => {
-    it('should update tag with valid ID and data', async () => {
+    it('should send only update fields, not the full existing tag', async () => {
       const tagId = 'tag-1';
       const updateData = {
         name: 'Updated JavaScript',
@@ -414,6 +414,8 @@ describe('ghostServiceImproved - Tags', () => {
         id: tagId,
         name: 'JavaScript',
         slug: 'javascript',
+        url: 'https://example.com/tag/javascript',
+        visibility: 'public',
       };
 
       const mockUpdatedTag = {
@@ -427,7 +429,16 @@ describe('ghostServiceImproved - Tags', () => {
       const result = await updateTag(tagId, updateData);
 
       expect(api.tags.read).toHaveBeenCalled();
-      expect(api.tags.edit).toHaveBeenCalled();
+      // Should send ONLY updateData, NOT the full existing tag
+      expect(api.tags.edit).toHaveBeenCalledWith(
+        { id: tagId, name: 'Updated JavaScript', description: 'Updated description' },
+        {}
+      );
+      // Verify read-only fields are NOT sent
+      const editCallData = api.tags.edit.mock.calls[0][0];
+      expect(editCallData).not.toHaveProperty('url');
+      expect(editCallData).not.toHaveProperty('visibility');
+      expect(editCallData).not.toHaveProperty('slug');
       expect(result).toEqual(mockUpdatedTag);
     });
 

package/src/services/__tests__/ghostServiceImproved.tiers.test.js

@@ -270,14 +270,7 @@ describe('ghostServiceImproved - Tiers', () => {
 
       const result = await getTier('tier-1');
 
-      expect(api.tiers.read).toHaveBeenCalledWith(
-        expect.objectContaining({
-          id: 'tier-1',
-        }),
-        expect.objectContaining({
-          id: 'tier-1',
-        })
-      );
+      expect(api.tiers.read).toHaveBeenCalledWith({}, { id: 'tier-1' });
       expect(result).toEqual(mockTier);
     });
 
@@ -300,12 +293,15 @@ describe('ghostServiceImproved - Tiers', () => {
   });
 
   describe('updateTier', () => {
-    it('should update a tier', async () => {
+    it('should send only update fields and updated_at, not the full existing tier', async () => {
       const existingTier = {
         id: 'tier-1',
+        slug: 'premium',
         name: 'Premium',
         currency: 'USD',
         monthly_price: 999,
+        type: 'paid',
+        active: true,
         updated_at: '2024-01-01T00:00:00.000Z',
       };
 
@@ -324,19 +320,22 @@ describe('ghostServiceImproved - Tiers', () => {
 
       const result = await updateTier('tier-1', updateData);
 
-      expect(api.tiers.read).toHaveBeenCalledWith(
-        expect.objectContaining({ id: 'tier-1' }),
-        expect.objectContaining({ id: 'tier-1' })
-      );
+      expect(api.tiers.read).toHaveBeenCalledWith({}, { id: 'tier-1' });
+      // Should send ONLY updateData + updated_at, NOT the full existing tier
       expect(api.tiers.edit).toHaveBeenCalledWith(
-        expect.objectContaining({
-          ...existingTier,
-          ...updateData,
-        }),
-        expect.objectContaining({
+        {
           id: 'tier-1',
-        })
+          name: 'Premium Plus',
+          monthly_price: 1299,
+          updated_at: '2024-01-01T00:00:00.000Z',
+        },
+        {}
       );
+      // Verify read-only fields are NOT sent
+      const editCallData = api.tiers.edit.mock.calls[0][0];
+      expect(editCallData).not.toHaveProperty('slug');
+      expect(editCallData).not.toHaveProperty('type');
+      expect(editCallData).not.toHaveProperty('active');
       expect(result).toEqual(mockUpdatedTier);
     });
 

package/src/services/__tests__/memberService.test.js

@@ -6,7 +6,6 @@ import {
   validateMemberLookup,
   validateSearchQuery,
   validateSearchOptions,
-  sanitizeNqlValue,
 } from '../memberService.js';
 
 describe('memberService - Validation', () => {
@@ -447,31 +446,4 @@ describe('memberService - Validation', () => {
       );
     });
   });
-
-  describe('sanitizeNqlValue', () => {
-    it('should escape backslashes', () => {
-      expect(sanitizeNqlValue('test\\value')).toBe('test\\\\value');
-    });
-
-    it('should escape single quotes', () => {
-      expect(sanitizeNqlValue("test'value")).toBe("test\\'value");
-    });
-
-    it('should escape double quotes', () => {
-      expect(sanitizeNqlValue('test"value')).toBe('test\\"value');
-    });
-
-    it('should handle multiple special characters', () => {
-      expect(sanitizeNqlValue('test\'value"with\\chars')).toBe('test\\\'value\\"with\\\\chars');
-    });
-
-    it('should not modify strings without special characters', () => {
-      expect(sanitizeNqlValue('normalvalue')).toBe('normalvalue');
-      expect(sanitizeNqlValue('test@example.com')).toBe('test@example.com');
-    });
-
-    it('should handle empty string', () => {
-      expect(sanitizeNqlValue('')).toBe('');
-    });
-  });
 });

package/src/services/__tests__/tierService.test.js

@@ -3,7 +3,6 @@ import {
   validateTierData,
   validateTierUpdateData,
   validateTierQueryOptions,
-  sanitizeNqlValue,
 } from '../tierService.js';
 import { ValidationError } from '../../errors/index.js';
 
@@ -342,31 +341,4 @@ describe('tierService - Validation', () => {
       ).not.toThrow();
     });
   });
-
-  describe('sanitizeNqlValue', () => {
-    it('should return value if undefined or null', () => {
-      expect(sanitizeNqlValue(null)).toBe(null);
-      expect(sanitizeNqlValue(undefined)).toBe(undefined);
-    });
-
-    it('should escape backslashes', () => {
-      expect(sanitizeNqlValue('test\\value')).toBe('test\\\\value');
-    });
-
-    it('should escape single quotes', () => {
-      expect(sanitizeNqlValue("test'value")).toBe("test\\'value");
-    });
-
-    it('should escape double quotes', () => {
-      expect(sanitizeNqlValue('test"value')).toBe('test\\"value');
-    });
-
-    it('should escape multiple special characters', () => {
-      expect(sanitizeNqlValue('test\\value"with\'quotes')).toBe('test\\\\value\\"with\\\'quotes');
-    });
-
-    it('should handle strings without special characters', () => {
-      expect(sanitizeNqlValue('simple-value')).toBe('simple-value');
-    });
-  });
 });