@jfvilas/kwirth-common 0.4.30 → 0.4.31

package/dist/Version.d.ts

@@ -5,5 +5,5 @@
  * @returns true if version1 version is higher than version2
  */
 declare const versionGreatOrEqualThan: (version1: string, version2: string) => boolean;
-declare const versionGreatThan: (version1: string, version2: string) => boolean;
-export { versionGreatOrEqualThan, versionGreatThan };
+declare const versionGreaterThan: (version1: string, version2: string) => boolean;
+export { versionGreatOrEqualThan, versionGreaterThan };

package/dist/Version.js

@@ -15,29 +15,32 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.versionGreatThan = exports.versionGreatOrEqualThan = void 0;
+exports.versionGreaterThan = exports.versionGreatOrEqualThan = void 0;
 /**
  *
  * @param version1 version to check against a specifi level
  * @param version2 level you want to compare to
  * @returns true if version1 version is higher than version2
  */
+// const versionGreatOrEqualThan = (version1: string, version2: string): boolean => {
+//     const v1 = version1.split('.').map(Number)
+//     const v2 = version2.split('.').map(Number)
+//     for (let i = 0; i < Math.max(v1.length, v2.length); i++) {
+//         const num1 = v1[i] || 0
+//         const num2 = v2[i] || 0
+//         if (num1 > num2) 
+//             return true
+//         else if (num1 < num2)
+//             return false
+//     }
+//     // versions are equal
+//     return true
+// }
 const versionGreatOrEqualThan = (version1, version2) => {
-    const v1 = version1.split('.').map(Number);
-    const v2 = version2.split('.').map(Number);
-    for (let i = 0; i < Math.max(v1.length, v2.length); i++) {
-        const num1 = v1[i] || 0;
-        const num2 = v2[i] || 0;
-        if (num1 >= num2)
-            return true;
-        else if (num1 < num2)
-            return false;
-    }
-    // versions are equal
-    return true;
+    return versionGreaterThan(version1, version2) || (version1 === version2);
 };
 exports.versionGreatOrEqualThan = versionGreatOrEqualThan;
-const versionGreatThan = (version1, version2) => {
+const versionGreaterThan = (version1, version2) => {
     const v1 = version1.split('.').map(Number);
     const v2 = version2.split('.').map(Number);
     for (let i = 0; i < Math.max(v1.length, v2.length); i++) {
@@ -51,4 +54,4 @@ const versionGreatThan = (version1, version2) => {
     // versions are equal
     return false;
 };
-exports.versionGreatThan = versionGreatThan;
+exports.versionGreaterThan = versionGreaterThan;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jfvilas/kwirth-common",
-  "version": "0.4.30",
+  "version": "0.4.31",
   "description": "Common interfaces for integrating applications with Kwirth",
   "scripts": {
     "build": "del .\\dist\\* /s /q && tsc"