@jesdi/skills 0.0.40 → 0.0.41

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jesdi/skills",
-  "version": "0.0.40",
+  "version": "0.0.41",
   "description": "jesdi's agent skills (content package consumed by @jesdi/skills-cli)",
   "license": "MIT",
   "repository": {

package/skills/implement-spec/ARCHITECTURE.md

@@ -110,8 +110,8 @@ and do not know about the run, except `driver_run.py`, which the three deciding
   A timeout doubles the time of the rerun.
 - Fix rounds stop at 4, and round 3 goes to the next implementer entry. The correctness pass never runs on the
   provider of the implementer.
-- A red gate on a fixer's commit is a finding of the next round (`driver_fixloop._gate`), so it blocks only after
-  round 4.
+- A red gate on the implementer's or a fixer's commit is a finding of the next round (`driver_fixloop._gate`), so
+  it blocks only after round 4. A red gate on a test-writer correction blocks.
 
 ### Questions
 

package/skills/implement-spec/README.md

@@ -119,7 +119,7 @@ Rules for each agent:
 
 A fix round is one **fixer** (`prompts/fixer.md`), then the gate on the new tip, then a re-review of the range of the fix. A mutation proof is repeated only when the fix changed its production line.
 
-A red gate on the commit of a fixer is a critical finding with source `gate`. Its file is the gate record, and the record holds the output. No review runs on that tip, and the next round starts. The re-review after that round covers each fix since the last review and repeats each proof that one of them made due. A red gate after round 4 blocks the ticket, as does a red gate on the commit of the implementer or of a test-writer correction.
+A red gate on the commit of the implementer or of a fixer is a critical finding with source `gate`. Its file is the gate record, and the record holds the output. No review runs on that tip, and the next round starts: a red gate on the commit of the implementer starts round 1. The review after that round covers each fix since the last review and repeats each proof that one of them made due. A red gate after round 4 blocks the ticket, as does a red gate on the commit of a test-writer correction: the correction is outside the fix rounds, and a fixer may not edit the locked files.
 
 - Rounds 1 and 2 run on the first entry of the implementer list.
 - Rounds 3 and 4 run on the second entry of the implementer list. When the list has one entry, they stay on it and the ledger says so.

package/skills/implement-spec/driver_fixloop.py

@@ -164,12 +164,13 @@ def _act_on(job: Job, found: list[dict]) -> bool:
 
 
 def _gate(job: Job) -> list[dict]:
-    """Gate the tip. A red gate on a fixer's commit before round 4 is a finding for the next round; any other red
-    gate blocks. Returns the findings: the red gate, or none."""
+    """Gate the tip. A red gate on the implementer's commit or a fixer's commit before round 4 is a finding for the
+    next round; a red gate after round 4 or on a test-writer correction blocks. Returns the findings: the red gate,
+    or none."""
     run, number = job.run, job.ticket.number
     job.red = False
     with during("the gate"):
-        if not 0 < job.round < ROUNDS or job.corrected:
+        if job.round == ROUNDS or job.corrected:
             run.gate(number, job.slot, job.tip)
             return []
         record = run.red_gate(number, job.slot, job.tip)

package/skills/implement-spec/tests/test_driver.py

@@ -358,6 +358,9 @@ echo "$nn $PWD" >> "$0.calls"
 # Ticket 01 waits until ticket 02 has its branch, so both start from the same PR tip.
 TOGETHER = """[ "$nn" != 01 ] || until git rev-parse -q --verify refs/heads/ticket/02 > /dev/null; do sleep 0.02; done\n"""
 REFACTOR = {"seam": "none — refactor"}
+# A fixer that cannot make the red gate green: the ticket blocks at fix round 1.
+GIVE_UP = """[ $role != fixer ] || { printf '{"status": "BLOCKED", "commits": [], "files": [], "concerns": ["the gate stays red"], "green": [], "ticket": "01"}' > "$report"; exit 0; }\n"""
+GAVE_UP = "Ticket 01: BLOCKED at fix round 1: the fixer reported BLOCKED: the gate stays red."
 
 
 def walk(tmp_path, capsys, body, *args, gate="true"):
@@ -452,13 +455,13 @@ def test_a_conflict_cli_that_fails_stops_the_run_and_leaves_no_open_merge(repo,
         assert out_of("git", "-C", slot, "rev-parse", "-q", "--verify", "MERGE_HEAD") == ""
 
 
-def test_a_red_gate_blocks_the_ticket_and_the_ticket_it_blocks_never_starts(repo, tmp_path, capsys):
+def test_a_red_gate_is_a_finding_and_the_ticket_it_blocks_never_starts(repo, tmp_path, capsys):
     two(repo, second="01")
-    code, ledger, out = walk(tmp_path, capsys, WORK + REPORT, gate="echo CHECK-OUTPUT; exit 1")
+    code, ledger, out = walk(tmp_path, capsys, GIVE_UP + WORK + REPORT, gate="echo CHECK-OUTPUT; exit 1")
     tip = out_of("git", "rev-parse", "--short=7", "ticket/01")
-    assert code == 1 and len(ledger) == 2, out
-    assert ledger[1] == (f"Ticket 01: BLOCKED at the gate: the gate is red on {tip}, "
-                         f"record .agent/implement/01/gate-{tip}.log.")
+    assert code == 1 and ledger[-1] == GAVE_UP, out
+    assert ledger[1] == (f"Ticket 01: critical finding of kind code from the gate at "
+                         f".agent/implement/01/gate-{tip}.log:0: the gate is red on {tip}.")
     record = (tmp_path / f".agent/implement/01/gate-{tip}.log").read_text()
     assert "status: clean\n" in record and "CHECK-OUTPUT\n\nexit: 1\nafter: clean\nend: " in record
     assert "Ticket 02 is not merged: its phase is pending." in out and "| gates run | 1 |" in out
@@ -479,8 +482,8 @@ def test_a_red_merge_gate_blocks_the_ticket_and_the_pr_branch_does_not_move(repo
 
 def test_a_tree_that_is_not_clean_is_a_red_gate_and_the_slot_keeps_the_work(repo, tmp_path, capsys):
     repo(t01=ticket("01", **REFACTOR))
-    code, ledger, out = walk(tmp_path, capsys, WORK + REPORT + "echo left > junk.txt\n", gate="echo NEVER")
-    assert code == 1 and "BLOCKED at the gate" in ledger[-1], out
+    code, ledger, out = walk(tmp_path, capsys, GIVE_UP + WORK + REPORT + "echo left > junk.txt\n", gate="echo NEVER")
+    assert code == 1 and "from the gate at .agent/implement/01/gate-" in ledger[-3] and ledger[-1] == GAVE_UP, out
     record = next((tmp_path / ".agent/implement/01").glob("gate-*.log")).read_text()
     assert "status: not clean\n    ?? junk.txt\n" in record and "exit: not run" in record and "\nNEVER\n" not in record
     assert out_of("git", "symbolic-ref", "--short", "HEAD") == "ticket/01" and (tmp_path / "junk.txt").exists()
@@ -729,8 +732,8 @@ def test_a_merge_commit_the_slot_cannot_check_out_is_not_gated_and_does_not_land
 ])
 def test_a_gate_that_changes_the_tree_or_moves_head_is_red(repo, tmp_path, capsys, gate, after):
     repo(t01=ticket("01", **REFACTOR))
-    code, ledger, out = walk(tmp_path, capsys, WORK + REPORT, gate=gate)
-    assert code == 1 and "BLOCKED at the gate: the gate is red on " in ledger[-1], out
+    code, ledger, out = walk(tmp_path, capsys, GIVE_UP + WORK + REPORT, gate=gate)
+    assert code == 1 and "from the gate at .agent/implement/01/gate-" in ledger[-3] and ledger[-1] == GAVE_UP, out
     record = next((tmp_path / ".agent/implement/01").glob("gate-*.log")).read_text()
     assert "\nexit: 0\n" in record and after in record
     assert state_of(tmp_path)["tickets"]["01"]["green_gates"] == []

package/skills/implement-spec/tests/test_fixloop.py

@@ -399,6 +399,21 @@ def test_a_red_gate_on_a_fixer_commit_starts_the_next_round_with_the_record_as_e
     assert f"The fix is {rig.sha('01', 'implementer')}..{second}" in again and "demo/export.py:2" in again
 
 
+def test_a_red_gate_on_the_implementer_commit_starts_fix_round_1_with_the_record_as_evidence(tmp_path):
+    """Issue 80: the gate of the implementer commit is red. That is a finding for round 1, not a BLOCKED ticket."""
+    rig = Inside(tmp_path, gate={"subjects": ["feat: 01 rows"]})
+    rig.run(plan(**{"01/reviewer": [review("01")], "01/fixer": [fix("01", 1)]}))
+    assert rig.code == 0, rig.ledger()
+    assert [call["role"] for call in rig.calls("01")] == ["test-writer", "implementer", "fixer", "reviewer"]
+    tip = rig.sha("01", "implementer")
+    record = f".agent/implement/01/gate-{tip[:7]}.log"
+    (gate,) = json.loads((rig.folder() / "findings-0.json").read_text())
+    assert (gate["source"], gate["severity"], gate["kind"]) == ("gate", "critical", "code")
+    assert gate["title"] == f"the gate is red on {tip[:7]}" and record in gate["evidence"]
+    assert "findings-0.json" in rig.prompt("fixer-1") and rig.state()["tickets"]["01"]["phase"] == "merged"
+    assert "The fix is" not in rig.prompt("reviewer-1")  # no review saw the implementer commit: a full review
+
+
 def test_a_red_gate_on_the_fixer_commit_of_round_4_blocks_the_ticket(tmp_path):
     rig = Inside(tmp_path, gate={"subjects": ["fix: 01 round 4"]})
     rig.run(plan(**{"01/reviewer": [review("01", [STUCK])] * 4, "01/fixer": [fix("01", n) for n in (1, 2, 3, 4)]}))

package/skills/implement-spec/tests/test_review.py

@@ -22,7 +22,7 @@ from pathlib import Path
 import pytest
 
 from test_cli import SKILL, ticket, three, git, models_file
-from test_walk import RUNNER, Rig, impl, plan, tw
+from test_walk import RUNNER, Rig, fix, impl, plan, tw
 
 # The fake runner of test_walk plus two hooks: `git` runs before the step's files, `git_after` right after them.
 HOOKED = RUNNER.replace(
@@ -76,13 +76,6 @@ def correct(findings=(), **extra):
     return {"report": report, **extra}
 
 
-def fix(nn, n, text=None, **changes):
-    """A fixer step: one commit on the ticket branch."""
-    step = impl(nn, text=text or f"def fn_{nn}():\n    return 'fix{n}'\n", commit=f"fix: {nn} round {n}", **changes)
-    step["report"]["ticket"] = nn
-    return step
-
-
 def edit(text, **new):
     """`text` with line N replaced (keyword `l<N>`)."""
     lines = text.splitlines(keepends=True)

package/skills/implement-spec/tests/test_walk.py

@@ -130,6 +130,13 @@ def impl(nn, path="demo/export.py", text=None, **changes):
     return {**step, **changes}
 
 
+def fix(nn, n, text=None, **changes):
+    """A fixer step: one commit on the ticket branch."""
+    step = impl(nn, text=text or f"def fn_{nn}():\n    return 'fix{n}'\n", commit=f"fix: {nn} round {n}", **changes)
+    step["report"]["ticket"] = nn
+    return step
+
+
 PATHS = {"01": "demo/export.py", "02": "demo/export.py", "03": "demo/cli.py"}
 
 
@@ -264,8 +271,9 @@ def std(tmp_path_factory):
 
 @pytest.fixture(scope="module")
 def blocked(tmp_path_factory):
-    """The default scenario with a red gate on ticket/01."""
-    return Rig(tmp_path_factory.mktemp("blocked"), gate={"red": ["ticket/01"]}).run(plan())
+    """The default scenario with a red gate on ticket/01 that four fix rounds do not make green."""
+    fixes = [fix("01", n) for n in (1, 2, 3, 4)]
+    return Rig(tmp_path_factory.mktemp("blocked"), gate={"red": ["ticket/01"]}).run(plan(**{"01/fixer": fixes}))
 
 
 def test_01_starts_in_slot_1_03_in_slot_2_and_02_after_the_merge_of_01(std):
@@ -331,12 +339,15 @@ def test_gate_environment_names_the_pr_branch_and_a_pycache_prefix_under_agent_i
     assert os.path.realpath(gate["pycache"]).startswith(str((rig.repo / ".agent/implement").resolve()) + os.sep)
 
 
-def test_red_gate_blocks_the_ticket_names_the_record_and_launches_no_later_role(blocked):
+def test_red_gate_blocks_the_ticket_after_round_4_names_the_record_and_launches_no_review(blocked):
     assert blocked.code == 1, blocked.output()
     a1 = blocked.sha("01", "implementer")
-    assert [l for l in blocked.ledger() if "01" in l and "BLOCKED" in l and f"gate-{a1[:7]}.log" in l], blocked.ledger()
+    finding = f"Ticket 01: critical finding of kind code from the gate at .agent/implement/01/gate-{a1[:7]}.log:0: "
+    assert [l for l in blocked.ledger() if l.startswith(finding)], blocked.ledger()
     assert re.search(r"exit\D*1", (blocked.repo / f".agent/implement/01/gate-{a1[:7]}.log").read_text())
-    assert {c["role"] for c in blocked.calls("01")} == {"test-writer", "implementer"}
+    last = blocked.calls("01", "fixer")[-1]["sha"]
+    assert [l for l in blocked.ledger() if "01" in l and "BLOCKED" in l and f"gate-{last[:7]}.log" in l], blocked.ledger()
+    assert [c["role"] for c in blocked.calls("01")] == ["test-writer", "implementer"] + ["fixer"] * 4
     assert blocked.state()["tickets"]["01"]["phase"] == "blocked"
     assert "ticket/01" in blocked.branches() and "feat: 01 rows" not in blocked.pr_subjects()
 

package/skills-manifest.json

@@ -1,6 +1,6 @@
 {
   "schemaVersion": 1,
-  "generatedAt": "2026-10-15T23:44:37.469Z",
+  "generatedAt": "2026-10-16T09:21:05.102Z",
   "skills": [
     {
       "name": "backlog",
@@ -46,8 +46,8 @@
     },
     {
       "name": "implement-spec",
-      "version": "0.1.16",
-      "hash": "sha256-8f7e4b06072b26e3a6699974dced9afe2745917c01784f9f6166d972c3ba60f1",
+      "version": "0.1.17",
+      "hash": "sha256-3e93a264e28048f143a4d39786bb30974e42b4da6a6f5da36a1ea3418b840632",
       "description": "Implement a specification in code."
     },
     {